[kudu-CR] Validate security flags with gflags validators

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged.

Change subject: Validate security flags with gflags validators
..


Validate security flags with gflags validators

This allows validation to be done early in server startup, which works
around a bug that leaves the filesystem in an inconsistent state if the
server fails early.

Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
Reviewed-on: http://gerrit.cloudera.org:8080/6128
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/messenger.cc
M src/kudu/server/webserver_options.cc
2 files changed, 96 insertions(+), 35 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] Validate security flags with gflags validators

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Validate security flags with gflags validators
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] Validate security flags with gflags validators

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Validate security flags with gflags validators
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6128/2/src/kudu/rpc/messenger.cc
File src/kudu/rpc/messenger.cc:

Line 115: extern Status ParseTriState(const char* flag_name, const string& 
flag_value, T* tri_state) {
> Why are all these functions marked 'extern'?
changed to static.


Line 132:   Status s = ParseTriState("--rpc_authentication", 
FLAGS_rpc_authentication, );
> To prevent the flag name and flag value becoming desynchronized, how about 
Apparently the CommandLineFlagInfo instances aren't set up yet during 
validation.


Line 249: if (!FLAGS_rpc_certificate_file.empty()) {
> Can you either CHECK that the rest are set, or add a comment saying that th
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] Validate security flags with gflags validators

[Dan Burkert (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6128

to look at the new patch set (#3).

Change subject: Validate security flags with gflags validators
..

Validate security flags with gflags validators

This allows validation to be done early in server startup, which works
around a bug that leaves the filesystem in an inconsistent state if the
server fails early.

Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
---
M src/kudu/rpc/messenger.cc
M src/kudu/server/webserver_options.cc
2 files changed, 96 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/6128/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] Validate security flags with gflags validators

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Validate security flags with gflags validators
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6128/2/src/kudu/rpc/messenger.cc
File src/kudu/rpc/messenger.cc:

Line 115: extern Status ParseTriState(const char* flag_name, const string& 
flag_value, T* tri_state) {
Why are all these functions marked 'extern'?


Line 132:   Status s = ParseTriState("--rpc_authentication", 
FLAGS_rpc_authentication, );
To prevent the flag name and flag value becoming desynchronized, how about 
using google::GetCommandLineFlagInfoOrDie() to fetch the latter using the 
former?


Line 249: if (!FLAGS_rpc_certificate_file.empty()) {
Can you either CHECK that the rest are set, or add a comment saying that 
they've been checked?


-- 
To view, visit http://gerrit.cloudera.org:8080/6128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] Validate security flags with gflags validators

[Dan Burkert (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6128

to look at the new patch set (#2).

Change subject: Validate security flags with gflags validators
..

Validate security flags with gflags validators

This allows validation to be done early in server startup, which works
around a bug that leaves the filesystem in an inconsistent state if the
server fails early.

Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
---
M src/kudu/rpc/messenger.cc
M src/kudu/server/webserver_options.cc
2 files changed, 94 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/6128/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] Validate security flags with gflags validators

[Dan Burkert (Code Review)]

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/6128

to review the following change.

Change subject: Validate security flags with gflags validators
..

Validate security flags with gflags validators

This allows validation to be done early in server startup, which works
around a bug that leaves the filesystem in an inconsistent state if the
server fails early.

Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
---
M src/kudu/rpc/messenger.cc
M src/kudu/server/webserver_options.cc
2 files changed, 94 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/6128/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bf2f7f54a1366b73157bf2426a16b0a197c9f50
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo