[kudu-CR] comment: delete the outdated comment
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13917 ) Change subject: comment: delete the outdated comment .. Patch Set 1: > > Patch Set 1: Code-Review+2 > > > > I couldn't find a document with this name anywhere in Kudu's > commit history. Perhaps it's something David forgot to merge and > has since been lost to time. > > > > Andrew, does this ring any bells to you? > > It doesn't. My best guess is this may have pointed to > https://github.com/apache/kudu/blob/37a81b82cc2e5e1ca9ad7291740b4e963e609bcc/docs/transaction_semantics.adoc#recommendations, > which outlines transaction semantics with respect to scans. > > Patch Set 1: Code-Review+2 > > > > I couldn't find a document with this name anywhere in Kudu's > commit history. Perhaps it's something David forgot to merge and > has since been lost to time. > > > > Andrew, does this ring any bells to you? > > It doesn't. My best guess is this may have pointed to > https://github.com/apache/kudu/blob/37a81b82cc2e5e1ca9ad7291740b4e963e609bcc/docs/transaction_semantics.adoc#recommendations, > which outlines transaction semantics with respect to scans. It seems the reference to docs/design-docs/repeatable-reads.md appeared in time_manager.h in the very first revision. Also, referencing transaction_semantics.adoc from mvcc.h mentions 'clean' time, which is not mentioned anywhere in the top-level of design docs (as I can see). Most likely, it might be a document that David had in his local git workspace, but it hasn't been committed? -- To view, visit http://gerrit.cloudera.org:8080/13917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 Gerrit-Change-Number: 13917 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang Gerrit-Comment-Date: Thu, 25 Jul 2019 21:23:11 + Gerrit-HasComments: No
[kudu-CR] comment: delete the outdated comment
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13917 ) Change subject: comment: delete the outdated comment .. comment: delete the outdated comment Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 Reviewed-on: http://gerrit.cloudera.org:8080/13917 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/consensus/time_manager.h M src/kudu/tablet/mvcc.h 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 Gerrit-Change-Number: 13917 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang
[kudu-CR] comment: delete the outdated comment
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13917 ) Change subject: comment: delete the outdated comment .. Patch Set 1: > Patch Set 1: Code-Review+2 > > I couldn't find a document with this name anywhere in Kudu's commit history. > Perhaps it's something David forgot to merge and has since been lost to time. > > Andrew, does this ring any bells to you? It doesn't. My best guess is this may have pointed to https://github.com/apache/kudu/blob/37a81b82cc2e5e1ca9ad7291740b4e963e609bcc/docs/transaction_semantics.adoc#recommendations, which outlines transaction semantics with respect to scans. -- To view, visit http://gerrit.cloudera.org:8080/13917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 Gerrit-Change-Number: 13917 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang Gerrit-Comment-Date: Thu, 25 Jul 2019 21:18:58 + Gerrit-HasComments: No
[kudu-CR] comment: delete the outdated comment
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13917 ) Change subject: comment: delete the outdated comment .. Patch Set 1: Code-Review+2 I couldn't find a document with this name anywhere in Kudu's commit history. Perhaps it's something David forgot to merge and has since been lost to time. Andrew, does this ring any bells to you? -- To view, visit http://gerrit.cloudera.org:8080/13917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 Gerrit-Change-Number: 13917 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang Gerrit-Comment-Date: Thu, 25 Jul 2019 18:12:05 + Gerrit-HasComments: No
[kudu-CR] comment: delete the outdated comment
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13917 Change subject: comment: delete the outdated comment .. comment: delete the outdated comment Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 --- M src/kudu/consensus/time_manager.h M src/kudu/tablet/mvcc.h 2 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/13917/1 -- To view, visit http://gerrit.cloudera.org:8080/13917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 Gerrit-Change-Number: 13917 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
