[kudu-CR] consensus: remove bits of dead code
Todd Lipcon has submitted this change and it was merged. Change subject: consensus: remove bits of dead code .. consensus: remove bits of dead code We had some old code path in which PeerMessageQueue::AppendOperations() would previously return ServiceUnavailable indicating some kind of memory limit. However, I traced through the code and could only find one case in which it would return ServiceUnavailable: if the log itself is shut down. We expect that the lifecycle of the log is controlled such that this will never happen. So, the code path that tried to handle this is now just a CHECK, and I was able to remove some code that was only called in this (dead) case. Additionally removes some other unused typedefs and methods in ReplicaState. Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Reviewed-on: http://gerrit.cloudera.org:8080/4712 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro AlvesReviewed-by: Mike Percy --- M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus_state.cc M src/kudu/consensus/raft_consensus_state.h 3 files changed, 4 insertions(+), 47 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] consensus: remove bits of dead code
Mike Percy has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] consensus: remove bits of dead code
David Ribeiro Alves has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] consensus: remove bits of dead code
Mike Percy has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] consensus: remove bits of dead code
David Ribeiro Alves has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] consensus: remove bits of dead code
David Ribeiro Alves has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4712/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 596: // or if we had an actual IO error, which we currently don't handle. > Done. Actually decided that there are no errors here we need to try to hand sgtm -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] consensus: remove bits of dead code
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4712 to look at the new patch set (#2). Change subject: consensus: remove bits of dead code .. consensus: remove bits of dead code We had some old code path in which PeerMessageQueue::AppendOperations() would previously return ServiceUnavailable indicating some kind of memory limit. However, I traced through the code and could only find one case in which it would return ServiceUnavailable: if the log itself is shut down. We expect that the lifecycle of the log is controlled such that this will never happen. So, the code path that tried to handle this is now just a CHECK, and I was able to remove some code that was only called in this (dead) case. Additionally removes some other unused typedefs and methods in ReplicaState. Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee --- M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus_state.cc M src/kudu/consensus/raft_consensus_state.h 3 files changed, 4 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4712/2 -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] consensus: remove bits of dead code
Todd Lipcon has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4712/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 596: CHECK(!s.IsServiceUnavailable()) << LogPrefixUnlocked() << "Log is shut down: " << s.ToString(); > can we consolidate this check? seems like we're fataling here and below Done. Actually decided that there are no errors here we need to try to handle. -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] consensus: remove bits of dead code
David Ribeiro Alves has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4712/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 596: CHECK(!s.IsServiceUnavailable()) << LogPrefixUnlocked() << "Log is shut down: " << s.ToString(); can we consolidate this check? seems like we're fataling here and below -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] consensus: remove bits of dead code
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4712 to review the following change. Change subject: consensus: remove bits of dead code .. consensus: remove bits of dead code We had some old code path in which PeerMessageQueue::AppendOperations() would previously return ServiceUnavailable indicating some kind of memory limit. However, I traced through the code and could only find one case in which it would return ServiceUnavailable: if the log itself is shut down. We expect that the lifecycle of the log is controlled such that this will never happen. So, the code path that tried to handle this is now just a CHECK, and I was able to remove some code that was only called in this (dead) case. Additionally removes some other unused typedefs and methods in ReplicaState. Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee --- M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus_state.cc M src/kudu/consensus/raft_consensus_state.h 3 files changed, 2 insertions(+), 42 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4712/1 -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8dc0a129f4f136256083a31e4b4b27e6a673dbee Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Mike Percy