[kudu-CR] tool: Allow hyphens to be used instead of underscores

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged.

Change subject: tool: Allow hyphens to be used instead of underscores
..


tool: Allow hyphens to be used instead of underscores

This works for both modes and actions.

Change-Id: Ie8bf958ee8841e9624687fb5ae50cc908e3e41c3
Reviewed-on: http://gerrit.cloudera.org:8080/5311
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_main.cc
2 files changed, 26 insertions(+), 2 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8bf958ee8841e9624687fb5ae50cc908e3e41c3
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] tool: Allow hyphens to be used instead of underscores

[Mike Percy (Code Review)]

Hello Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5311

to look at the new patch set (#4).

Change subject: tool: Allow hyphens to be used instead of underscores
..

tool: Allow hyphens to be used instead of underscores

This works for both modes and actions.

Change-Id: Ie8bf958ee8841e9624687fb5ae50cc908e3e41c3
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_main.cc
2 files changed, 26 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/5311/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8bf958ee8841e9624687fb5ae50cc908e3e41c3
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] tool: Allow hyphens to be used instead of underscores

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change.

Change subject: tool: Allow hyphens to be used instead of underscores
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5311/2/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

Line 113: string ReplaceCopy(string str, char target, char replacement) {
> Nit: since you always replace hyphens with underscores, how about baking th
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8bf958ee8841e9624687fb5ae50cc908e3e41c3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] tool: Allow hyphens to be used instead of underscores

[Mike Percy (Code Review)]

Hello Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5311

to look at the new patch set (#3).

Change subject: tool: Allow hyphens to be used instead of underscores
..

tool: Allow hyphens to be used instead of underscores

This works for both modes and actions.

Change-Id: Ie8bf958ee8841e9624687fb5ae50cc908e3e41c3
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_main.cc
2 files changed, 26 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/5311/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8bf958ee8841e9624687fb5ae50cc908e3e41c3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] tool: Allow hyphens to be used instead of underscores

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: tool: Allow hyphens to be used instead of underscores
..


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5311/2/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

Line 113: string ReplaceCopy(string str, char target, char replacement) {
Nit: since you always replace hyphens with underscores, how about baking that 
into the function itself? Fewer arguments to pass around.


-- 
To view, visit http://gerrit.cloudera.org:8080/5311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8bf958ee8841e9624687fb5ae50cc908e3e41c3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes