[kudu-CR] tools: add more detail about unsafe change config

[Andrew Wong (Code Review)]

Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9278 )

Change subject: tools: add more detail about unsafe_change_config
..

tools: add more detail about unsafe_change_config

Given the tooling docs pages are auto-generated from the descriptions
provided by the tools directly, it'd be helpful to start describing when
to use each tool, in addition to the action itself.

In particular, in the docs page, when searching for the word "evict",
it'd be nice to be pointed to the `unsafe_change_config` tool.

Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Reviewed-on: http://gerrit.cloudera.org:8080/9278
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
---
M src/kudu/tools/tool_action_remote_replica.cc
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] tools: add more detail about unsafe change config

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9278 )

Change subject: tools: add more detail about unsafe_change_config
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 23 Feb 2018 02:20:55 +
Gerrit-HasComments: No

[kudu-CR] tools: add more detail about unsafe change config

[Andrew Wong (Code Review)]

Hello Will Berkeley, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9278

to look at the new patch set (#4).

Change subject: tools: add more detail about unsafe_change_config
..

tools: add more detail about unsafe_change_config

Given the tooling docs pages are auto-generated from the descriptions
provided by the tools directly, it'd be helpful to start describing when
to use each tool, in addition to the action itself.

In particular, in the docs page, when searching for the word "evict",
it'd be nice to be pointed to the `unsafe_change_config` tool.

Change-Id: If389f9fec4926b798c9885dac17b4de136644239
---
M src/kudu/tools/tool_action_remote_replica.cc
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/9278/4
--
To view, visit http://gerrit.cloudera.org:8080/9278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] tools: add more detail about unsafe change config

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9278 )

Change subject: tools: add more detail about unsafe_change_config
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 23 Feb 2018 02:02:08 +
Gerrit-HasComments: No

[kudu-CR] tools: add more detail about unsafe change config

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9278 )

Change subject: tools: add more detail about unsafe_change_config
..


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc
File src/kudu/tools/tool_action_remote_replica.cc:

http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@437
PS2, Line 437: when a config
> when
Done


http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@437
PS2, Line 437: hange is "
 : "necessary because a tablet cannot make 
progress with "
 : "its current Raft configuration (
> Howabout "a config change is necessary because a tablet cannot make progres
Done


http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@439
PS2, Line 439:  evict "
 : "followers when a
> Do you mean to evict followers when a majority is unavailable?
Done


http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@442
PS2, Line 442: g "
 : "committ
> Redundant.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 23 Feb 2018 00:52:47 +
Gerrit-HasComments: Yes

[kudu-CR] tools: add more detail about unsafe change config

[Andrew Wong (Code Review)]

Hello Will Berkeley, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9278

to look at the new patch set (#3).

Change subject: tools: add more detail about unsafe_change_config
..

tools: add more detail about unsafe_change_config

Given the tooling docs pages are auto-generated from the descriptions
provided by the tools directly, it'd be helpful to start describing when
to use each tool, in addition to the action itself.

In particular, in the docs page, when searching for the word "evict",
it'd be nice to be pointed to the `unsafe_change_config` tool.

Change-Id: If389f9fec4926b798c9885dac17b4de136644239
---
M src/kudu/tools/tool_action_remote_replica.cc
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/9278/3
--
To view, visit http://gerrit.cloudera.org:8080/9278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] tools: add more detail about unsafe change config

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9278 )

Change subject: tools: add more detail about unsafe_change_config
..


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc
File src/kudu/tools/tool_action_remote_replica.cc:

http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@437
PS2, Line 437: in cases where
when


http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@437
PS2, Line 437: a tablet cannot "
 : "make progress with its current Raft 
configuration, "
 : "and a config change is necessary
Howabout "a config change is necessary because a tablet cannot make progress 
with its current Raft configuration"


http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@439
PS2, Line 439: as a means to "
 : "follower eviction
Do you mean to evict followers when a majority is unavailable?


http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@442
PS2, Line 442: on that "
 : "replica
Redundant.



--
To view, visit http://gerrit.cloudera.org:8080/9278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 22 Feb 2018 20:04:01 +
Gerrit-HasComments: Yes

[kudu-CR] tools: add more detail about unsafe change config

[Andrew Wong (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9278

to look at the new patch set (#2).

Change subject: tools: add more detail about unsafe_change_config
..

tools: add more detail about unsafe_change_config

Given the tooling docs pages are auto-generated from the descriptions
provided by the tools directly, it'd be helpful to start describing when
to use each tool, in addition to the action itself.

In particular, in the docs page, when searching for the word "evict",
it'd be nice to be pointed to the `unsafe_change_config` tool.

Change-Id: If389f9fec4926b798c9885dac17b4de136644239
---
M src/kudu/tools/tool_action_remote_replica.cc
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/9278/2
--
To view, visit http://gerrit.cloudera.org:8080/9278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins