[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12707 ) Change subject: tserver: correct usage of col idx in SplitKeyRange .. tserver: correct usage of col idx in SplitKeyRange Added a basic tserver-level test to use the SplitKeyRange endpoint that would fail without this patch. Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Reviewed-on: http://gerrit.cloudera.org:8080/12707 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins Reviewed-by: Yao Xu Reviewed-by: Grant Henke --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc 2 files changed, 29 insertions(+), 3 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified Yao Xu: Looks good to me, but someone else must approve Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12707 ) Change subject: tserver: correct usage of col idx in SplitKeyRange .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Mon, 11 Mar 2019 15:04:15 + Gerrit-HasComments: No
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12707 ) Change subject: tserver: correct usage of col idx in SplitKeyRange .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Mon, 11 Mar 2019 03:16:44 + Gerrit-HasComments: No
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12707 ) Change subject: tserver: correct usage of col idx in SplitKeyRange .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12707/2/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/12707/2/src/kudu/tserver/tablet_server-test.cc@2673 PS2, Line 2673: SCOPED_TRACE(SecureDebugString(resp)); > Maybe SCOPED_TRACE instead? Done -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Sun, 10 Mar 2019 02:20:26 + Gerrit-HasComments: Yes
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12707 ) Change subject: tserver: correct usage of col idx in SplitKeyRange .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Sun, 10 Mar 2019 02:21:02 + Gerrit-HasComments: No
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Hello Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12707 to look at the new patch set (#3). Change subject: tserver: correct usage of col idx in SplitKeyRange .. tserver: correct usage of col idx in SplitKeyRange Added a basic tserver-level test to use the SplitKeyRange endpoint that would fail without this patch. Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc 2 files changed, 29 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/12707/3 -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12707 ) Change subject: tserver: correct usage of col idx in SplitKeyRange .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12707/2/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/12707/2/src/kudu/tserver/tablet_server-test.cc@2673 PS2, Line 2673: LOG(INFO) << SecureDebugString(resp); Maybe SCOPED_TRACE instead? -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Sun, 10 Mar 2019 02:17:20 + Gerrit-HasComments: Yes
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12707 ) Change subject: tserver: correct usage of col idx in SplitKeyRange .. Patch Set 2: > Patch Set 1: Code-Review+1 > > schema.cc has this in it: > > // In a new schema, we typically would start assigning column IDs at 0. > However, this > // makes it likely that in many test cases, the column IDs and the column > indexes are > // equal to each other, and it's easy to accidentally pass an index where > we meant to pass > // an ID, without having any issues. So, in DEBUG builds, we start > assigning columns at ID > // 10, ensuring that if we accidentally mix up IDs and indexes, we're > likely to fire an > // assertion or bad memory access. > #ifdef NDEBUG > static const ColumnId kFirstColumnId(0); > #else > static const ColumnId kFirstColumnId(10); > #endif > > This tells me that we had no coverage for the SplitKeyRange API, or at least > no coverage for requests with real projections. Is that true? I think so. The feature could certainly use more tests (at the very least I added one at the tserver-level). -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Sun, 10 Mar 2019 02:16:15 + Gerrit-HasComments: No
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Hello Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12707 to look at the new patch set (#2). Change subject: tserver: correct usage of col idx in SplitKeyRange .. tserver: correct usage of col idx in SplitKeyRange Added a basic tserver-level test to use the SplitKeyRange endpoint that would fail without this patch. Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc 2 files changed, 29 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/12707/2 -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12707 ) Change subject: tserver: correct usage of col idx in SplitKeyRange .. Patch Set 1: Code-Review+1 schema.cc has this in it: // In a new schema, we typically would start assigning column IDs at 0. However, this // makes it likely that in many test cases, the column IDs and the column indexes are // equal to each other, and it's easy to accidentally pass an index where we meant to pass // an ID, without having any issues. So, in DEBUG builds, we start assigning columns at ID // 10, ensuring that if we accidentally mix up IDs and indexes, we're likely to fire an // assertion or bad memory access. #ifdef NDEBUG static const ColumnId kFirstColumnId(0); #else static const ColumnId kFirstColumnId(10); #endif This tells me that we had no coverage for the SplitKeyRange API, or at least no coverage for requests with real projections. Is that true? -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Sat, 09 Mar 2019 22:26:19 + Gerrit-HasComments: No
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12707 ) Change subject: tserver: correct usage of col idx in SplitKeyRange .. Patch Set 1: This could use a test, but thought I'd put it on your radars. -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Sat, 09 Mar 2019 05:17:59 + Gerrit-HasComments: No
[kudu-CR] tserver: correct usage of col idx in SplitKeyRange
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12707 Change subject: tserver: correct usage of col idx in SplitKeyRange .. tserver: correct usage of col idx in SplitKeyRange Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e --- M src/kudu/tserver/tablet_service.cc 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/12707/1 -- To view, visit http://gerrit.cloudera.org:8080/12707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If444ffa408b3827425ab07ef06ffd6ccc10e926e Gerrit-Change-Number: 12707 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
