[kudu-CR] [WIP][catalog manager] Skip eviction during bootstrapping
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20958 to look at the new patch set (#5). Change subject: [WIP][catalog_manager] Skip eviction during bootstrapping .. [WIP][catalog_manager] Skip eviction during bootstrapping If the leader replica shuts down and returns to the quorum, it will take some time to bootstrap. During this time, it is possible to send a full tablet report it still reckons itself as the leader and since it is bootstrapping, the overall health is unknown. This can cause trouble as it there is a check that the leader must be always healthy. This issue is solved by checking if the tablet is bootstrapping and if it is then eviction check is skipped. There is no need for new test because this change fixes ToolTest::TestRecreateCMeta flakiness and verifies the correct behaviour indirectly. Change-Id: I0cbbe6b77d99d167fc58692047072f86d3d963cf --- M src/kudu/master/catalog_manager.cc 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/20958/5 -- To view, visit http://gerrit.cloudera.org:8080/20958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0cbbe6b77d99d167fc58692047072f86d3d963cf Gerrit-Change-Number: 20958 Gerrit-PatchSet: 5 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [log block manager] Write lock for deletion
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20901 to look at the new patch set (#9). Change subject: [log_block_manager] Write lock for deletion .. [log_block_manager] Write lock for deletion Both removing blocks and compacting metadata manipulates the live_blocks_ value and file content. This way it can happen that on thread A live_blocks_ is updated, on thread B metadata is compacted and live_blocks_ value is overwritten, then thread A writes deletion records in the metadata file. This way it creates inconsistency between file content and live_blocks_ value, which leads to incorrect behaviour to skip compaction later. This fix makes sure that CompactMetadata and deletion can not overlap each other. No new test is needed because it fixes LogBlockManagerTest:: TestContainerBlockLimitingByMetadataSizeWithCompaction flakiness. Change-Id: I73712a5fd8eccf23621f8abda3e99ebdf10a769f --- M src/kudu/fs/log_block_manager.cc 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/20901/9 -- To view, visit http://gerrit.cloudera.org:8080/20901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73712a5fd8eccf23621f8abda3e99ebdf10a769f Gerrit-Change-Number: 20901 Gerrit-PatchSet: 9 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [log block manager] Write lock for deletion
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20901 to look at the new patch set (#10). Change subject: [log_block_manager] Write lock for deletion .. [log_block_manager] Write lock for deletion Both removing blocks and compacting metadata manipulates the live_blocks_ value and file content. This way it can happen that on thread A live_blocks_ is updated, on thread B metadata is compacted and live_blocks_ value is overwritten, then thread A writes deletion records in the metadata file. This way it creates inconsistency between file content and live_blocks_ value, which leads to incorrect behaviour to skip compaction later. This fix makes sure that CompactMetadata and deletion can not overlap each other. No new test is needed because it fixes LogBlockManagerTest:: TestContainerBlockLimitingByMetadataSizeWithCompaction flakiness. Change-Id: I73712a5fd8eccf23621f8abda3e99ebdf10a769f --- M src/kudu/fs/log_block_manager.cc 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/20901/10 -- To view, visit http://gerrit.cloudera.org:8080/20901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73712a5fd8eccf23621f8abda3e99ebdf10a769f Gerrit-Change-Number: 20901 Gerrit-PatchSet: 10 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP][catalog manager] Skip eviction during bootstrapping
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20958 to look at the new patch set (#6). Change subject: [WIP][catalog_manager] Skip eviction during bootstrapping .. [WIP][catalog_manager] Skip eviction during bootstrapping If the leader replica shuts down and returns to the quorum, it will take some time to bootstrap. During this time, it is possible to send a full tablet report it still reckons itself as the leader and since it is bootstrapping, the overall health is unknown. This can cause trouble as it there is a check that the leader must be always healthy. This issue is solved by checking if the tablet is bootstrapping and if it is then eviction check is skipped. There is no need for new test because this change fixes ToolTest::TestRecreateCMeta flakiness and verifies the correct behaviour indirectly. Change-Id: I0cbbe6b77d99d167fc58692047072f86d3d963cf --- M src/kudu/master/catalog_manager.cc 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/20958/6 -- To view, visit http://gerrit.cloudera.org:8080/20958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0cbbe6b77d99d167fc58692047072f86d3d963cf Gerrit-Change-Number: 20958 Gerrit-PatchSet: 6 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20984 Change subject: [test] a small clean-up on StringGaugePrometheusTest .. [test] a small clean-up on StringGaugePrometheusTest I took a quick look at KUDU-3549, and a natural first step was to check whether we have a proper test coverage for handling StringGauge in when dumping metrics in Prometheus format. The result was this patch, adding a couple new sub-scenarios into MetricsTest.StringGaugePrometheusTest. While this didn't lead to discovering the root case of the reported issue, the new sub-scenarios are still useful since they provide extra coverage for the related functionality. I also took the liberty of cleaning up the code a bit. Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 --- M src/kudu/util/metrics-test.cc 1 file changed, 43 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/20984/1 -- To view, visit http://gerrit.cloudera.org:8080/20984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [WIP][catalog manager] Skip eviction during bootstrapping
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20958 ) Change subject: [WIP][catalog_manager] Skip eviction during bootstrapping .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20958/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20958/6//COMMIT_MSG@10 PS6, Line 10: During this time, it is possible to send a full : tablet report it still reckons itself as the leader and since it is : bootstrapping Oh, really? I thought ReportedTabletPB::consensus_state isn't present when the state of the tablet is BOOTSTRAPPING, but I might be missing something. I'd think we saw the DCHECK() triggering much more often if that was the root cause. The situation described here happens every time upon bootstrapping a tablet replica that has been a leader in prior incarnation, especially if it has a lot of data. However, that's not the case. Are you sure your analysis is correct? http://gerrit.cloudera.org:8080/#/c/20958/6//COMMIT_MSG@15 PS6, Line 15: There is no need for new test : because this change fixes ToolTest::TestRecreateCMeta flakiness and : verifies the correct behaviour indirectly. I'm not sure this makes sense to me. The issue that was triggering the DCHECK() in quorum_utils.cc was happening extremely rare. With that, how do you know that your analysis is correct if you don't have a test that at least allows for the reproduction of the issue on a regular basis, so you could see if the fix is working? -- To view, visit http://gerrit.cloudera.org:8080/20958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cbbe6b77d99d167fc58692047072f86d3d963cf Gerrit-Change-Number: 20958 Gerrit-PatchSet: 6 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 02 Feb 2024 05:27:03 + Gerrit-HasComments: Yes
[kudu-CR] [Tool] KUDU-3318 Compact container metadata file manually
Wang Xixu has posted comments on this change. (
http://gerrit.cloudera.org:8080/19327 )
Change subject: [Tool] KUDU-3318 Compact container metadata file manually
..
Patch Set 9:
(19 comments)
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.h
File src/kudu/fs/log_block_manager.h:
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.h@215
PS8, Line 215: static Status GetContainerNames(Env* env, const std::string&
data_dir,
> Add some comments for this function.
Done
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc@957
PS8, Line 957: // Aborted: the container will be repaired later;
> It's similar to LogBlockContainerNativeMeta::ProcessRecords(), how about re
Using LogBlockContainerNativeMeta::ProcessRecords() needs to open log block
manager. But this tool can not open log block manager, because opening log
block manager will load all log block containers and causes staring tserver
very slowly, which is the problem this tool needs to solve.
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc@2789
PS8, Line 2789:
> Just skip the compact procedure if compact_metadata is 0.
Done
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc@2801
PS8, Line 2801:
> I guess the .compacted is needed to be deleted if the .offset file generate
In function GenerateCompactedFile(), there exists a method to delete .compacted
file, if generating it failed. Besides, on the next operation 'merge', it will
check .compacted file and .offset file existing at the same time.
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc@2930
PS8, Line 2930: optional limit;
: if (FLAGS_log_container_max_blocks == -1) {
: // No limit, unless this is KUDU-1508.
:
: // The log block manager requires hole punching and, of
the ext
: // filesystems, only ext4 supports it. Thus, if this is
an ext
: // filesystem, it's ext4 by definition.
: if (buggy_el6_kernel_ && dd->fs_type() == FsType::EXT) {
: uint64_t fs_block_size =
:
dd->instance()->metadata()->filesystem_block_size_bytes();
: bool untested_block_size =
: !ContainsKey(kPerFsBlockSizeBlockLimits,
fs_block_size);
: string msg = Substitute(
: "Data dir $0 is on an ext4 filesystem vulnerable to
KUDU-1508 "
: "with $1block size $2", dd->dir(),
: untested_block_size ? "untested " : "",
fs_block_size);
: if (untested_block_size) {
: LOG(WARNING) << msg;
: } else {
:
> There are a bit of duplicate, how about adding the suffixes to a list, and
Done
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc@2987
PS8, Line 2987: this->OpenDataDir(dd_raw, results, s,
containers_processed, containers_total);
> How about do a small refactor for LogBlockManager::RewriteMetadataFile() an
RewriteMetadataFile() is only called with log block manager opened. Even we can
make this function to a static function, but the macro
`RETURN_NOT_OK_LBM_DISK_FAILURE_PREPEND` can not be a static one, and the macro
is important.
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc@3028
PS8, Line 3028: dead_containers.c
> There is a similar code piece in LogBlockManager::OpenDataDir(), is it poss
Done
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/tools/tool_action_fs.cc
File src/kudu/tools/tool_action_fs.cc:
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/tools/tool_action_fs.cc@151
PS8, Line 151: "for every container."
: "--compact: Compact metadata f
> nit: use a std::set/std::unordered_set for fast lookup, and JoinStrings can
Done
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/tools/tool_action_fs.cc@1036
PS8, Line 1036:
> Why it's 1 at the beginning? The same to cur_finished_containers_count and
It uses 'fetch_add' to keep thread-safe. 'fetch_add' will return the old value.
So set the value to 1 at the beginning.
http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/tools/tool_action_fs.cc@1033
PS8, Line 1033: unique_ptr pool;
: RETURN_NOT_OK(ThreadPoolBuilder("metadata-compact-pool")
: .set_max_threads(FLAGS_num_threads)
: .Build());
:
> nit: Move them closer to the place where use it.
Done
[kudu-CR] [Tool] KUDU-3318 Compact container metadata file manually
Hello Tidy Bot, Yingchun Lai, Yifan Zhang, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19327 to look at the new patch set (#9). Change subject: [Tool] KUDU-3318 Compact container metadata file manually .. [Tool] KUDU-3318 Compact container metadata file manually Some old versions of Kudu do not support compacting log container metadata file at runtime. A long time later, metadata file becomes very large, for example, more than 100G. When restarting Kudu tablet server, it will read all metadata files to check which blocks are still alive and compact metadata files into new small metadata files which only record alive blocks. As the metadata files are very big, compacting metadata files will cost a lot of time, maybe 2-3 hours. That will cause the service unavailabe for a long time, which is unacceptable. Runtime metadata file compacting has already been supported above version of 1.16.0, see jira: KUDU-3318. Upgrading old version to above Kudu 1.16.0 still needs to restart Kudu. This tool helps to compact metdata file for old versions of Kudu. It supports 4 operations: --print: Statistic the total blocks and alive blocks for every container. --compact: Compact metadata files when Kudu is still running --merge: Stop Kudu and write incremental records into compacted metadata files. Then backup old metadata files. --clear: Delete metadata backup files. Restarting old version of Kudu maybe cost 2-3 hours, but using compact tool, service stopped only lasts 3 minutes. Change-Id: Id61cb6c88d7a093a8448e2497639f5c5c094efa4 --- M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_fs.cc M src/kudu/util/pb_util.cc M src/kudu/util/pb_util.h 7 files changed, 677 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/19327/9 -- To view, visit http://gerrit.cloudera.org:8080/19327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id61cb6c88d7a093a8448e2497639f5c5c094efa4 Gerrit-Change-Number: 19327 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Hello Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20761 to look at the new patch set (#9). Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. [Java] KUDU-3498 Scanner keeps alive in periodically Kudu caches the scanner in the tablet server for continuing reading. It will be expired if the idle time is over the defined scanner ttl time. Sometimes the client reads a batch of data, if the data is every large, it takes a long time to handle it. Then the client reads the next batch using the same scanner, the scanner will be expired even if it has sent a keep alive request. This patch adds support for keeping a scanner alive periodically. It uses a timer to send keep alive requests background. So, it will never be expired when the scanner is in using. Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java 3 files changed, 205 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/20761/9 -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20761 ) Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/20761/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/20761/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@430 PS8, Line 430: int rowCount = 0; > We have a checkstyle error here: Done -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Fri, 02 Feb 2024 07:56:33 + Gerrit-HasComments: Yes
[kudu-CR] [Tool] KUDU-3318 Compact container metadata file manually
Hello Tidy Bot, Yingchun Lai, Yifan Zhang, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19327 to look at the new patch set (#10). Change subject: [Tool] KUDU-3318 Compact container metadata file manually .. [Tool] KUDU-3318 Compact container metadata file manually Some old versions of Kudu do not support compacting log container metadata file at runtime. A long time later, metadata file becomes very large, for example, more than 100G. When restarting Kudu tablet server, it will read all metadata files to check which blocks are still alive and compact metadata files into new small metadata files which only record alive blocks. As the metadata files are very big, compacting metadata files will cost a lot of time, maybe 2-3 hours. That will cause the service unavailabe for a long time, which is unacceptable. Runtime metadata file compacting has already been supported above version of 1.16.0, see jira: KUDU-3318. Upgrading old version to above Kudu 1.16.0 still needs to restart Kudu. This tool helps to compact metdata file for old versions of Kudu. It supports 4 operations: --print: Statistic the total blocks and alive blocks for every container. --compact: Compact metadata files when Kudu is still running --merge: Stop Kudu and write incremental records into compacted metadata files. Then backup old metadata files. --clear: Delete metadata backup files. Restarting old version of Kudu maybe cost 2-3 hours, but using compact tool, service stopped only lasts 3 minutes. Change-Id: Id61cb6c88d7a093a8448e2497639f5c5c094efa4 --- M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_fs.cc M src/kudu/util/pb_util.cc M src/kudu/util/pb_util.h 7 files changed, 681 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/19327/10 -- To view, visit http://gerrit.cloudera.org:8080/19327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id61cb6c88d7a093a8448e2497639f5c5c094efa4 Gerrit-Change-Number: 19327 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20984 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 02 Feb 2024 06:15:00 + Gerrit-HasComments: No
[kudu-CR] [Java] KUDU-3498 Scanner keeps alive in periodically
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20761 ) Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20761/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/20761/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@430 PS8, Line 430: int row_count = 0; We have a checkstyle error here: [ant:checkstyle] [WARN] /home/jenkins-slave/workspace/kudu-master/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:430:11: Local variable name 'row_count' must match pattern '^[a-z]([a-z0-9][a-zA-Z0-9]*)?$'. [LocalVariableName] -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Fri, 02 Feb 2024 07:46:30 + Gerrit-HasComments: Yes
