[kudu-CR] [tests] fix a misprint
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21229 ) Change subject: [tests] fix a misprint .. Patch Set 1: Verified+1 unrelated test failures -- To view, visit http://gerrit.cloudera.org:8080/21229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1 Gerrit-Change-Number: 21229 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 02 Apr 2024 16:57:01 + Gerrit-HasComments: No
[kudu-CR] [tests] fix a misprint
Alexey Serbin has removed a vote on this change. Change subject: [tests] fix a misprint .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1 Gerrit-Change-Number: 21229 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [tests] fix a misprint
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21229 ) Change subject: [tests] fix a misprint .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1 Gerrit-Change-Number: 21229 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 02 Apr 2024 18:20:43 + Gerrit-HasComments: No
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Hello Mahesh Reddy, Marton Greber, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21226 to look at the new patch set (#2). Change subject: KUDU-3561 skip tablet entities in Prometheus format .. KUDU-3561 skip tablet entities in Prometheus format Currently, the Prometheus metrics writer outputs only server-level metrics. Prior to this patch, the Prometheus metrics writer would output a warning message for every tablet it encounters while iterating through all the existing metric entities. This patch addresses the issue: the tablet entries are now silently skipped, as they should. I also added a TODO for KUDU-3563 to output tablet-level metrics in Prometheus format as well. Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 --- M src/kudu/util/metrics.cc 1 file changed, 31 insertions(+), 20 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/21226/2 -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21226/1/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/21226/1/src/kudu/util/metrics.cc@436 PS1, Line 436: metricsa > nit: metrics Done http://gerrit.cloudera.org:8080/#/c/21226/1/src/kudu/util/metrics.cc@442 PS1, Line 442: metricsa > nit: metrics Done -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 02 Apr 2024 18:09:46 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 02 Apr 2024 18:18:37 + Gerrit-HasComments: No
[kudu-CR] [tests] fix a misprint
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21229 ) Change subject: [tests] fix a misprint .. [tests] fix a misprint Tests should use ASSERT_NE(), not DCHECK_NE(). This is a follow-up to e54c80cf9ba129b943eed6af3266899753b1b4ac. Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1 Reviewed-on: http://gerrit.cloudera.org:8080/21229 Tested-by: Alexey Serbin Reviewed-by: Mahesh Reddy Reviewed-by: Abhishek Chennaka --- M src/kudu/integration-tests/disk_reservation-itest.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexey Serbin: Verified Mahesh Reddy: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1 Gerrit-Change-Number: 21229 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yingchun Lai
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 02 Apr 2024 21:32:31 + Gerrit-HasComments: No
[kudu-CR] [tests] fix a misprint
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21229 ) Change subject: [tests] fix a misprint .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1 Gerrit-Change-Number: 21229 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 02 Apr 2024 21:32:57 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3562 fix integer overflow in available space metrics
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21228 ) Change subject: KUDU-3562 fix integer overflow in available space metrics .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec Gerrit-Change-Number: 21228 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 02 Apr 2024 21:33:23 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3562 fix integer overflow in available space metrics
Abhishek Chennaka has removed a vote on this change. Change subject: KUDU-3562 fix integer overflow in available space metrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: deleteVote Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec Gerrit-Change-Number: 21228 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) KUDU-3562 fix integer overflow in available space metrics
Abhishek Chennaka has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/21228 )
Change subject: KUDU-3562 fix integer overflow in available space metrics
..
KUDU-3562 fix integer overflow in available space metrics
This patch addresses KUDU-3562. The problem was in implicit casting
of 64-bit integers down to 32-bit ones when introducing a helper
variable in CalculateAvailableSpace(). A new test scenario is added
to cover the fixed issue and catch regressions in future, if any.
In addition, this patch corrects the type of the related metrics in
disk_failure-itest.cc. It also clarifies on the description and tags
of the --fs_{data_dirs,wal_dir}_available_space_cache_seconds flags.
Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Reviewed-on: http://gerrit.cloudera.org:8080/21227
Reviewed-by: Abhishek Chennaka
Tested-by: Abhishek Chennaka
Reviewed-by: Mahesh Reddy
(cherry picked from commit e54c80cf9ba129b943eed6af3266899753b1b4ac)
Reviewed-on: http://gerrit.cloudera.org:8080/21228
---
M src/kudu/fs/data_dirs.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/server/server_base.cc
4 files changed, 108 insertions(+), 14 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Gerrit-Change-Number: 21228
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Abhishek Chennaka
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. KUDU-3561 skip tablet entities in Prometheus format Currently, the Prometheus metrics writer outputs only server-level metrics. Prior to this patch, the Prometheus metrics writer would output a warning message for every tablet it encounters while iterating through all the existing metric entities. This patch addresses the issue: the tablet entries are now silently skipped, as they should. I also added a TODO for KUDU-3563 to output tablet-level metrics in Prometheus format as well. Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Reviewed-on: http://gerrit.cloudera.org:8080/21226 Reviewed-by: Mahesh Reddy Reviewed-by: Abhishek Chennaka Tested-by: Alexey Serbin --- M src/kudu/util/metrics.cc 1 file changed, 31 insertions(+), 20 deletions(-) Approvals: Mahesh Reddy: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 02 Apr 2024 23:38:32 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3561 skip tablet entities in Prometheus format
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21231 Change subject: KUDU-3561 skip tablet entities in Prometheus format .. KUDU-3561 skip tablet entities in Prometheus format Currently, the Prometheus metrics writer outputs only server-level metrics. Prior to this patch, the Prometheus metrics writer would output a warning message for every tablet it encounters while iterating through all the existing metric entities. This patch addresses the issue: the tablet entries are now silently skipped, as they should. I also added a TODO for KUDU-3563 to output tablet-level metrics in Prometheus format as well. Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Reviewed-on: http://gerrit.cloudera.org:8080/21226 Reviewed-by: Mahesh Reddy Reviewed-by: Abhishek Chennaka Tested-by: Alexey Serbin (cherry picked from commit dd4e37b445da7f367746fb83d92e21b8dc3d8eb8) --- M src/kudu/util/metrics.cc 1 file changed, 31 insertions(+), 20 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/21231/1 -- To view, visit http://gerrit.cloudera.org:8080/21231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: newchange Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21231 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [codegen] fix compilation with CLANG 15 on macOS
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21232 Change subject: [codegen] fix compilation with CLANG 15 on macOS .. [codegen] fix compilation with CLANG 15 on macOS Prior to this fix, compiling Kudu with CLANG 15 on macOS Sonoma would fail with an error like below: [..%] Generating precompiled.ll In file included from src/kudu/codegen/precompiled.cc:39: In file included from src/kudu/common/rowblock.h:21: ... /Applications/Xcode-15.3.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/cstdlib:144:9: error: no member named 'at_quick_exit' in the global namespace using ::at_quick_exit _LIBCPP_USING_IF_EXISTS; ~~^ /Applications/Xcode-15.3.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/cstdlib:145:9: error: no member named 'quick_exit' in the global namespace using ::quick_exit _LIBCPP_USING_IF_EXISTS; Change-Id: Ibe92b7f00fdd446010cea1bda5fd25868a9acabc --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 40 insertions(+), 58 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21232/1 -- To view, visit http://gerrit.cloudera.org:8080/21232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibe92b7f00fdd446010cea1bda5fd25868a9acabc Gerrit-Change-Number: 21232 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
