[kudu-CR] Update build pattern for fetching flaky test list
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 3: Build Aborted http://jenkins.kudu.apache.org/job/pre_commit/17/ : ABORTED -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 11:17:48 + Gerrit-HasComments: No
[kudu-CR] Update build pattern for fetching flaky test list
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 4: Build Started http://jenkins.kudu.apache.org/job/pre_commit/18/ -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 11:17:54 + Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for scans op time
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21291 ) Change subject: [metrics] Add tablet level metrics for scans op time .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/19/ -- To view, visit http://gerrit.cloudera.org:8080/21291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503 Gerrit-Change-Number: 21291 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 18 Apr 2024 11:20:14 + Gerrit-HasComments: No
[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 3: (16 comments) http://gerrit.cloudera.org:8080/#/c/21295/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21295/2//COMMIT_MSG@7 PS2, Line 7: upon opening FSM > 'incorrectly exist' sounds a bit vague and strange to me. Done http://gerrit.cloudera.org:8080/#/c/21295/2//COMMIT_MSG@12 PS2, Line 12: creating a Kudu d > creating ? Done http://gerrit.cloudera.org:8080/#/c/21295/2//COMMIT_MSG@12 PS2, Line 12: ta directory, : open it w > a Kudu data directory Done http://gerrit.cloudera.org:8080/#/c/21295/1/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/21295/1/src/kudu/fs/data_dirs.cc@212 PS1, Line 212: // Initialize the directory only if it's healthy. : // Note: the unhealthy directories wi > Cool, thank you for the details. Because the rocksdb instance will be Open() in RdbDir::Prepare(), this procedure includes some file operations (open files or create files), it'not suitable to place these kind of operations in constructor, so I kept them in the independent Prepare() function. http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/dir_manager.cc File src/kudu/fs/dir_manager.cc: http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/dir_manager.cc@241 PS2, Line 241: // opts.db_log_dir > Is this item still relevant with the patch? Removed. http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1409 PS2, Line 1409: TestOpenDirectoryWithRdbMissing > Does it make sense to also add a test scenario for the following: Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1411 PS2, Line 1411: Skipping 'logr'-specific test"; > Skipping 'logr'-specific test Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1420 PS2, Line 1420: ealthy > nit: healthy Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1420 PS2, Line 1420: Opening the fs manager succeeds, > Opening the fs manager succeeds ... Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1429 PS2, Line 1429: ReinitFsManagerWithOpts(opts); > Opening the fs manager succeeds ... Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1443 PS2, Line 1443: } > Opening Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1457 PS2, Line 1457: ASSERT_STR_CONTAINS(failed_dir->in > ... but this one is 'logr'-specific ... Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1458 PS2, Line 1458: le or > Present Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1460 PS2, Line 1460: > Skipping 'logr'-specific test Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1471 PS2, Line 1471: ASSERT_EQ(2, fs_manager( > nit: move this as close as possible to the call site where it's used? Done http://gerrit.cloudera.org:8080/#/c/21295/2/src/kudu/fs/fs_manager-test.cc@1478 PS2, Line 1478: > nit: add ' << s.ToString();' for easier troubleshooting if this assertion e Done -- To view, visit http://gerrit.cloudera.org:8080/21295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4bffc6b902ab96edf0ca6c44f51c8db2670d52 Gerrit-Change-Number: 21295 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 18 Apr 2024 11:41:43 + Gerrit-HasComments: Yes
[kudu-CR] [CMakeLists] Make kudu test main static
Hello Alexey Serbin, Zoltan Martonka, Attila Bukor, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21282 to look at the new patch set (#2). Change subject: [CMakeLists] Make kudu_test_main static .. [CMakeLists] Make kudu_test_main static This change makes sure that kudu_util.so is loaded at the beginning of the library search order. This is needed because in unwind_safeness.cc there is a dlsym execution in the constructor function, that creates a wrapper for dlopen and dlclose to prevent a potential deadlock during unwind stack resolve. It looks for the next declaration of the functions called "dlopen" and "dlclose" in shared object files. If kudu_util is loaded too late, then it won't find these functions and throws an error. This happens in ubuntu 22.04 test runs. To solve this issue, the kudu_test_main was changed to a static library and kudu_util was moved to the front of the library list. This is a best effort fix, and it should only have impact on test execution. Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea --- M src/kudu/util/CMakeLists.txt 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/21282/2 -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai
[kudu-CR] Update build pattern for fetching flaky test list
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 1: Build Started http://jenkins.kudu.apache.org/job/pre_commit/14/ -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Apr 2024 09:16:24 + Gerrit-HasComments: No
[kudu-CR] [Partition] Allow creating a table with empty range partition
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: [Partition] Allow creating a table with empty range partition .. Patch Set 1: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/16/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 Gerrit-Change-Number: 21328 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Apr 2024 11:15:32 + Gerrit-HasComments: No
[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 3: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/20/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4bffc6b902ab96edf0ca6c44f51c8db2670d52 Gerrit-Change-Number: 21295 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 18 Apr 2024 13:17:46 + Gerrit-HasComments: No
[kudu-CR] Update build pattern for fetching flaky test list
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 3: -Verified Build Started http://jenkins.kudu.apache.org/job/pre_commit/17/ -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 11:17:14 + Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for scans op time
Hello Alexey Serbin, Yingchun Lai, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21291 to look at the new patch set (#2). Change subject: [metrics] Add tablet level metrics for scans op time .. [metrics] Add tablet level metrics for scans op time We currently have monitoring in place for scan data volume and slow scans, but we are still lacking monitoring data for scan time. In this patch, I have added monitoring for scan time at the tablet level to assist us in pinpointing specific scenarios of high CPU usage during scanning operations. Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503 --- M src/kudu/tablet/tablet_metrics.cc M src/kudu/tablet/tablet_metrics.h M src/kudu/tserver/scanners.h M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc 5 files changed, 202 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/21291/2 -- To view, visit http://gerrit.cloudera.org:8080/21291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503 Gerrit-Change-Number: 21291 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yingchun Lai
[kudu-CR] Update build pattern for fetching flaky test list
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh@186 PS2, Line 186: because > nit: because Done http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh@187 PS2, Line 187: As > nit: As Done http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh@188 PS2, Line 188: Any > nit: Any Done -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 11:18:14 + Gerrit-HasComments: Yes
[kudu-CR] Update build pattern for fetching flaky test list
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 4: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/18/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 12:21:34 + Gerrit-HasComments: No
[kudu-CR] [Partition] Allow creating a table with empty range partition
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: [Partition] Allow creating a table with empty range partition .. Patch Set 1: Build Started http://jenkins.kudu.apache.org/job/pre_commit/16/ -- To view, visit http://gerrit.cloudera.org:8080/21328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 Gerrit-Change-Number: 21328 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Apr 2024 09:41:19 + Gerrit-HasComments: No
[kudu-CR] Update build pattern for fetching flaky test list
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 2: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/15/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 11:15:33 + Gerrit-HasComments: No
[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#3). Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. KUDU-3371 check for RocksDB dir presence upon opening FSManager When using RocksDB to store LBM metadata, specify the create_if_missing and error_if_exists options of rocksdb::Options to make sure we can open the RocksDB directory correctly. When creating a Kudu data directory, open it with the options enabled, otherwise, open it with the options disabled. Change-Id: Iab4bffc6b902ab96edf0ca6c44f51c8db2670d52 --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/log_block_manager.cc 5 files changed, 177 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/21295/3 -- To view, visit http://gerrit.cloudera.org:8080/21295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iab4bffc6b902ab96edf0ca6c44f51c8db2670d52 Gerrit-Change-Number: 21295 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [Partition] Allow creating a table with empty range partition
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: [Partition] Allow creating a table with empty range partition .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/common/partition.h@378 PS1, Line 378: Status CreatePartitions( This is not an library exported function, why not add the extra parameter to the function above? http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/common/partition.h@723 PS1, Line 723: Status EncodeRangeBounds( Ditto. http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/catalog_manager.cc@a2041 PS1, Line 2041: The comments can be removed now? http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/master.proto@578 PS1, Line 578: optional bool allow_create_empty_partition = 14 [ default = false ]; Ommit the 'create' word because this structure name (Create...PB) has such a meaning. The same to the parameters and function names in CPP code. http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/tools/kudu-tool-test.cc@1763 PS1, Line 1763: } How about test adding some range partitions to the created table? -- To view, visit http://gerrit.cloudera.org:8080/21328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 Gerrit-Change-Number: 21328 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 18 Apr 2024 11:57:14 + Gerrit-HasComments: Yes
[kudu-CR] [CMakeLists] Make kudu test main static
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21282/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21282/1//COMMIT_MSG@10 PS1, Line 10: loading chain > Please use "library search order" not "loading chain". That's the correct t I fixed the first part, and added a mention that this is a best effort fix. I saw that comment in the code that dynamic linkage isn't used in production anyway. I'm not sure it is a good argument that something is not used in production anyway when there is nothing to stop somebody to use it in production. It is true that it is statically linked on the production environment I could check. http://gerrit.cloudera.org:8080/#/c/21282/1//COMMIT_MSG@14 PS1, Line 14: This happens in ubuntu 22.04 test runs > Could you provide a set of instructions to reproduce the issue? There isn't too much change needed to get this error. On ubuntu 22.04, just run build with this: build-support/enable_devtoolset.sh ./thirdparty/build-if-necessary.sh && $KUDU_DIR/build-support/enable_devtoolset.sh \ $KUDU_DIR/thirdparty/installed/common/bin/cmake \ -DCMAKE_BUILD_TYPE=debug -G Ninja $KUDU_DIR and tests that are in kudu/gutil(for example sysinfo-test) will fail with dlopen error. But it is not 100% reproducable, sometimes it buils fine and sometimes not. It happened on my physical machine and docker and it happened on Zoltan's machine, too. This is a best effort fix from my side. It fixes the problem by making sure that statically linked resources are loaded before dynamically linked. The other solution is to somehow manipulate the library order in the executables, but I couldn't find anything about it and I couldn't even create a 100% percent working solution with manipulating the clang linking command either. http://gerrit.cloudera.org:8080/#/c/21282/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/21282/1/src/kudu/util/CMakeLists.txt@469 PS1, Line 469: add_library(kudu_test_main STATIC > The real question is: How much will this affect TSAN/ASAN build time/disk s I checked it on sysinfo-test with asan build. Without patch: File size: 8.4M Compile time(ninja sysinfo-test): 12.8 sec With patch: File size: 8.6M Compile time(ninja sysinfo-test): 12.6 sec TSAN build is not possible at the moment at all. I tested "-DKUDU_LINK=dynamic", it still seems to work and take effect: with dynamic, kudu-master executable is 75K, with static, it is 520M. I tested with only the static keyword, it sometimes still generated the dlopen error. -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Thu, 18 Apr 2024 13:22:23 + Gerrit-HasComments: Yes
[kudu-CR] [CMakeLists] Make kudu test main static
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 2: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/21/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Thu, 18 Apr 2024 14:18:37 + Gerrit-HasComments: No
[kudu-CR] [Partition] Allow creating a table with empty range partition
Wang Xixu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21328 Change subject: [Partition] Allow creating a table with empty range partition .. [Partition] Allow creating a table with empty range partition Currently, when creating a table without setting range partition, it will create an unbounded partition defaultly. In some cases, this method is not suitable. For example, the user wants to create a table with empty partition, and add a new partition daily to import the data into Kudu. Besides, copying a empty partition table to another cluster will create an unbounded partition table when using the CLI command 'kudu table copy'. It changes the orginal table structure. Therefore, it is better to support to create a table with empty partition, that is without any partitions. Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/table_creator-internal.h M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc 8 files changed, 113 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/21328/1 -- To view, visit http://gerrit.cloudera.org:8080/21328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 Gerrit-Change-Number: 21328 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <1450306...@qq.com>
[kudu-CR] [metrics] Add tablet level metrics for scans op time
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21291 ) Change subject: [metrics] Add tablet level metrics for scans op time .. Patch Set 2: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/19/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503 Gerrit-Change-Number: 21291 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 18 Apr 2024 12:44:09 + Gerrit-HasComments: No
[kudu-CR] Update build pattern for fetching flaky test list
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21327 Change subject: Update build pattern for fetching flaky test list .. Update build pattern for fetching flaky test list During the infra changes which happened in the last months, the build_id prefix has been changed unintentionally. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky test can be fetched correctly. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f --- M build-support/jenkins/build-and-test.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21327/1 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber
[kudu-CR] Update build pattern for fetching flaky test list
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/15/ -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 09:39:29 + Gerrit-HasComments: No
[kudu-CR] Update build pattern for fetching flaky test list
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21327 to look at the new patch set (#2). Change subject: Update build pattern for fetching flaky test list .. Update build pattern for fetching flaky test list During the infra changes which happened in the last months, the build_id prefix has been changed unintentionally. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky test can be fetched correctly. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f --- M build-support/jenkins/build-and-test.sh 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21327/2 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] Update build pattern for fetching flaky test list
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 1: Build Aborted http://jenkins.kudu.apache.org/job/pre_commit/14/ : ABORTED -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 09:39:22 + Gerrit-HasComments: No
[kudu-CR] Update build pattern for fetching flaky test list
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh@186 PS2, Line 186: becuase nit: because http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh@187 PS2, Line 187: as nit: As http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh@188 PS2, Line 188: any nit: Any -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 10:21:11 + Gerrit-HasComments: Yes
[kudu-CR] Update build pattern for fetching flaky test list
Hello Zoltan Chovan, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21327 to look at the new patch set (#4). Change subject: Update build pattern for fetching flaky test list .. Update build pattern for fetching flaky test list During the infra changes which happened in the last months, the build_id prefix has been changed unintentionally. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky test can be fetched correctly. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f --- M build-support/jenkins/build-and-test.sh 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21327/4 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] [metrics] Add tablet level metrics for scans op time
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21291 ) Change subject: [metrics] Add tablet level metrics for scans op time .. Patch Set 2: (1 comment) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21291/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/21291/1/src/kudu/tserver/tablet_service.cc@3025 PS1, Line 3025: tablet->metrics()->tablet_scans_duration_wall_time->Increment(elapsed.wall_seconds()); > Compare to statistics the wall time, is it worthy to consider 'user time' a Done -- To view, visit http://gerrit.cloudera.org:8080/21291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503 Gerrit-Change-Number: 21291 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 18 Apr 2024 11:20:59 + Gerrit-HasComments: Yes
[kudu-CR] Update build pattern for fetching flaky test list
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 09:31:38 + Gerrit-HasComments: No
[kudu-CR] Update build pattern for fetching flaky test list
Hello Zoltan Chovan, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21327 to look at the new patch set (#3). Change subject: Update build pattern for fetching flaky test list .. Update build pattern for fetching flaky test list During the infra changes which happened in the last months, the build_id prefix has been changed unintentionally. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky test can be fetched correctly. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f --- M build-support/jenkins/build-and-test.sh 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21327/3 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 3: Build Started http://jenkins.kudu.apache.org/job/pre_commit/20/ -- To view, visit http://gerrit.cloudera.org:8080/21295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4bffc6b902ab96edf0ca6c44f51c8db2670d52 Gerrit-Change-Number: 21295 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 18 Apr 2024 11:40:39 + Gerrit-HasComments: No
[kudu-CR] [CMakeLists] Make kudu test main static
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/21/ -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Thu, 18 Apr 2024 13:24:25 + Gerrit-HasComments: No
[kudu-CR] Update build pattern for fetching flaky test list
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 4: (2 comments) Overall looks good to me. Just a couple of minor comments. http://gerrit.cloudera.org:8080/#/c/21327/4/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/21327/4/build-support/jenkins/build-and-test.sh@42 PS4, Line 42: kudu-test nit: Change here as well? http://gerrit.cloudera.org:8080/#/c/21327/4/build-support/jenkins/build-and-test.sh@190 PS4, Line 190: jenkins For my understanding or maybe posterity, where was build_id prefix changed that caused the issue? -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 15:13:33 + Gerrit-HasComments: Yes
[kudu-CR] Update build pattern for fetching flaky test list
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 16:32:08 + Gerrit-HasComments: No
[kudu-CR] Allow creating a table with empty range partition
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: Allow creating a table with empty range partition .. Patch Set 2: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/22/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 Gerrit-Change-Number: 21328 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 19 Apr 2024 04:18:26 + Gerrit-HasComments: No
[kudu-CR] Allow creating a table with empty range partition
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: Allow creating a table with empty range partition .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/22/ -- To view, visit http://gerrit.cloudera.org:8080/21328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 Gerrit-Change-Number: 21328 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 19 Apr 2024 03:09:02 + Gerrit-HasComments: No
[kudu-CR] Allow creating a table with empty range partition
Hello Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21328 to look at the new patch set (#2). Change subject: Allow creating a table with empty range partition .. Allow creating a table with empty range partition Currently, when creating a table without setting range partition, it will create an unbounded partition defaultly. In some cases, this method is not suitable. For example, the user wants to create a table with empty partition, and add a new partition daily to import the data into Kudu. Besides, copying a empty partition table to another cluster will create an unbounded partition table when using the CLI command 'kudu table copy'. It changes the orginal table structure. Therefore, it is better to support to create a table with empty partition, that is without any partitions. Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/table_creator-internal.h M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc 8 files changed, 90 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/21328/2 -- To view, visit http://gerrit.cloudera.org:8080/21328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 Gerrit-Change-Number: 21328 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] Allow creating a table with empty range partition
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: Allow creating a table with empty range partition .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/common/partition.h@378 PS1, Line 378: Status CreatePartitionsForRange( > This is not an library exported function, why not add the extra parameter t Done http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/common/partition.h@723 PS1, Line 723: HashSchema hash_schema_; > Ditto. Done http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/catalog_manager.cc@a2041 PS1, Line 2041: > The comments can be removed now? No, this comments is for the code line 2046 ~ 2050 http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/master.proto@578 PS1, Line 578: optional bool allow_empty_partition = 14 [ default = false ]; > Ommit the 'create' word because this structure name (Create...PB) has such Done http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/tools/kudu-tool-test.cc@1763 PS1, Line 1763: // Create a new partition. > How about test adding some range partitions to the created table? Done -- To view, visit http://gerrit.cloudera.org:8080/21328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 Gerrit-Change-Number: 21328 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 19 Apr 2024 03:10:21 + Gerrit-HasComments: Yes
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Hello Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21300 to look at the new patch set (#3). Change subject: [metrics] Add tablet level metrics for alter schema op time .. [metrics] Add tablet level metrics for alter schema op time Add tablet-level statistics to track the time consumption of alter schema operations. Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a --- M src/kudu/tablet/ops/alter_schema_op.cc M src/kudu/tablet/ops/alter_schema_op.h M src/kudu/tablet/tablet_metrics.cc M src/kudu/tablet/tablet_metrics.h M src/kudu/tablet/tablet_replica-test.cc 5 files changed, 55 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/21300/3 -- To view, visit http://gerrit.cloudera.org:8080/21300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a Gerrit-Change-Number: 21300 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 ) Change subject: [metrics] Add tablet level metrics for alter schema op time .. Patch Set 3: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/13/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a Gerrit-Change-Number: 21300 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 18 Apr 2024 07:18:33 + Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 ) Change subject: [metrics] Add tablet level metrics for alter schema op time .. Patch Set 3: Build Started http://jenkins.kudu.apache.org/job/pre_commit/13/ -- To view, visit http://gerrit.cloudera.org:8080/21300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a Gerrit-Change-Number: 21300 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 18 Apr 2024 06:23:23 + Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
KeDeng has posted comments on this change. (
http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
..
Patch Set 3:
(7 comments)
Thanks for your reviews.
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/ops/alter_schema_op.cc
File src/kudu/tablet/ops/alter_schema_op.cc:
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/ops/alter_schema_op.cc@179
PS2, Line 179: DCHECK_EQ(result, Op::APPLIED);
> 1. Should this metric also statistics the duraction when the ops aborted (l
1.done
2.The scope of ScopedLatencyMetric is limited and not quite suitable here; I
will use a lambda function to achieve a similar functionality.
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_metrics.cc
File src/kudu/tablet/tablet_metrics.cc:
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_metrics.cc@227
PS2, Line 227: METRIC_DEFINE_histogram(tablet, alter_schema_duration,
> nit: Leave one blank line is enough.
Done
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc
File src/kudu/tablet/tablet_replica-test.cc:
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@267
PS2, Line 267: const int orig_schema_version =
tablet()->metadata()->schema_version();
> Is 'orig_schema_pb' necessary?
Removed.
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@272
PS2, Line 272: const auto before_cnt = alter_schema_duration->TotalCount();
:
> Is it possible to get the metric via tablet_replica_->tablet()->metrics()->
Done
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@274
PS2, Line 274: // Add a new column.
> nit: add 'const'
Done
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@279
PS2, Line 279: ASSERT_OK(UpdateSchema(new_schema, orig_schema_version + 1));
> Is 'new_client_schema' necessary?
Removed.
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@285
PS2, Line 285: TEST_F(TabletReplicaTest, TestMRSAnchorPreventsLogGC) {
: ConsensusBootstrapInfo info;
> Is this debugging purpose only? Remove it if not necessary, check the metri
Done
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng
Gerrit-Reviewer: KeDeng
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai
Gerrit-Comment-Date: Thu, 18 Apr 2024 06:24:51 +
Gerrit-HasComments: Yes
