[kudu-CR] [java client] Fix GetTableLocations error handling
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3295 to look at the new patch set (#2). Change subject: [java client] Fix GetTableLocations error handling .. [java client] Fix GetTableLocations error handling When GetTableLocations get an error, e.g. table not found, in some scenario the callback will silently drop the error, not notifying the RPC which triggered this GetTableLocations call, causing the RPC to hang. This usually happens when user is inserting data, but underlying table is deleted and recreated. Change-Id: I79d246a83e9f0071063a23fb9a8d4b4c0220e507 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java 2 files changed, 34 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/3295/2 -- To view, visit http://gerrit.cloudera.org:8080/3295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79d246a83e9f0071063a23fb9a8d4b4c0220e507 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin ChangGerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions
Dan Burkert has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3255/2/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: PS2, Line 308: else if (!s.ok()) { : return s; : } > You don't need the 'else' statement either. Done -- To view, visit http://gerrit.cloudera.org:8080/3255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3255 to look at the new patch set (#7). Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. KUDU-1308 [c++-client]: support tables with non-covering range partitions This commit introduces range bounds to the C++ client's table creation options. Specifying range bounds allows applications to create tables with non-covering range partitions, as described in the non-covering range partitions design document. Additionally, the client is updated to work with tables with non-covering range partitions. Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 --- M src/kudu/client/batcher.cc M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/scan_token-internal.cc M src/kudu/client/scanner-internal.cc M src/kudu/client/scanner-internal.h M src/kudu/client/table_creator-internal.h M src/kudu/common/partition_pruner-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/partition_pruner.h M src/kudu/integration-tests/flex_partitioning-itest.cc 16 files changed, 597 insertions(+), 314 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/3255/7 -- To view, visit http://gerrit.cloudera.org:8080/3255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3255 to look at the new patch set (#6). Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. KUDU-1308 [c++-client]: support tables with non-covering range partitions This commit introduces range bounds to the C++ client's table creation options. Specifying range bounds allows applications to create tables with non-covering range partitions, as described in the non-covering range partitions design document. Additionally, the client is updated to work with tables with non-covering range partitions. Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 --- M src/kudu/client/batcher.cc M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/scan_token-internal.cc M src/kudu/client/scanner-internal.cc M src/kudu/client/scanner-internal.h M src/kudu/client/table_creator-internal.h M src/kudu/common/partition_pruner-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/partition_pruner.h M src/kudu/integration-tests/flex_partitioning-itest.cc 16 files changed, 597 insertions(+), 314 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/3255/6 -- To view, visit http://gerrit.cloudera.org:8080/3255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Avoid unused var warning in deltafile-test.cc
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3288 Change subject: Avoid unused var warning in deltafile-test.cc .. Avoid unused var warning in deltafile-test.cc Now that in memory env has been removed kTestPath is no longer needed and was causing a compilation warning. Change-Id: I8b8ad55b3a7711515e84bc6453bd152b41556f14 --- M src/kudu/tablet/deltafile-test.cc 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/3288/1 -- To view, visit http://gerrit.cloudera.org:8080/3288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b8ad55b3a7711515e84bc6453bd152b41556f14 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves
[kudu-CR] Avoid unused var warning in deltafile-test.cc
Kudu Jenkins has posted comments on this change. Change subject: Avoid unused var warning in deltafile-test.cc .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1722/ -- To view, visit http://gerrit.cloudera.org:8080/3288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b8ad55b3a7711515e84bc6453bd152b41556f14 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro AlvesGerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/1721/ -- To view, visit http://gerrit.cloudera.org:8080/3255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] increase table locations-itest timeout
Kudu Jenkins has posted comments on this change. Change subject: increase table_locations-itest timeout .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1720/ -- To view, visit http://gerrit.cloudera.org:8080/3287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I982ece11c93a2853e0d8ae29d66bb0ccdd0a1288 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] increase table locations-itest timeout
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3287 to review the following change. Change subject: increase table_locations-itest timeout .. increase table_locations-itest timeout The table_locations-itest is frequently timing out while creating an 8 tablet, 3 replica table. The current timeout is 5 seconds, this commit raises it to 38. Change-Id: I982ece11c93a2853e0d8ae29d66bb0ccdd0a1288 --- M src/kudu/integration-tests/table_locations-itest.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/3287/1 -- To view, visit http://gerrit.cloudera.org:8080/3287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I982ece11c93a2853e0d8ae29d66bb0ccdd0a1288 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3255 to look at the new patch set (#5). Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. KUDU-1308 [c++-client]: support tables with non-covering range partitions This commit introduces range bounds to the C++ client's table creation options. Specifying range bounds allows applications to create tables with non-covering range partitions, as described in the non-covering range partitions design document. Additionally, the client is updated to work with tables with non-covering range partitions. Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 --- M src/kudu/client/batcher.cc M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/scan_token-internal.cc M src/kudu/client/scanner-internal.cc M src/kudu/client/scanner-internal.h M src/kudu/client/table_creator-internal.h M src/kudu/common/partition_pruner-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/partition_pruner.h M src/kudu/integration-tests/flex_partitioning-itest.cc 16 files changed, 580 insertions(+), 298 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/3255/5 -- To view, visit http://gerrit.cloudera.org:8080/3255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions
Dan Burkert has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/3255/2/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: Line 811: void MetaCache::ClearCacheForTesting() { > Surprised ASAN didn't complain about this. More missing test coverage? There are ASAN failures, but I haven't tracked them all down yet... http://gerrit.cloudera.org:8080/#/c/3255/4/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: PS4, Line 776: if (not_found) return Status::NotFound("No tablet covering the requested range partition"); : return Status::OK(); > Nit: how about: Done http://gerrit.cloudera.org:8080/#/c/3255/4/src/kudu/integration-tests/flex_partitioning-itest.cc File src/kudu/integration-tests/flex_partitioning-itest.cc: Line 63: HashPartitionOptions(vector columns, > Do you really need the constructors for this and RangePartitionOptions? Can Didn't know that was an option. TIL. Line 249: STLDeleteValues(_map); > What's this doing here? The map is new. Done PS4, Line 250: CHECK_OK(itest::CreateTabletServerMap(cluster_->master_proxy().get(), : cluster_->messenger(), : _map)); : : vector tablets; : CHECK_OK(ListTablets(ts_map.begin()->second, MonoDelta::FromSeconds(10), )); : return tablets.size(); > Seems strange to do this via a tserver call instead of GetTableLocations() What class is GetTableLocations defined on? Line 263: Status InsertRows(const RangePartitionOptions& range_partition, int* row_count); > Nit: also add that on success, row_count contains the number of rows actual Done Line 297: vector> default_bounds = { { { 0 }, { 1000 } } }; > Maybe should be static and declared as kDefaultBounds? Done Line 552: NO_FATALS(TestPartitionOptions(hash_option, range_option)); > Does this do the right thing even though there are no NO_FATALS() wrappers I'm not sure. I made sure every call site of a helper function that has an assert is wrapped in NO_FATALS, but maybe this isn't the correct way -- To view, visit http://gerrit.cloudera.org:8080/3255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Improve tpch usability
Adar Dembo has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh File src/kudu/scripts/tpch.sh: Line 70: $ROOT/src/kudu/scripts/ensure_cpu_scaling.sh "$@" > To clarify, the script expected me to run from $ROOT but I ran from $ROOT/b So $BASH_SOURCE doesn't actually yield absolute paths? Didn't know that. How about this instead: $(cd $(dirname $BASH_SOURCE) && pwd)/ensure_cpu_scaling.sh "$@" The advantage is that we haven't hardcoded a subdirectory tree into the call, so it'll be less stuff to update if the scripts are moved. -- To view, visit http://gerrit.cloudera.org:8080/3279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] Improve tpch usability
Adar Dembo has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3279/2/src/kudu/scripts/tpch.sh File src/kudu/scripts/tpch.sh: Line 129: $ROOT/build/$BUILD_TYPE/bin/tpch1 -logtostderr=1 \ Why is this necessary? L81 does "cd $ROOT", and the rest of the code here (e.g. L111 and L112) behaves accordingly. Line 133: $* \ Surprised this doesn't need quoting, or to be "$@" or something. I can never remember exactly what the difference is in bash. -- To view, visit http://gerrit.cloudera.org:8080/3279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] Fix reorder warning in TabletMetadata
Kudu Jenkins has posted comments on this change. Change subject: Fix reorder warning in TabletMetadata .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/1718/ -- To view, visit http://gerrit.cloudera.org:8080/3281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I125b4d9d28b5883870bc99987898410957e657b5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](gh-pages) No default partitioning blog post
Dan Burkert has uploaded a new patch set (#4). Change subject: No default partitioning blog post .. No default partitioning blog post Change-Id: I14ace416b3eb5b61bb522a388e564be2e7dce3a9 --- A _posts/2016-06-02-no-default-partitioning.md 1 file changed, 97 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/3277/4 -- To view, visit http://gerrit.cloudera.org:8080/3277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I14ace416b3eb5b61bb522a388e564be2e7dce3a9 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Dan BurkertGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Improve tpch usability
Mike Percy has abandoned this change. Change subject: Improve tpch usability .. Abandoned accidental dup review -- To view, visit http://gerrit.cloudera.org:8080/3280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1acab30034c3404ebefe3c50858640a6b2d9fe8c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Kudu Jenkins
[kudu-CR] Improve tpch usability
Mike Percy has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh File src/kudu/scripts/tpch.sh: Line 70: $ROOT/src/kudu/scripts/ensure_cpu_scaling.sh "$@" > Since dirname "../../foo/bar" remains just that even after you change direc To clarify, the script expected me to run from $ROOT but I ran from $ROOT/build/release and it barfed. -- To view, visit http://gerrit.cloudera.org:8080/3279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes