[kudu-CR] Implement SchemaRelationProvider

2016-06-29 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: Implement SchemaRelationProvider
..


Patch Set 1:

(1 comment)

LGTM except for the style nit.

http://gerrit.cloudera.org:8080/#/c/3529/1/java/kudu-spark/src/main/scala/org/kududb/spark/kudu/DefaultSource.scala
File java/kudu-spark/src/main/scala/org/kududb/spark/kudu/DefaultSource.scala:

Line 140:   override def schema: StructType = {
I think the body of this would be clearer as:

userSchema match {
  case Some(x) =>
StructType(x.fields.map(uf => table.getSchema.getColumn(uf.name))
   .map(kuduColumnToSparkField))
  case None =>

StructType(table.getSchema.getColumns.asScala.map(kuduColumnToSparkField).toArray)
}


-- 
To view, visit http://gerrit.cloudera.org:8080/3529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4194d7ec139f0f9e3c1d508e8aca860484839d56
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andy Grove 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Implement SchemaRelationProvider

2016-06-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Implement SchemaRelationProvider
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2093/

-- 
To view, visit http://gerrit.cloudera.org:8080/3529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4194d7ec139f0f9e3c1d508e8aca860484839d56
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andy Grove 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Implement SchemaRelationProvider

2016-06-28 Thread Andy Grove (Code Review) 
Andy Grove has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3529

Change subject: Implement SchemaRelationProvider
..

Implement SchemaRelationProvider

Change-Id: I4194d7ec139f0f9e3c1d508e8aca860484839d56
---
M java/kudu-spark/src/main/scala/org/kududb/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/test/scala/org/kududb/spark/kudu/DefaultSourceTest.scala
2 files changed, 75 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/3529/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4194d7ec139f0f9e3c1d508e8aca860484839d56
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andy Grove