Re: Review Request 35433: CHECK that checkpointed resources exist on the slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review87849 --- Patch looks great! Reviews applied: [35433] All tests passed. - Mesos ReviewBot On June 13, 2015, 9:43 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 13, 2015, 9:43 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos Description --- No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches. Diffs - src/slave/slave.cpp 9af69d8f0b28c9441c684886c52320378f9b2869 Diff: https://reviews.apache.org/r/35433/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 34375: Removed use of namespace aliases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/#review87851 --- Patch looks great! Reviews applied: [34375] All tests passed. - Mesos ReviewBot On June 13, 2015, 9:51 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/ --- (Updated June 13, 2015, 9:51 p.m.) Review request for mesos and Till Toenshoff. Repository: mesos Description --- See summary. Diffs - src/master/master.cpp 3049e057c87571f5db73ee0b14db8b47132b2dff src/slave/slave.cpp 9af69d8f0b28c9441c684886c52320378f9b2869 src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b src/tests/slave_tests.cpp 8dae6e0842c2bedddc13d1c036390e85c7a96df7 Diff: https://reviews.apache.org/r/34375/diff/ Testing --- make check Thanks, Michael Park
Re: Review Request 35395: Improvements to the synchronized macro.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35395/
---
(Updated June 14, 2015, 2:20 a.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Summary (updated)
-
Improvements to the synchronized macro.
Repository: mesos
Description
---
(1) Simplify introducing new synchronization primitives.
Before:
```cpp
template
class Synchronizedbufferevent
{
public:
Synchronized(bufferevent* _bev) : bev(CHECK_NOTNULL(_bev))
{
bufferevent_lock(bev);
}
Synchronized(bufferevent** _bev) : Synchronized(*CHECK_NOTNULL(_bev)) {}
~Synchronized()
{
bufferevent_unlock(bev);
}
operator bool() const { return true; }
private:
bufferevent* bev;
};
```
After:
```cpp
Synchronizedbufferevent synchronize(bufferevent* bev) {
return {
bev,
[](bufferevent* bev) { bufferevent_lock(bev); }
[](bufferevent* bev) { bufferevent_unlock(bev); }
};
}
```
(2) Enable `return` within `synchronized` and avoid the `control reaches end of
non-void function` warning.
```cpp
int foo()
{
int x = 42;
std::mutex m;
synchronized (m) {
return x;
}
}
```
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp
60eaf263f220b4990aefe4e5d6d2aa1296891e57
Diff: https://reviews.apache.org/r/35395/diff/
Testing
---
`make check`
Thanks,
Michael Park
Re: Review Request 35395: Improvements to Synchronized.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35395/
---
(Updated June 13, 2015, 12:51 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Repository: mesos
Description
---
(1) Simplify introducing new synchronization primitives.
Before:
```cpp
template
class Synchronizedbufferevent
{
public:
Synchronized(bufferevent* _bev) : bev(CHECK_NOTNULL(_bev))
{
bufferevent_lock(bev);
}
Synchronized(bufferevent** _bev) : Synchronized(*CHECK_NOTNULL(_bev)) {}
~Synchronized()
{
bufferevent_unlock(bev);
}
operator bool() const { return true; }
private:
bufferevent* bev;
};
```
After:
```cpp
Synchronizedbufferevent synchronize(bufferevent* bev) {
return {
bev,
[](bufferevent* bev) { bufferevent_lock(bev); }
[](bufferevent* bev) { bufferevent_unlock(bev); }
};
}
```
(2) Enable `return` within `synchronized` and avoid the `control reaches end of
non-void function` warning.
```cpp
int foo()
{
int x = 42;
std::mutex m;
synchronized (m) {
return x;
}
}
```
Diffs (updated)
-
3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp
60eaf263f220b4990aefe4e5d6d2aa1296891e57
Diff: https://reviews.apache.org/r/35395/diff/
Testing
---
`make check`
Thanks,
Michael Park
Re: Review Request 35095: Update linux fs to use synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35095/#review87821 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35095/ --- (Updated June 4, 2015, 10:54 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 Diff: https://reviews.apache.org/r/35095/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35094: Update libprocess gate to use synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35094/#review87820 --- Ship it! Same comment as https://reviews.apache.org/r/35093 here, basically, we can still use synchronized! I'll fix and commit. - Benjamin Hindman On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35094/ --- (Updated June 4, 2015, 10:54 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/src/gate.hpp 69c906baabbc05fdc33aca94b587fc3c8633f7b6 Diff: https://reviews.apache.org/r/35094/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35097: Update mesos executor to use synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35097/#review87823 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 11:07 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35097/ --- (Updated June 4, 2015, 11:07 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - include/mesos/executor.hpp f3cd3ccd505ed4b308a1a42b238fc21fe45cc3b3 src/exec/exec.cpp 0dfd5a6a45a9b2dabeee5e402ab1c5e310c24848 Diff: https://reviews.apache.org/r/35097/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35102: Remove common/lock. Use synchronized instead.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/#review87830 --- Ship it! Ship It! - Benjamin Hindman On June 5, 2015, 7:42 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/ --- (Updated June 5, 2015, 7:42 a.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/Makefile.am 3cf8bd2e86ce5823160f2984738c4e1391081c6a src/common/lock.hpp 988dff524e3d9f6c0bafa3398f6c3c258829cfe3 src/common/lock.cpp bb8ea3ada6b710357e6872959868d2d8a2035371 Diff: https://reviews.apache.org/r/35102/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 35426: mesos: Use CHECK_SOME, CHECK_NONE, CHECK_ERROR.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35426/#review87832 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 2:07 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35426/ --- (Updated June 13, 2015, 2:07 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- Used `grep -r CHECK([^!].*.isNone()) .` to find the instances that look like `CHECK(x.isNone());` Diffs - src/launcher/fetcher.cpp a3d27dc0675221fdeab8ab57e053e98fbc6fccbd src/linux/cgroups.cpp a612fab2d25516be0981822658bef2d0b90488f0 src/master/registrar.cpp 3fde8fa3ed3b412fa48542c001d86efdd0a9768a src/slave/containerizer/isolators/cgroups/cpushare.cpp 5bd352549553fc0caf62bf116deb5cece35679c6 src/slave/containerizer/isolators/cgroups/mem.cpp 7fb6c8ab69ea64aadc81f2b0e4c769d5305107e3 src/slave/status_update_manager.cpp 1d7c4d09cd530e03c47c0cffca336ea2104b0bcf src/state/leveldb.cpp 4303df3849a2023cfddaf9cf741ffefe6aada528 src/state/zookeeper.cpp d355bd7ea39a69e4a248f03b776067e5da49e0e3 src/zookeeper/contender.cpp 55cb7a14542e5344148106e196f8c4470496a542 src/zookeeper/group.cpp 173caa859d8566318a1a832a8b763405ce41afc1 Diff: https://reviews.apache.org/r/35426/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 28763: Add configure flag to enable SSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28763/#review87833 --- Ship it! Ship It! - Michael Park On June 13, 2015, 8:26 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28763/ --- (Updated June 13, 2015, 8:26 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-2108 https://issues.apache.org/jira/browse/MESOS-2108 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/configure.ac 710490b2a7c71f35434494e87e2d132f78ef370a Diff: https://reviews.apache.org/r/28763/diff/ Testing --- configure with '--enable-libevent --enable--ssl' and without. Thanks, Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87834 --- Ship it! Ship It! - Michael Park On June 13, 2015, 9:23 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 9:23 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-1913 https://issues.apache.org/jira/browse/MESOS-1913 Repository: mesos Description --- Requires: configure --enable-libevent --enable-libevent-socket --enable-ssl New environment variables: ``` SSL_ENABLED=(false|0,true|1) SSL_CERT_FILE=(path to certificate) SSL_KEY_FILE=(path to key) SSL_VERIFY_CERT=(false|0,true|1) SSL_REQUIRE_CERT=(false|0,true|1) SSL_VERIFY_DEPTH=(4) SSL_CA_DIR=(path to CA directory) SSL_CA_FILE=(path to CA file) SSL_CIPHERS=(accepted ciphers separated by ':') SSL_ENABLE_SSL_V2=(false|0,true|1) SSL_ENABLE_SSL_V3=(false|0,true|1) SSL_ENABLE_TLS_V1_0=(false|0,true|1) SSL_ENABLE_TLS_V1_1=(false|0,true|1) SSL_ENABLE_TLS_V1_2=(false|0,true|1) ``` Only TLSV1.2 is enabled by default. Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols. Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers. Diffs - 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION 3rdparty/libprocess/src/openssl.hpp PRE-CREATION 3rdparty/libprocess/src/openssl.cpp PRE-CREATION 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere
Re: Review Request 35426: mesos: Use CHECK_SOME, CHECK_NONE, CHECK_ERROR.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35426/#review87835 --- Patch looks great! Reviews applied: [35422, 35423, 35425, 35426] All tests passed. - Mesos ReviewBot On June 13, 2015, 2:07 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35426/ --- (Updated June 13, 2015, 2:07 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- Used `grep -r CHECK([^!].*.isNone()) .` to find the instances that look like `CHECK(x.isNone());` Diffs - src/launcher/fetcher.cpp a3d27dc0675221fdeab8ab57e053e98fbc6fccbd src/linux/cgroups.cpp a612fab2d25516be0981822658bef2d0b90488f0 src/master/registrar.cpp 3fde8fa3ed3b412fa48542c001d86efdd0a9768a src/slave/containerizer/isolators/cgroups/cpushare.cpp 5bd352549553fc0caf62bf116deb5cece35679c6 src/slave/containerizer/isolators/cgroups/mem.cpp 7fb6c8ab69ea64aadc81f2b0e4c769d5305107e3 src/slave/status_update_manager.cpp 1d7c4d09cd530e03c47c0cffca336ea2104b0bcf src/state/leveldb.cpp 4303df3849a2023cfddaf9cf741ffefe6aada528 src/state/zookeeper.cpp d355bd7ea39a69e4a248f03b776067e5da49e0e3 src/zookeeper/contender.cpp 55cb7a14542e5344148106e196f8c4470496a542 src/zookeeper/group.cpp 173caa859d8566318a1a832a8b763405ce41afc1 Diff: https://reviews.apache.org/r/35426/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35096: Update mesos scheduler to use synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35096/#review87822 --- Ship it! Can also use synchronized with std::unique_lock here, I'll adjust and commit. - Benjamin Hindman On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35096/ --- (Updated June 4, 2015, 10:54 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - include/mesos/scheduler.hpp 2ee6b5cc0745b3ac4637bb97843a00024fb94570 src/sched/sched.cpp 8c366ec3e3cf55dacf49483e1ceeef61ab0187b3 Diff: https://reviews.apache.org/r/35096/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35098: Update module manager to use synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35098/#review87824 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35098/ --- (Updated June 4, 2015, 10:54 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/module/manager.hpp 4befb64420632e6f34e380e276ebfa030872b135 src/module/manager.cpp c6de654ec6188665f20bf75f079bc95f378b6a3a Diff: https://reviews.apache.org/r/35098/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35099: Update cram_md5 to use synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35099/#review87826 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:55 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35099/ --- (Updated June 4, 2015, 10:55 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/authentication/cram_md5/auxprop.hpp 1a054ba99f28030f3ccfa670c666284f46d1a35c src/authentication/cram_md5/auxprop.cpp 4cabaa303e19a9f9a42d1412520f5440f1949a5d Diff: https://reviews.apache.org/r/35099/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35253: Enable configure to detect libevent and openssl on Mac OS X.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35253/ --- (Updated June 13, 2015, 2:32 p.m.) Review request for mesos, Benjamin Hindman, Cody Maloney, Joris Van Remoortere, and Till Toenshoff. Changes --- Rebase Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/configure.ac 710490b2a7c71f35434494e87e2d132f78ef370a Diff: https://reviews.apache.org/r/35253/diff/ Testing --- Ran `configure` and observed that the warnings from OS X system-level `libevent` and `openssl` disappear. Thanks, Michael Park
Re: Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/#review87809 --- Patch looks great! Reviews applied: [35422, 35423] All tests passed. - Mesos ReviewBot On June 13, 2015, 12:24 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/ --- (Updated June 13, 2015, 12:24 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/check.hpp 60989accf3a4d8a9453843015aeff35143b6b737 Diff: https://reviews.apache.org/r/35423/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35089: Replace lock_guard with synchronized in fetcher_cache_test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35089/#review87813 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:53 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35089/ --- (Updated June 4, 2015, 10:53 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/tests/fetcher_cache_tests.cpp cbd44b98d19953d174fac977f509d4900a37481f Diff: https://reviews.apache.org/r/35089/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35091: Update libprocess gmock to use synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35091/#review87815 --- Ship it! With MPark's refactor we can kill the 'UNREACHABLE()'! I'll do that for you now! AWESOME! - Benjamin Hindman On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35091/ --- (Updated June 4, 2015, 10:54 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/gmock.hpp 6adc034daf8976e3dc6df46f9adf8ab73eaf2af8 Diff: https://reviews.apache.org/r/35091/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35129/#review87816 --- 3rdparty/libprocess/include/process/future.hpp https://reviews.apache.org/r/35129/#comment140262 `CHECK_ERROR` exists now :) - Michael Park On June 5, 2015, 1:16 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35129/ --- (Updated June 5, 2015, 1:16 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-2801 https://issues.apache.org/jira/browse/MESOS-2801 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/future.hpp 75cbe122f18d2a8ea919331e7fc91e1ec3bfd28b Diff: https://reviews.apache.org/r/35129/diff/ Testing --- make check Thanks, Joris Van Remoortere
Review Request 35426: mesos: Use CHECK_SOME, CHECK_NONE, CHECK_ERROR.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35426/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description --- Used `grep -r CHECK([^!].*.isNone()) .` to find the instances that look like `CHECK(x.isNone());` Diffs - src/launcher/fetcher.cpp a3d27dc0675221fdeab8ab57e053e98fbc6fccbd src/linux/cgroups.cpp a612fab2d25516be0981822658bef2d0b90488f0 src/master/registrar.cpp 3fde8fa3ed3b412fa48542c001d86efdd0a9768a src/slave/containerizer/isolators/cgroups/cpushare.cpp 5bd352549553fc0caf62bf116deb5cece35679c6 src/slave/containerizer/isolators/cgroups/mem.cpp 7fb6c8ab69ea64aadc81f2b0e4c769d5305107e3 src/slave/status_update_manager.cpp 1d7c4d09cd530e03c47c0cffca336ea2104b0bcf src/state/leveldb.cpp 4303df3849a2023cfddaf9cf741ffefe6aada528 src/state/zookeeper.cpp d355bd7ea39a69e4a248f03b776067e5da49e0e3 src/zookeeper/contender.cpp 55cb7a14542e5344148106e196f8c4470496a542 src/zookeeper/group.cpp 173caa859d8566318a1a832a8b763405ce41afc1 Diff: https://reviews.apache.org/r/35426/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35100: Update hook manager to use synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35100/#review87828 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:55 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35100/ --- (Updated June 4, 2015, 10:55 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/hook/manager.cpp 54b0d34b6e9f2f8a8cf7a6c2f5ded2f6ab6c6955 Diff: https://reviews.apache.org/r/35100/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35101: Update zookeeper tests to use synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35101/#review87829 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:55 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35101/ --- (Updated June 4, 2015, 10:55 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/tests/zookeeper.hpp d8f1cb345040121368094d1e6d55ddaa791f0e31 src/tests/zookeeper.cpp 08cab86d148edf0cae3aaebfda30c21a75bca2b2 Diff: https://reviews.apache.org/r/35101/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35425: libprocess: Use CHECK_NONE.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35425/#review87831 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 2:06 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35425/ --- (Updated June 13, 2015, 2:06 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- Used `grep -r CHECK([^!].*.isNone()) .` to find the instances that look like `CHECK(x.isNone());` Diffs - 3rdparty/libprocess/src/decoder.hpp 56adde07b650984de367fb861d7a496fa37884cb Diff: https://reviews.apache.org/r/35425/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 29406: Introduce libevent ssl socket.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 7:13 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Changes --- Clean up some error cases. Bugs: MESOS-1913 https://issues.apache.org/jira/browse/MESOS-1913 Repository: mesos Description --- Requires: configure --enable-libevent --enable-libevent-socket --enable-ssl New environment variables: ``` SSL_ENABLED=(false|0,true|1) SSL_CERT_FILE=(path to certificate) SSL_KEY_FILE=(path to key) SSL_VERIFY_CERT=(false|0,true|1) SSL_REQUIRE_CERT=(false|0,true|1) SSL_VERIFY_DEPTH=(4) SSL_CA_DIR=(path to CA directory) SSL_CA_FILE=(path to CA file) SSL_CIPHERS=(accepted ciphers separated by ':') SSL_ENABLE_SSL_V2=(false|0,true|1) SSL_ENABLE_SSL_V3=(false|0,true|1) SSL_ENABLE_TLS_V1_0=(false|0,true|1) SSL_ENABLE_TLS_V1_1=(false|0,true|1) SSL_ENABLE_TLS_V1_2=(false|0,true|1) ``` Only TLSV1.2 is enabled by default. Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols. Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers. Diffs (updated) - 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION 3rdparty/libprocess/src/openssl.hpp PRE-CREATION 3rdparty/libprocess/src/openssl.cpp PRE-CREATION 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere
Re: Review Request 28763: Add configure flag to enable SSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28763/ --- (Updated June 13, 2015, 8:26 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Changes --- modify LIB line during configure as opposed to makefile Bugs: MESOS-2108 https://issues.apache.org/jira/browse/MESOS-2108 Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/configure.ac 710490b2a7c71f35434494e87e2d132f78ef370a Diff: https://reviews.apache.org/r/28763/diff/ Testing --- configure with '--enable-libevent --enable--ssl' and without. Thanks, Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87783
---
Reviewed `libevent_ssl_socket.{hpp,cpp}`.
I don't have much confidence at all around whether we free memory properly. The
calls to `SSL_free`, `delete request`, `bufferevent_free(bev); bev = NULL;`
occur in many places :( Otherwise things look good to me.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140225
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
Note: The 'self' needs to be explicitly captured because we're not using
it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140207
`bev` is unused and also shadows the member variable. Omit?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140208
`bev` is unused and also shadows the member variable. Omit?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140209
`bev` is unused and also shadows the member variable. Omit?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140210
```cpp
current_connect_request-promise.fail(
Failed connect: connection closed);
```
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140229
Remove newline.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140217
This fits in one line.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140218
No need for `else`.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140216
Maybe `s/weak_socket/weak_self/`?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140214
Add space after `//`: `// executed.`
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140215
`s/un-necessarily/unnecessarily/`
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140220
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
Note: The 'self' needs to be explicitly captured because we're not using
it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140212
No need for `else`.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140219
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
Note: The 'self' needs to be explicitly captured because we're not using
it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140213
The `size` is captured here but not used?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140221
No need for `else`.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140222
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
Note: The 'self' needs to be explicitly captured because we're not using
it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140223
No need for `else`.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140224
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
Note: The 'self' needs to be explicitly captured because we're not using
it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140230
Remove newline.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140226
Can we move this below the `bufferevent_setcb` call? That way we construct
it as late as possible, and we can also do: `Socket socket =
Socket::Impl::socket(std::move(impl));`
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140227
`char error_buffer[1024] = {};`
3rdparty/libprocess/src/libevent_ssl_socket.cpp
https://reviews.apache.org/r/29406/#comment140228
`ERR_error_string_n(openssl_error, error_buffer, sizeof(error_buffer));`
Also, I don't think we need `sizeof(error_buffer) - 1`.
ERR_error_string_n() is a variant of ERR_error_string() that writes at
most `len` characters (__including the terminating 0__) and truncates the
string if necessary. For ERR_error_string_n(), buf may
Re: Review Request 29406: Introduce libevent ssl socket.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 8:27 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Changes --- modify LIB line during configure as opposed to makefile Bugs: MESOS-1913 https://issues.apache.org/jira/browse/MESOS-1913 Repository: mesos Description --- Requires: configure --enable-libevent --enable-libevent-socket --enable-ssl New environment variables: ``` SSL_ENABLED=(false|0,true|1) SSL_CERT_FILE=(path to certificate) SSL_KEY_FILE=(path to key) SSL_VERIFY_CERT=(false|0,true|1) SSL_REQUIRE_CERT=(false|0,true|1) SSL_VERIFY_DEPTH=(4) SSL_CA_DIR=(path to CA directory) SSL_CA_FILE=(path to CA file) SSL_CIPHERS=(accepted ciphers separated by ':') SSL_ENABLE_SSL_V2=(false|0,true|1) SSL_ENABLE_SSL_V3=(false|0,true|1) SSL_ENABLE_TLS_V1_0=(false|0,true|1) SSL_ENABLE_TLS_V1_1=(false|0,true|1) SSL_ENABLE_TLS_V1_2=(false|0,true|1) ``` Only TLSV1.2 is enabled by default. Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols. Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers. Diffs (updated) - 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION 3rdparty/libprocess/src/openssl.hpp PRE-CREATION 3rdparty/libprocess/src/openssl.cpp PRE-CREATION 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere
Re: Review Request 35253: Enable configure to detect libevent and openssl on Mac OS X.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35253/#review87836 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533, 29534, 29535, 29536, 29538, 29539, 29540, 29569, 28763, 35253] All tests passed. - Mesos ReviewBot On June 13, 2015, 2:32 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35253/ --- (Updated June 13, 2015, 2:32 p.m.) Review request for mesos, Benjamin Hindman, Cody Maloney, Joris Van Remoortere, and Till Toenshoff. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/configure.ac 710490b2a7c71f35434494e87e2d132f78ef370a Diff: https://reviews.apache.org/r/35253/diff/ Testing --- Ran `configure` and observed that the warnings from OS X system-level `libevent` and `openssl` disappear. Thanks, Michael Park
Re: Review Request 29406: Introduce libevent ssl socket.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 8:47 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Changes --- fix gcc compilation error. fix configure error. Bugs: MESOS-1913 https://issues.apache.org/jira/browse/MESOS-1913 Repository: mesos Description --- Requires: configure --enable-libevent --enable-libevent-socket --enable-ssl New environment variables: ``` SSL_ENABLED=(false|0,true|1) SSL_CERT_FILE=(path to certificate) SSL_KEY_FILE=(path to key) SSL_VERIFY_CERT=(false|0,true|1) SSL_REQUIRE_CERT=(false|0,true|1) SSL_VERIFY_DEPTH=(4) SSL_CA_DIR=(path to CA directory) SSL_CA_FILE=(path to CA file) SSL_CIPHERS=(accepted ciphers separated by ':') SSL_ENABLE_SSL_V2=(false|0,true|1) SSL_ENABLE_SSL_V3=(false|0,true|1) SSL_ENABLE_TLS_V1_0=(false|0,true|1) SSL_ENABLE_TLS_V1_1=(false|0,true|1) SSL_ENABLE_TLS_V1_2=(false|0,true|1) ``` Only TLSV1.2 is enabled by default. Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols. Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers. Diffs (updated) - 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION 3rdparty/libprocess/src/openssl.hpp PRE-CREATION 3rdparty/libprocess/src/openssl.cpp PRE-CREATION 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere
Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/check.hpp 60989accf3a4d8a9453843015aeff35143b6b737 Diff: https://reviews.apache.org/r/35423/diff/ Testing --- `make check` Thanks, Michael Park
Review Request 35422: stout: Introduce CHECK_NONE and CHECK_ERROR.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35422/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 3972383d7de2d6c7afcef0478554fab8da2f64f2 Diff: https://reviews.apache.org/r/35422/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/#review87808 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 12:24 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/ --- (Updated June 13, 2015, 12:24 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/check.hpp 60989accf3a4d8a9453843015aeff35143b6b737 Diff: https://reviews.apache.org/r/35423/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/ --- (Updated June 13, 2015, 12:24 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/include/process/check.hpp 60989accf3a4d8a9453843015aeff35143b6b737 Diff: https://reviews.apache.org/r/35423/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35422: stout: Introduce CHECK_NONE and CHECK_ERROR.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35422/ --- (Updated June 13, 2015, 12:24 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 3972383d7de2d6c7afcef0478554fab8da2f64f2 Diff: https://reviews.apache.org/r/35422/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35422: stout: Introduce CHECK_NONE and CHECK_ERROR.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35422/#review87807 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 12:24 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35422/ --- (Updated June 13, 2015, 12:24 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 3972383d7de2d6c7afcef0478554fab8da2f64f2 Diff: https://reviews.apache.org/r/35422/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 29406: Introduce libevent ssl socket.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 9:23 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Changes --- address mpark's comments. Bugs: MESOS-1913 https://issues.apache.org/jira/browse/MESOS-1913 Repository: mesos Description --- Requires: configure --enable-libevent --enable-libevent-socket --enable-ssl New environment variables: ``` SSL_ENABLED=(false|0,true|1) SSL_CERT_FILE=(path to certificate) SSL_KEY_FILE=(path to key) SSL_VERIFY_CERT=(false|0,true|1) SSL_REQUIRE_CERT=(false|0,true|1) SSL_VERIFY_DEPTH=(4) SSL_CA_DIR=(path to CA directory) SSL_CA_FILE=(path to CA file) SSL_CIPHERS=(accepted ciphers separated by ':') SSL_ENABLE_SSL_V2=(false|0,true|1) SSL_ENABLE_SSL_V3=(false|0,true|1) SSL_ENABLE_TLS_V1_0=(false|0,true|1) SSL_ENABLE_TLS_V1_1=(false|0,true|1) SSL_ENABLE_TLS_V1_2=(false|0,true|1) ``` Only TLSV1.2 is enabled by default. Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols. Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers. Diffs (updated) - 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION 3rdparty/libprocess/src/openssl.hpp PRE-CREATION 3rdparty/libprocess/src/openssl.cpp PRE-CREATION 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere
Review Request 35431: Enable Option to hold a noncopyable type.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35431/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9 Diff: https://reviews.apache.org/r/35431/diff/ Testing --- Added tests for `OptionNonCopyable` and ran `make check`. Thanks, Michael Park
Review Request 35432: Enable move semantics for Future and Promise.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35432/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/future.hpp 75cbe122f18d2a8ea919331e7fc91e1ec3bfd28b Diff: https://reviews.apache.org/r/35432/diff/ Testing --- `make check` Thanks, Michael Park
Review Request 35433: CHECK that checkpointed resources exist on the slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos Description --- No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches. Diffs - src/slave/slave.cpp 9af69d8f0b28c9441c684886c52320378f9b2869 Diff: https://reviews.apache.org/r/35433/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 34375: Removed use of namespace aliases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/ --- (Updated June 13, 2015, 9:51 p.m.) Review request for mesos and Till Toenshoff. Changes --- Rebased. Repository: mesos Description --- See summary. Diffs (updated) - src/master/master.cpp 3049e057c87571f5db73ee0b14db8b47132b2dff src/slave/slave.cpp 9af69d8f0b28c9441c684886c52320378f9b2869 src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b src/tests/slave_tests.cpp 8dae6e0842c2bedddc13d1c036390e85c7a96df7 Diff: https://reviews.apache.org/r/34375/diff/ Testing --- make check Thanks, Michael Park
Re: Review Request 35431: Enable Option to hold a noncopyable type.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35431/#review87847 --- Patch looks great! Reviews applied: [34276, 34517, 35431] All tests passed. - Mesos ReviewBot On June 13, 2015, 8:57 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35431/ --- (Updated June 13, 2015, 8:57 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9 Diff: https://reviews.apache.org/r/35431/diff/ Testing --- Added tests for `OptionNonCopyable` and ran `make check`. Thanks, Michael Park
Re: Review Request 35432: Enable move semantics for Future and Promise.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35432/#review87848 --- Patch looks great! Reviews applied: [35432] All tests passed. - Mesos ReviewBot On June 13, 2015, 9:26 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35432/ --- (Updated June 13, 2015, 9:26 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/future.hpp 75cbe122f18d2a8ea919331e7fc91e1ec3bfd28b Diff: https://reviews.apache.org/r/35432/diff/ Testing --- `make check` Thanks, Michael Park
