Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43826/
---

Review request for mesos, Joerg Schad and Neil Conway.


Repository: mesos


Description
---

See summary.


Diffs
-

  site/source/blog/2016-02-16-synchronized-statements-in-mesos.md PRE-CREATION 

Diff: https://reviews.apache.org/r/43826/diff/


Testing
---

Locally rendered with `rake && rake dev` from `/site`


Thanks,

Michael Park

Review Request 43824: Addressed comments of 41672.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/
---

Review request for mesos, Adam B and Alexander Rukletsov.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Addressed comments of 41672.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43824/diff/


Testing
---

make && make check successfully.


Thanks,

Yongqiao Wang

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

[Yongqiao Wang]

> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote:
> >
> 
> Adam B wrote:
> Yongqiao, since Alex didn't get his review in before I committed the 
> patch, could you create a new patch addressing his feedback and link to it 
> from the comments here? Thanks.

Thanks Adam and Alex, I have posted patch https://reviews.apache.org/r/43824/ 
to address the comments as below.


> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2338
> > 
> >
> > Backticks instead of single quotes, please! Here and everywhere.

I find single quote?apostrophe and backticks are all used in our comments, You 
can check this file and others like `master_quota_tests.cpp` 
`master_maintenance_tests.cpp`, etc. Cloud you tell me what is the rule for 
using them in comments, I will follow up later. Thanks.


> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2423-2433
> > 
> >
> > Will it be cleaner to put resources from the allocation into a hashmap 
> > by framework id? I think this way you can even get rid of the loop.
> > 
> > Same suggestions for the section below.

Personallly, the current implementation is cleaner, if we using a loop for 
this, we also need to check the framework Id in the loop due to there 
allocation size and resources are different.


> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2373
> > 
> >
> > You can put framework id's into a `std::set` instead. Given there are 
> > two allocations, there is a guarantee, that there will be no attempts to 
> > put the same framework into the set twice.

In the current implementation, we only need to check the allocation size for 
each framework, it does not care the size of whole contianer (currentt is 
hashmap), so I think use hashmap can meet the current requirement.


> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2402-2403
> > 
> >
> > If you use `set` as proposed above, you can check  set against set here.

Sorry to do not understand your suggestion here, current using hashmap and use 
frameworkid as it's key, here to check value for allocation number for each 
framework.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41672/#review119839
---


On Jan. 20, 2016, 8:36 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41672/
> ---
> 
> (Updated Jan. 20, 2016, 8:36 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Test case(s) for weights + allocation behaviour.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 953712149bd951789beb29c72779c4ac65aa48dc 
> 
> Diff: https://reviews.apache.org/r/41672/diff/
> 
> 
> Testing
> ---
> 
> Make check done:
> $ ./src/mesos-tests --gtest_filter=HierarchicalAllocatorTest.UpdateWeight
> Source directory: /Users/yqwyq/Desktop/mesos
> Build directory: /Users/yqwyq/Desktop/mesos/build
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from HierarchicalAllocatorTest
> [ RUN  ] HierarchicalAllocatorTest.UpdateWeight
> [   OK ] HierarchicalAllocatorTest.UpdateWeight (87 ms)
> [--] 1 test from HierarchicalAllocatorTest (87 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (176 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43817: Removed no-longer-used model functions.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/
---

(Updated Feb. 22, 2016, 7:13 a.m.)


Review request for mesos and Michael Park.


Summary (updated)
-

Removed no-longer-used model functions.


Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description (updated)
---

These `model()` variants provided functionality that is now
implemented via jsonify; no more call-sites of the old functions
remain.


Diffs (updated)
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43817/diff/


Testing
---

make check

Also updated a few comments to not refer to `summarize`.


Thanks,

Neil Conway

Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

Updated `/tasks` master endpoint to use jsonify.


Diffs
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43823/diff/


Testing
---

make check. Also verified that this endpoint is covered by the unit tests.


Thanks,

Neil Conway

Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43822/
---

Review request for mesos.


Repository: mesos


Description
---

Updated `/slaves` master endpoint to use jsonify.


Diffs
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43822/diff/


Testing
---

make check. Also verified that this endpoint is covered by the unit tests.


Thanks,

Neil Conway

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43816/
---

(Updated Feb. 22, 2016, 7:11 a.m.)


Review request for mesos and Michael Park.


Summary (updated)
-

Updated `/frameworks` master endpoint to use jsonify.


Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description (updated)
---

Updated `/frameworks` master endpoint to use jsonify.


Diffs (updated)
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43816/diff/


Testing
---

1. make check
2. Verified that after introducing a bug into the jsonify version of 
`frameworks()`, `make check` fails (i.e., the test suite covers the 
`/frameworks` endpoint).
3. Compared output of `/frameworks` with old and new implementation on a test 
Mesos installation to try to gauge correctness visually.


Thanks,

Neil Conway

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Guangya Liu]

> On 二月 12, 2016, 3:43 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 536
> > 
> >
> > Seems like we're increasing trying to find docker versions in our code 
> > base. How about let's capture the docker version and save it in the Docker 
> > class, so we can re-use it and don't have to compute it every time?
> 
> Abhishek Dasgupta wrote:
> How about we store the docker version in docker class inside 
> validateVersion() method?
> 
> Abhishek Dasgupta wrote:
> Capturing docker version in Docker class needs the member variables of 
> version.hpp to be non-constant variables. I don't know if that can be 
> allowed. Are you suggesting this way or any other way possible?

Why need update version.http? Is it possible to get the version from 
`Docker::Create` by splitting some logic from `validateVersion`?

  Future version_ = this->version();

  if (!version_.await(DOCKER_VERSION_WAIT_TIMEOUT)) {
return Error("Timed out getting docker version");
  }

  if (version_.isFailed()) {
return Error("Failed to get docker version: " + version.failure());
  }
  
  // Get the docker version.
  version = version_;


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review119039
---


On 二月 22, 2016, 6:37 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated 二月 22, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
>   src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43817: Removed `model(const Framework&)` and `summarize(const Framework&)`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/#review120119
---



Patch looks great!

Reviews applied: [43816, 43817]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 2:11 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43817/
> ---
> 
> (Updated Feb. 22, 2016, 2:11 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4731
> https://issues.apache.org/jira/browse/MESOS-4731
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These provided functionality that is now implemented via jsonify; no more
> call-sites of the old functions remain.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
> 
> Diff: https://reviews.apache.org/r/43817/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also updated a few comments to not refer to `summarize`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Abhishek Dasgupta]

> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 543
> > 
> >
> > Does label.value() return a Try? What kind of error do we expect from 
> > it?
> 
> Abhishek Dasgupta wrote:
> No, it does not return Try. But I thought to check if there is value 
> inside label. So, used Try. Should I use Result instead?

Used Option instead.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review119039
---


On Feb. 22, 2016, 6:37 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated Feb. 22, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
>   src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/
---

(Updated Feb. 22, 2016, 6:37 a.m.)


Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy Chen.


Bugs: MESOS-4446
https://issues.apache.org/jira/browse/MESOS-4446


Repository: mesos


Description
---

Set Docker labels based on TaskInfo labels.


Diffs (updated)
-

  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
  src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
  src/tests/containerizer/docker_containerizer_tests.cpp 
a299c9e0744b5657984e5bb0afbe4874a266ddb6 
  src/tests/containerizer/docker_tests.cpp 
620819330847a10d9dcd817968df9d2b180a9a29 
  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
  src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 

Diff: https://reviews.apache.org/r/43032/diff/


Testing
---

The following test cases in docker_tests have been changed:
DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
docker run command through arguments.


Thanks,

Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/
---

(Updated Feb. 22, 2016, 6:29 a.m.)


Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy Chen.


Bugs: MESOS-4446
https://issues.apache.org/jira/browse/MESOS-4446


Repository: mesos


Description
---

Set Docker labels based on TaskInfo labels.


Diffs (updated)
-

  CHANGELOG e6cc39b4f45317f94145f0a4a1b64215b9a0cbff 
  Doxyfile 779a8ea9e3dd029c4e5bac876a6bd95d402c17de 
  docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 
  docs/fetcher.md 15f70b51294fa647d653bfe4d641dc032ec91f44 
  docs/high-availability-framework-guide.md 
0d9c483985d61b512339f50f395f9360de034e2d 
  docs/home.md 07214b927c112d7a180507ae03245892455fd757 
  docs/images/log-architecture.png 34c57f19387868486882e6fa8bd5d2362113c952 
  docs/images/log-cluster.png 62042d2811dd21bd7b7301f140a9d474c4e8fd07 
  docs/maintenance.md 4d24ec680f3245b12b99e4bb6440ae5aab473460 
  docs/operational-guide.md a4d6710a8a3a4cde10fdccad332e3d539246ec83 
  docs/release-guide.md f0963e750494fcf1f9d80e87bac8dbd6f76adc9f 
  docs/replicated-log-internals.md 4f379a3ff4e957a486fa13d721f4b66333aea6b3 
  include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
  include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
  include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
  site/README.md eb90a86721d9a2636f98512e2e957e375ccc5110 
  site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
  site/source/blog/2016-02-12-mesoscon-2016-cfp-is-now-open.md 
514358ec0675bc74ab9e0e648b7103a8a1c2c7e8 
  site/source/index.html.md 3988fa044a264d988b832494490be3956078ff90 
  src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 
  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
  src/main.dox a6765f6f1535146b76488464e674f8d86f5835ba 
  src/master/allocator/mesos/allocator.hpp 
64bce0fb143b109c26f923cd97d5facb393dee9d 
  src/master/allocator/mesos/hierarchical.hpp 
0d39d3f3b5f4ff7f62f9de7200d062845c71818a 
  src/master/allocator/mesos/hierarchical.cpp 
5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
  src/master/allocator/sorter/drf/sorter.hpp 
46b2a9caf13b028a3aee6c1590679f885be90fd6 
  src/master/allocator/sorter/drf/sorter.cpp 
9e863dd0ca5e2f2f0d517cb833687b757bed2c52 
  src/master/allocator/sorter/sorter.hpp 
ba91a38e47065718af87c9b3b7c5b74d25a258df 
  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
  src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
  src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 
  src/messages/messages.cpp 41dcdb3996ce173fb0a56704053e4b4e03f6dd63 
  src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
  src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
0fe2f486eb733acf738c1c61fc44f820d7401afc 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
134b6c759b769cf335539e49eff817973c7f96a4 
  src/slave/containerizer/mesos/provisioner/appc/cache.cpp 
e075e488c03d20c7b78e1969ea76e95b89fb7cfa 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
f3e7c042f2c9980f6274c8185ee8bb89a8b02002 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
2f1d3e002140f34c646aab445a419c9c3d712f99 
  src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
  src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
  src/slave/metrics.hpp d4432136590a3021f6743c79e98db64cb044118a 
  src/slave/metrics.cpp 42c66d7d7176232ccc71f1e040bcae99900f49f8 
  src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 
  src/tests/command_executor_tests.cpp 0d2fcf6d4b8d9a925eb6748e6bd33cf279b8f7f8 
  src/tests/containerizer/docker_containerizer_tests.cpp 
a299c9e0744b5657984e5bb0afbe4874a266ddb6 
  src/tests/containerizer/docker_tests.cpp 
620819330847a10d9dcd817968df9d2b180a9a29 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
6a60962b4593b3521c182c7320331743ccffd4ba 
  src/tests/containerizer/port_mapping_tests.cpp 
983a6be160aefe5a32acb6111bb3c85230ec 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
  

Re: Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43821/#review120113
---




docs/high-availability-framework-guide.md (line 205)


How about we put an example here? Like the following:
This is useful for tasks that require some time to terminate 
gracefully(e.g. stopping a docker container).
As to stop a docker container, it always takes a little bit of time, so 
this might make a good example.


- Abhishek Dasgupta


On Feb. 22, 2016, 5:19 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43821/
> ---
> 
> (Updated Feb. 22, 2016, 5:19 a.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta and Neil Conway.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/high-availability-framework-guide.md 
> 0d9c483985d61b512339f50f395f9360de034e2d 
> 
> Diff: https://reviews.apache.org/r/43821/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43821/#review120110
---


Ship it!





docs/high-availability-framework-guide.md (line 204)


"has not yet been killed" ?



docs/high-availability-framework-guide.md (line 206)


"`FrameworkInfo.capabilities`" ?


Typo in commit summary.

- Neil Conway


On Feb. 22, 2016, 5:19 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43821/
> ---
> 
> (Updated Feb. 22, 2016, 5:19 a.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta and Neil Conway.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/high-availability-framework-guide.md 
> 0d9c483985d61b512339f50f395f9360de034e2d 
> 
> Diff: https://reviews.apache.org/r/43821/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

[Abhishek Dasgupta]

> On Feb. 18, 2016, 1:44 a.m., Qian Zhang wrote:
> > I see you send TASK_KILLING once the killTask() is invoked. However, 
> > according to the description of MESOS-4140, we may need to send such status 
> > update after SIGTERM is sent to the task and before SIGKILL is sent. So 
> > maybe you should send TASK_KILLING in shutdown() instead?
> 
> Abhishek Dasgupta wrote:
> Okay, i see. but in the case of docker executor, TASK_KILLING should come 
> after docker stop. Does it sound good??
> 
> Abhishek Dasgupta wrote:
> Actually, to set the status, we need to send the task_id also. Task_id is 
> not available inside shutdown. Moreover, I don't think it will make any 
> difference if it is called inside shutdown instead of killTask. It makes 
> sense to change the status a TASK_KILLING as soon as killTask is issued.
> 
> Qian Zhang wrote:
> shutdown() will be not only called by killTask(), but also called when 
> the executor itself is asked to shutdown, so if you send the status in 
> killTask(), that means for the latter case (executor shutdown), the 
> TASK_KILLING status will not be sent?
> 
> Abhishek Dasgupta wrote:
> So, here is the dubious scenario. If executor shuts down, you can't 
> exepect to provide task_id to shutdown() as there might be lots of tasks. 
> That's why the only argument of shutdown() is executordriver. But to update 
> TASK_KILLING status, you must need task_id. So, in my understanding, shutdown 
> by executor shut down should not require TASK_KILLING status as in that case, 
> all the tasks are unhealthy.
> 
> Ben Mahler wrote:
> Recall that executors can manage many tasks, the command/docker executors 
> are implementations provided by mesos and they manage a single task only. It 
> is up to the executor to decide how to shutdown, in the case of the command 
> executor we kill the active task and report TASK_KILLED (in both the killTask 
> and shutdown cases):
> 
> 
> https://github.com/apache/mesos/blob/0.27.0/src/launcher/executor.cpp#L514-L516
> 
> Since we'd like to send a TASK_KILLING when we start to kill a task, we 
> need to send it in both the killTask and shutdown.
> 
> Make sense?
> 
> Qian Zhang wrote:
> Make sense to me, but I see this patch has been submitted and 
> TASK_KILLING is only sent in killTask but not in shutdown?

The patch has been changed. Ben modified the patch to send TASK_KILLING inside 
shutdown.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43489/#review119568
---


On Feb. 16, 2016, 10:23 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43489/
> ---
> 
> (Updated Feb. 16, 2016, 10:23 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> KillTask introduces TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43489/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43821/
---

Review request for mesos, Abhishek Dasgupta and Neil Conway.


Bugs: MESOS-4547
https://issues.apache.org/jira/browse/MESOS-4547


Repository: mesos


Description
---

See summary.


Diffs
-

  docs/high-availability-framework-guide.md 
0d9c483985d61b512339f50f395f9360de034e2d 

Diff: https://reviews.apache.org/r/43821/diff/


Testing
---

N/A


Thanks,

Ben Mahler

Re: Review Request 43718: Added fs::supported() function.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120106
---



Patch looks great!

Reviews applied: [43718]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 2:10 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 22, 2016, 2:10 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Vinod Kone]

> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote:
> > In general, I prefer scripts with a bunch of helper functions and a compact 
> > main() that steps through each of them. I'm not sure what the general 
> > concensus for the Mesos code base is, but I generally find this easier to 
> > walk through.  Example: support/generate-endpoint-help.py

In our C++ code base we generally prefer procedural style as it requires fewer 
context switches. We haven't officially defined the style for Python code in 
our code base, but I would guess we want to be similar. 

That said if something makes sense to be a function (e.g, reuse) we should 
extract it into a function. I've added a main and refactored a bit. Let me know 
if it looks ok.


> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote:
> > support/push-reviews.py, lines 27-30
> > 
> >
> > Do we have guidelines for indentation here?  When writing the 
> > support/generate-endpoints-help.py script, bmahler suggested something 
> > different than what you have here.

I'm trying to be close to our C++ style. This is how it is in apply-reviews.py 
too. 

What did bmahler suggest?


> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote:
> > support/push-reviews.py, lines 32-39
> > 
> >
> > If the tracking branch is reauired to be of the form `remote/branch` 
> > (as mentioned in a later comment), what do we need the `remote` flag for?

"tracking branch" is mainly required to figure out the new commits to push. 
Technically it can be just "master". "remote" is to figure out the upstream to 
push to. If remote is not specified, we try to deduce it from "tracking 
branch", in which case we expect it to be a "remote tracking branch". 

But I agree it's all confusing. I will kill both "--remote" and 
"--tracking_branch" and expect users to run this from "master" branch for 
simplicity.


> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote:
> > support/push-reviews.py, line 52
> > 
> >
> > We need some sort of way to enforce that the tracking branch is always 
> > of the form `remote/branch`. Otherwise, if we run e.g.
> > 
> > ```
> > $ klueska@c99:~/projects/mesos$ support/push-reviews.py -t master
> > ```
> > 
> > remote gets set to `master` here, which obviously breaks things later 
> > on.

see above.


> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote:
> > support/push-reviews.py, lines 108-112
> > 
> >
> > As we close the review, we should also post a comment to reviewboard 
> > with the commit message we actually pushed to master.
> > 
> > You can use the --description flag:
> > 
> > https://www.reviewboard.org/docs/rbtools/dev/rbt/commands/close/

I'll make a TODO for now as committers don't currently/always set the commit 
message on RB.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review119507
---


On Feb. 22, 2016, 4:52 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43552/
> ---
> 
> (Updated Feb. 22, 2016, 4:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-3929
> https://issues.apache.org/jira/browse/MESOS-3929
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script allows committers to push locally applied review chain to the ASF
> git repo and mark the reviews as submitted.
> 
> 
> Diffs
> -
> 
>   support/push-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43552/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/
---

(Updated Feb. 22, 2016, 4:52 a.m.)


Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.


Changes
---

kevin's comments.


Bugs: MESOS-3929
https://issues.apache.org/jira/browse/MESOS-3929


Repository: mesos


Description
---

This script allows committers to push locally applied review chain to the ASF
git repo and mark the reviews as submitted.


Diffs (updated)
-

  support/push-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/43552/diff/


Testing
---

Tested locally.


Thanks,

Vinod Kone

Re: Review Request 39939: Make docker_socket option support different protocols.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
---




src/slave/flags.cpp (line 437)


I think we need to handle feature interaction with `docker_mesos_image`. 
Currently, we mount unix socket into container; but it'll failed when using TCP 
socket.


- Klaus Ma


On Feb. 22, 2016, 11:35 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated Feb. 22, 2016, 11:35 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43807: Replaced with `~` in authentication.md.

[Klaus Ma]

> On Feb. 22, 2016, 11:57 a.m., haosdent huang wrote:
> > docs/authentication.md, line 97
> > 
> >
> > I try `echo ~/a` in both bash and zsh. Seems it works for me. And do we 
> > have a jira ticket related to this?

Yes, it works in shell for me too; but we did not replace `~` in mesos, and it 
seems shell did not replace it when passing it to mesos.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43807/#review120099
---


On Feb. 21, 2016, 2:42 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43807/
> ---
> 
> (Updated Feb. 21, 2016, 2:42 p.m.)
> 
> 
> Review request for mesos, Adam B and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced  with `~` in authentication.md.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
> 
> Diff: https://reviews.apache.org/r/43807/diff/
> 
> 
> Testing
> ---
> 
> Can not parss `~` to $HOME in Mac OS; update document to use $HOME. Test 
> passed in Mac OS.
> 
> Failed when using `~`:
> I0221 13:08:41.717308 4284416 credentials.hpp:35] Loading credentials for 
> authentication from '~/credentials'
> Failed to read credentials file '~/credentials': Failed to open file 
> '~/credentials': No such file or directory (see --credentials flag)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Adam B]

> On Feb. 19, 2016, 2:24 a.m., Alexander Rukletsov wrote:
> > src/master/master.hpp, lines 1530-1531
> > 
> >
> > Let's pull at least the implementation out of the header. You may look 
> > at maintenance and quota for inspiration : ).
> > 
> > Going further, how about extracting registry part into a separate 
> > patch? It will make reviewing easier. Also, it would be great to see some 
> > registry tests as well.
> 
> Yongqiao Wang wrote:
> Thanks Alex. Personally, I find it more difficult to review a chain of 
> commits than a single, a single patch can give a whole picture of a feature 
> at a time. In addition, the main reason is Adam has completed to review this 
> patch, if I split it into some small patches, then maybe Adam needs to review 
> them again before commiting them. Can we keep this patch except make the 
> smaller chagnes for addressing comments? can you just review the changes to 
> each file one at a time in the this commit? Based on your comments, I will 
> post another patch for registery test later.
> 
> For moving the implementation out of the header, I will update this 
> patches later.

I agree with Yongqioa. While patches with <100 lines are quicker/easier to 
review, this patch is only about 300 new/changed lines, and I like to think 
I've reviewed it pretty thoroughly already. Please review the patch as is, and 
let us know if there's anything for which we should block the commit.
We can pull the implementation out of the header in a separate, follow-up patch.
We can also add additional registry tests and/or authz tests in a follow-up 
patch, if they aren't already covered in https://reviews.apache.org/r/41790/
In the future, we can encourage Yongqiao to break up larger patches earlier in 
the review process.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/#review119857
---


On Feb. 14, 2016, 4:02 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41681/
> ---
> 
> (Updated Feb. 14, 2016, 4:02 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduce HTTP endpoint /weights for updating weight.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 5ee3c7afadd131802c93febbb6b4dbad069c2d81 
>   include/mesos/authorizer/authorizer.proto 
> 226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
>   src/authorizer/local/authorizer.hpp 
> c7321c276d566eca6a91f45c546468bea1b0da15 
>   src/authorizer/local/authorizer.cpp 
> 9557bbdf68ff182c4538bbf70cee576d717abc05 
>   src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
>   src/master/weights_handler.cpp PRE-CREATION 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/41681/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> $ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master  
> --weights="role1=4.2,role2=3.1" --authenticate_http 
> --credentials=/opt/credentials.json  >> /tmp/mesos-master.log 2>&1 &)
> $ curl http://localhost:5050/roles | python -mjson.tool
> {
> "roles": [
> {
> "frameworks": [ ], 
> "name": "*", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 1
> }, 
> {
> "frameworks": [ ], 
> "name": "role1", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 4.2
> }, 
> {
> "frameworks": [ ], 
> "name": "role2", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 3.1
> }
> ]
> }
> 
> Test update:
> $ curl --user framework1:secret_string1 --data 
> "[{\"weight\":1.8,\"role\":\"role1\"},{\"weight\":1.0,\"role\":\"role2\"},{\"weight\":3.4,\"role\":\"role3\"}]"
>  

Re: Review Request 43814: Enabled volume propagation for docker volume.

[Guangya Liu]

> On 二月 22, 2016, 3:53 a.m., haosdent huang wrote:
> > include/mesos/mesos.proto, line 1498
> > 
> >
> > I think we could not mix `rw` and propagation modes when mount, right?

Yes, we cannot. I was now asking the relationship of rw and propagation modes 
here: https://github.com/docker/docker/issues/20555


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43814/#review120098
---


On 二月 22, 2016, 1:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43814/
> ---
> 
> (Updated 二月 22, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4717
> https://issues.apache.org/jira/browse/MESOS-4717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled volume propagation for docker volume.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
>   include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/43814/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Will rebase after https://reviews.apache.org/r/42516 , as 
> https://reviews.apache.org/r/42516 is going to add a docker version in Docker 
> class.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43580: Add indent to comments in protobuf_tests.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43580/#review120102
---


Ship it!




Ship It!

- haosdent huang


On Feb. 15, 2016, 4:16 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43580/
> ---
> 
> (Updated Feb. 15, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add indent to comments in protobuf_tests.cpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> 8dd9cfd3e7d1e3ab4ace87066a43a3094b776d82 
> 
> Diff: https://reviews.apache.org/r/43580/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 43802: Wrapped TASK_LOST with `` in authorization.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43802/#review120100
---


Ship it!




Ship It!

- haosdent huang


On Feb. 21, 2016, 1:05 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43802/
> ---
> 
> (Updated Feb. 21, 2016, 1:05 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wrapped TASK_LOST with `` in authorization.md
> 
> 
> Diffs
> -
> 
>   docs/authorization.md bbb4f2a 
> 
> Diff: https://reviews.apache.org/r/43802/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 43807: Replaced with `~` in authentication.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43807/#review120099
---




docs/authentication.md (line 97)


I try `echo ~/a` in both bash and zsh. Seems it works for me. And do we 
have a jira ticket related to this?


- haosdent huang


On Feb. 21, 2016, 6:42 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43807/
> ---
> 
> (Updated Feb. 21, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos, Adam B and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced  with `~` in authentication.md.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
> 
> Diff: https://reviews.apache.org/r/43807/diff/
> 
> 
> Testing
> ---
> 
> Can not parss `~` to $HOME in Mac OS; update document to use $HOME. Test 
> passed in Mac OS.
> 
> Failed when using `~`:
> I0221 13:08:41.717308 4284416 credentials.hpp:35] Loading credentials for 
> authentication from '~/credentials'
> Failed to read credentials file '~/credentials': Failed to open file 
> '~/credentials': No such file or directory (see --credentials flag)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 43814: Enabled volume propagation for docker volume.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43814/#review120098
---


Ship it!




Ship It!


include/mesos/mesos.proto (line 1498)


I think we could not mix `rw` and propagation modes when mount, right?


- haosdent huang


On Feb. 22, 2016, 1:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43814/
> ---
> 
> (Updated Feb. 22, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4717
> https://issues.apache.org/jira/browse/MESOS-4717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled volume propagation for docker volume.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
>   include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/43814/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Will rebase after https://reviews.apache.org/r/42516 , as 
> https://reviews.apache.org/r/42516 is going to add a docker version in Docker 
> class.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43814: Enabled volume propagation for docker volume.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43814/#review120095
---



Patch looks great!

Reviews applied: [43814]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 1:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43814/
> ---
> 
> (Updated Feb. 22, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4717
> https://issues.apache.org/jira/browse/MESOS-4717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled volume propagation for docker volume.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
>   include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/43814/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Will rebase after https://reviews.apache.org/r/42516 , as 
> https://reviews.apache.org/r/42516 is going to add a docker version in Docker 
> class.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120094
---




docs/configuration.md (line 1029)


s/unix:///var/run/docker.sock//var/run/docker.sock ?

Or else the Line 105 in docker.cpp may need some update.



docs/configuration.md (line 1030)


s/default/by default



src/slave/flags.cpp (line 441)


by default


- Guangya Liu


On 二月 22, 2016, 3:35 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated 二月 22, 2016, 3:35 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43540: Added 'MesosCon 2016 CFP is now open!' blog post.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43540/
---

(Updated Feb. 22, 2016, 3:22 a.m.)


Review request for mesos and Adam B.


Summary (updated)
-

Added 'MesosCon 2016 CFP is now open!' blog post.


Repository: mesos


Description (updated)
---

Added 'MesosCon 2016 CFP is now open!' blog post.


Diffs (updated)
-

  site/source/blog/2016-02-12-mesoscon-2016-cfp-is-now-open.md PRE-CREATION 
  site/source/index.html.md 727c216a5902cd2bf845c557b3ef0f76a087e971 

Diff: https://reviews.apache.org/r/43540/diff/


Testing
---

# News:
![news](https://reviews.apache.org/media/uploaded/files/2016/02/12/d6528970-6034-4a7e-ae42-cdff1a106ab5__Screen_Shot_2016-02-12_at_3.00.24_PM.png)

-

# Blog post:
![blog](https://reviews.apache.org/media/uploaded/files/2016/02/12/6d542a6b-7081-41fe-b718-ea4f0abac11d__Screen_Shot_2016-02-12_at_3.00.32_PM.png)


File Attachments


news
  
https://reviews.apache.org/media/uploaded/files/2016/02/12/d6528970-6034-4a7e-ae42-cdff1a106ab5__Screen_Shot_2016-02-12_at_3.00.24_PM.png
blog
  
https://reviews.apache.org/media/uploaded/files/2016/02/12/6d542a6b-7081-41fe-b718-ea4f0abac11d__Screen_Shot_2016-02-12_at_3.00.32_PM.png


Thanks,

Michael Park

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43819/#review120091
---




docs/app-framework-development-guide.md (line 17)


s/interface/interfaces



docs/app-framework-development-guide.md (line 129)


Why not merge this and above `Scheduler API` into one section?



docs/app-framework-development-guide.md (line 131)


s/Interface/Interfaces



docs/app-framework-development-guide.md (lines 168 - 172)


Do we need to mention this here? The API was not implemented by the 
built-in allocator, so the framework cannot leverage this if using built-in 
allocator.


- Guangya Liu


On 二月 22, 2016, 3 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43819/
> ---
> 
> (Updated 二月 22, 2016, 3 a.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Scheduler-Driver API to app-framework-development-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
> 
> Diff: https://reviews.apache.org/r/43819/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/b4bf279a55e1b62051e6) and 
> via docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

> On Feb. 19, 2016, 10:24 a.m., Alexander Rukletsov wrote:
> > src/master/master.hpp, lines 1530-1531
> > 
> >
> > Let's pull at least the implementation out of the header. You may look 
> > at maintenance and quota for inspiration : ).
> > 
> > Going further, how about extracting registry part into a separate 
> > patch? It will make reviewing easier. Also, it would be great to see some 
> > registry tests as well.

Thanks Alex. Personally, I find it more difficult to review a chain of commits 
than a single, a single patch can give a whole picture of a feature at a time. 
In addition, the main reason is Adam has completed to review this patch, if I 
split it into some small patches, then maybe Adam needs to review them again 
before commiting them. Can we keep this patch except make the smaller chagnes 
for addressing comments? can you just review the changes to each file one at a 
time in the this commit? Based on your comments, I will post another patch for 
registery test later.

For moving the implementation out of the header, I will update this patches 
later.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/#review119857
---


On Feb. 14, 2016, 12:02 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41681/
> ---
> 
> (Updated Feb. 14, 2016, 12:02 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduce HTTP endpoint /weights for updating weight.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 5ee3c7afadd131802c93febbb6b4dbad069c2d81 
>   include/mesos/authorizer/authorizer.proto 
> 226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
>   src/authorizer/local/authorizer.hpp 
> c7321c276d566eca6a91f45c546468bea1b0da15 
>   src/authorizer/local/authorizer.cpp 
> 9557bbdf68ff182c4538bbf70cee576d717abc05 
>   src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
>   src/master/weights_handler.cpp PRE-CREATION 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/41681/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> $ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master  
> --weights="role1=4.2,role2=3.1" --authenticate_http 
> --credentials=/opt/credentials.json  >> /tmp/mesos-master.log 2>&1 &)
> $ curl http://localhost:5050/roles | python -mjson.tool
> {
> "roles": [
> {
> "frameworks": [ ], 
> "name": "*", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 1
> }, 
> {
> "frameworks": [ ], 
> "name": "role1", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 4.2
> }, 
> {
> "frameworks": [ ], 
> "name": "role2", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 3.1
> }
> ]
> }
> 
> Test update:
> $ curl --user framework1:secret_string1 --data 
> "[{\"weight\":1.8,\"role\":\"role1\"},{\"weight\":1.0,\"role\":\"role2\"},{\"weight\":3.4,\"role\":\"role3\"}]"
>  -X PUT http://127.0.0.1:5050/weights
> $ curl http://localhost:5050/roles | python -mjson.tool
> {
> "roles": [
> {
> "frameworks": [],
> "name": "*",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "weight": 1.0
> },
> {
> "frameworks": [],
> "name": "role1",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "weight": 1.8
> },
> {
> "frameworks": [],
> "name": "role2",
> 

Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43819/
---

Review request for mesos, Adam B and Neil Conway.


Repository: mesos


Description
---

Added Scheduler-Driver API to app-framework-development-guide.md.


Diffs
-

  docs/app-framework-development-guide.md 
e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 

Diff: https://reviews.apache.org/r/43819/diff/


Testing
---

Viewed via gist (https://gist.github.com/joerg84/b4bf279a55e1b62051e6) and via 
docker website container.


Thanks,

Joerg Schad

Review Request 43817: Removed `model(const Framework&)` and `summarize(const Framework&)`.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/
---

Review request for mesos and Michael Park.


Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description
---

These provided functionality that is now implemented via jsonify; no more
call-sites of the old functions remain.


Diffs
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43817/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43817: Removed `model(const Framework&)` and `summarize(const Framework&)`.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/
---

(Updated Feb. 22, 2016, 2:11 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description
---

These provided functionality that is now implemented via jsonify; no more
call-sites of the old functions remain.


Diffs
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43817/diff/


Testing (updated)
---

make check

Also updated a few comments to not refer to `summarize`.


Thanks,

Neil Conway

Re: Review Request 43718: Added fs::supported() function.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/
---

(Updated Feb. 22, 2016, 2:10 a.m.)


Review request for mesos and Jie Yu.


Changes
---

use "proc" and "sysfs" in the fs::supported test


Bugs: MESOS-4707
https://issues.apache.org/jira/browse/MESOS-4707


Repository: mesos


Description
---

Added fs::supported() function.


Diffs (updated)
-

  src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
  src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
  src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 

Diff: https://reviews.apache.org/r/43718/diff/


Testing
---

make check on ubuntu 14.04 64bit vm


Thanks,

Shuai Lin

Review Request 43816: Updated `/frameworks` endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43816/
---

Review request for mesos and Michael Park.


Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description
---

Updated `/frameworks` endpoint to use jsonify.


Diffs
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43816/diff/


Testing
---

1. make check
2. Verified that after introducing a bug into the jsonify version of 
`frameworks()`, `make check` fails (i.e., the test suite covers the 
`/frameworks` endpoint).
3. Compared output of `/frameworks` with old and new implementation on a test 
Mesos installation to try to gauge correctness visually.


Thanks,

Neil Conway

Review Request 43814: Enabled volume propagation for docker volume.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43814/
---

Review request for mesos, Jie Yu and Timothy Chen.


Bugs: MESOS-4717
https://issues.apache.org/jira/browse/MESOS-4717


Repository: mesos


Description
---

Enabled volume propagation for docker volume.


Diffs
-

  include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
  include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 

Diff: https://reviews.apache.org/r/43814/diff/


Testing
---

make
make check

Will rebase after https://reviews.apache.org/r/42516 , as 
https://reviews.apache.org/r/42516 is going to add a docker version in Docker 
class.


Thanks,

Guangya Liu

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

[Qian Zhang]

> On Feb. 21, 2016, 12:30 a.m., Ben Mahler wrote:
> > src/launcher/executor.cpp, lines 460-469
> > 
> >
> > Let's do this inside shutdown per my comment at the top.
> > 
> > It's also not clear to me why the health check process is only killed 
> > inside killTask, seems that we'll leak the health check process if we only 
> > are sent shutdown! Looks like a bug :(

Is it because the health check process is part of the executor process group 
and once executor is shutdown it will be terminated too?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43489/#review120043
---


On Feb. 16, 2016, 6:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43489/
> ---
> 
> (Updated Feb. 16, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> KillTask introduces TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43489/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

[Qian Zhang]

> On Feb. 18, 2016, 9:44 a.m., Qian Zhang wrote:
> > I see you send TASK_KILLING once the killTask() is invoked. However, 
> > according to the description of MESOS-4140, we may need to send such status 
> > update after SIGTERM is sent to the task and before SIGKILL is sent. So 
> > maybe you should send TASK_KILLING in shutdown() instead?
> 
> Abhishek Dasgupta wrote:
> Okay, i see. but in the case of docker executor, TASK_KILLING should come 
> after docker stop. Does it sound good??
> 
> Abhishek Dasgupta wrote:
> Actually, to set the status, we need to send the task_id also. Task_id is 
> not available inside shutdown. Moreover, I don't think it will make any 
> difference if it is called inside shutdown instead of killTask. It makes 
> sense to change the status a TASK_KILLING as soon as killTask is issued.
> 
> Qian Zhang wrote:
> shutdown() will be not only called by killTask(), but also called when 
> the executor itself is asked to shutdown, so if you send the status in 
> killTask(), that means for the latter case (executor shutdown), the 
> TASK_KILLING status will not be sent?
> 
> Abhishek Dasgupta wrote:
> So, here is the dubious scenario. If executor shuts down, you can't 
> exepect to provide task_id to shutdown() as there might be lots of tasks. 
> That's why the only argument of shutdown() is executordriver. But to update 
> TASK_KILLING status, you must need task_id. So, in my understanding, shutdown 
> by executor shut down should not require TASK_KILLING status as in that case, 
> all the tasks are unhealthy.
> 
> Ben Mahler wrote:
> Recall that executors can manage many tasks, the command/docker executors 
> are implementations provided by mesos and they manage a single task only. It 
> is up to the executor to decide how to shutdown, in the case of the command 
> executor we kill the active task and report TASK_KILLED (in both the killTask 
> and shutdown cases):
> 
> 
> https://github.com/apache/mesos/blob/0.27.0/src/launcher/executor.cpp#L514-L516
> 
> Since we'd like to send a TASK_KILLING when we start to kill a task, we 
> need to send it in both the killTask and shutdown.
> 
> Make sense?

Make sense to me, but I see this patch has been submitted and TASK_KILLING is 
only sent in killTask but not in shutdown?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43489/#review119568
---


On Feb. 16, 2016, 6:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43489/
> ---
> 
> (Updated Feb. 16, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> KillTask introduces TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43489/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120076
---




src/tests/containerizer/fs_tests.cpp (line 48)


Well, not all kernels compile ext4 module, you can actually test "procfs" 
and "sysfs" here, they are required by Mesos.


- Cong Wang


On Feb. 21, 2016, 12:24 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 21, 2016, 12:24 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120075
---


Ship it!




Ship It!

- haosdent huang


On Feb. 21, 2016, 12:24 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 21, 2016, 12:24 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 37168: Added example for dynamic reservation features.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review120074
---



Patch looks great!

Reviews applied: [37168]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 21, 2016, 2:07 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated Feb. 21, 2016, 2:07 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 37531: Fix master CHECK failure if a framework uses duplicated task id.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37531/#review120073
---



ping @jieyu/vinodkone.

- Klaus Ma


On Jan. 13, 2016, 10:06 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37531/
> ---
> 
> (Updated Jan. 13, 2016, 10:06 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-3070
> https://issues.apache.org/jira/browse/MESOS-3070
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> __Phenomenon:__
> The master crash because of duplicated task id
> 
> __Root Cause:__
> The task id are stored in slave agent; if master failover, there's a time 
> window that new slave lanched a task with same task id; so if the old task 
> re-registered back, the master will crash because of duplicated task id.
> 
> __Solution:__
> Stores tasks info in Master::Framework by SlaveID to avoid duplicated issue.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp bcafc7aff89659a68352f3876ce6042f8b34bd5d 
>   src/master/master.hpp f02d165874fa8023675e545793de699aeecae29b 
>   src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/37531/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 37168: Added example for dynamic reservation features.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
---

(Updated Feb. 21, 2016, 10:07 p.m.)


Review request for mesos and Michael Park.


Changes
---

Update summary to add period


Summary (updated)
-

Added example for dynamic reservation features.


Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063


Repository: mesos


Description
---

Provide example for dynamic reservation features.


Diffs
-

  src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
  src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
  src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
  src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6 

Diff: https://reviews.apache.org/r/37168/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 43718: Added fs::supported() function.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120072
---



Patch looks great!

Reviews applied: [43718]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 21, 2016, 12:24 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 21, 2016, 12:24 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
---

(Updated Feb. 21, 2016, 9:49 p.m.)


Review request for mesos and Michael Park.


Changes
---

rebase & ping @mcypark :).


Summary (updated)
-

Add an example framework using dynamic reservation.


Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063


Repository: mesos


Description
---

Provide example for dynamic reservation features.


Diffs (updated)
-

  src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
  src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
  src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
  src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6 

Diff: https://reviews.apache.org/r/37168/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 43762: Added a comment for `ShutdownProcess` in the executor library.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43762/#review120071
---


Ship it!




Thanks Alex, I'll get this in with an adjustment of the comment.


src/exec/exec.cpp (lines 75 - 81)


How about this?

```
// The ShutdownProcess is a relic of the pre-cgroup process isolation
// days. It ensures that the executor process tree is killed after a
// shutdown has been sent.
//
// TODO(bmahler): Update 'delay' to handle deferred callbacks without
// needing a Process. This would eliminate the need for an explicit
// Process here, see: MESOS-4729.
```

I filed MESOS-4729 to avoid the need for a Process here.


- Ben Mahler


On Feb. 19, 2016, 1:12 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43762/
> ---
> 
> (Updated Feb. 19, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-1571
> https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp 83dbee9dd2d9a4e7ebf395c8070bc7f9f8412ef1 
> 
> Diff: https://reviews.apache.org/r/43762/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/43764/ .
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 43761: Replaced an exit status numeral with the appropriate constant.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43761/#review120070
---


Ship it!




I'll commit this, any reason you didn't do the broader sweep?

- Ben Mahler


On Feb. 19, 2016, 1:12 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43761/
> ---
> 
> (Updated Feb. 19, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-1571
> https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp 83dbee9dd2d9a4e7ebf395c8070bc7f9f8412ef1 
> 
> Diff: https://reviews.apache.org/r/43761/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/43764/ .
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Shuai Lin]

> On Feb. 21, 2016, 11:25 a.m., Klaus Ma wrote:
> > src/linux/fs.cpp, line 56
> > 
> >
> > Would you add comments on expected format in `/proc/systems`? It'll 
> > help other contributors to understand magic number `1` & `2`.

Good suggetstion, updated patch.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120067
---


On Feb. 21, 2016, 12:24 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 21, 2016, 12:24 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/
---

(Updated Feb. 21, 2016, 12:24 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Added comments explaining the format of `/proc/filesystems`


Bugs: MESOS-4707
https://issues.apache.org/jira/browse/MESOS-4707


Repository: mesos


Description
---

Added fs::supported() function.


Diffs (updated)
-

  src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
  src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
  src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 

Diff: https://reviews.apache.org/r/43718/diff/


Testing
---

make check on ubuntu 14.04 64bit vm


Thanks,

Shuai Lin

Re: Review Request 43809: Moved composing containerizer to composing folder.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43809/#review120068
---



Patch looks great!

Reviews applied: [42710, 43809]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 21, 2016, 9:50 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43809/
> ---
> 
> (Updated Feb. 21, 2016, 9:50 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4716
> https://issues.apache.org/jira/browse/MESOS-4716
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos now support three kind for containerizers: Mesos, Docker
> and Compose. The Mesos containerizer is under slave/containerizer/mesos
> and it is better to move composing containerizer to 
> slave/containerizer/composing.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
>   src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
>   src/slave/containerizer/composing.hpp  
>   src/slave/containerizer/composing.cpp 
> 15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
>   src/slave/containerizer/containerizer.cpp 
> 59904684cdeb17ef2b42092a3558802c42bfb6bd 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> e7e3b622b6606a812aef046c761bf92368d34af2 
> 
> Diff: https://reviews.apache.org/r/43809/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120067
---




src/linux/fs.cpp (line 56)


Would you add comments on expected format in `/proc/systems`? It'll help 
other contributors to understand magic number `1` & `2`.


- Klaus Ma


On Feb. 21, 2016, 3:46 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 21, 2016, 3:46 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42710: Moved docker containerizer to docker folder.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42710/
---

(Updated 二月 21, 2016, 9:50 a.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Bugs: MESOS-4716
https://issues.apache.org/jira/browse/MESOS-4716


Repository: mesos


Description (updated)
---

The Mesos now support three kind for containerizers: Mesos, Docker
and Compose. The Mesos containerizer is under slave/containerizer/mesos
and it is better to move docker containerizer to slave/containerizer/docker.


Diffs (updated)
-

  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
  src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
  src/slave/containerizer/containerizer.cpp 
59904684cdeb17ef2b42092a3558802c42bfb6bd 
  src/slave/containerizer/docker.hpp  
  src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
  src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f 
  src/tests/containerizer/docker_containerizer_tests.cpp 
a299c9e0744b5657984e5bb0afbe4874a266ddb6 
  src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
  src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 

Diff: https://reviews.apache.org/r/42710/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 43809: Moved composing containerizer to composing folder.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43809/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4716
https://issues.apache.org/jira/browse/MESOS-4716


Repository: mesos


Description
---

The Mesos now support three kind for containerizers: Mesos, Docker
and Compose. The Mesos containerizer is under slave/containerizer/mesos
and it is better to move composing containerizer to 
slave/containerizer/composing.


Diffs
-

  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
  src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
  src/slave/containerizer/composing.hpp  
  src/slave/containerizer/composing.cpp 
15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
  src/slave/containerizer/containerizer.cpp 
59904684cdeb17ef2b42092a3558802c42bfb6bd 
  src/tests/containerizer/composing_containerizer_tests.cpp 
e7e3b622b6606a812aef046c761bf92368d34af2 

Diff: https://reviews.apache.org/r/43809/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 43718: Added fs::supported() function.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120066
---



Patch looks great!

Reviews applied: [43718]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 21, 2016, 7:46 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 21, 2016, 7:46 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43328: Title for documentation webpages.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review120065
---



It's Apache Mesos, and don't you forget it. :)


docs/allocation-module.md (line 2)


Please start the titles with "Apache Mesos -" instead of just "Mesos - " to 
appease the Apache Branding Requirements.

"The first and most prominent reference to a project or product on each 
page, and especially in page titles or headers, must use the "Apache 
Projectname" form of its name."
https://www.apache.org/foundation/marks/pmcs.html#naming



docs/documentation-guide.md (line 6)


Double-space here too, actually.


- Adam B


On Feb. 18, 2016, 8:48 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 18, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/documentation-guide.md b7e861468e8abe1b8e83c115d353e78e601fb41f 
>   docs/doxygen-style-guide.md 1bd3b3d373af4ab39df1ab8b1ed9c78dc3bfc721 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md 30f9d0f7f622db7ac960c5bf255319c2553b94ee 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md dd7b1f063367568de2ff2b2a371023b71e1923de 
>   docs/high-availability-framework-guide.md 
> f21f95f24c0e9f3c4376b64e6a5776aafec39172 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md 982ad28d392570b40b83e9e85d21583b88ff755e 
>   docs/logging.md 50a95ba5fedcb5b803e183bea8243e2e7750aa3e 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3 
>   docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md d29bbaf5677b68ee1f47308047a1c56869284710 
>   docs/quota.md d4233be0f39e05c1c326680dbddae1ec601eef4f 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md a0d27cbafeb5311d2c704dcb632b4de179ba994c 
>   

Re: Review Request 43716: Endpoint documents with title.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/
---

(Updated Feb. 21, 2016, 12:04 a.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
---

Autometically generated markdown files with corresponding titles.


Diffs
-

  docs/endpoints/files/browse.json.md 7c7049344980a16978a25431e713fbfe61e1cc5f 
  docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
  docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
  docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
  docs/endpoints/files/download.json.md 
77c6b97988c30ddcd71d69da1ffa55a10e871051 
  docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
  docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
  docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
  docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
  docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
  docs/endpoints/master/api/v1/scheduler.md 
6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
  docs/endpoints/master/create-volumes.md 
1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
  docs/endpoints/master/destroy-volumes.md 
7209a7cf788116a29eb6235d3a8a0225253c04f7 
  docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
  docs/endpoints/master/frameworks.md bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
  docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
  docs/endpoints/master/machine/down.md 
82cce61e2a02f7896e7db351bed7a08138e87768 
  docs/endpoints/master/machine/up.md 5bfd95e0945d82030ee536ee247665c455629a64 
  docs/endpoints/master/maintenance/schedule.md 
e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
  docs/endpoints/master/maintenance/status.md 
17e3eef1c2fac12375892ec125a727a62a4ebfca 
  docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
  docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
  docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
  docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
  docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 
  docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
  docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
  docs/endpoints/master/state-summary.md 
a6d79f0e5703c3f9118869e287fbb512e86c22c0 
  docs/endpoints/master/state.json.md dad5627eea9481fdbfd91966062c813be7e0f586 
  docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
  docs/endpoints/master/tasks.json.md cb1856f296d7420ce3162a60bf634de0991cdde4 
  docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
  docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
  docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
  docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
  docs/endpoints/monitor/statistics.json.md 
5ce4fc69aaa4b54541841e58ffa29703363b73e2 
  docs/endpoints/monitor/statistics.md 602104b2484022cfa7f41b04affc106703e6f09f 
  docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
  docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
  docs/endpoints/registrar/registry.md 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
  docs/endpoints/slave/api/v1/executor.md 
e92df49b0a50e0152e54866e812438c9af63c4e0 
  docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
  docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
  docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
  docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
  docs/endpoints/system/stats.json.md a5fb58f35c602c8b03ed911eb374d26f98449585 
  docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 

Diff: https://reviews.apache.org/r/43716/diff/


Testing
---

This patch includes all the endpoint documents with title generated from 
generated-endpoint-help.py file.
Tested on live site using "rake"


Thanks,

Abhishek Dasgupta