Review Request 47003: Fixed table accessibility.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47003/
---

Review request for mesos.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Fixed table accessibility.


Diffs
-

  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 

Diff: https://reviews.apache.org/r/47003/diff/


Testing
---


Thanks,

Zhiwei Chen

Re: Review Request 46990: Removed authorization from libprocess endpoint handlers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46990/#review131783
---



Bad patch!

Reviews applied: [46990, 46989, 46882, 46881, 46880, 46876, 46870, 46869, 
46883, 46868, 46867, 46866]

Failed command: ./support/apply-review.sh -n -r 46883

Error:
2016-05-05 04:58:11 URL:https://reviews.apache.org/r/46883/diff/raw/ 
[1105/1105] -> "46883.patch" [1]
error: patch failed: src/common/http.cpp:589
error: src/common/http.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12891/console

- Mesos ReviewBot


On May 4, 2016, 6:48 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46990/
> ---
> 
> (Updated May 4, 2016, 6:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous commit added authorization handling
> to `ProcessBase::visit`, so the authorization
> handlers in the endpoint code can be removed.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/logging.hpp 
> 651cb3736705124bec9e4366c0e7adc5d5b488f0 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 
> 25e8fcaeb9c71eaa43096165745e79c8198c139a 
>   3rdparty/libprocess/src/logging.cpp 
> ad7aa3aabbfc4a496e7e624a691a72e45c72e35d 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 65b58433158c51cebace9b591d4121e8d9a59ecc 
> 
> Diff: https://reviews.apache.org/r/46990/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 47001: Fix race conditions in ROOT_XFS_QuotaTest.NoCheckpointRecovery.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47001/
---

Review request for mesos, Gilbert Song and Jiang Yan Xu.


Bugs: MESOS-5308
https://issues.apache.org/jira/browse/MESOS-5308


Repository: mesos


Description
---

There are two race conditions in ROOT_XFS_QuotaTest.NoCheckpointRecovery.
The first is when we were checking the disk resources consumed
without knowing whether the dd command had completed. We can just
eliminate this check since other tests cover the resource usage
case. The second race was installing the
MesosContainerizerProcess::___recover expectation after starting
the slave. We need to install this before starting.


Diffs
-

  src/tests/containerizer/xfs_quota_tests.cpp 
61ea2e55e5c71cb10f6c84d23c205169567e8c96 

Diff: https://reviews.apache.org/r/47001/diff/


Testing
---

Fedora 23.

$ mesos-tests --gtest_filter=ROOT_XFS_QuotaTest.NoCheckpointRecovery 
--gtest_repeat=1 --gtest_break_on_failure


Thanks,

James Peach

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[James Peach]

> On May 4, 2016, 3:33 p.m., James Peach wrote:
> > configure.ac, line 591
> > 
> >
> > So in practice, libraries would be installed in either 
> > ``3rdparty/lib64`` or ``3rdparty/lib``, but not both?
> > 
> > Is there a libtool or autoconf variable to figure that out?
> 
> Kapil Arya wrote:
> On 32-bit, they'll be installed in lib. On 64-bit, it could be either 
> :-(. I believe there might be a way to figure it out but I am not so sure 
> given that we are talking about 3rdparty software (with their own configure 
> scripts) here. I'll try to think of a better alternative.

Another question ... I don't recall whether you actually need the link flags 
for modules? all the 3rdparty libraries should already be present in the mesos 
process by the time module are loaded, so you wouldn't need them at link time. 
Right?


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review131691
---


On May 4, 2016, 3:22 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 4, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

[Alex Clemmer]

> On May 2, 2016, 9:14 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess_windows.cpp, line 89
> > 
> >
> > The initialization with `INVALID_HANDLE_VALUE` has no semantic meaning, 
> > right? We should just leave it uninitialized, since we initialize it with 
> > the `duplicateHandle` call.

I think it makes sense to initialize it to a "safe" value, but it's fine to do 
it this way too, so let's do that.


> On May 2, 2016, 9:14 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess_windows.cpp, lines 199-200
> > 
> >
> > Is this because using `GENERIC_WRITE` with `FILE_SHARE_READ` is a no-op?

It's not a no-op, or I might not understand what you're saying. 
`FILE_SHARE_READ` will allow other processes to read the file, which in this 
case I think is what we want. I can add a comment.


> On May 2, 2016, 9:14 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess_windows.cpp, line 414
> > 
> >
> > Remove newline.

I wasn't sure of intent here. You mean, remove all similar newlines? because we 
do this in other lambdas, too.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/#review131356
---


On May 5, 2016, 3:12 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46608/
> ---
> 
> (Updated May 5, 2016, 3:12 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Implemented `subprocess_windows.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/io.cpp 83e5f04f246b46880cfc34aa56441046b569b142 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46608/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/
---

(Updated May 5, 2016, 3:12 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Libprocess: Implemented `subprocess_windows.cpp`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/src/io.cpp 83e5f04f246b46880cfc34aa56441046b569b142 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46608/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46980: Implemented adding a cni network config via 'cni/config' endpoint.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46980/
---

(Updated May 5, 2016, 10:44 a.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5310
https://issues.apache.org/jira/browse/MESOS-5310


Repository: mesos


Description
---

Implemented adding a cni network config via 'cni/config' endpoint.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
a06bb89a7a79a62949a48274df806f9f95da09e7 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
dae369aadb940150aa806b28d9269e3d88cf57ed 

Diff: https://reviews.apache.org/r/46980/diff/


Testing
---

Used `curl` to add a new CNI network configuration via 'cni/config' endpoint, 
and then used `mesos-execute` to launch a container to join the newly added CNI 
network successfully.


Thanks,

Qian Zhang

Re: Review Request 46964: Using the summary attribute of the table element.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46964/
---

(Updated 五月 5, 2016, 2:14 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Using the summary attribute of the table element.


Diffs (updated)
-

  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/46964/diff/


Testing
---

Have checked with the patch by firebug, each table should have summary 
attribute.

For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html


Thanks,

Chen Nan Li

Re: Review Request 46979: Introduced 'cni/config' endpoint.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46979/
---

(Updated May 5, 2016, 10:01 a.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5310
https://issues.apache.org/jira/browse/MESOS-5310


Repository: mesos


Description
---

Introduced 'cni/config' endpoint.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
a06bb89a7a79a62949a48274df806f9f95da09e7 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
dae369aadb940150aa806b28d9269e3d88cf57ed 

Diff: https://reviews.apache.org/r/46979/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38451/
---

(Updated 五月 5, 2016, 1:46 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description
---

Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
7fcb289b8701424d17567710fe5f8627d6fe25b6 

Diff: https://reviews.apache.org/r/38451/diff/


Testing
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsSlaveRecovery" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46954/
---

(Updated 五月 5, 2016, 1:19 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Ensuring that id attributes are unique on a Web page.


Diffs
-

  src/webui/master/static/directives/tableHeader.html 
448f67ef20c279fdd542890158fb9f96a10ebebc 

Diff: https://reviews.apache.org/r/46954/diff/


Testing (updated)
---

Have checked with the patch by firebug, the ID of each table header is 
different with each other.

can refer to https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H93


Thanks,

Chen Nan Li

Review Request 46964: Using the summary attribute of the table element.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46964/
---

Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Using the summary attribute of the table element.


Diffs
-

  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/46964/diff/


Testing
---

Have checked with the patch by firebug, each table should have summary 
attribute.

For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html


Thanks,

Chen Nan Li

Review Request 46966: Form controls must have associated labels.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46966/
---

Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Form controls must have associated labels.


Diffs
-

  src/webui/master/static/directives/tableHeader.html 
448f67ef20c279fdd542890158fb9f96a10ebebc 

Diff: https://reviews.apache.org/r/46966/diff/


Testing
---

Using aria-label "search" to make screen reader to identify that the text form 
is for search.

and use content to replace placeholder to make the "Find"text more visible.

Use of the placeholder attribute as a replacement for a programmatically 
associated visible label can reduce the accessibility and usability of the 
control for a range of users including older users and users with cognitive, 
mobility.

refer to 
https://www.paciellogroup.com/blog/2011/02/html5-accessibility-chops-the-placeholder-attribute/


Thanks,

Chen Nan Li

Review Request 46975: Add title and heading in Mesos Log Page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/
---

Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Add title and heading in Mesos Log Page.


Diffs
-

  src/webui/master/static/pailer.html 19e0981143bd7e8372b49f4f036867e9dd05727a 

Diff: https://reviews.apache.org/r/46975/diff/


Testing
---

Mesos log page should have a title for details: 
https://www.w3.org/TR/WCAG20-TECHS/H25

And Should give a heading to tell screen reader that content in the page is 
Mesos log


Thanks,

Chen Nan Li

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

[Alex Clemmer]

> On April 28, 2016, 11:52 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess_windows.cpp, lines 534-539
> > 
> >
> > A few comments here.
> > 
> > (1) I think we can simply this to:
> > 
> > ```
> > string env;
> > foreach (const string& key, const string& value, environment.get()) {
> >   env += key + '=' + value + '\0';
> > }
> > ```
> > 
> > then pass `env.data()` to `createChildProcess`.
> > 
> > (2) Currently, if the string is larger than 32767 bytes, 
> > `createProcessEnvironment` returns `NULL`. We subsequently pass that result 
> > to `createChildProcess`, which result in the following behavior:
> > 
> > > lpEnvironment [in, optional]
> > A pointer to the environment block for the new process. If this 
> > parameter is NULL, the new process uses the environment of the calling 
> > process.
> > 
> > Is this what we want? I think we can definitely incorporate whatever 
> > behavior we need if we go beyond the 32767 bytes, but I'm not sure exactly 
> > what behavior is expected here.

We can do that. It was a bad failure mode to silently map environments that 
were too big to `NULL`. We should let `::CreateProcess` error out in that case 
which will cause us to return an `Error`.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/#review130974
---


On May 3, 2016, 5:45 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46608/
> ---
> 
> (Updated May 3, 2016, 5:45 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Implemented `subprocess_windows.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/io.cpp 83e5f04f246b46880cfc34aa56441046b569b142 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46608/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

[Qian Zhang]

> On May 5, 2016, 7:49 a.m., Jie Yu wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, lines 180-189
> > 
> >
> > Hum, i thought you already pulled these into a helper? Do you need to 
> > update this patch?

Yeah, I have not updated this patch yet, will do so soon.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46435/#review131761
---


On April 20, 2016, 10:35 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46435/
> ---
> 
> (Updated April 20, 2016, 10:35 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46435/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_VerifyCheckpointedInfo
> I0420 22:34:55.747752 10309 exec.cpp:150] Version: 0.29.0
> I0420 22:34:55.768620 10328 exec.cpp:225] Executor registered on agent 
> e5403695-ee6e-435c-a273-b9523adf7051-S0
> Registered executor on mesos
> Starting task 51bf9caa-9305-4533-8ba5-1d7982d807b7
> sh -c 'sleep 1000'
> Forked command at 10332
> Received killTask for task 51bf9caa-9305-4533-8ba5-1d7982d807b7
> Sending SIGTERM to process tree at pid 10332
> Sent SIGTERM to the following process trees:
> [ 
> -+- 10332 sh -c sleep 1000 
>  --- 10333 sleep 1000 
> ]
> Command terminated with signal Terminated (pid: 10332)
> [   OK ] CniIsolatorTest.ROOT_VerifyCheckpointedInfo (3090 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46435/#review131761
---




src/tests/containerizer/cni_isolator_tests.cpp (lines 180 - 189)


Hum, i thought you already pulled these into a helper? Do you need to 
update this patch?


- Jie Yu


On April 20, 2016, 2:35 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46435/
> ---
> 
> (Updated April 20, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46435/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_VerifyCheckpointedInfo
> I0420 22:34:55.747752 10309 exec.cpp:150] Version: 0.29.0
> I0420 22:34:55.768620 10328 exec.cpp:225] Executor registered on agent 
> e5403695-ee6e-435c-a273-b9523adf7051-S0
> Registered executor on mesos
> Starting task 51bf9caa-9305-4533-8ba5-1d7982d807b7
> sh -c 'sleep 1000'
> Forked command at 10332
> Received killTask for task 51bf9caa-9305-4533-8ba5-1d7982d807b7
> Sending SIGTERM to process tree at pid 10332
> Sent SIGTERM to the following process trees:
> [ 
> -+- 10332 sh -c sleep 1000 
>  --- 10333 sleep 1000 
> ]
> Command terminated with signal Terminated (pid: 10332)
> [   OK ] CniIsolatorTest.ROOT_VerifyCheckpointedInfo (3090 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 42028: Added test "ROOT_CommandTaskNoRootfsFailedWithSameVolumes".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42028/
---

(Updated 五月 4, 2016, 11:32 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description
---

Added test "ROOT_CommandTaskNoRootfsFailedWithSameVolumes".


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
7fcb289b8701424d17567710fe5f8627d6fe25b6 

Diff: https://reviews.apache.org/r/42028/diff/


Testing
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsFailedWithSameVolumes"
 --verbose


Thanks,

Guangya Liu

Re: Review Request 46096: Updated prepare() method of "network/cni" isolator for tests.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46096/#review131757
---


Ship it!




Ship It!

- Jie Yu


On April 26, 2016, 3:53 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46096/
> ---
> 
> (Updated April 26, 2016, 3:53 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated prepare() method of "network/cni" isolator for tests.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> ef0bc1092d761804ca6bd73016c0f3dd23719257 
> 
> Diff: https://reviews.apache.org/r/46096/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/#review131756
---



Thanks Yu Jie, I saw that 
https://github.com/apache/mesos/blob/master/src/tests/containerizer/filesystem_isolator_tests.cpp
 also have some issues you listed, will try to make a cleanp after the test 
case done.

- Guangya Liu


On 五月 4, 2016, 8:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46140/
> ---
> 
> (Updated 五月 4, 2016, 8:54 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test "ROOT_CommandTaskNoRootfsWithVolumes".
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2ba82a78975f2f54bee8f93bc04b7816ce0887c1 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 
> 070d52018e82ed3e46fb1b79714ffc4716f6a306 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46140/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  
> --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithVolumes" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46395/#review131755
---




3rdparty/libprocess/src/process.cpp (lines 896 - 897)


```cpp
  if (::setsockopt(
  __s__->get(),
  SOL_SOCKET,
  SO_REUSEADDR,
  reinterpret_cast(),
  sizeof(on)) < 0) {
```



3rdparty/libprocess/src/process.cpp (lines 2240 - 2269)


Consider this if you would to preserve the guarantee:

```cpp
  struct
  {
void operator()() const
{
  do {
ProcessBase* process = process_manager->dequeue();
if (process == NULL) {
  Gate::state_t old = gate->approach();
  process = process_manager->dequeue();
  if (process == NULL) {
if (joining_threads.load()) {
  break;
}
gate->arrive(old);
// Wait
// at
// gate
// if
// idle.
continue;
  } else {
gate->leave();
  }
}
process_manager->resume(process);
  } while (true);
}

// We hold a constant reference to `joining_threads` to make it clear 
that this
// value is only being tested (read), and not manipulated.
const std::atomic_bool& joining_threads;
  } worker{joining_threads};

  // Create processing threads.
  for (long i = 0; i < num_worker_threads; i++) {
// Retain the thread handles so that we can join when shutting down.
threads.emplace_back(new std::thread(worker));
  }
```


- Michael Park


On April 23, 2016, 11:26 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46395/
> ---
> 
> (Updated April 23, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Removed `std::bind` from `process.cpp` to build on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
> 
> Diff: https://reviews.apache.org/r/46395/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/
---

(Updated May 4, 2016, 9:21 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
---

Changed `authorization_callbacks` to a pointer.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds the handling of authorization calls
for libprocess-level HTTP endpoints into the
`ProcessBase::visit` method. The authorization results
are sequenced to assure that operations are execute in
the same order in which they are received.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46989/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

[Greg Mann]

> On May 4, 2016, 3:24 a.m., Kapil Arya wrote:
> > 3rdparty/libprocess/include/process/http.hpp, lines 89-91
> > 
> >
> > Is that the correct line-break here? Can we make it better?

I read through the relevant sections of our style guide and the Google style 
guide, and I can't find guidance on this specific situation. I played around 
with it for a bit and found a format that I think is more readable; let me know 
what you think.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46866/#review131613
---


On May 4, 2016, 9:18 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46866/
> ---
> 
> (Updated May 4, 2016, 9:18 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables libprocess to store and execute
> authorization callbacks provided by a client
> application.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46866/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46866/
---

(Updated May 4, 2016, 9:18 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
---

Addressed comments.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch enables libprocess to store and execute
authorization callbacks provided by a client
application.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297 
  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46866/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46935/#review131738
---



Please run the script and include the .md change into this patch.


src/slave/http.cpp (lines 621 - 625)


Indentation : )



src/slave/http.cpp (lines 623 - 624)


How about something like: "The principal should be authorized to query this 
endpoint"?


- Alexander Rukletsov


On May 3, 2016, 2:17 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46935/
> ---
> 
> (Updated May 3, 2016, 2:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil 
> Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the agent endpoint '/metrics/snapshot'.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46935/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang-trunk w/o optimizations)
> 
> I also ran `generate-endpoints` and inspected the generated documentation.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46936: Documented the agent endpoint '/flags'.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46936/#review131739
---




src/slave/http.cpp (lines 356 - 357)


How about something like: "The principal should be authorized to query this 
endpoint"?


- Alexander Rukletsov


On May 3, 2016, 2:36 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46936/
> ---
> 
> (Updated May 3, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil 
> Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/flags.md b2740e6a4ce4bb8c25de07071bafbf174adf9137 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46936/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/#review131715
---


Fix it, then Ship it!




I'll make the change for you for this patch. Please update the subsequent 
patches according to the comments in this patch.


src/tests/containerizer/docker_volume_isolator_tests.cpp (line 26)


This is not needed as the test source if wrapped in OS_LINUX in the 
makefile.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 51)


We avoid using 'using namespace' now. Please include them explicitly.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 83)


Ditto on removing it.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 243)


indentation.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 259)


offers->size()



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 263)


Is this used?



src/tests/containerizer/docker_volume_isolator_tests.cpp (lines 266 - 268)


Why we need option here. I would simply not use it since we don't check 
that anyway.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 289)


you should use &&



src/tests/containerizer/docker_volume_isolator_tests.cpp (lines 310 - 311)


Why not checking driver name as well?



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 320)


Align the args please.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 326)


Align the args please.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 332)


why not offer.id()?



src/tests/containerizer/docker_volume_isolator_tests.cpp (lines 334 - 339)


The expectation should be placed before driver.launchTasks. Otherwise, it's 
possible that the expectation is not setup while the event has already been 
triggered.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 342)


You can replace .get().xxx with ->xxx



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 349)


Ditto on .get(). Please fix all of them.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 366)


Kill this line.


- Jie Yu


On May 4, 2016, 8:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46140/
> ---
> 
> (Updated May 4, 2016, 8:54 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test "ROOT_CommandTaskNoRootfsWithVolumes".
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2ba82a78975f2f54bee8f93bc04b7816ce0887c1 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 
> 070d52018e82ed3e46fb1b79714ffc4716f6a306 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46140/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  
> --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithVolumes" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 46990: Removed authorization from libprocess endpoint handlers.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46990/
---

Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

The previous commit added authorization handling
to `ProcessBase::visit`, so the authorization
handlers in the endpoint code can be removed.


Diffs
-

  3rdparty/libprocess/include/process/logging.hpp 
651cb3736705124bec9e4366c0e7adc5d5b488f0 
  3rdparty/libprocess/include/process/metrics/metrics.hpp 
25e8fcaeb9c71eaa43096165745e79c8198c139a 
  3rdparty/libprocess/src/logging.cpp ad7aa3aabbfc4a496e7e624a691a72e45c72e35d 
  3rdparty/libprocess/src/metrics/metrics.cpp 
65b58433158c51cebace9b591d4121e8d9a59ecc 

Diff: https://reviews.apache.org/r/46990/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/
---

Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds the handling of authorization calls
for libprocess-level HTTP endpoints into the
`ProcessBase::visit` method. The authorization results
are sequenced to assure that operations are execute in
the same order in which they are received.


Diffs
-

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46989/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/#review131697
---



Patch looks great!

Reviews applied: [46680, 46681, 46682, 46140, 42028, 38451, 39474]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 4, 2016, 2:33 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39474/
> ---
> 
> (Updated May 4, 2016, 2:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test "ROOT_CommandTaskRootfsWithVolumes".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39474/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  
> --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskRootfsWithVolumes" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Kapil Arya]

> On May 4, 2016, 11:33 a.m., James Peach wrote:
> > configure.ac, line 591
> > 
> >
> > So in practice, libraries would be installed in either 
> > ``3rdparty/lib64`` or ``3rdparty/lib``, but not both?
> > 
> > Is there a libtool or autoconf variable to figure that out?

On 32-bit, they'll be installed in lib. On 64-bit, it could be either :-(. I 
believe there might be a way to figure it out but I am not so sure given that 
we are talking about 3rdparty software (with their own configure scripts) here. 
I'll try to think of a better alternative.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review131691
---


On May 4, 2016, 11:22 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 4, 2016, 11:22 a.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review131691
---




configure.ac (line 591)


So in practice, libraries would be installed in either ``3rdparty/lib64`` 
or ``3rdparty/lib``, but not both?

Is there a libtool or autoconf variable to figure that out?


- James Peach


On May 4, 2016, 3:22 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 4, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/
---

(Updated May 4, 2016, 11:22 a.m.)


Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy 
St. Clair.


Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250


Repository: mesos


Description
---

Updated pkg-config file to include module dependency info.


Diffs
-

  configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
  mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 

Diff: https://reviews.apache.org/r/46540/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 46980: Implemented adding a cni network config via 'cni/config' endpoint.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46980/
---

Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5310
https://issues.apache.org/jira/browse/MESOS-5310


Repository: mesos


Description
---

Implemented adding a cni network config via 'cni/config' endpoint.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
a06bb89a7a79a62949a48274df806f9f95da09e7 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
ef0bc1092d761804ca6bd73016c0f3dd23719257 

Diff: https://reviews.apache.org/r/46980/diff/


Testing
---

Used `curl` to add a new CNI network configuration via 'cni/config' endpoint, 
and then used `mesos-execute` to launch a container to join the newly added CNI 
network successfully.


Thanks,

Qian Zhang

Review Request 46979: Introduced 'cni/config' endpoint.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46979/
---

Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5310
https://issues.apache.org/jira/browse/MESOS-5310


Repository: mesos


Description
---

Introduced 'cni/config' endpoint.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
a06bb89a7a79a62949a48274df806f9f95da09e7 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
ef0bc1092d761804ca6bd73016c0f3dd23719257 

Diff: https://reviews.apache.org/r/46979/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/
---

(Updated 五月 4, 2016, 2:33 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-

Added test "ROOT_CommandTaskRootfsWithVolumes".


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description (updated)
---

Added test "ROOT_CommandTaskRootfsWithVolumes".


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39474/diff/


Testing (updated)
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskRootfsWithVolumes" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46969/#review131666
---



Patch looks great!

Reviews applied: [46613, 46969]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 4, 2016, 12:58 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46969/
> ---
> 
> (Updated May 4, 2016, 12:58 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-5169
> https://issues.apache.org/jira/browse/MESOS-5169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows us to use common protobug messages for authorization.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.proto 
> 32492a59ad95df3bb673ec42321518f86c11af59 
>   src/authorizer/local/authorizer.cpp 
> e59c11269670a7ed72b780913971b421ee17f33f 
> 
> Diff: https://reviews.apache.org/r/46969/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain (see upcoming patches)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

[Guangya Liu]

> On 五月 3, 2016, 10:36 p.m., Gilbert Song wrote:
> > It seems to me that we have `Starting container..` in launch() and `cloning 
> > child..` in fork().

Yes, but what I want to hightlight is the flags that we used to start 
`mesos-containerizer`, so just using `lauch mesos-containerizer`, any 
suggestion on the message?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46874/#review131575
---


On 五月 1, 2016, 6:24 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46874/
> ---
> 
> (Updated 五月 1, 2016, 6:24 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The mesos-containerizer will help prepare the rootfs, mount and
> network conf for a container when launch with some flags, it
> would be helpful to print out all of the mesos-containerizer launch
> flags for trouble shooting.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 8d538954d6e1f13e833d75c2eaa37e700278ee0c 
> 
> Diff: https://reviews.apache.org/r/46874/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Enhanced log message:
> I0501 14:12:17.910006  5991 containerizer.cpp:1175] Launching 
> 'mesos-containerizer' with flags as 
> '--command="{"shell":true,"value":"\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-executor"}"
>  --commands="{"commands":[{"shell":true,"value":"#!\/bin\/sh\nset -x 
> -e\n\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-containerizer mount 
> --help=\"false\" --operation=\"make-rslave\" --path=\"\/\"\ngrep -E 
> '\/tmp\/mesos\/.+' \/proc\/self\/mountinfo | grep -v 
> 'a2cc264f-72eb-416c-b876-e4a98484a0ab' | cut -d' ' -f5 | xargs 
> --no-run-if-empty umount -l || true \n"}]}" --help="false" --pipe_read="8" 
> --pipe_write="9" 
> --sandbox="/tmp/mesos/slaves/5763efb9-8e12-4bfc-b06b-2a324881608d-S0/frameworks/425afd24-796d-42dd-98c0-593f1d71e246-/executors/test/runs/a2cc264f-72eb-416c-b876-e4a98484a0ab"
>  --user="root"'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46969/
---

(Updated May 4, 2016, 12:58 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Rebased.


Bugs: MESOS-5169
https://issues.apache.org/jira/browse/MESOS-5169


Repository: mesos


Description (updated)
---

This allows us to use common protobug messages for authorization.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.proto 
32492a59ad95df3bb673ec42321518f86c11af59 
  src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f 

Diff: https://reviews.apache.org/r/46969/diff/


Testing
---

tested entire chain (see upcoming patches)


Thanks,

Joerg Schad

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/
---

(Updated May 4, 2016, 12:57 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Rebased.


Bugs: MESOS-5169
https://issues.apache.org/jira/browse/MESOS-5169


Repository: mesos


Description
---

Introduced VIEW_(FRAMEWORK,TASK}_WITH_INFO actions to authorizer.


Diffs (updated)
-

  docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
  include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
  include/mesos/authorizer/authorizer.proto 
32492a59ad95df3bb673ec42321518f86c11af59 
  src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f 

Diff: https://reviews.apache.org/r/46613/diff/


Testing
---

make check (OSX)


Thanks,

Joerg Schad

Re: Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46969/#review131649
---



Bad patch!

Reviews applied: [46969, 46613]

Failed command: ./support/apply-review.sh -n -r 46613

Error:
2016-05-04 10:38:03 URL:https://reviews.apache.org/r/46613/diff/raw/ 
[4877/4877] -> "46613.patch" [1]
error: patch failed: include/mesos/authorizer/acls.proto:146
error: include/mesos/authorizer/acls.proto: patch does not apply
error: patch failed: include/mesos/authorizer/authorizer.proto:58
error: include/mesos/authorizer/authorizer.proto: patch does not apply
error: patch failed: src/authorizer/local/authorizer.cpp:201
error: src/authorizer/local/authorizer.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12882/console

- Mesos ReviewBot


On May 4, 2016, 10:07 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46969/
> ---
> 
> (Updated May 4, 2016, 10:07 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-5169
> https://issues.apache.org/jira/browse/MESOS-5169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: This allows us to use common protobug messages for authorization.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.proto 
> 40d93ea257d1df8d22eee8a21667db90d579a8fe 
>   src/authorizer/local/authorizer.cpp 
> c744a16041c2466d3839a37fbee2bf86887bf4e1 
> 
> Diff: https://reviews.apache.org/r/46969/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain (see upcoming patches)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38451/
---

(Updated 五月 4, 2016, 10:14 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-

Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description (updated)
---

Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38451/diff/


Testing (updated)
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsSlaveRecovery" 
--verbose


Thanks,

Guangya Liu

Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46969/
---

Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-5169
https://issues.apache.org/jira/browse/MESOS-5169


Repository: mesos


Description
---

WIP: This allows us to use common protobug messages for authorization.


Diffs
-

  include/mesos/authorizer/authorizer.proto 
40d93ea257d1df8d22eee8a21667db90d579a8fe 
  src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1 

Diff: https://reviews.apache.org/r/46969/diff/


Testing
---

tested entire chain (see upcoming patches)


Thanks,

Joerg Schad

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/
---

(Updated May 4, 2016, 10:05 a.m.)


Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-5169
https://issues.apache.org/jira/browse/MESOS-5169


Repository: mesos


Description
---

Introduced VIEW_(FRAMEWORK,TASK}_WITH_INFO actions to authorizer.


Diffs (updated)
-

  docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
  include/mesos/authorizer/acls.proto c50deeb5565dfd5b3e5e7210283d9a36a3bfd579 
  include/mesos/authorizer/authorizer.proto 
40d93ea257d1df8d22eee8a21667db90d579a8fe 
  src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1 
  src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 

Diff: https://reviews.apache.org/r/46613/diff/


Testing
---

make check (OSX)


Thanks,

Joerg Schad

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131647
---



Patch looks great!

Reviews applied: [46958]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 4, 2016, 9:03 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 9:03 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[Zhiwei Chen]

> On May 4, 2016, 4:57 p.m., Neil Conway wrote:
> > docs/getting-started.md, line 47
> > 
> >
> > This should end in a period. Also, I'd say "(Only necessary if SSL and 
> > libevent are enabled)."

Thank you very much, I missed this.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131642
---


On May 4, 2016, 5:03 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 42028: Added test "ROOT_CommandTaskNoRootfsFailedWithSameVolumes".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42028/
---

(Updated 五月 4, 2016, 9:03 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-

Added test "ROOT_CommandTaskNoRootfsFailedWithSameVolumes".


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description (updated)
---

Added test "ROOT_CommandTaskNoRootfsFailedWithSameVolumes".


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/42028/diff/


Testing (updated)
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsFailedWithSameVolumes"
 --verbose


Thanks,

Guangya Liu

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/
---

(Updated May 4, 2016, 5:03 p.m.)


Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5321
https://issues.apache.org/jira/browse/MESOS-5321


Repository: mesos


Description
---

Added Ubuntu 16.04 LTS to getting started document.


Diffs (updated)
-

  docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 

Diff: https://reviews.apache.org/r/46958/diff/


Testing
---

./configure --enable-ssl --enable-libevent && make


Thanks,

Zhiwei Chen

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131642
---


Fix it, then Ship it!





docs/getting-started.md (line 47)


This should end in a period. Also, I'd say "(Only necessary if SSL and 
libevent are enabled)."



docs/getting-started.md (line 69)


Same as above.


- Neil Conway


On May 4, 2016, 8:31 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 8:31 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/
---

(Updated 五月 4, 2016, 8:54 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-

Added test "ROOT_CommandTaskNoRootfsWithVolumes".


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description
---

Added test "ROOT_CommandTaskNoRootfsWithVolumes".


Diffs (updated)
-

  src/Makefile.am 2ba82a78975f2f54bee8f93bc04b7816ce0887c1 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 
070d52018e82ed3e46fb1b79714ffc4716f6a306 
  src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46140/diff/


Testing
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithVolumes" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/
---

(Updated May 4, 2016, 4:31 p.m.)


Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5321
https://issues.apache.org/jira/browse/MESOS-5321


Repository: mesos


Description
---

Added Ubuntu 16.04 LTS to getting started document.


Diffs (updated)
-

  docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 

Diff: https://reviews.apache.org/r/46958/diff/


Testing
---

./configure --enable-ssl --enable-libevent && make


Thanks,

Zhiwei Chen

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[Zhiwei Chen]

> On May 4, 2016, 3:48 p.m., Neil Conway wrote:
> > docs/getting-started.md, line 64
> > 
> >
> > Is automake also required for 14.04?

my falt, it will be automatically installed. Will remove it in next patch.


> On May 4, 2016, 3:48 p.m., Neil Conway wrote:
> > docs/getting-started.md, line 66
> > 
> >
> > Can we synchronize this with the instructions for Ubuntu 14.04? i.e., 
> > either mention installing the SSL dependencies for both versions or neither.

OK, I will also update the Ubuntu 14.04 section.


> On May 4, 2016, 3:48 p.m., Neil Conway wrote:
> > docs/getting-started.md, line 70
> > 
> >
> > Is zlib1g-dev also required for 14.04?

Yes, it is required for 14.04, but it will be automatically installed when 
install libcurl4-nss-dev. In Ubuntu 16.04, it will no be installed when install 
libcurl4-nss-dev.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131637
---


On May 4, 2016, 10:50 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 10:50 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review131640
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On May 4, 2016, 7:55 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 4, 2016, 7:55 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/
---

Review request for mesos.


Repository: mesos


Description
---

Using ARIA landmarks to identify regions of a page and Providing heading 
elements at the beginning of each section of content.


Diffs
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 
  src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 

Diff: https://reviews.apache.org/r/46965/diff/


Testing
---

we should Using ARIA landmarks to identify regions of a page.

1.Should add "main" role to main content page and use "banner" role for header
refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11

2. Providing heading elements at the beginning of each section of content. So 
for the header section we need provide a h1
refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html


Thanks,

Chen Nan Li

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131637
---




docs/getting-started.md (line 64)


Is automake also required for 14.04?



docs/getting-started.md (line 66)


Can we synchronize this with the instructions for Ubuntu 14.04? i.e., 
either mention installing the SSL dependencies for both versions or neither.



docs/getting-started.md (line 70)


Is zlib1g-dev also required for 14.04?


- Neil Conway


On May 4, 2016, 2:50 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 2:50 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46923: Added framework failover timeout validation.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46923/#review131635
---



I notice that `Master::_exited` also checks that the `failover_timeout` is 
valid. Do you think it would be better to simplify that logic to assume that 
the `failover_timeout` is always valid? i.e., add a `CHECK` that it is valid 
rather than printing a warning message.


src/master/master.hpp (line 938)


You can remove this change.



src/master/master.cpp (line 2256)


I think using `stringify` here would be a bit more idiomatic in Mesos.



src/master/master.cpp (line 2479)


This should be consistent with the first instance of the error message 
above.



src/tests/master_tests.cpp (line 4481)


This comment still seems unclear to me -- we should explain why 
`9` is an invalid framework timeout. (The reason is that we 
internally represent the timeout using nanoseconds since the epoch as an int64; 
`9` in seconds converted to nanoseconds is too large for an 
int64). Also, the conversion fails internally to Mesos (stout), not because of 
protobuf.


- Neil Conway


On May 4, 2016, 12:43 a.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46923/
> ---
> 
> (Updated May 4, 2016, 12:43 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Kevin Sweeney, Neil Conway, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-1575
> https://issues.apache.org/jira/browse/MESOS-1575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Frameworks were allowed to subscribe themselves with invalid failover
> timeout. For this reason, a validation has been made in the master to
> deny framework subscription if it set a invalid value for the failover
> timeout. MESOS-1575
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
> 
> Diff: https://reviews.apache.org/r/46923/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Re: Review Request 46140: WIP: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/
---

(Updated 五月 4, 2016, 7:01 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description
---

Added test "ROOT_CommandTaskNoRootfsWithVolumes".


Diffs (updated)
-

  src/Makefile.am 2ba82a78975f2f54bee8f93bc04b7816ce0887c1 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 
070d52018e82ed3e46fb1b79714ffc4716f6a306 
  src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46140/diff/


Testing
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithVolumes" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 46140: WIP: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/
---

(Updated 五月 4, 2016, 6:53 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-

WIP: Added test "ROOT_CommandTaskNoRootfsWithVolumes".


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description (updated)
---

Added test "ROOT_CommandTaskNoRootfsWithVolumes".


Diffs (updated)
-

  src/Makefile.am 2ba82a78975f2f54bee8f93bc04b7816ce0887c1 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 
070d52018e82ed3e46fb1b79714ffc4716f6a306 
  src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46140/diff/


Testing (updated)
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithVolumes" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 46960: Remove un-necessary copying of `slave->tasks` in master.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46960/#review131630
---



Patch looks great!

Reviews applied: [46960]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 4, 2016, 5:14 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46960/
> ---
> 
> (Updated May 4, 2016, 5:14 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It seems that we removed an else block in 0.26 that removed the
> `removeTask` call from the `foreachvalue` loop but we still kept
> on copying `slave->tasks` though it is not needed anymore.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
> 
> Diff: https://reviews.apache.org/r/46960/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>