Re: Review Request 50713: Documented behavior of content-type header in presence of errors.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50713/#review144584
---



Patch looks great!

Reviews applied: [50626, 50713]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 2, 2016, 5:40 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50713/
> ---
> 
> (Updated Aug. 2, 2016, 5:40 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-5853
> https://issues.apache.org/jira/browse/MESOS-5853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When an error response is generated for http v1 api, default
> contentType is "text/plain; charset=utf-8". This has been
> documented for the docs of http v1 api in this patch.
> 
> 
> Diffs
> -
> 
>   docs/executor-http-api.md fb70f75c43c2751ff430a571ed8d4630d29a7ef8 
>   docs/operator-http-api.md 4f4c39e7b4b6de32af1933c34eba21f126fae8ac 
>   docs/scheduler-http-api.md 4be961214c63e4e3b25c5c350b2c4f0e66863817 
> 
> Diff: https://reviews.apache.org/r/50713/diff/
> 
> 
> Testing
> ---
> 
> Viewed with "rake dev".
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 50732: Check for shared count and scalar values in subtraction of resources.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50732/#review144580
---


Ship it!




Committed it with the suggested fix. Thanks!

- Jiang Yan Xu


On Aug. 2, 2016, 6:50 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50732/
> ---
> 
> (Updated Aug. 2, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5972
> https://issues.apache.org/jira/browse/MESOS-5972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Incase of shared resources, the Resource_ object is removed if the
> shared count is <= 0, and for non-shared resources, it is removed
> if the scalar value is <= 0.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 7b52c72534cca55185c1df2257b48cb85c49f65c 
>   src/v1/resources.cpp d27c1a24c8e3de40d47cecac0e4528908a39ba52 
> 
> Diff: https://reviews.apache.org/r/50732/diff/
> 
> 
> Testing
> ---
> 
> Tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 50732: Check for shared count and scalar values in subtraction of resources.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50732/#review144576
---



Thanks for the fix!


src/common/resources.cpp (lines 1631 - 1637)


- A shared resource is not necessarily a SCALAR.
- Also, while true, understanding that "Resources arithmetic logic doesn't 
allow Resource_ with positive sharedCount but negative value" requires some 
nonlocal reasoning.

Intead I think this is more intuitive: a "negative" Resource_ either has a 
negative sharedCount or a negative scalar value".

This translates into:

```
bool negative =
  (resource_.isShared() && resource_.sharedCount.get() < 0) ||
  (resource_.resource.type() == Value::SCALAR &&
  resource_.resource.scalar().value() < 0);
```


- Jiang Yan Xu


On Aug. 2, 2016, 6:50 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50732/
> ---
> 
> (Updated Aug. 2, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5972
> https://issues.apache.org/jira/browse/MESOS-5972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Incase of shared resources, the Resource_ object is removed if the
> shared count is <= 0, and for non-shared resources, it is removed
> if the scalar value is <= 0.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 7b52c72534cca55185c1df2257b48cb85c49f65c 
>   src/v1/resources.cpp d27c1a24c8e3de40d47cecac0e4528908a39ba52 
> 
> Diff: https://reviews.apache.org/r/50732/diff/
> 
> 
> Testing
> ---
> 
> Tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50733/
---

Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Bugs: MESOS-5973
https://issues.apache.org/jira/browse/MESOS-5973


Repository: mesos


Description
---

Removed CgroupsCpushareIsolatorProcess.


Diffs
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 
74982a610b6c0a74734165a0c6aa8c9f72f54deb 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
4f0a43b9d8b0d04a8e3e11b1a11688d4fa93 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50733/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50732: Check for shared count and scalar values in subtraction of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50732/
---

(Updated Aug. 3, 2016, 1:50 a.m.)


Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Changes
---

Updated comment and a minor tweak.


Bugs: MESOS-5972
https://issues.apache.org/jira/browse/MESOS-5972


Repository: mesos


Description
---

Incase of shared resources, the Resource_ object is removed if the
shared count is <= 0, and for non-shared resources, it is removed
if the scalar value is <= 0.


Diffs (updated)
-

  src/common/resources.cpp 7b52c72534cca55185c1df2257b48cb85c49f65c 
  src/v1/resources.cpp d27c1a24c8e3de40d47cecac0e4528908a39ba52 

Diff: https://reviews.apache.org/r/50732/diff/


Testing
---

Tests passed.


Thanks,

Anindya Sinha

Review Request 50732: Check for shared count and scalar values in subtraction of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50732/
---

Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Bugs: MESOS-5972
https://issues.apache.org/jira/browse/MESOS-5972


Repository: mesos


Description
---

Incase of shared resources, the Resource_ object is removed if the
shared count is <= 0, and for non-shared resources, it is removed
if the scalar value is <= 0.


Diffs
-

  src/common/resources.cpp 7b52c72534cca55185c1df2257b48cb85c49f65c 
  src/v1/resources.cpp d27c1a24c8e3de40d47cecac0e4528908a39ba52 

Diff: https://reviews.apache.org/r/50732/diff/


Testing
---

Tests passed.


Thanks,

Anindya Sinha

Re: Review Request 50728: Added MESOS-5927 to 1.0.1 CHANGELOG.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50728/#review144565
---


Ship it!




Ship It!

- Jie Yu


On Aug. 2, 2016, 11:53 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50728/
> ---
> 
> (Updated Aug. 2, 2016, 11:53 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added MESOS-5927 to 1.0.1 CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG eca695cc83683772fd17241b1dcda183678f5d65 
> 
> Diff: https://reviews.apache.org/r/50728/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 50729: Added MESOS-5927 to 0.28.3 CHANGELOG.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50729/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added MESOS-5927 to 0.28.3 CHANGELOG.


Diffs
-

  CHANGELOG eca695cc83683772fd17241b1dcda183678f5d65 

Diff: https://reviews.apache.org/r/50729/diff/


Testing
---

N/A.


Thanks,

Gilbert Song

Review Request 50728: Added MESOS-5927 to 1.0.1 CHANGELOG.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50728/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added MESOS-5927 to 1.0.1 CHANGELOG.


Diffs
-

  CHANGELOG eca695cc83683772fd17241b1dcda183678f5d65 

Diff: https://reviews.apache.org/r/50728/diff/


Testing
---

N/A.


Thanks,

Gilbert Song

Re: Review Request 50727: Added a unit test for scratch based docker images.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50727/#review144563
---


Ship it!




Ship It!

- Jie Yu


On Aug. 2, 2016, 11:46 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50727/
> ---
> 
> (Updated Aug. 2, 2016, 11:46 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Phil Winder, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-5927
> https://issues.apache.org/jira/browse/MESOS-5927
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a unit test for scratch based docker images.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> ffe3382da8b1199e257a72ca9034fbccec9494b1 
> 
> Diff: https://reviews.apache.org/r/50727/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 50727: Added a unit test for scratch based docker images.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50727/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, Phil Winder, and Timothy 
Chen.


Bugs: MESOS-5927
https://issues.apache.org/jira/browse/MESOS-5927


Repository: mesos


Description
---

Added a unit test for scratch based docker images.


Diffs
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
ffe3382da8b1199e257a72ca9034fbccec9494b1 

Diff: https://reviews.apache.org/r/50727/diff/


Testing
---

make check

sudo ./bin/mesos-tests.sh


Thanks,

Gilbert Song

Re: Review Request 50719: Supported scratch containers in Unified Containerizer.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50719/
---

(Updated Aug. 2, 2016, 4:44 p.m.)


Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen, 
and Jiang Yan Xu.


Bugs: MESOS-5927
https://issues.apache.org/jira/browse/MESOS-5927


Repository: mesos


Description
---

Before this patch, we are assuming the 'tmpfs' mount point '/tmp'
always exist in the container's new rootfs. However, this is not
true. For the scratch container (which is a common case), '/tmp'
may not exist, and there may only be an executable binary in the
new rootfs. So we need to create the mount point for 'tmpfs' in
fs::enter().

However, this change may break some cases using the bind backend,
because we are not able the create the '/tmp' mount point in a
read-only filesystem. So we require users to make sure the
directory '/tmp' must already exist in their single layer scratch
images for the following reasons:
  1. For most cases, when operators prefer using the bind backend,
 the single-layer images are usually large in size, and '/tmp'
 exists in the rootfs.
  2. For scratch images, most of them contain more than one layer,
 which means the bind backend cannot be used in those cases.
 So we can create the '/tmp' mount point if it does not exist.
  3. If this is strictly a single layer scratch image, it is
 reasonable that we require users to make sure the mount point
 '/tmp' existed in the image rootfs if they are using the bind
 backend, because we already require the sandbox mount point
 to be existed in those iamges.


Diffs (updated)
-

  src/linux/fs.cpp 27d322c759b6ef9ea17b371e7013cace926bff47 

Diff: https://reviews.apache.org/r/50719/diff/


Testing
---

make check

Manually tested using single-layered scratch image `hello-seattle` from local 
puller (the one fetched from registry puller is a two-layer image due to 
dockerhub server redirection) and copy backend.

Other scratch image like hello-world is also tested.


Thanks,

Gilbert Song

Re: Review Request 50721: Fixed the bind backend document in container-image.md.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50721/
---

(Updated Aug. 2, 2016, 4:44 p.m.)


Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen, 
and Jiang Yan Xu.


Bugs: MESOS-5927
https://issues.apache.org/jira/browse/MESOS-5927


Repository: mesos


Description
---

Fixed the bind backend document in container-image.md.


Diffs (updated)
-

  docs/container-image.md 745f6b045d11de6f54323347ebadac9e3ae6cab2 

Diff: https://reviews.apache.org/r/50721/diff/


Testing
---

gist.


Thanks,

Gilbert Song

Re: Review Request 50718: Deprecated the 'rootfs' proto field in ContainerLaunchInfo.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50718/
---

(Updated Aug. 2, 2016, 4:44 p.m.)


Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen, 
and Jiang Yan Xu.


Repository: mesos


Description
---

Deprecated the 'rootfs' proto field in ContainerLaunchInfo.


Diffs (updated)
-

  include/mesos/slave/isolator.proto a971a582da2ec121ed8dd4ef0b7f5ee47a0c3d03 

Diff: https://reviews.apache.org/r/50718/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 50720: Added comments for tmpfs and sandbox mountpoints for bind backend.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50720/
---

(Updated Aug. 2, 2016, 4:44 p.m.)


Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen, 
and Jiang Yan Xu.


Bugs: MESOS-5927
https://issues.apache.org/jira/browse/MESOS-5927


Repository: mesos


Description
---

Added comments for tmpfs and sandbox mountpoints for bind backend.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
31aa3e7ed09173701b4d6663492e6c2fc0743887 
  src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
2b2fcdca2298aa022d4136ad0b2f6e851f7c9202 

Diff: https://reviews.apache.org/r/50720/diff/


Testing
---

N/A.


Thanks,

Gilbert Song

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50674/#review144555
---




3rdparty/stout/tests/flags_tests.cpp (lines 231 - 235)


This test will build on Windows, right?

If so, you should prepend `DISABLED_` instead of `#ifdef`-ing it.  Same 
with most of these tests, I believe.


- Joseph Wu


On Aug. 1, 2016, 2:27 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50674/
> ---
> 
> (Updated Aug. 1, 2016, 2:27 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A large number of Stout test files are currently not being built on
> Windows.  Many of these files contain tests for parts of Stout that have
> already been ported, or require only trivial fixes to work (such as
> removing `#include`s on Windows). A small minority of the tests contain
> bugs that we should fix.
> 
> This commit will add these files to the build, fix some of the
> trivially-fixable tests, and disable tests that are known to fail
> because of bugs, including comments explaining why and links to JIRA
> issues where appropriate.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/mac.hpp 
> 91c4fdad350459b3e0bdf1744089e14ac883829a 
>   3rdparty/stout/include/stout/os/windows/kill.hpp 
> 0ddb3eeae3377688ad298a45c849c829c218890f 
>   3rdparty/stout/tests/CMakeLists.txt 
> f85dc998e8ba5f8d727933373c3e14500d0bdfae 
>   3rdparty/stout/tests/flags_tests.cpp 
> 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
>   3rdparty/stout/tests/ip_tests.cpp 4d1f1c9a4dd35da2a21bef1349a662af44bb4ba1 
>   3rdparty/stout/tests/mac_tests.cpp 1ff60cf5506c1855547400aa20107ec5086d8431 
>   3rdparty/stout/tests/os/rmdir_tests.cpp 
> ffe234baac305e26b5a29cffcdd310350d10167e 
>   3rdparty/stout/tests/os_tests.cpp e67444077eae55fd25945b451164b5bcc37552b0 
> 
> Diff: https://reviews.apache.org/r/50674/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 50724: Added MESOS-5388 to 1.0.1 CHANGELOG.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50724/#review144558
---


Ship it!




Ship It!

- Jie Yu


On Aug. 2, 2016, 11:05 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50724/
> ---
> 
> (Updated Aug. 2, 2016, 11:05 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added MESOS-5388 to 1.0.1 CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 6168b5ef23fec605deae1f382e1c0dface59c148 
> 
> Diff: https://reviews.apache.org/r/50724/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50726: Fixed the white space indentation in CHANGELOG.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50726/#review144557
---


Ship it!




Ship It!

- Jie Yu


On Aug. 2, 2016, 11:06 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50726/
> ---
> 
> (Updated Aug. 2, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the white space indentation in CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 6168b5ef23fec605deae1f382e1c0dface59c148 
> 
> Diff: https://reviews.apache.org/r/50726/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 50726: Fixed the white space indentation in CHANGELOG.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50726/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Fixed the white space indentation in CHANGELOG.


Diffs
-

  CHANGELOG 6168b5ef23fec605deae1f382e1c0dface59c148 

Diff: https://reviews.apache.org/r/50726/diff/


Testing
---

N/A.


Thanks,

Gilbert Song

Re: Review Request 50724: Added MESOS-5388 to 1.0.1 CHANGELOG.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50724/
---

(Updated Aug. 2, 2016, 4:05 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added MESOS-5388 to 1.0.1 CHANGELOG.


Diffs (updated)
-

  CHANGELOG 6168b5ef23fec605deae1f382e1c0dface59c148 

Diff: https://reviews.apache.org/r/50724/diff/


Testing
---

N/A.


Thanks,

Gilbert Song

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

[Greg Mann]

> On Aug. 2, 2016, 6:04 p.m., Vinod Kone wrote:
> > src/master/main.cpp, lines 220-223
> > 
> >
> > shouldn't this be moved up above the load error as well?

Sure thing - I was going to only address the '--version' flag in this patch, 
but since it's a small change I think there's no harm in including this here.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/#review144517
---


On Aug. 2, 2016, 11:04 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50609/
> ---
> 
> (Updated Aug. 2, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Pierre Cheynier.
> 
> 
> Bugs: MESOS-5928
> https://issues.apache.org/jira/browse/MESOS-5928
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The recent removal of the agent's default `work_dir`
> requires us to check for the presence of the `--version`
> flag before we check for errors in flag loading; this
> patch makes that change, and also moves the
> corresponding code in the master for consistency.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
>   src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 
> 
> Diff: https://reviews.apache.org/r/50609/diff/
> 
> 
> Testing
> ---
> 
> Ran the mesos agent and master binaries with and without the '--version' flag 
> to verify correct behavior and return code.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/
---

(Updated Aug. 2, 2016, 11:04 p.m.)


Review request for mesos, Jie Yu and Pierre Cheynier.


Changes
---

Addressed comment.


Bugs: MESOS-5928
https://issues.apache.org/jira/browse/MESOS-5928


Repository: mesos


Description
---

The recent removal of the agent's default `work_dir`
requires us to check for the presence of the `--version`
flag before we check for errors in flag loading; this
patch makes that change, and also moves the
corresponding code in the master for consistency.


Diffs (updated)
-

  src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
  src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 

Diff: https://reviews.apache.org/r/50609/diff/


Testing
---

Ran the mesos agent and master binaries with and without the '--version' flag 
to verify correct behavior and return code.


Thanks,

Greg Mann

Re: Review Request 50673: Made semantics of `os::rmdir` consistent between POSIX and Windows.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50673/#review144547
---




3rdparty/stout/tests/os/rmdir_tests.cpp (line 105)


Per the next comment (below this one), this line would become:
```
EXPECT_EQ(hashset::EMPTY, listfiles(tmpdir));
```



3rdparty/stout/tests/os/rmdir_tests.cpp (lines 116 - 117)


Since these two sets are only modified once within the test, why not do:
```
  const hashset expectedRootListing = { newDirectoryName };
  const hashset expectedSubListing = { newFileName };
```

I realize this is the pattern within the other tests in this file.  So 
perhaps you can change the pattern in a subsequent review :)


- Joseph Wu


On Aug. 1, 2016, 2:24 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50673/
> ---
> 
> (Updated Aug. 1, 2016, 2:24 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joseph Wu.
> 
> 
> Bugs: MESOS-5942
> https://issues.apache.org/jira/browse/MESOS-5942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit will fix 2 known bugs in the Windows implementation of
> `os::rmdir`, as chronicled in MESOS-5942, namely:
> 
> 1. Calling `os::rmdir` with a file argument (rather than a directory)
>and the `recursive` parameter set to `true` will fail on Windows,
>but succeed on POSIX.
> 
> The POSIX semantics of `os::rmdir` are a union of `rm -r` and `::rmdir`,
> the behavior of which depends on the arguments the caller passes in. If
> the formal parameter `recursive` is set to `true`, then the semantics
> are meant to be`rm -r`; if `false`, the semantics are meant to be
> `::rmdir`.
> 
> The implications of this are somewhat subtle: `::rmdir` will error out
> if you try to delete (e.g.) regular files, while `rm -r` will happily
> delete them.
> 
> On Windows, we currently always have `::rmdir`-style semantics, in that
> we if you pass a path that points at a file to `os::rmdir`, it will not
> delete that file.
> 
> This commit will reverse this, and move make the Windows implementation
> semantically identical to the POSIX implementation (at least in this
> regard).
> 
> 2. Recursively deleting nested directories fails on windows when
>`removeRoot` is set to `false`.
> 
> Currently if you set the `removeRoot` parameter to `false`, the Windows
> implementation of `os::rmdir` will fail to delete a directory inside a
> directory. The reason is that we are propagating the `removeRoot` flag
> to the recursive calls to `os::rmdir`. The implication of this is that
> the recursive call will *not* delete the nested directory (since
> `removeRoot` is `false`).
> 
> This commit will fix this by setting `removeRoot` to `true` in recursive
> calls to `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> b74bf7153a15435ce424880df84901c349dee216 
>   3rdparty/stout/tests/os/rmdir_tests.cpp 
> ffe234baac305e26b5a29cffcdd310350d10167e 
> 
> Diff: https://reviews.apache.org/r/50673/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 50724: Added MESOS-5388 to 1.0.1 CHANGELOG.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50724/#review144550
---




CHANGELOG (line 7)


can you seprate the white space fix?


- Jie Yu


On Aug. 2, 2016, 10:45 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50724/
> ---
> 
> (Updated Aug. 2, 2016, 10:45 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added MESOS-5388 to 1.0.1 CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 6168b5ef23fec605deae1f382e1c0dface59c148 
> 
> Diff: https://reviews.apache.org/r/50724/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 50724: Added MESOS-5388 to 1.0.1 CHANGELOG.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50724/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added MESOS-5388 to 1.0.1 CHANGELOG.


Diffs
-

  CHANGELOG 6168b5ef23fec605deae1f382e1c0dface59c148 

Diff: https://reviews.apache.org/r/50724/diff/


Testing
---

N/A.


Thanks,

Gilbert Song

Re: Review Request 50581: Added logs for pre-exec commands to sandbox in MesosContainerizerLaunch.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50581/
---

(Updated Aug. 2, 2016, 3:43 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Added logs for pre-exec commands to sandbox in MesosContainerizerLaunch.


Diffs (updated)
-

  src/slave/containerizer/mesos/launch.cpp 
e1cf9d5226ca4b4b33d8f9d9efb968be35d4ec4d 

Diff: https://reviews.apache.org/r/50581/diff/


Testing
---

make check

sudo ./bin/mesos-tests.sh

The sandbox log will look as the following:
```
Executing pre-exec command 
{"arguments":["mesos-containerizer","mount","--help=false","--operation=make-rslave","--path=\/"],"shell":false,"value":"\/home\/vagrant\/mesos\/build\/src\/mesos-containerizer"}
Executing pre-exec command 
{"arguments":["mount","-n","--rbind","\/tmp\/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutor_NuNoW5\/slaves\/c203dac1-ca1c-4a38-8d6b-3c48af6a5ab9-S0\/frameworks\/c203dac1-ca1c-4a38-8d6b-3c48af6a5ab9-\/executors\/09e642aa-e545-44e9-8bca-18292b171cca\/runs\/7f494191-2518-4f37-836a-bcdee4b634f2","\/tmp\/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutor_NuNoW5\/provisioner\/containers\/7f494191-2518-4f37-836a-bcdee4b634f2\/backends\/copy\/rootfses\/43665fdd-2361-4a82-9f92-56ff21b428c9\/mnt\/mesos\/sandbox"],"shell":false,"value":"mount"}
I0802 20:34:17.818397 29502 exec.cpp:161] Version: 1.1.0
I0802 20:34:17.826095 29561 exec.cpp:236] Executor registered on agent 
c203dac1-ca1c-4a38-8d6b-3c48af6a5ab9-S0
Received SUBSCRIBED event
Subscribed executor on vagrant-ubuntu-trusty-64
Received LAUNCH event
Starting task 09e642aa-e545-44e9-8bca-18292b171cca
/home/vagrant/mesos/build/src/mesos-containerizer launch 
--command="{"shell":true,"value":"test -d \/mnt\/mesos\/sandbox"}" 
--help="false" 
--rootfs="/tmp/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutor_NuNoW5/provisioner/containers/7f494191-2518-4f37-836a-bcdee4b634f2/backends/copy/rootfses/43665fdd-2361-4a82-9f92-56ff21b428c9"
 --unshare_namespace_mnt="false" --user="root" 
--working_directory="/mnt/mesos/sandbox"
```


Thanks,

Gilbert Song

Re: Review Request 50721: Fixed the bind backend document in container-image.md.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50721/#review144546
---


Ship it!




Ship It!

- Jie Yu


On Aug. 2, 2016, 9:43 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50721/
> ---
> 
> (Updated Aug. 2, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy 
> Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5927
> https://issues.apache.org/jira/browse/MESOS-5927
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the bind backend document in container-image.md.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 745f6b045d11de6f54323347ebadac9e3ae6cab2 
> 
> Diff: https://reviews.apache.org/r/50721/diff/
> 
> 
> Testing
> ---
> 
> gist.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

[Guangya Liu]

> On 七月 29, 2016, 8:35 p.m., Benjamin Mahler wrote:
> > src/tests/resources_tests.cpp, lines 2515-2523
> > 
> >
> > Can we make the initial resources another parameter? I believe Klaus 
> > took this approach initially but I had removed 'initial' to simplify the 
> > patch.
> > 
> > If we make it a parameter we can have initial ports only for the port 
> > test case.
> 
> Guangya Liu wrote:
> Hi Ben, one quick question want to get some comments from you. Regarding 
> to your comments, what about set `initial` resources for all resources types 
> including `scalar`, `range`, `reservations` and then for the new added 
> `contain` benchmark test, I can simply check if the `initial` contains 
> `resources`, what do you think of this approach?
> 
> Benjamin Mahler wrote:
> For the contains test, how about we start with three parameters: (a, b, 
> numContains)
> 
> Then we do `a.contains(b)` numContains times and `b.contains(a)` 
> numContains times?
> 
> Guangya Liu wrote:
> So do you mean that I need to introduce some new parameters for 
> `contains` benchmark test as following?
> 
> ```
> struct Parameter
> {
>   Resources resources1;
>   Resources resources2;
>   size_t numContains;
> };
> ```
> 
> My thinking is want to levearaget the current parameters and do not 
> introduce new parameters:
> ```
> struct Parameter
> {
>   Resources initial;
>   Resources resources;
>   size_t totalOperations;
> };
> ```
> 
> Then I will do `initial.contains(resources)` and 
> `resources.contains(initial)` for `totalOperations` times.
> 
> For `Filters` or `Filtering` test, I will do `resources.nonRevocable()` 
> for `totalOperations` times.
> 
> What do you think?

Ben, any comments for this, this will impact how we implement the benchmark 
test for both `contains` and `filter`, thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50380/#review144175
---


On 七月 30, 2016, 9:10 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50380/
> ---
> 
> (Updated 七月 30, 2016, 9:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Klaus Ma.
> 
> 
> Bugs: MESOS-5898
> https://issues.apache.org/jira/browse/MESOS-5898
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When run benchmark test for `ports` resources, the `-=` and `-` only
> consumed about 10ms, this cannot reflect the real time of operating
> 1000 `ports` with `-=` and `-`.
> 
> The root cause is that the current calculation is always using same
> port range, with port, the formula for `+` is `a+a+a+a+...+a==a`;
> for `-`, it will be `a-a=0` and `0-a=0`.
> 
> With `0-a=0`, the code here
> https://github.com/apache/mesos/blob/master/src/common/values.cpp#L544
> will cause there is no validation as the `left` is empty after the
> `ports` was subtracted to 0.
> 
> The fix is adding a new parameter `inital` act as the intial resources
> for differente benchmark test. For `ports` resource, using an initial
> `ports` which is different from the `resources`, this can make sure
> the`ports` resources will never be subtracted to 0.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 4111e080b84079e100b731c9a56861b204f17388 
> 
> Diff: https://reviews.apache.org/r/50380/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Before fix:
> ```
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
> Took 2.844742secs to perform 1000 'total += r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> Took 9ms to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 7-8, 
> 10-11, 13-14, 16-17, 1...
> Took 2.977936secs to perform 1000 'total = total + r' operations on 
> ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> Took 9576us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (5843 
> ms)
> [--] 1 test from ResourcesOperators/Resources_BENCHMARK_Test (5843 ms 
> total)
> ```
> 
> After fix:
> ```
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
> Took 2.728995secs to perform 1000 'total += r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
> ports(*):[3-5]
> Took 3.641868secs to perform 1000 'total -= r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
> ports(*):[3-5]
> Took 

Re: Review Request 50720: Added comments for tmpfs and sandbox mountpoints for bind backend.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50720/#review144544
---


Ship it!




Ship It!

- Jie Yu


On Aug. 2, 2016, 9:43 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50720/
> ---
> 
> (Updated Aug. 2, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy 
> Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5927
> https://issues.apache.org/jira/browse/MESOS-5927
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added comments for tmpfs and sandbox mountpoints for bind backend.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> db3ed8f69de8b52633194b252b0e5aba38ec69c0 
>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
> 2b2fcdca2298aa022d4136ad0b2f6e851f7c9202 
> 
> Diff: https://reviews.apache.org/r/50720/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50719: Supported scratch containers in Unified Containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50719/#review144543
---


Ship it!




Ship It!

- Jie Yu


On Aug. 2, 2016, 9:43 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50719/
> ---
> 
> (Updated Aug. 2, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy 
> Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5927
> https://issues.apache.org/jira/browse/MESOS-5927
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Before this patch, we are assuming the 'tmpfs' mount point '/tmp'
> always exist in the container's new rootfs. However, this is not
> true. For the scratch container (which is a common case), '/tmp'
> may not exist, and there may only be an executable binary in the
> new rootfs. So we need to create the mount point for 'tmpfs' in
> fs::enter().
> 
> However, this change may break some cases using the bind backend,
> because we are not able the create the '/tmp' mount point in a
> read-only filesystem. So we require users to make sure the
> directory '/tmp' must already exist in their single layer scratch
> images for the following reasons:
>   1. For most cases, when operators prefer using the bind backend,
>  the single-layer images are usually large in size, and '/tmp'
>  exists in the rootfs.
>   2. For scratch images, most of them contain more than one layer,
>  which means the bind backend cannot be used in those cases.
>  So we can create the '/tmp' mount point if it does not exist.
>   3. If this is strictly a single layer scratch image, it is
>  reasonable that we require users to make sure the mount point
>  '/tmp' existed in the image rootfs if they are using the bind
>  backend, because we already require the sandbox mount point
>  to be existed in those iamges.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.cpp 27d322c759b6ef9ea17b371e7013cace926bff47 
> 
> Diff: https://reviews.apache.org/r/50719/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Manually tested using single-layered scratch image `hello-seattle` from local 
> puller (the one fetched from registry puller is a two-layer image due to 
> dockerhub server redirection) and copy backend.
> 
> Other scratch image like hello-world is also tested.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50569: Checked if resource is negative scalar directly in subtract.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50569/#review144542
---



I updated the commit to the following:

```
commit e1cb01a15e447bdf59cc5ea46870734bebf77033
Author: Guangya Liu 
Date:   Tue Aug 2 15:25:22 2016 -0700

Avoid unnecessary validation during resource subtraction.

When subtract resources finished, we need to call `validate` to
check if the scalar resource is negative so as to remove this
resource if it is negative. This is a bit heavy as we only need
to check if a scalar has become negative.

This patch is clarifying the logic by checking if the resource
is a negative scalar directly.

Review: https://reviews.apache.org/r/50569/
```

- Benjamin Mahler


On Aug. 2, 2016, 6:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50569/
> ---
> 
> (Updated Aug. 2, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.
> 
> 
> Bugs: MESOS-5921
> https://issues.apache.org/jira/browse/MESOS-5921
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When subtract resources finished, we need to call `validate` to
> check if the scalar resource is negative so as to remove this
> resource if it is negative. This is a bit heavy as the `validate`
> did many stuffs.
> 
> This patch is simpilfying the logic by checking if the resource
> is negative scalar directly.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 309b17626d33bc6b4df07f002b0eea4f4803b3e5 
>   src/v1/resources.cpp 3f67e32519600a22f07a66ebfe05a7b647cb2c61 
> 
> Diff: https://reviews.apache.org/r/50569/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> [==] Running 3 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
> Took 222763us to perform 5 'total += r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 231983us to perform 5 'total -= r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 679121us to perform 5 'total = total + r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 698024us to perform 5 'total = total - r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (1832 
> ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
> Took 22.630349secs to perform 10 'total += r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> Took 22.499543secs to perform 10 'total -= r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> Took 22.566697secs to perform 10 'total = total + r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> Took 22.798371secs to perform 10 'total = total - r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (90621 
> ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
> Took 2.831782secs to perform 1000 'total += r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> Took 8935us to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 
> 7-8, 10-11, 13-14, 16-17, 1...
> Took 2.96492secs to perform 1000 'total = total + r' operations on 
> ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> Took 9220us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (5817 
> ms)
> [--] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test (98270 
> ms total)
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 50718: Deprecated the 'rootfs' proto field in ContainerLaunchInfo.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50718/#review144541
---


Ship it!




Ship It!

- Jie Yu


On Aug. 2, 2016, 9:43 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50718/
> ---
> 
> (Updated Aug. 2, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy 
> Chen, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Deprecated the 'rootfs' proto field in ContainerLaunchInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.proto a971a582da2ec121ed8dd4ef0b7f5ee47a0c3d03 
> 
> Diff: https://reviews.apache.org/r/50718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5930
https://issues.apache.org/jira/browse/MESOS-5930


Repository: mesos


Description
---

The master's status handler function used to ignore the status updates
from the agents for frameworks not yet re-connected with the master
upon a failover. This change modifies that logic to still update
the local state and not bail out early.


Diffs
-

  src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
  src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 

Diff: https://reviews.apache.org/r/50723/diff/


Testing
---

make check (gtest_repeat=100)


Thanks,

Anand Mazumdar

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

[Ammar Askar]

> On July 25, 2016, 6:04 p.m., Greg Mann wrote:
> > Thanks Ammar! Patches look good to me; Vinod is going to take a look when 
> > he has some cycles.

bump


- Ammar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50003/#review143085
---


On July 21, 2016, 1:38 a.m., Ammar Askar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50003/
> ---
> 
> (Updated July 21, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5613
> https://issues.apache.org/jira/browse/MESOS-5613
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Propagate work_dir flag from local runs to agents/masters.
> 
> 
> Diffs
> -
> 
>   src/local/flags.hpp f0af0d2 
>   src/local/local.cpp a543aef 
> 
> Diff: https://reviews.apache.org/r/50003/diff/
> 
> 
> Testing
> ---
> 
> Manually tested that `mesos local` and `mesos-local` run now. Not sure if a 
> regression test for this would be good, please advise.
> 
> 
> Thanks,
> 
> Ammar Askar
> 
>

Review Request 50718: Deprecated the 'rootfs' proto field in ContainerLaunchInfo.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50718/
---

Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen, 
and Jiang Yan Xu.


Repository: mesos


Description
---

Deprecated the 'rootfs' proto field in ContainerLaunchInfo.


Diffs
-

  include/mesos/slave/isolator.proto a971a582da2ec121ed8dd4ef0b7f5ee47a0c3d03 

Diff: https://reviews.apache.org/r/50718/diff/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 50721: Fixed the bind backend document in container-image.md.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50721/
---

Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen, 
and Jiang Yan Xu.


Bugs: MESOS-5927
https://issues.apache.org/jira/browse/MESOS-5927


Repository: mesos


Description
---

Fixed the bind backend document in container-image.md.


Diffs
-

  docs/container-image.md 745f6b045d11de6f54323347ebadac9e3ae6cab2 

Diff: https://reviews.apache.org/r/50721/diff/


Testing
---

gist.


Thanks,

Gilbert Song

Review Request 50720: Added comments for tmpfs and sandbox mountpoints for bind backend.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50720/
---

Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen, 
and Jiang Yan Xu.


Bugs: MESOS-5927
https://issues.apache.org/jira/browse/MESOS-5927


Repository: mesos


Description
---

Added comments for tmpfs and sandbox mountpoints for bind backend.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
db3ed8f69de8b52633194b252b0e5aba38ec69c0 
  src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
2b2fcdca2298aa022d4136ad0b2f6e851f7c9202 

Diff: https://reviews.apache.org/r/50720/diff/


Testing
---

N/A.


Thanks,

Gilbert Song

Review Request 50719: Supported scratch containers in Unified Containerizer.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50719/
---

Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen, 
and Jiang Yan Xu.


Bugs: MESOS-5927
https://issues.apache.org/jira/browse/MESOS-5927


Repository: mesos


Description
---

Before this patch, we are assuming the 'tmpfs' mount point '/tmp'
always exist in the container's new rootfs. However, this is not
true. For the scratch container (which is a common case), '/tmp'
may not exist, and there may only be an executable binary in the
new rootfs. So we need to create the mount point for 'tmpfs' in
fs::enter().

However, this change may break some cases using the bind backend,
because we are not able the create the '/tmp' mount point in a
read-only filesystem. So we require users to make sure the
directory '/tmp' must already exist in their single layer scratch
images for the following reasons:
  1. For most cases, when operators prefer using the bind backend,
 the single-layer images are usually large in size, and '/tmp'
 exists in the rootfs.
  2. For scratch images, most of them contain more than one layer,
 which means the bind backend cannot be used in those cases.
 So we can create the '/tmp' mount point if it does not exist.
  3. If this is strictly a single layer scratch image, it is
 reasonable that we require users to make sure the mount point
 '/tmp' existed in the image rootfs if they are using the bind
 backend, because we already require the sandbox mount point
 to be existed in those iamges.


Diffs
-

  src/linux/fs.cpp 27d322c759b6ef9ea17b371e7013cace926bff47 

Diff: https://reviews.apache.org/r/50719/diff/


Testing
---

make check

Manually tested using single-layered scratch image `hello-seattle` from local 
puller (the one fetched from registry puller is a two-layer image due to 
dockerhub server redirection) and copy backend.

Other scratch image like hello-world is also tested.


Thanks,

Gilbert Song

Re: Review Request 49924: Added libprocess as a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/
---

(Updated Aug. 2, 2016, 9:41 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added libprocess as a shared library.


Diffs (updated)
-

  3rdparty/libprocess/src/CMakeLists.txt 
d1547ef6a8762385f653d3824307727e4d0a7e71 

Diff: https://reviews.apache.org/r/49924/diff/


Testing
---

cmake .. && make

With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
http_parser and libprocess to shared libraries and we are using libevent shared 
library, zookeeper does not have a shared library in the 3rdparty (I guess the 
code is compiled as relocatable) and did not have issues linking.


Thanks,

Srinivas Brahmaroutu

Review Request 50722: TestCommit.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50722/
---

Review request for mesos.


Repository: mesos


Description
---

DO NOT MERGE TestCommit.


Diffs
-

  test PRE-CREATION 

Diff: https://reviews.apache.org/r/50722/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 50717: Fixed `clean-python` Makefile target.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50717/#review144531
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 2, 2016, 9:30 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50717/
> ---
> 
> (Updated Aug. 2, 2016, 9:30 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Vinod Kone.
> 
> 
> Bugs: MESOS-5958
> https://issues.apache.org/jira/browse/MESOS-5958
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Our usage of `find ... -exec` did not take into account the order of
> operations in `find`.  The placement of `-exec` at the end meant that
> only the `*.egg-info` files were being deleted.
> 
> Adding parentheses around all the `-o` operators fixes what is being
> deleted.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5eabc331579155df9011ade4489aad30b7f5bfe7 
> 
> Diff: https://reviews.apache.org/r/50717/diff/
> 
> 
> Testing
> ---
> 
> make distcheck (CentOS 7)
> 
> Confirmed that the build succeeds without complaining about remaining files.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 50664: Fixed continuation logic in logrotate module.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50664/#review144530
---


Ship it!




Ship It!

- Joris Van Remoortere


On Aug. 1, 2016, 6:16 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50664/
> ---
> 
> (Updated Aug. 1, 2016, 6:16 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the module's inner loop followed via `.then([=]`
> which potentially executes the continuation on a different process.
> This patch fixes this behavior (it should run on the same process)
> and future-proofs this code in case the module is extended with
> additional processes/behavior.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/logrotate.cpp 
> b863d931b08992ea9e94a7e6837b44cfc94ae8f1 
> 
> Diff: https://reviews.apache.org/r/50664/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 50717: Fixed `clean-python` Makefile target.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50717/
---

Review request for mesos, Artem Harutyunyan and Vinod Kone.


Bugs: MESOS-5958
https://issues.apache.org/jira/browse/MESOS-5958


Repository: mesos


Description
---

Our usage of `find ... -exec` did not take into account the order of
operations in `find`.  The placement of `-exec` at the end meant that
only the `*.egg-info` files were being deleted.

Adding parentheses around all the `-o` operators fixes what is being
deleted.


Diffs
-

  src/Makefile.am 5eabc331579155df9011ade4489aad30b7f5bfe7 

Diff: https://reviews.apache.org/r/50717/diff/


Testing
---

make distcheck (CentOS 7)

Confirmed that the build succeeds without complaining about remaining files.


Thanks,

Joseph Wu

Re: Review Request 50683: Libprocess: [3/3] Removed old http_parser code.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50683/
---

(Updated Aug. 2, 2016, 9:06 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-5970
https://issues.apache.org/jira/browse/MESOS-5970


Repository: mesos


Description
---

We remove the code that supported the `HTTP_PARSER_VERSION_MAJOR` < 2
path.


Diffs
-

  3rdparty/libprocess/src/decoder.hpp c0cefd4bdc55049ca0b0f63cd463de5ab30d952b 

Diff: https://reviews.apache.org/r/50683/diff/


Testing
---

The tests fail during incremental parsing of URLs. This is expected. The 
subsequent patch fixes these tests.


Thanks,

Joris Van Remoortere

Re: Review Request 50683: Libprocess: [3/3] Removed old http_parser code.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50683/
---

(Updated Aug. 2, 2016, 6:29 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Changes
---

rebased.


Bugs: MESOS-5943
https://issues.apache.org/jira/browse/MESOS-5943


Repository: mesos


Description
---

We remove the code that supported the `HTTP_PARSER_VERSION_MAJOR` < 2
path.


Diffs (updated)
-

  3rdparty/libprocess/src/decoder.hpp c0cefd4bdc55049ca0b0f63cd463de5ab30d952b 

Diff: https://reviews.apache.org/r/50683/diff/


Testing
---

The tests fail during incremental parsing of URLs. This is expected. The 
subsequent patch fixes these tests.


Thanks,

Joris Van Remoortere

Re: Review Request 50634: Libprocess: [2/3] Fixed decoder to support incremental URL parsing.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50634/
---

(Updated Aug. 2, 2016, 6:28 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-5943
https://issues.apache.org/jira/browse/MESOS-5943


Repository: mesos


Description
---

Libprocess: [2/3] Fixed decoder to support incremental URL parsing.


Diffs (updated)
-

  3rdparty/libprocess/src/decoder.hpp c0cefd4bdc55049ca0b0f63cd463de5ab30d952b 

Diff: https://reviews.apache.org/r/50634/diff/


Testing
---

make check.
Verified that the incremental parsing tests passed.
Re-ran original repro that broke scheduler driver connection. Verified the 
behavior was no longer re-producible.


Thanks,

Joris Van Remoortere

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/#review144517
---




src/master/main.cpp (lines 215 - 218)


shouldn't this be moved up above the load error as well?


- Vinod Kone


On Aug. 2, 2016, 4:16 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50609/
> ---
> 
> (Updated Aug. 2, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Pierre Cheynier.
> 
> 
> Bugs: MESOS-5928
> https://issues.apache.org/jira/browse/MESOS-5928
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The recent removal of the agent's default `work_dir`
> requires us to check for the presence of the `--version`
> flag before we check for errors in flag loading; this
> patch makes that change, and also moves the
> corresponding code in the master for consistency.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
>   src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 
> 
> Diff: https://reviews.apache.org/r/50609/diff/
> 
> 
> Testing
> ---
> 
> Ran the mesos agent and master binaries with and without the '--version' flag 
> to verify correct behavior and return code.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 49851: Implemented `MemorySubsystem`.

[haosdent huang]

> On July 27, 2016, 2:05 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494
> > 
> >
> > How do we recover this field `updatedLimit`? I mean during agent 
> > recovery, `updatedLimit` of each Info will be reset to `false`, right? But 
> > I think that is not correct.

I think this problem exists at `mem.cpp` as well, and update the limit twice 
here does not bring problems here. So I drop this. Feel free to reopen this if 
you think it would bring problems here.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/#review143517
---


On Aug. 2, 2016, 5:48 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49851/
> ---
> 
> (Updated Aug. 2, 2016, 5:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5045
> https://issues.apache.org/jira/browse/MESOS-5045
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `MemorySubsystem`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> b191b2a52a9645fc902a35ed52909b2142f0b4c0 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 179eb070d9621348bd7fa7d9a093a857ff0f2855 
>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
> c45d88092f3fe497373dfeaa8346aef9126c7b8b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

[Neil Conway]

> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote:
> > hmm, why can't the TaskID's have spaces? 
> > 
> > They are generated by the framework and are free to contain spaces.
> 
> Neil Conway wrote:
> Yeah, I was wondering that myself :) We don't quote them almost all the 
> time, however. I figured I would first make it consistent and then do a sweep 
> to fix the quotation later -- but I can do that now if you'd prefer.
> 
> Anand Mazumdar wrote:
> Yeah, would be good to fix them all now since we are at it.
> 
> Neil Conway wrote:
> I don't have time to do task IDs at the moment, so I just removed this 
> change.
> 
> Anand Mazumdar wrote:
> np, mind filing a newbie JIRA issue to track this for posterity?

https://issues.apache.org/jira/browse/MESOS-5968


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50516/#review144155
---


On Aug. 2, 2016, 3:58 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50516/
> ---
> 
> (Updated Aug. 2, 2016, 3:58 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor IDs should be quoted.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp f8343768f3dc803e6bd7f4253c77d9fef82408e5 
>   src/slave/slave.cpp c19a63e4f8df11d8150071ef427bd8038584586b 
> 
> Diff: https://reviews.apache.org/r/50516/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49855/
---

(Updated Aug. 2, 2016, 5:51 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5652
https://issues.apache.org/jira/browse/MESOS-5652


Repository: mesos


Description
---

Enabled cgroups unified isolator in isolation.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 

Diff: https://reviews.apache.org/r/49855/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49852: Implemented `NetClsSubsystem`.

[haosdent huang]

> On July 28, 2016, 3:01 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, line 359
> > 
> >
> > Where is the implementation of this class `NetClsHandleManager`?

Would move it from `net_cls.cpp` into `subsystem.cpp` in the following patches.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49852/#review143943
---


On Aug. 2, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49852/
> ---
> 
> (Updated Aug. 2, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5046
> https://issues.apache.org/jira/browse/MESOS-5046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `NetClsSubsystem`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 179eb070d9621348bd7fa7d9a093a857ff0f2855 
>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
> c45d88092f3fe497373dfeaa8346aef9126c7b8b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49852/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49852: Implemented `NetClsSubsystem`.

[haosdent huang]

> On July 28, 2016, 2:23 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 961-965
> > 
> >
> > Should this be a CHECK()?

I return `Failure` here, feel free to reopen this if you prefer `CHECK`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49852/#review143933
---


On Aug. 2, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49852/
> ---
> 
> (Updated Aug. 2, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5046
> https://issues.apache.org/jira/browse/MESOS-5046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `NetClsSubsystem`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 179eb070d9621348bd7fa7d9a093a857ff0f2855 
>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
> c45d88092f3fe497373dfeaa8346aef9126c7b8b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49852/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49854: Implemented `DevicesSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49854/
---

(Updated Aug. 2, 2016, 5:50 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5651
https://issues.apache.org/jira/browse/MESOS-5651


Repository: mesos


Description
---

Implemented `DevicesSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
179eb070d9621348bd7fa7d9a093a857ff0f2855 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49854/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49853/
---

(Updated Aug. 2, 2016, 5:49 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Implemented `PerfEventSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
179eb070d9621348bd7fa7d9a093a857ff0f2855 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49853/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45573: Added `PerfEventHandleManager`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45573/
---

(Updated Aug. 2, 2016, 5:49 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Added `PerfEventHandleManager`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
1de38491a33e5782b20e5ee491412779d09ee391 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
31f35385691681ef5da14be747edfb5f57c5d05a 

Diff: https://reviews.apache.org/r/45573/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49851: Implemented `MemorySubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/
---

(Updated Aug. 2, 2016, 5:48 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Implemented `MemorySubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
179eb070d9621348bd7fa7d9a093a857ff0f2855 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49851/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49850/
---

(Updated Aug. 2, 2016, 5:48 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Implemented `CpuacctSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
179eb070d9621348bd7fa7d9a093a857ff0f2855 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49850/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49849: Implemented `CpuSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49849/
---

(Updated Aug. 2, 2016, 5:48 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Address @qianzhang's comment.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Implemented `CpuSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
179eb070d9621348bd7fa7d9a093a857ff0f2855 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49849/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49828/
---

(Updated Aug. 2, 2016, 5:47 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5039
https://issues.apache.org/jira/browse/MESOS-5039


Repository: mesos


Description
---

Added default methods implementations for `Subsystem` base class.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49828/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated Aug. 2, 2016, 5:47 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
179eb070d9621348bd7fa7d9a093a857ff0f2855 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50713: Documented behavior of content-type header in presence of errors.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50713/
---

Review request for mesos and Anand Mazumdar.


Bugs: MESOS-5853
https://issues.apache.org/jira/browse/MESOS-5853


Repository: mesos


Description
---

When an error response is generated for http v1 api, default
contentType is "text/plain; charset=utf-8". This has been
documented for the docs of http v1 api in this patch.


Diffs
-

  docs/executor-http-api.md fb70f75c43c2751ff430a571ed8d4630d29a7ef8 
  docs/operator-http-api.md 4f4c39e7b4b6de32af1933c34eba21f126fae8ac 
  docs/scheduler-http-api.md 4be961214c63e4e3b25c5c350b2c4f0e66863817 

Diff: https://reviews.apache.org/r/50713/diff/


Testing
---

Viewed with "rake dev".


Thanks,

Abhishek Dasgupta

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated Aug. 2, 2016, 4:48 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
1477b5e769cde3915938542e077b5df1d1fc293e 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
5a50a62c3788dea8653b78188979586c7679a8db 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50643: Implemented `CgroupsIsolatorProcess::finalize`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50643/
---

(Updated Aug. 2, 2016, 4:46 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::finalize`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
1477b5e769cde3915938542e077b5df1d1fc293e 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
5a50a62c3788dea8653b78188979586c7679a8db 

Diff: https://reviews.apache.org/r/50643/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50642: Implemented `CgroupsIsolatorProcess::initialize`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50642/
---

(Updated Aug. 2, 2016, 4:46 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::initialize`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
1477b5e769cde3915938542e077b5df1d1fc293e 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
5a50a62c3788dea8653b78188979586c7679a8db 

Diff: https://reviews.apache.org/r/50642/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50642: Implemented `CgroupsIsolatorProcess::initialize`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50642/#review144508
---



Can you rebase?

- Jie Yu


On July 31, 2016, 5:48 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50642/
> ---
> 
> (Updated July 31, 2016, 5:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
> https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `CgroupsIsolatorProcess::initialize`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> 422b4653fc3cb3d14c94b93ff456625fc59fbb27 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> bd20631a9650cf84e99c6489b2e92bc40ed764ca 
> 
> Diff: https://reviews.apache.org/r/50642/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

[Anand Mazumdar]

> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote:
> > hmm, why can't the TaskID's have spaces? 
> > 
> > They are generated by the framework and are free to contain spaces.
> 
> Neil Conway wrote:
> Yeah, I was wondering that myself :) We don't quote them almost all the 
> time, however. I figured I would first make it consistent and then do a sweep 
> to fix the quotation later -- but I can do that now if you'd prefer.
> 
> Anand Mazumdar wrote:
> Yeah, would be good to fix them all now since we are at it.
> 
> Neil Conway wrote:
> I don't have time to do task IDs at the moment, so I just removed this 
> change.

np, mind filing a newbie JIRA issue to track this for posterity?


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50516/#review144155
---


On Aug. 2, 2016, 3:58 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50516/
> ---
> 
> (Updated Aug. 2, 2016, 3:58 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor IDs should be quoted.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp f8343768f3dc803e6bd7f4253c77d9fef82408e5 
>   src/slave/slave.cpp c19a63e4f8df11d8150071ef427bd8038584586b 
> 
> Diff: https://reviews.apache.org/r/50516/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50516/#review144507
---


Ship it!




Ship It!

- Anand Mazumdar


On Aug. 2, 2016, 3:58 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50516/
> ---
> 
> (Updated Aug. 2, 2016, 3:58 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor IDs should be quoted.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp f8343768f3dc803e6bd7f4253c77d9fef82408e5 
>   src/slave/slave.cpp c19a63e4f8df11d8150071ef427bd8038584586b 
> 
> Diff: https://reviews.apache.org/r/50516/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/
---

(Updated Aug. 2, 2016, 4:16 p.m.)


Review request for mesos, Jie Yu and Pierre Cheynier.


Summary (updated)
-

Moved check for '--version' in master and agent 'main.cpp'.


Bugs: MESOS-5928
https://issues.apache.org/jira/browse/MESOS-5928


Repository: mesos


Description (updated)
---

The recent removal of the agent's default `work_dir`
requires us to check for the presence of the `--version`
flag before we check for errors in flag loading; this
patch makes that change, and also moves the
corresponding code in the master for consistency.


Diffs
-

  src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
  src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 

Diff: https://reviews.apache.org/r/50609/diff/


Testing (updated)
---

Ran the mesos agent and master binaries with and without the '--version' flag 
to verify correct behavior and return code.


Thanks,

Greg Mann

Re: Review Request 50609: Moved check for '--version' in agent's 'main.cpp'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/
---

(Updated Aug. 2, 2016, 4:14 p.m.)


Review request for mesos, Jie Yu and Pierre Cheynier.


Changes
---

Addressed comment.


Bugs: MESOS-5928
https://issues.apache.org/jira/browse/MESOS-5928


Repository: mesos


Description
---

The recent removal of the agent's default `work_dir`
requires us to check for the presence of the `--version`
flag before we check for errors in flag loading; this
patch makes that change.


Diffs (updated)
-

  src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
  src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 

Diff: https://reviews.apache.org/r/50609/diff/


Testing
---

Ran the mesos agent binary with and without the '--version' flag to verify 
correct behavior and return code.


Thanks,

Greg Mann

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

[Neil Conway]

> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote:
> > hmm, why can't the TaskID's have spaces? 
> > 
> > They are generated by the framework and are free to contain spaces.
> 
> Neil Conway wrote:
> Yeah, I was wondering that myself :) We don't quote them almost all the 
> time, however. I figured I would first make it consistent and then do a sweep 
> to fix the quotation later -- but I can do that now if you'd prefer.
> 
> Anand Mazumdar wrote:
> Yeah, would be good to fix them all now since we are at it.

I don't have time to do task IDs at the moment, so I just removed this change.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50516/#review144155
---


On Aug. 2, 2016, 3:58 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50516/
> ---
> 
> (Updated Aug. 2, 2016, 3:58 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor IDs should be quoted.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp f8343768f3dc803e6bd7f4253c77d9fef82408e5 
>   src/slave/slave.cpp c19a63e4f8df11d8150071ef427bd8038584586b 
> 
> Diff: https://reviews.apache.org/r/50516/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50516/
---

(Updated Aug. 2, 2016, 3:58 p.m.)


Review request for mesos and Anand Mazumdar.


Changes
---

Removed task ID changes.


Summary (updated)
-

Fixed quoting for executor IDs in log messages.


Repository: mesos


Description (updated)
---

Executor IDs should be quoted.


Diffs (updated)
-

  src/master/validation.cpp f8343768f3dc803e6bd7f4253c77d9fef82408e5 
  src/slave/slave.cpp c19a63e4f8df11d8150071ef427bd8038584586b 

Diff: https://reviews.apache.org/r/50516/diff/


Testing
---

make check, visual inspection.


Thanks,

Neil Conway

Re: Review Request 50205: Enhanced benchmark test for resources to include shared resources.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50205/#review144499
---


Ship it!




The test itself LGTM so I'll commit it. However when I ran it it does show some 
performance regression on the basic scalars.

## Head
Resources benchmark on top of 6ce156b2bed7edecb27ce50f68d262ea4ab4f88e

```
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
Took 72228us to perform 5 'total += r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 101574us to perform 5 'total -= r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 251715us to perform 5 'total = total + r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 293414us to perform 5 'total = total - r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
```

## Pre-shared resources
Resources benchmark on top of 48a492cd9d7d0a194735b9b4107a35b489c596e1

```
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
Took 48583us to perform 5 'total += r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 86166us to perform 5 'total -= r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 233148us to perform 5 'total = total + r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 265719us to perform 5 'total = total - r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
```

'total += r' run time sees 40% jump. (I've run these 10 times and took an 
average, the avg is 48685.4us (pre-shared resources) vs. 68421.7us (post-shared 
resources).

The overhead seems to be due we call `addable()` and `subtractable()` twice for 
'total += r' and 'total -= r'. After I remove one of the calls, the numbers 
become:

Resources benchmarks on top of 6ce156b2bed7edecb27ce50f68d262ea4ab4f88e but 
with addable()/subtractable() tweaks
```
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
Took 48955us to perform 5 'total += r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 85126us to perform 5 'total -= r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 226796us to perform 5 'total = total + r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 266480us to perform 5 'total = total - r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
```

Let's address this issue. :)

- Jiang Yan Xu


On July 30, 2016, 12:03 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50205/
> ---
> 
> (Updated July 30, 2016, 12:03 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhanced benchmark test for resources to include shared resources.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 4111e080b84079e100b731c9a56861b204f17388 
> 
> Diff: https://reviews.apache.org/r/50205/diff/
> 
> 
> Testing
> ---
> 
> Tests passed. Results for resources benchmark is as follows:
> 
> Minimal impact seen in Resources arithmetic with the Resources refactor 
> changes to incorporate shared resources.
> 
> With shared resources patch (note that 4th test below is for shared resources 
> for scalars)
> 
> [--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (806 ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17032 
> ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (1048 
> ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3 (940 ms)
> [--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test (19826 
> ms total)
> 
> HEAD
> 
> [--] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (726 ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17413 
> ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (1026 
> ms)
> [--] 3 tests 

Re: Review Request 49921: Fixed mesos tests to run most of the tests on Unix and OSX.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49921/
---

(Updated Aug. 2, 2016, 3:37 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Summary (updated)
-

Fixed mesos tests to run most of the tests on Unix and OSX.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

Fixed mesos tests to run most of the tests on Unix and OSX.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/tests/CMakeLists.txt 1ea8b2102753ae294bd75706ffaf08308e928acd 
  src/tests/cmake/MesosTestsConfigure.cmake 
361032082c3a5f76b949dc7981f75b53e02d84f5 

Diff: https://reviews.apache.org/r/49921/diff/


Testing
---

cmake .. && make
src/tests/mesos-tests  (runs 723 tests with no failures)
I did not enable any module that has even a single failue. There are many more 
tests that are passing.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49921: Fixed mesos tests to run 723 test on Unix.

[Srinivas Brahmaroutu]

> On July 12, 2016, 5:11 a.m., Alex Clemmer wrote:
> > src/tests/CMakeLists.txt, line 52
> > 
> >
> > Is this review relevant anymore? In #49688 it looks like we're using a 
> > much more recent version of this file, and I don't see un-commenting these 
> > files as part of the diff?
> > 
> > Based on what I see here, it seems like we should probably discard this 
> > review and/or merge it with that last one.
> > 
> > Thoughts?

This is where the tests are enabled as we agreed this way.


- Srinivas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49921/#review141847
---


On July 16, 2016, 8:47 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49921/
> ---
> 
> (Updated July 16, 2016, 8:47 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed mesos tests to run 723 test on Unix.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 493b6dbd28945332fbda2d3172018e109e73235a 
>   src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
>   src/tests/cmake/MesosTestsConfigure.cmake 
> caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
> 
> Diff: https://reviews.apache.org/r/49921/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> src/tests/mesos-tests  (runs 723 tests with no failures)
> I did not enable any module that has even a single failue. There are many 
> more tests that are passing.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49870: Added test executables required to run tests.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49870/
---

(Updated Aug. 2, 2016, 3:36 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added test executables required to run tests.


Diffs (updated)
-

  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/49870/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49874/
---

(Updated Aug. 2, 2016, 3:36 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added logrotate_container_logger for running mesos tests.


Diffs (updated)
-

  src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 
  src/slave/container_loggers/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/49874/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated Aug. 2, 2016, 3:35 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/http-parser/CMakeLists.txt.template 
9a671973b754095e1de917f135a7deb978fb6eb6 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/master/cmake/MasterConfigure.cmake 
6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49688: Added cmake build variables for mesos tests.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49688/
---

(Updated Aug. 2, 2016, 3:32 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added cmake build variables for mesos tests.


Diffs (updated)
-

  src/tests/cmake/MesosTestsConfigure.cmake 
361032082c3a5f76b949dc7981f75b53e02d84f5 
  src/tests/containerizer/CMakeLists.txt 
2c52e43a9deee90fa32693731d6ebedb5201bb1f 

Diff: https://reviews.apache.org/r/49688/diff/


Testing
---

cmake ..
cmake check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49688: Added cmake build variables for mesos tests.

[Srinivas Brahmaroutu]

> On Aug. 2, 2016, 1:17 a.m., Alex Clemmer wrote:
> > src/tests/cmake/MesosTestsConfigure.cmake, line 76
> > 
> >
> > This variable doesn't seem to exist. Did you mean the (eminently badly 
> > named) `AGENT_DEPENDENCIES`?

I can refactor this later, simplify variables hierarchy and code clean up. For 
now taking it out.


- Srinivas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49688/#review144424
---


On July 19, 2016, 9:35 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49688/
> ---
> 
> (Updated July 19, 2016, 9:35 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added cmake build variables for mesos tests.
> 
> 
> Diffs
> -
> 
>   src/tests/cmake/MesosTestsConfigure.cmake 
> caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
>   src/tests/containerizer/CMakeLists.txt 
> 41e792a2c9ec588d4897d60d012e67c606bbe601 
> 
> Diff: https://reviews.apache.org/r/49688/diff/
> 
> 
> Testing
> ---
> 
> cmake ..
> cmake check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50252: Added native implementation for v1 Mesos interface.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50252/
---

(Updated Aug. 2, 2016, 3:23 p.m.)


Review request for mesos, Joris Van Remoortere and Vinod Kone.


Changes
---

Review comments. NNFR


Bugs: MESOS-5788
https://issues.apache.org/jira/browse/MESOS-5788


Repository: mesos


Description
---

This change adds the native C++ implementation for the v1
Java class `JNIMesos` used for interacting with Mesos.


Diffs (updated)
-

  src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d 
  src/java/jni/org_apache_mesos_v1_scheduler_JNIMesos.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50252/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 50127: Added NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu.

[Yubo Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/
---

(Updated 八月 2, 2016, 2:23 p.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

This added a testing case for end-to-end GPU support for docker
containerizer.


Diffs (updated)
-

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
fea1f9f0a03373692ef2a6dd2bc5722dc6f46d5b 

Diff: https://reviews.apache.org/r/50127/diff/


Testing
---

GTEST_FILTER="NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu" make 
-j check


Thanks,

Yubo Li

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

[Yubo Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/
---

(Updated 八月 2, 2016, 2:22 p.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

This added 'NvidiaGpuAllocator' to docker containerizer so that the
docker containerizer can use it to allocate GPUs to the task with 'gpus'
resource. Also, allocated GPUs will automatically deallocated after the
job destroyed.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
  src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
  src/tests/mesos.hpp 9174a3810d0da34b99dc257e9c77f83107fdd9f5 
  src/tests/mesos.cpp 30492d7e3b4c5e9ae9d2b2446cadba62d43a3c65 

Diff: https://reviews.apache.org/r/50123/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50125: Added mesos-docker-executor support for device control.

[Yubo Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50125/
---

(Updated 八月 2, 2016, 2:21 p.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.


Changes
---

Changed commit order and commit message


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description (updated)
---

Added a new flag '--device' to mesos-docker-executor, and gave its
feature to control device exposition, isolation, and access permission.


Diffs (updated)
-

  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 

Diff: https://reviews.apache.org/r/50125/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

[Yubo Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50128/
---

(Updated 八月 2, 2016, 2:19 p.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.


Changes
---

Changed commit order


Summary (updated)
-

Added helper functions to 'Docker::Device'.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description (updated)
---

Wrapped helper functions 'serialize()' and 'parse()' to 'Docker::Device'
to handle data tranformation between 'Docker::Device' structure and
string.


Diffs (updated)
-

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 

Diff: https://reviews.apache.org/r/50128/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50513: Added missing process IDs in libprocess.

[Gastón Kleiman]

> On July 29, 2016, 12:44 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/authenticator.cpp, line 57
> > 
> >
> > Why this one is enclosed in underscores?
> 
> Gastón Kleiman wrote:
> Added the naming schema to the commit description.

(in https://reviews.apache.org/r/50519/)


- Gastón


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50513/#review144082
---


On Aug. 2, 2016, 1:45 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50513/
> ---
> 
> (Updated Aug. 2, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After this change, all libprocess actors should have a distinguishable
> ID, making it possible to match the logging output or the output of
> the "__process__" enpoint to the source actor.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> 5a92b72eb7668494dc832ec446a41b3d673a20cc 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> 78ff40ed64c4313dd9daddcf96e1447ad015c734 
>   3rdparty/libprocess/include/process/run.hpp 
> d141fb0f5f71e24d1652a11dbaa6d2b7c5b70f5f 
>   3rdparty/libprocess/src/authenticator.cpp 
> 55e8558a5272cb0447ad9268ad9c7f27e2f30385 
>   3rdparty/libprocess/src/process.cpp 
> 7f331b812de2f0437838f48e0959441c8e04c358 
> 
> Diff: https://reviews.apache.org/r/50513/diff/
> 
> 
> Testing
> ---
> 
> `make check` in OS X and various linux distribution.
> 
> I also looked at the output of the `__process__` endpoint. After this change, 
> some of the unidentifiable processes have a nicer id now. The goal of this 
> review chain is to give all processes there an identifiable ID.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50563: Made HierarchicalAllocatorProcess specify a process ID.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50563/
---

(Updated Aug. 2, 2016, 1:55 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebased.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

I had to move the initialization of ProcessBase to the public
HierarchicalAllocatorProcess constructor. The ID would otherwise get
lost, leading to an undistinguishable ID.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
b72ba16277a3210e4d309b616d185a10e2029a66 

Diff: https://reviews.apache.org/r/50563/diff/


Testing
---

`make check` in OS X and various linux distributions, checked the output of 
`__processes__`.


Thanks,

Gastón Kleiman

Re: Review Request 50521: Added "zookeeper" prefix to ZK process IDs.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50521/
---

(Updated Aug. 2, 2016, 1:55 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebased + renamed 2 more actors.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

Added "zookeeper" prefix to ZK process IDs.


Diffs (updated)
-

  src/zookeeper/contender.cpp 320658182c85d333539be3c20534ad889a2ce99e 
  src/zookeeper/detector.cpp f1def68740e4941a5daa3a889bc14278d7ea7366 
  src/zookeeper/group.cpp 7438eccf285ad2ab6462c0bb091966179d6906d5 

Diff: https://reviews.apache.org/r/50521/diff/


Testing
---

`make check` in OS X and various linux distribution.


Thanks,

Gastón Kleiman

Re: Review Request 50639: Made all Actor IDs outside of libprocess follow the same schema.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50639/
---

(Updated Aug. 2, 2016, 1:54 p.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

Made all Actor IDs contain only lower case letters and dashes (not
underscores).


Diffs (updated)
-

  src/authentication/cram_md5/authenticatee.cpp 
236de252192c4875eb76bc91e9aea1df331bcad7 
  src/authentication/cram_md5/authenticator.cpp 
4ec15680b236704c89c9c8b24758797ea6a3dd03 
  src/executor/v0_v1executor.cpp cd1c59016590383b9b57f14da54165b75b441883 

Diff: https://reviews.apache.org/r/50639/diff/


Testing
---

`make check` in OS X and various linux distribution, checked the output of 
`__processes__`.


Thanks,

Gastón Kleiman

Re: Review Request 50513: Added missing process IDs in libprocess.

[Gastón Kleiman]

> On July 29, 2016, 12:44 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/include/process/sequence.hpp, line 66
> > 
> >
> > Why do you treat `Sequence` not like other processes in this patch?
> > 
> > I see that you also changed `Sequence` instances are contrsucted, but 
> > maybe it makes more sence it get an optional suffix here? By default the id 
> > is just `seuqence` and if suffix is passed, it will be something like 
> > `sequence-authentications`. Also, maybe it makes sense to extact `Sequence` 
> > update into a separate RR?

Created a separate RR with the `Sequence` change.


> On July 29, 2016, 12:44 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/authenticator.cpp, line 57
> > 
> >
> > Why this one is enclosed in underscores?

Added the naming schema to the commit description.


- Gastón


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50513/#review144082
---


On Aug. 2, 2016, 1:45 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50513/
> ---
> 
> (Updated Aug. 2, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After this change, all libprocess actors should have a distinguishable
> ID, making it possible to match the logging output or the output of
> the "__process__" enpoint to the source actor.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> 5a92b72eb7668494dc832ec446a41b3d673a20cc 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> 78ff40ed64c4313dd9daddcf96e1447ad015c734 
>   3rdparty/libprocess/include/process/run.hpp 
> d141fb0f5f71e24d1652a11dbaa6d2b7c5b70f5f 
>   3rdparty/libprocess/src/authenticator.cpp 
> 55e8558a5272cb0447ad9268ad9c7f27e2f30385 
>   3rdparty/libprocess/src/process.cpp 
> 7f331b812de2f0437838f48e0959441c8e04c358 
> 
> Diff: https://reviews.apache.org/r/50513/diff/
> 
> 
> Testing
> ---
> 
> `make check` in OS X and various linux distribution.
> 
> I also looked at the output of the `__process__` endpoint. After this change, 
> some of the unidentifiable processes have a nicer id now. The goal of this 
> review chain is to give all processes there an identifiable ID.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50519: Made libprocess Actor IDs consistent.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50519/
---

(Updated Aug. 2, 2016, 1:50 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebase + new description + caught one more ID.


Summary (updated)
-

Made libprocess Actor IDs consistent.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description (updated)
---

Enforced the following actor ID schema in libprocess:

- Actor IDs contain only lowercase characters, dashes or underscores.
- The ID of an actor that is exposed to libprocess users, via a route/
  associated to an endpoint uses dashes as word separator, e.g., `help`.
- The ID of an actor internal to libprocess, with not associated
  route/endpoint, must be enclosed in double quotes and use underscores
  instead of dashes as word separator, e.g.,
  `__authentication_router__`.


Diffs (updated)
-

  3rdparty/libprocess/src/authenticator_manager.cpp 
7def832147df01ed51e642f8baf1216590745fdf 
  3rdparty/libprocess/src/reap.cpp ac60c6d769076912293950432266c956d6c7e705 

Diff: https://reviews.apache.org/r/50519/diff/


Testing
---

`make check` in OS X and various linux distribution, checked the output of 
`__processes__`.


Thanks,

Gastón Kleiman

Re: Review Request 50515: Added missing process IDs.

[Gastón Kleiman]

> On July 29, 2016, 12:45 p.m., Alexander Rukletsov wrote:
> > src/exec/exec.cpp, line 87
> > 
> >
> > No need for `process::` here because
> > `using namespace process` above.

Fixed here and in `src/linux/cgroups.cpp`.


- Gastón


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50515/#review144087
---


On Aug. 2, 2016, 1:47 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50515/
> ---
> 
> (Updated Aug. 2, 2016, 1:47 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After this change, all actors should have a distinguishable ID, making
> it possible to match the logging output or the output of the
> "__process__" enpoint to the source actor.
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp f4063d398838d99d8c055447cd411124cfb9985f 
>   src/exec/exec.cpp 90a16a90410027969adf93091bcce253a98d 
>   src/linux/cgroups.cpp 610857a436e07e0f2f4629d3a389e90fa31cc258 
>   src/linux/perf.cpp ea823b32edaa82a71cbfac9932aae543c0d7bef4 
>   src/linux/routing/link/link.cpp 96bd50e245ef7e29d4767ba0871e0ac4abad55a0 
>   src/slave/container_loggers/logrotate.cpp 
> b863d931b08992ea9e94a7e6837b44cfc94ae8f1 
>   src/slave/container_loggers/sandbox.cpp 
> 00272f82de9a6257d8654b36085b3427c18e81ec 
>   src/slave/containerizer/composing.cpp 
> 15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 3274e09f66b53cb67b6a20c88faa4c1e45569b22 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp 
> e8fe131e355796d450dd4d823a6be4e4e4ec4506 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> c304e2a896d1d8ae085914c0fd7e6326fd68ad2d 
>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
> 4f0a43b9d8b0d04a8e3e11b1a11688d4fa93 
>   src/slave/containerizer/mesos/isolators/cgroups/devices.cpp 
> 66db4fc7253094a2691ead3a5621f186b59c1f21 
>   src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 
> af8d1654a47b3ce50878c69b6f9aad053d3055e6 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> 2665b022260b9228d4d34f030feb0d2f5de54bb3 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 1de38491a33e5782b20e5ee491412779d09ee391 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 5af0ae93526af41ec54263fd44b5c2b55a7011a4 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> d10c424b48cb2ff974c49f91dd75805859ec39ef 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ed7366aeeed6646b74f2087fd00449c70dd16e82 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 0809e8ec35232fbdafee171a7a960cbdec272134 
>   src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
> 51d15186bd5005e2e069d68907a9e3969eb65ebb 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> 0bee68bea363d53978d82db2f85ee16744580bc9 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> c7e8cf0ec3ff10e9d5ddd218b0e33ed1e8195b68 
>   src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 
> 4e0dcd11067e0b05338f7c61e11840b7004ecbc9 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 527c579bb80bb0a02ca4ff16d1b1d94823d0dea0 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> 21a86e3087bea46a2d2125e53292251243086554 
>   src/slave/containerizer/mesos/isolators/posix.hpp 
> e5cee9c6a77ade1a48b056c981ad23edee56969d 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 3dfe7ad4477dd1a6c8585bf761eaf435fd0cb366 
>   src/slave/containerizer/mesos/isolators/windows.hpp 
> aec331663a58b17fac0396e2d17df7a28e1ee164 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 19e55111edc0bf80a14fb7b2dade120b4432de53 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> c27b1b5ca05a5883831c86575ac129903e758598 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 
> 54c005764c4aa84af2606b69e5f5f10db61fab80 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> af9544e2eaef754a7cf4cbb865c1e0a054f01d7f 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> b9f6d7a5d5ee341d7e3ac2663a8d2a5fc4746096 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> e3d8494694447c57596f332c9f120549478a5c7d 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 4be26faf0d46ee29fb4169bfe69264c57a6b9fce 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 

Re: Review Request 50515: Added missing process IDs.

[Gastón Kleiman]

> On July 29, 2016, 12:45 p.m., Alexander Rukletsov wrote:
> > src/slave/containerizer/mesos/containerizer.hpp, line 304
> > 
> >
> > See my comment in the previous patch regarding `sequence`.

Fixed, renamed it to `mesos-container-status-updates `.


- Gastón


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50515/#review144087
---


On Aug. 2, 2016, 1:47 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50515/
> ---
> 
> (Updated Aug. 2, 2016, 1:47 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After this change, all actors should have a distinguishable ID, making
> it possible to match the logging output or the output of the
> "__process__" enpoint to the source actor.
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp f4063d398838d99d8c055447cd411124cfb9985f 
>   src/exec/exec.cpp 90a16a90410027969adf93091bcce253a98d 
>   src/linux/cgroups.cpp 610857a436e07e0f2f4629d3a389e90fa31cc258 
>   src/linux/perf.cpp ea823b32edaa82a71cbfac9932aae543c0d7bef4 
>   src/linux/routing/link/link.cpp 96bd50e245ef7e29d4767ba0871e0ac4abad55a0 
>   src/slave/container_loggers/logrotate.cpp 
> b863d931b08992ea9e94a7e6837b44cfc94ae8f1 
>   src/slave/container_loggers/sandbox.cpp 
> 00272f82de9a6257d8654b36085b3427c18e81ec 
>   src/slave/containerizer/composing.cpp 
> 15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 3274e09f66b53cb67b6a20c88faa4c1e45569b22 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp 
> e8fe131e355796d450dd4d823a6be4e4e4ec4506 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> c304e2a896d1d8ae085914c0fd7e6326fd68ad2d 
>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
> 4f0a43b9d8b0d04a8e3e11b1a11688d4fa93 
>   src/slave/containerizer/mesos/isolators/cgroups/devices.cpp 
> 66db4fc7253094a2691ead3a5621f186b59c1f21 
>   src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 
> af8d1654a47b3ce50878c69b6f9aad053d3055e6 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> 2665b022260b9228d4d34f030feb0d2f5de54bb3 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 1de38491a33e5782b20e5ee491412779d09ee391 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 5af0ae93526af41ec54263fd44b5c2b55a7011a4 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> d10c424b48cb2ff974c49f91dd75805859ec39ef 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ed7366aeeed6646b74f2087fd00449c70dd16e82 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 0809e8ec35232fbdafee171a7a960cbdec272134 
>   src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
> 51d15186bd5005e2e069d68907a9e3969eb65ebb 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> 0bee68bea363d53978d82db2f85ee16744580bc9 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> c7e8cf0ec3ff10e9d5ddd218b0e33ed1e8195b68 
>   src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 
> 4e0dcd11067e0b05338f7c61e11840b7004ecbc9 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 527c579bb80bb0a02ca4ff16d1b1d94823d0dea0 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> 21a86e3087bea46a2d2125e53292251243086554 
>   src/slave/containerizer/mesos/isolators/posix.hpp 
> e5cee9c6a77ade1a48b056c981ad23edee56969d 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 3dfe7ad4477dd1a6c8585bf761eaf435fd0cb366 
>   src/slave/containerizer/mesos/isolators/windows.hpp 
> aec331663a58b17fac0396e2d17df7a28e1ee164 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 19e55111edc0bf80a14fb7b2dade120b4432de53 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> c27b1b5ca05a5883831c86575ac129903e758598 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 
> 54c005764c4aa84af2606b69e5f5f10db61fab80 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> af9544e2eaef754a7cf4cbb865c1e0a054f01d7f 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> b9f6d7a5d5ee341d7e3ac2663a8d2a5fc4746096 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> e3d8494694447c57596f332c9f120549478a5c7d 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 4be26faf0d46ee29fb4169bfe69264c57a6b9fce 
>   

Re: Review Request 50515: Added missing process IDs.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50515/
---

(Updated Aug. 2, 2016, 1:47 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebased.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

After this change, all actors should have a distinguishable ID, making
it possible to match the logging output or the output of the
"__process__" enpoint to the source actor.


Diffs (updated)
-

  src/examples/test_hook_module.cpp f4063d398838d99d8c055447cd411124cfb9985f 
  src/exec/exec.cpp 90a16a90410027969adf93091bcce253a98d 
  src/linux/cgroups.cpp 610857a436e07e0f2f4629d3a389e90fa31cc258 
  src/linux/perf.cpp ea823b32edaa82a71cbfac9932aae543c0d7bef4 
  src/linux/routing/link/link.cpp 96bd50e245ef7e29d4767ba0871e0ac4abad55a0 
  src/slave/container_loggers/logrotate.cpp 
b863d931b08992ea9e94a7e6837b44cfc94ae8f1 
  src/slave/container_loggers/sandbox.cpp 
00272f82de9a6257d8654b36085b3427c18e81ec 
  src/slave/containerizer/composing.cpp 
15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
  src/slave/containerizer/mesos/containerizer.hpp 
3274e09f66b53cb67b6a20c88faa4c1e45569b22 
  src/slave/containerizer/mesos/isolators/appc/runtime.cpp 
e8fe131e355796d450dd4d823a6be4e4e4ec4506 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
c304e2a896d1d8ae085914c0fd7e6326fd68ad2d 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
4f0a43b9d8b0d04a8e3e11b1a11688d4fa93 
  src/slave/containerizer/mesos/isolators/cgroups/devices.cpp 
66db4fc7253094a2691ead3a5621f186b59c1f21 
  src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 
af8d1654a47b3ce50878c69b6f9aad053d3055e6 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
2665b022260b9228d4d34f030feb0d2f5de54bb3 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
1de38491a33e5782b20e5ee491412779d09ee391 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
5af0ae93526af41ec54263fd44b5c2b55a7011a4 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
d10c424b48cb2ff974c49f91dd75805859ec39ef 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
ed7366aeeed6646b74f2087fd00449c70dd16e82 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
0809e8ec35232fbdafee171a7a960cbdec272134 
  src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
51d15186bd5005e2e069d68907a9e3969eb65ebb 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
0bee68bea363d53978d82db2f85ee16744580bc9 
  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
c7e8cf0ec3ff10e9d5ddd218b0e33ed1e8195b68 
  src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 
4e0dcd11067e0b05338f7c61e11840b7004ecbc9 
  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
527c579bb80bb0a02ca4ff16d1b1d94823d0dea0 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
21a86e3087bea46a2d2125e53292251243086554 
  src/slave/containerizer/mesos/isolators/posix.hpp 
e5cee9c6a77ade1a48b056c981ad23edee56969d 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
3dfe7ad4477dd1a6c8585bf761eaf435fd0cb366 
  src/slave/containerizer/mesos/isolators/windows.hpp 
aec331663a58b17fac0396e2d17df7a28e1ee164 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
19e55111edc0bf80a14fb7b2dade120b4432de53 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
c27b1b5ca05a5883831c86575ac129903e758598 
  src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 
54c005764c4aa84af2606b69e5f5f10db61fab80 
  src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
af9544e2eaef754a7cf4cbb865c1e0a054f01d7f 
  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
b9f6d7a5d5ee341d7e3ac2663a8d2a5fc4746096 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
e3d8494694447c57596f332c9f120549478a5c7d 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
4be26faf0d46ee29fb4169bfe69264c57a6b9fce 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6545a6d29cb91d6cf8919c7796c283084178e499 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
81e9d94553874a74cc115d9a1fd659652313a94c 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
40ee1da5ea453127c1e5e4cdf4b9a49bc998698a 
  src/slave/gc.hpp 294b75f43b2f5b589e5fc93fd544b6f38e031e6b 
  src/slave/qos_controllers/load.cpp abc98fa77dae8bc7b49b28d397eed80ff10d2a2b 
  src/slave/qos_controllers/noop.cpp 38b73bc8f5c4ce427b0d00a021a306bf787b0acc 
  src/slave/resource_estimators/fixed.cpp 
767ba6acfe6c91ed44c684d9c929057876099b79 
  src/slave/resource_estimators/noop.cpp 
ffc9a3ed7aaba48c60ba12afdc5e7a2dc7098b8d 
  src/state/in_memory.cpp c16637d4b216424a40c4c49ce38c714144350d91 
  src/state/leveldb.cpp 

Re: Review Request 50513: Added missing process IDs in libprocess.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50513/
---

(Updated Aug. 2, 2016, 1:45 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebased.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

After this change, all libprocess actors should have a distinguishable
ID, making it possible to match the logging output or the output of
the "__process__" enpoint to the source actor.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
5a92b72eb7668494dc832ec446a41b3d673a20cc 
  3rdparty/libprocess/include/process/protobuf.hpp 
78ff40ed64c4313dd9daddcf96e1447ad015c734 
  3rdparty/libprocess/include/process/run.hpp 
d141fb0f5f71e24d1652a11dbaa6d2b7c5b70f5f 
  3rdparty/libprocess/src/authenticator.cpp 
55e8558a5272cb0447ad9268ad9c7f27e2f30385 
  3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358 

Diff: https://reviews.apache.org/r/50513/diff/


Testing
---

`make check` in OS X and various linux distribution.

I also looked at the output of the `__process__` endpoint. After this change, 
some of the unidentifiable processes have a nicer id now. The goal of this 
review chain is to give all processes there an identifiable ID.


Thanks,

Gastón Kleiman

Re: Review Request 50637: Added id to the libprocess Sequence constructor.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50637/
---

(Updated Aug. 2, 2016, 1:42 p.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

Sequence IDs used to follow the following schema; "(1)", "(2)", etc.
This made it very hard to match the output from logging or the
"__processes__" endpoint to them.

This change makes it possible to give sequence processes a
distinguishable ID.


Diffs (updated)
-

  3rdparty/libprocess/include/process/sequence.hpp 
78ccdb95422d0f7e12f1d66b4456c4f0014f4ffe 

Diff: https://reviews.apache.org/r/50637/diff/


Testing
---

make check


Thanks,

Gastón Kleiman

Re: Review Request 50637: Added id to the libprocess Sequence constructor.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50637/
---

(Updated Aug. 2, 2016, 1:29 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebased.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

Sequence IDs used to follow the following schema; "(1)", "(2)", etc.
This made it very hard to match the output from logging or the
"__processes__" endpoint to them.

This change makes it possible to give sequence processes a
distinguishable ID.


Diffs (updated)
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
497f6107567ef47c16a0c906238bc7dfdcf84701 
  3rdparty/libprocess/include/process/sequence.hpp 
78ccdb95422d0f7e12f1d66b4456c4f0014f4ffe 
  CHANGELOG f720f0ec36825ec2c51a1e682fd25ed1a7224052 
  include/mesos/resources.hpp 829f39d7c1af3eb4e2efd97e01f87acf7c854bb4 
  include/mesos/v1/resources.hpp f3c5f315c3701e37aeb8fd468ee288829461338e 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/cli/CMakeLists.txt c0120cd7f4ef8dc275edbd5cb1a4a6e23952ec63 
  src/common/resources.cpp 309b17626d33bc6b4df07f002b0eea4f4803b3e5 
  src/local/CMakeLists.txt 643a6cf653d91b8a606ac83b126dfd2245fa49bd 
  src/master/validation.cpp f8343768f3dc803e6bd7f4253c77d9fef82408e5 
  src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 
  src/slave/containerizer/containerizer.cpp 
ba3b3f62fe0cf755fdbebf52350d9069cb2efca8 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
8814299e5c1efa857cdc78759f422a2e4e94e9b0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
c304e2a896d1d8ae085914c0fd7e6326fd68ad2d 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
d10c424b48cb2ff974c49f91dd75805859ec39ef 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
0a85935550e36c9142d845465cfa70a1634a647a 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
ed7366aeeed6646b74f2087fd00449c70dd16e82 
  src/slave/containerizer/mesos/isolators/gpu/volume.cpp 
478e106cdaa025af92117f14be91ec9e1c70425b 
  src/slave/containerizer/mesos/launch.cpp 
e1cf9d5226ca4b4b33d8f9d9efb968be35d4ec4d 
  src/tests/CMakeLists.txt 1ea8b2102753ae294bd75706ffaf08308e928acd 
  src/tests/cmake/MesosTestsConfigure.cmake 
361032082c3a5f76b949dc7981f75b53e02d84f5 
  src/tests/containerizer/CMakeLists.txt 
2c52e43a9deee90fa32693731d6ebedb5201bb1f 
  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
fea1f9f0a03373692ef2a6dd2bc5722dc6f46d5b 
  src/tests/hierarchical_allocator_tests.cpp 
cbed333f497016fe2811f755028796012b41db77 
  src/tests/mesos.hpp 9174a3810d0da34b99dc257e9c77f83107fdd9f5 
  src/tests/resources_tests.cpp 54eaabd7639d310dffbceee1af0f18c901c39865 
  src/v1/resources.cpp 3f67e32519600a22f07a66ebfe05a7b647cb2c61 

Diff: https://reviews.apache.org/r/50637/diff/


Testing
---

make check


Thanks,

Gastón Kleiman

Review Request 50706: Added test cases for PARTITION_AWARE behavior.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50706/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
---

Added test cases for PARTITION_AWARE behavior.


Diffs
-

  src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 

Diff: https://reviews.apache.org/r/50706/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 50707: Added test for agent removal behavior.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50707/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
---

This test tries to simulate a race between marking an agent unhealthy
and receiving an `UnregisterSlaveMessage` for that agent.

Unfortunately, this test is a little fragile (we need to manually
dispatch an event to the master process to simulate the action that
would be taken by the slave observer).


Diffs
-

  src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a 

Diff: https://reviews.apache.org/r/50707/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 50705: Changed master to allow partitioned slaves to reregister.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50705/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
---

The previous behavior was to shutdown partitioned agents that attempt to
reregister---unless the master has failed over, in which case the
reregistration is allowed (when running in "non-strict" mode).

The new behavior is always to allow partitioned agents to reregister.
This is part of a longer-term project to allow frameworks to define
their own policies for handling tasks running on partitioned agents.

In particular, if a framework has the PARTITION_AWARE capability, any
tasks running on the partitioned agent will continue to run after
reregistration. If the framework is not PARTITION_AWARE, any tasks that
were running on such an agent will be killed after the agent
reregisters. This is for backward compatibility with the previous
behavior. Note that regardless of the PARTITION_AWARE capability, the
agent will not be shutdown, which is a change from the previous Mesos
behavior.

This commit also changes the master so that an agent is removed and then
the master receives a message from that agent, the master will no longer
attempt to shutdown the agent. This is consistent with the goal of
getting the master out of the business of shutting down agents that we
suspect are unhealthy. Such an agent will eventually realize it is not
registered with the master (e.g., because it won't receive any pings
from the master), which will cause it to reregister.


Diffs
-

  src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
  src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
  src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
  src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 

Diff: https://reviews.apache.org/r/50705/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 50704: Made a few minor tweaks to comments.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50704/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
---

Made a few minor tweaks to comments.


Diffs
-

  src/messages/messages.proto 7b5e24fb1e9baf09ce024daeca90745f380d4c2f 
  src/slave/slave.cpp c19a63e4f8df11d8150071ef427bd8038584586b 

Diff: https://reviews.apache.org/r/50704/diff/


Testing
---

make check


Thanks,

Neil Conway