Re: Review Request 59467: Document new Fetcher metrics.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59467/#review175754
---



Patch looks great!

Reviews applied: [59464, 59466, 59467]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 22, 2017, 9:19 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59467/
> ---
> 
> (Updated May 22, 2017, 9:19 p.m.)
> 
> 
> Review request for mesos and Mesos Reviewbot.
> 
> 
> Bugs: MESOS-7524
> https://issues.apache.org/jira/browse/MESOS-7524
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document new Fetcher metrics.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md a027f4905a0e6e41ff4e1348d34fd7aa5f1cbe61 
> 
> 
> Diff: https://reviews.apache.org/r/59467/diff/2/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 59141: Added new parameter 'data' to the URI fetcher interface.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59141/#review175749
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On May 22, 2017, 6:03 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59141/
> ---
> 
> (Updated May 22, 2017, 6:03 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added new parameter 'data' to the URI fetcher interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp ebf86c78b794a6ef46332df788a1317bbec5d983 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
>   src/tests/uri_fetcher_tests.cpp 4892909bbb47f60c95d8d9f0f175a5db32d4a164 
>   src/uri/fetcher.cpp f4d1a4c69e910260dc536aa42ae03fd17403b060 
>   src/uri/fetchers/copy.hpp f4a2fb3d5156e5ebfdf7c4202f8dc9b1cd1d6ac7 
>   src/uri/fetchers/copy.cpp 5e1470503f4fa0e543680c93b2ad3e36351afc1c 
>   src/uri/fetchers/curl.hpp 083f155092d159cd83069bfdfd905d679e9ab57c 
>   src/uri/fetchers/curl.cpp 24b53c77946170cba45152c458d85b6fddfce9f8 
>   src/uri/fetchers/docker.hpp 65e01cba1d41688a8ee5da73d1d6f57515fbc7f5 
>   src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 
>   src/uri/fetchers/hadoop.hpp 4923dc6491d7cc6efc6ced4f5356af9f945ba5d2 
>   src/uri/fetchers/hadoop.cpp 3c5ffe607c92ea1ab66ba261bd70031f2907cea6 
> 
> 
> Diff: https://reviews.apache.org/r/59141/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59141: Added new parameter 'data' to the URI fetcher interface.

[Chun-Hung Hsiao]

> On May 18, 2017, 7:54 a.m., Qian Zhang wrote:
> > include/mesos/uri/fetcher.hpp
> > Line 72 (original), 74 (patched)
> > 
> >
> > Suggest to add a description for the newly introduced parameter `data` 
> > to explain what it is for.
> 
> Gilbert Song wrote:
> Thanks, Qian. That is the reason why I added a TODO below. This interface 
> for the URI fetcher is not finalized. We will update it asap.

We prorably also need some unit tests once we have finalized the interface and 
the functionalities supported for each fetcher.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59141/#review175360
---


On May 22, 2017, 6:03 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59141/
> ---
> 
> (Updated May 22, 2017, 6:03 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added new parameter 'data' to the URI fetcher interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp ebf86c78b794a6ef46332df788a1317bbec5d983 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
>   src/tests/uri_fetcher_tests.cpp 4892909bbb47f60c95d8d9f0f175a5db32d4a164 
>   src/uri/fetcher.cpp f4d1a4c69e910260dc536aa42ae03fd17403b060 
>   src/uri/fetchers/copy.hpp f4a2fb3d5156e5ebfdf7c4202f8dc9b1cd1d6ac7 
>   src/uri/fetchers/copy.cpp 5e1470503f4fa0e543680c93b2ad3e36351afc1c 
>   src/uri/fetchers/curl.hpp 083f155092d159cd83069bfdfd905d679e9ab57c 
>   src/uri/fetchers/curl.cpp 24b53c77946170cba45152c458d85b6fddfce9f8 
>   src/uri/fetchers/docker.hpp 65e01cba1d41688a8ee5da73d1d6f57515fbc7f5 
>   src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 
>   src/uri/fetchers/hadoop.hpp 4923dc6491d7cc6efc6ced4f5356af9f945ba5d2 
>   src/uri/fetchers/hadoop.cpp 3c5ffe607c92ea1ab66ba261bd70031f2907cea6 
> 
> 
> Diff: https://reviews.apache.org/r/59141/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59018/#review175745
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On May 22, 2017, 6:04 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59018/
> ---
> 
> (Updated May 22, 2017, 6:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported Image::Secret in docker URI fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 
> 
> 
> Diff: https://reviews.apache.org/r/59018/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> Manually tested using mesos-execute with task group. Verified that pulling 
> separate private image from different registries using different image 
> secrets works correctly.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59015: Implemented passing docker config depended methods.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review175746
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On May 22, 2017, 5:59 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59015/
> ---
> 
> (Updated May 22, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented passing docker config depended methods.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
> 
> 
> Diff: https://reviews.apache.org/r/59015/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59015: Implemented passing docker config depended methods.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review175742
---


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 87 (patched)


I think we don't need a default here.



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 101 (patched)


Ditto.


- Chun-Hung Hsiao


On May 22, 2017, 5:59 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59015/
> ---
> 
> (Updated May 22, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented passing docker config depended methods.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
> 
> 
> Diff: https://reviews.apache.org/r/59015/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 56152: Implemented the 'fetchManifest()' method of prefix puller.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56152/
---

(Updated May 23, 2017, 9:45 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Minor changes.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Implemented the 'fetchManifest()' method of prefix puller.


Diffs (updated)
-

  include/mesos/oci/spec.hpp d8eef84b5770608c359285d9168f7ea5de4eba12 
  src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/prefix_puller.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/56152/diff/5/

Changes: https://reviews.apache.org/r/56152/diff/4-5/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 56150: Implemented the 'fetchIndex()' method of prefix puller.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56150/
---

(Updated May 23, 2017, 9:43 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Minor changes.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Implemented the 'fetchIndex()' method of prefix puller.


Diffs (updated)
-

  include/mesos/oci/spec.hpp d8eef84b5770608c359285d9168f7ea5de4eba12 
  src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/prefix_puller.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/56150/diff/3/

Changes: https://reviews.apache.org/r/56150/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 56149: Implemented the 'pull()' method of prefix puller.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56149/
---

(Updated May 23, 2017, 9:42 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Minor changes.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Implemented the 'pull()' method of prefix puller.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/oci/prefix_puller.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/56149/diff/3/

Changes: https://reviews.apache.org/r/56149/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 56148: Implemented the '_get()' method of OCI store.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56148/
---

(Updated May 23, 2017, 9:41 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Updated comments.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Implemented the '_get()' method of OCI store.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/56148/diff/4/

Changes: https://reviews.apache.org/r/56148/diff/3-4/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 55333: Implemented the 'get()' and '__get()' methods of OCI store.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55333/
---

(Updated May 23, 2017, 9:40 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Minor changes.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Implemented the 'get()' and '__get()' methods of OCI store.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/store.hpp 
82a9be64264ae829773c1e2e8a4360f78641cbf6 


Diff: https://reviews.apache.org/r/55333/diff/4/

Changes: https://reviews.apache.org/r/55333/diff/3-4/


Testing
---


Thanks,

Qian Zhang

Review Request 59474: Implemented the 'create()' method of puller interface.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59474/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Implemented the 'create()' method of puller interface.


Diffs
-

  src/slave/containerizer/mesos/provisioner/oci/puller.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59474/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 56147: Implemented metadata manager for OCI store.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56147/
---

(Updated May 23, 2017, 9:38 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Minor changes.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Implemented metadata manager for OCI store.


Diffs (updated)
-

  src/CMakeLists.txt ca7d538e2f7191c157e3e2237d56e3d75367f418 
  src/Makefile.am 7e4ce8532ec2c1b4216c2aa8d4262b2091e21c4a 
  src/slave/containerizer/mesos/provisioner/oci/metadata_manager.hpp 
PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/metadata_manager.cpp 
PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/56147/diff/3/

Changes: https://reviews.apache.org/r/56147/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 54639: Implemented the 'create()' method of OCI store.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54639/
---

(Updated May 23, 2017, 9:34 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Created `default` and `overlay` layers directories explicitly.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Implemented the 'create()' method of OCI store.


Diffs (updated)
-

  src/CMakeLists.txt ca7d538e2f7191c157e3e2237d56e3d75367f418 
  src/Makefile.am 7e4ce8532ec2c1b4216c2aa8d4262b2091e21c4a 
  src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/54639/diff/5/

Changes: https://reviews.apache.org/r/54639/diff/4-5/


Testing
---


Thanks,

Qian Zhang

Review Request 59473: Added stubs for prefix puller.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59473/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Added stubs for prefix puller.


Diffs
-

  src/CMakeLists.txt ca7d538e2f7191c157e3e2237d56e3d75367f418 
  src/Makefile.am 7e4ce8532ec2c1b4216c2aa8d4262b2091e21c4a 
  src/slave/containerizer/mesos/provisioner/oci/prefix_puller.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/prefix_puller.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59473/diff/1/


Testing
---


Thanks,

Qian Zhang

Review Request 59472: Added puller interface for OCI store.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59472/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Added puller interface for OCI store.


Diffs
-

  include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7 
  src/CMakeLists.txt ca7d538e2f7191c157e3e2237d56e3d75367f418 
  src/Makefile.am 7e4ce8532ec2c1b4216c2aa8d4262b2091e21c4a 
  src/slave/containerizer/mesos/provisioner/oci/puller.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/puller.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59472/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 52382: Added stubs for OCI store.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52382/
---

(Updated May 23, 2017, 9:17 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Fixed OCI store `using` format.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Added stubs for OCI store.


Diffs (updated)
-

  src/CMakeLists.txt ca7d538e2f7191c157e3e2237d56e3d75367f418 
  src/Makefile.am 7e4ce8532ec2c1b4216c2aa8d4262b2091e21c4a 
  src/slave/containerizer/mesos/provisioner/oci/store.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/52382/diff/10/

Changes: https://reviews.apache.org/r/52382/diff/9-10/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 55331: Added 'OCI' message into 'Image' message.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55331/
---

(Updated May 23, 2017, 9:14 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Made `Oci.Locator.type` optional.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Added 'OCI' message into 'Image' message.


Diffs (updated)
-

  include/mesos/mesos.proto 5ac35f481ed5431da256848d59434613e0d83d20 
  include/mesos/v1/mesos.proto dc58accfad34dd4cdaf8216c6cee002535d3a989 


Diff: https://reviews.apache.org/r/55331/diff/5/

Changes: https://reviews.apache.org/r/55331/diff/4-5/


Testing
---


Thanks,

Qian Zhang

Review Request 59471: Removed `features` field from `Platform` protobuf message.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59471/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

See https://github.com/opencontainers/image-spec/pull/672 for details.


Diffs
-

  include/mesos/oci/spec.proto f7f197909ebd5517941e063d8c80b0a7f745bb8d 


Diff: https://reviews.apache.org/r/59471/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 59464: Add Fetcher total and success metrics.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59464/#review175740
---



What do you think about making fetch failures a sub-metric of 
`container_launch_errors`?  The fetcher is only called during container launch. 
 If fetching fails, container launch will also fail (and increment this 
counter).  It might be useful to separate out fetch failures from other types 
of launch failures.  This approach might be a bit more work to do so, since the 
parent metric lives inside the Agent, rather than the Fetcher process.

- Joseph Wu


On May 22, 2017, 2:15 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59464/
> ---
> 
> (Updated May 22, 2017, 2:15 p.m.)
> 
> 
> Review request for mesos and Mesos Reviewbot.
> 
> 
> Bugs: MESOS-7524
> https://issues.apache.org/jira/browse/MESOS-7524
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the Fetcher metrics to track the number of fetch requests sent to
> the Fetcher (`containerizer/fetcher/total`) and the number of errors
> reported by the Fetcher (`containerizer/fetcher/errors`).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.hpp 
> 9e3018dc087ed55c61b2824d0105bc5339b83043 
>   src/slave/containerizer/fetcher.cpp 
> a910fea5a5556afb376524c5bb2ff98d7d84e611 
> 
> 
> Diff: https://reviews.apache.org/r/59464/diff/2/
> 
> 
> Testing
> ---
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 59318: Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/#review175739
---


Ship it!




Ship It!

- Gilbert Song


On May 22, 2017, 1:55 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59318/
> ---
> 
> (Updated May 22, 2017, 1:55 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
> 
> 
> Diff: https://reviews.apache.org/r/59318/diff/2/
> 
> 
> Testing
> ---
> 
> Make check with an without the patch.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58906: Removed extranous sandbox initialization in Docker containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58906/#review175737
---


Ship it!




Ship It!

- Jie Yu


On May 2, 2017, 2:06 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58906/
> ---
> 
> (Updated May 2, 2017, 2:06 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Docker containerizer will create a stdout/stderr file as well
> `chown` the sandbox directory to the user specified at container
> creation time.  This logic is already performed elsewhere.
> 
> The stdout/stderr files will either be created prior to the container
> launch via the mesos-fetcher, or during launch via the ContainerLogger.
> 
> The sandbox directory will be `chown`d by the Agent when it
> starts to launch the executor.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 
> 
> 
> Diff: https://reviews.apache.org/r/58906/diff/2/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 58905: Changed naming of Docker containers to the pre-0.23 scheme.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58905/#review175735
---


Ship it!




Ship It!

- Jie Yu


On May 19, 2017, 10:14 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58905/
> ---
> 
> (Updated May 19, 2017, 10:14 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The choice of naming scheme is cosmetic.  All versions of the Docker
> containerizer will consider containers starting with "mesos-"
> as containers started by Mesos.  The Docker containerizer does not
> consider the `SlaveID` at all when recovering.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3 
>   src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 
> 
> 
> Diff: https://reviews.apache.org/r/58905/diff/2/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> TODO: Add a backwards compatibility test .
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 59470: Windows: Fixed broken build due to environment secret isolator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59470/#review175730
---



Bad patch!

Reviews applied: [59470]

Failed command: ['cmd', '/c', 'support\\windows-build.bat 2>&1 > build_59470']

Error:

C:\Users\mesos\mesos>REM Licensed to the Apache Software Foundation (ASF) under 
one 

C:\Users\mesos\mesos>REM or more contributor license agreements.  See the 
NOTICE file 

C:\Users\mesos\mesos>REM distributed with this work for additional information 

C:\Users\mesos\mesos>REM regarding copyright ownership.  The ASF licenses this 
file 

C:\Users\mesos\mesos>REM to you under the Apache License, Version 2.0 (the 

C:\Users\mesos\mesos>REM "License"); you may not use this file except in 
compliance 

C:\Users\mesos\mesos>REM with the License.  You may obtain a copy of the 
License at 

C:\Users\mesos\mesos>REM

C:\Users\mesos\mesos>REM http://www.apache.org/licenses/LICENSE-2.0 

C:\Users\mesos\mesos>REM

C:\Users\mesos\mesos>REM Unless required by applicable law or agreed to in 
writing, software 

C:\Users\mesos\mesos>REM distributed under the License is distributed on an "AS 
IS" BASIS, 

C:\Users\mesos\mesos>REM WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
express or implied. 

C:\Users\mesos\mesos>REM See the License for the specific language governing 
permissions and 

C:\Users\mesos\mesos>REM limitations under the License. 

C:\Users\mesos\mesos>REM NOTE: Before you run this script, you must have the 
Visual Studio 

C:\Users\mesos\mesos>REM environment variables set up. Visual Studio provides a 
script to do this, 

C:\Users\mesos\mesos>REM depending on the version of Visual Studio installed: 

C:\Users\mesos\mesos>REM /path/to/Visual Studio 14/VC/vcvarsall.bat 

C:\Users\mesos\mesos>REM /path/to/Microsoft Visual 
Studio/2017/Community/VC/Auxiliary/Build/vcvars64.bat 

C:\Users\mesos\mesos>REM NOTE: Batch doesn't have any way of exiting upon 
failing a command. 

C:\Users\mesos\mesos>REM The best we can do is add this line after every 
command that matters: 

C:\Users\mesos\mesos>REM if 0 neq 0 exit /b 0 

C:\Users\mesos\mesos>REM NOTE: In order to run the tests, your Windows volume 
must have a 

C:\Users\mesos\mesos>REM folder named `tmp` at the top level. You can create it 
like this: 

C:\Users\mesos\mesos>REM MKDIR C:\tmp 

C:\Users\mesos\mesos>REM Make sure that we are in the right directory. We do 
this by checking that 

C:\Users\mesos\mesos>REM the `support` folder exists in the current directory 
and is not a symlink. 

C:\Users\mesos\mesos>REM This code is awkwardly split across two conditionals 
because batch scripts 

C:\Users\mesos\mesos>REM do not support logical operators like `&&`. 

C:\Users\mesos\mesos>if not exist support (goto not_in_root ) 

C:\Users\mesos\mesos>fsutil reparsepoint query "support"   | find "Symbolic 
Link"   1>nul  && (goto not_in_root ) 

C:\Users\mesos\mesos>REM Create a build directory. 

C:\Users\mesos\mesos>MKDIR build 

C:\Users\mesos\mesos>CD build 

C:\Users\mesos\mesos\build>if 0 NEQ 0 exit /b 0 

C:\Users\mesos\mesos\build>REM Generate the Visual Studio solution. 

C:\Users\mesos\mesos\build>REM You can pass in other flags by setting 
`OTHER_CMAKE_OPTIONS` before 

C:\Users\mesos\mesos\build>REM calling the script. For example, the ASF CI will 
add `-DPATCHEXE_PATH=...` 

C:\Users\mesos\mesos\build>REM because the path to GNU Patch is not the 
default. 

C:\Users\mesos\mesos\build>if not defined CMAKE_GENERATOR (set 
CMAKE_GENERATOR=Visual Studio 15 2017 Win64 ) 

C:\Users\mesos\mesos\build>cmake .. -G "Visual Studio 15 2017 Win64" -T 
"host=x64" -DENABLE_LIBEVENT=1 -DHAS_AUTHENTICATION=0  
-- The C compiler identification is MSVC 19.10.25017.0
-- The CXX compiler identification is MSVC 19.10.25017.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual 
Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual 
Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual 
Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual 
Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- cotire 1.7.9 loaded.
-- 
-- * Beginning Mesos CMake configuration step *
-- 
-- INSTALLATION PREFIX: C:/Program Files/Mesos
-- 

Review Request 59470: Windows: Fixed broken build due to environment secret isolator.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59470/
---

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-7545
https://issues.apache.org/jira/browse/MESOS-7545


Repository: mesos


Description
---

The environment secret resolver isolator was previously enabled for all
builds, but the isolator source was not included in the windows build
and caused build failure.


Diffs
-

  src/CMakeLists.txt ca7d538e2f7191c157e3e2237d56e3d75367f418 


Diff: https://reviews.apache.org/r/59470/diff/1/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59461/
---

(Updated May 22, 2017, 10:39 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-7540
https://issues.apache.org/jira/browse/MESOS-7540


Repository: mesos


Description
---

This patch updates the tests to make use of the new
'executor_reregister_timeout' agent flag.


Diffs (updated)
-

  src/tests/containerizer/port_mapping_tests.cpp 
a528382e8b4831b9c7e8dcc877a5e242909f0cd5 
  src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650 
  src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
  src/tests/persistent_volume_tests.cpp 
ef0085316d76bd05a86b7930446f6439b2101645 
  src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
  src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5 


Diff: https://reviews.apache.org/r/59461/diff/2/

Changes: https://reviews.apache.org/r/59461/diff/1-2/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 59460: Added new agent flag 'executor_reregistration_timeout'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59460/
---

(Updated May 22, 2017, 10:36 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Summary (updated)
-

Added new agent flag 'executor_reregistration_timeout'.


Bugs: MESOS-7540
https://issues.apache.org/jira/browse/MESOS-7540


Repository: mesos


Description (updated)
---

This patch adds a new agent flag, 'executor_reregistration_timeout',
which allows operators to configure the time which an executor has
to reregister with the agent before it will be considered gone and
terminated.


Diffs
-

  docs/configuration.md c5194e7566c13514f55742aa7278e75314f69d9c 
  src/slave/constants.hpp 9c1d7245c0a8ecd657bb64dafb8b0fa4780325f4 
  src/slave/flags.hpp 28f6482c38a2d388e624726d5e7bccc5cb260fce 
  src/slave/flags.cpp e172aa526cfd38f4f30efda22ef011146e5c1a7d 
  src/slave/slave.cpp 14de72fa4a8746504a251d735bf56041b934df40 


Diff: https://reviews.apache.org/r/59460/diff/2/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 59460: Added new agent flag 'executor_reregister_timeout'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59460/
---

(Updated May 22, 2017, 10:36 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Changes
---

Addressed comments, added docs.


Bugs: MESOS-7540
https://issues.apache.org/jira/browse/MESOS-7540


Repository: mesos


Description
---

This patch adds a new agent flag, 'executor_reregister_timeout',
which allows operators to configure the time which an executor has
to reregister with the agent before it will be considered gone and
terminated.


Diffs (updated)
-

  docs/configuration.md c5194e7566c13514f55742aa7278e75314f69d9c 
  src/slave/constants.hpp 9c1d7245c0a8ecd657bb64dafb8b0fa4780325f4 
  src/slave/flags.hpp 28f6482c38a2d388e624726d5e7bccc5cb260fce 
  src/slave/flags.cpp e172aa526cfd38f4f30efda22ef011146e5c1a7d 
  src/slave/slave.cpp 14de72fa4a8746504a251d735bf56041b934df40 


Diff: https://reviews.apache.org/r/59460/diff/2/

Changes: https://reviews.apache.org/r/59460/diff/1-2/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 59463: Added test for agent ping timeout during agent recovery.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59463/#review175720
---




src/tests/slave_recovery_tests.cpp
Lines 891-898 (patched)


This needs to advance and wait for each ping, otherwise it only leads to 1 
ping being fired. You can find some examples:

$ grep -R PingSlaveMessage src/tests
$ grep -R PongSlaveMessage src/tests


- Benjamin Mahler


On May 22, 2017, 9:17 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59463/
> ---
> 
> (Updated May 22, 2017, 9:17 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
> https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a new test, `SlaveRecoveryTest.PingTimeoutDuringRecovery`,
> which verifies that the agent will reply to pings from the master while it
> is performing recovery.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
> 
> 
> Diff: https://reviews.apache.org/r/59463/diff/1/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="*PingTimeoutDuringRecovery*" bin/mesos-tests.sh 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 59460: Added new agent flag 'executor_reregister_timeout'.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59460/#review175713
---


Fix it, then Ship it!





src/slave/constants.hpp
Line 36 (original), 36 (patched)


You'll also want to rename this one to be consistent with the flag name.



src/slave/constants.hpp
Lines 45 (patched)


How about 15 seconds here and we can increase if needed? In particular I'm 
a little concerned about this being high, since the agent has to wait for this 
entire timeout if an executor is dead.



src/slave/flags.hpp
Line 79 (original), 79-80 (patched)


Name these two consistently?



src/slave/flags.cpp
Lines 337-338 (patched)


Maybe mention that it's in the case of an agent restart? E.g. "re-register 
with after the agent has restarted, before the agent considers it gone and 
shuts it down"



src/slave/flags.cpp
Lines 338-340 (patched)


It would be good to mention that this is the current implementation (since 
it could be better): "Note that the current implementation of agent recovery 
..." And maybe even include the ticket number in the help message for not 
always waiting, and detecting dead executors.

Don't know if you need the "which will delay ..." since there's more we can 
say, e.g. "can't run tasks, can't send framework messages, etc".


- Benjamin Mahler


On May 22, 2017, 6:46 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59460/
> ---
> 
> (Updated May 22, 2017, 6:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
> https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a new agent flag, 'executor_reregister_timeout',
> which allows operators to configure the time which an executor has
> to reregister with the agent before it will be considered gone and
> terminated.
> 
> 
> Diffs
> -
> 
>   src/slave/constants.hpp 9c1d7245c0a8ecd657bb64dafb8b0fa4780325f4 
>   src/slave/flags.hpp 28f6482c38a2d388e624726d5e7bccc5cb260fce 
>   src/slave/flags.cpp e172aa526cfd38f4f30efda22ef011146e5c1a7d 
>   src/slave/slave.cpp 14de72fa4a8746504a251d735bf56041b934df40 
> 
> 
> Diff: https://reviews.apache.org/r/59460/diff/1/
> 
> 
> Testing
> ---
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59461/#review175712
---


Ship it!




Ship It!

- Vinod Kone


On May 22, 2017, 6:46 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59461/
> ---
> 
> (Updated May 22, 2017, 6:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
> https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the tests to make use of the new
> 'executor_reregister_timeout' agent flag.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/port_mapping_tests.cpp 
> a528382e8b4831b9c7e8dcc877a5e242909f0cd5 
>   src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650 
>   src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
>   src/tests/persistent_volume_tests.cpp 
> ef0085316d76bd05a86b7930446f6439b2101645 
>   src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
>   src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5 
> 
> 
> Diff: https://reviews.apache.org/r/59461/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 59460: Added new agent flag 'executor_reregister_timeout'.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59460/#review175707
---




src/slave/flags.cpp
Lines 335 (patched)


s/reregister/reregistration/

to be consistent with the above flag.



src/slave/flags.cpp
Lines 340 (patched)


s/offers./offers after an agent restart./



src/slave/flags.cpp
Lines 345 (patched)


s/to be less than/to be not more than/ ?



src/slave/slave.cpp
Lines 4204 (patched)


re-registration


- Vinod Kone


On May 22, 2017, 6:46 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59460/
> ---
> 
> (Updated May 22, 2017, 6:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
> https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a new agent flag, 'executor_reregister_timeout',
> which allows operators to configure the time which an executor has
> to reregister with the agent before it will be considered gone and
> terminated.
> 
> 
> Diffs
> -
> 
>   src/slave/constants.hpp 9c1d7245c0a8ecd657bb64dafb8b0fa4780325f4 
>   src/slave/flags.hpp 28f6482c38a2d388e624726d5e7bccc5cb260fce 
>   src/slave/flags.cpp e172aa526cfd38f4f30efda22ef011146e5c1a7d 
>   src/slave/slave.cpp 14de72fa4a8746504a251d735bf56041b934df40 
> 
> 
> Diff: https://reviews.apache.org/r/59460/diff/1/
> 
> 
> Testing
> ---
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 59467: Document new Fetcher metrics.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59467/
---

Review request for mesos and Mesos Reviewbot.


Bugs: MESOS-7524
https://issues.apache.org/jira/browse/MESOS-7524


Repository: mesos


Description
---

Document new Fetcher metrics.


Diffs
-

  docs/monitoring.md a027f4905a0e6e41ff4e1348d34fd7aa5f1cbe61 


Diff: https://reviews.apache.org/r/59467/diff/1/


Testing
---

None.


Thanks,

James Peach

Re: Review Request 59466: Add metrics check to Fetcher tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59466/
---

(Updated May 22, 2017, 9:18 p.m.)


Review request for mesos and Mesos Reviewbot.


Bugs: MESOS-7524
https://issues.apache.org/jira/browse/MESOS-7524


Repository: mesos


Description
---

Add metrics check to Fetcher tests.


Diffs
-

  src/tests/fetcher_tests.cpp 27ea7244c713934ef5a721ec133804a006dcb26e 


Diff: https://reviews.apache.org/r/59466/diff/1/


Testing
---

make check (Fedora 25)


Thanks,

James Peach

Review Request 59466: Add metrics check to Fetcher tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59466/
---

Review request for mesos.


Repository: mesos


Description
---

Add metrics check to Fetcher tests.


Diffs
-

  src/tests/fetcher_tests.cpp 27ea7244c713934ef5a721ec133804a006dcb26e 


Diff: https://reviews.apache.org/r/59466/diff/1/


Testing
---

make check (Fedora 25)


Thanks,

James Peach

Review Request 59463: Added test for agent ping timeout during agent recovery.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59463/
---

Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-7540
https://issues.apache.org/jira/browse/MESOS-7540


Repository: mesos


Description
---

This patch adds a new test, `SlaveRecoveryTest.PingTimeoutDuringRecovery`,
which verifies that the agent will reply to pings from the master while it
is performing recovery.


Diffs
-

  src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 


Diff: https://reviews.apache.org/r/59463/diff/1/


Testing
---

`GTEST_FILTER="*PingTimeoutDuringRecovery*" bin/mesos-tests.sh 
--gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann

Review Request 59464: Add fetch success metric.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59464/
---

Review request for mesos and Mesos Reviewbot.


Bugs: MESOS-7524
https://issues.apache.org/jira/browse/MESOS-7524


Repository: mesos


Description
---

Add fetch success metric.


Diffs
-

  src/slave/containerizer/fetcher.hpp 9e3018dc087ed55c61b2824d0105bc5339b83043 
  src/slave/containerizer/fetcher.cpp a910fea5a5556afb376524c5bb2ff98d7d84e611 


Diff: https://reviews.apache.org/r/59464/diff/1/


Testing
---

make check (Fedora 25)


Thanks,

James Peach

Re: Review Request 59318: Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/
---

(Updated May 22, 2017, 4:55 p.m.)


Review request for mesos and Gilbert Song.


Changes
---

Addressed Gilbert's comments


Summary (updated)
-

Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.


Repository: mesos


Description (updated)
---

Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.


Diffs (updated)
-

  src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 


Diff: https://reviews.apache.org/r/59318/diff/2/

Changes: https://reviews.apache.org/r/59318/diff/1-2/


Testing
---

Make check with an without the patch.


Thanks,

Kapil Arya

Re: Review Request 59434: Added a few master log lines.

[Jiang Yan Xu]

> On May 22, 2017, 9:42 a.m., James Peach wrote:
> > src/master/master.cpp
> > Lines 5615 (patched)
> > 
> >
> > This basically duplicates the INFO message below. Why do we need both?

I frankly did it for consistency between this and the re-register case.


> On May 22, 2017, 9:42 a.m., James Peach wrote:
> > src/master/master.cpp
> > Line 5946 (original), 5955 (patched)
> > 
> >
> > This basically duplicates the INFO message on line 6127. Why do we need 
> > both?

I guess you mean 6137:

```
  LOG(INFO) << "Re-registered agent " << *slave
<< " with " << slave->info.resources();
```

A lot is done between these lines (building the recovered tasks) and this 
indirectly gives us the time that is spent on these lines.

This information is normally not informative enough to warrant a LOG(INFO) so 
that's why I chose VLOG(1).


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59434/#review175652
---


On May 21, 2017, 10:38 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59434/
> ---
> 
> (Updated May 21, 2017, 10:38 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - On the agent (re)-registration code paths.
> - Could be helpful for triaging performance issues.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 02affe2d6dc76ef91363df04d8d8cbed3beaf34f 
> 
> 
> Diff: https://reviews.apache.org/r/59434/diff/1/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 59001: Added volume secret isolator.

[Kapil Arya]

> On May 22, 2017, 1:04 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/volume/secret.cpp
> > Lines 264 (patched)
> > 
> >
> > Do we have to do `force` move?

Yeah, in case the same secret is specified twice in two different volume protos.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59001/#review175639
---


On May 22, 2017, 4:55 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59001/
> ---
> 
> (Updated May 22, 2017, 4:55 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added volume secret isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a038c0b919cb7ac46c99b37bcfb839217b4ab9b4 
>   src/Makefile.am 3e71393c4a8e50c9c6f703bbef7f7bdc6a53e6ee 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 50a63b58b4960729316b0b5685793ce18ee5ce93 
>   src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION 
>   src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 
>   src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59001/diff/10/
> 
> 
> Testing
> ---
> 
> Added new tests an ran `make check`.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 59000: Added environment secret isolator.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59000/
---

(Updated May 22, 2017, 4:54 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone.


Changes
---

Addressed Vinod's comment


Repository: mesos


Description
---

Added environment secret isolator.


Diffs (updated)
-

  src/CMakeLists.txt a038c0b919cb7ac46c99b37bcfb839217b4ab9b4 
  src/Makefile.am 3e71393c4a8e50c9c6f703bbef7f7bdc6a53e6ee 
  src/launcher/executor.cpp 9971a67d75b33002127fd1decad59371fdf1e719 
  src/slave/containerizer/mesos/containerizer.cpp 
50a63b58b4960729316b0b5685793ce18ee5ce93 
  src/slave/containerizer/mesos/isolators/environment_secret.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/environment_secret.cpp PRE-CREATION 
  src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
  src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59000/diff/8/

Changes: https://reviews.apache.org/r/59000/diff/7-8/


Testing
---

Added a new test and ran `make check`.


Thanks,

Kapil Arya

Re: Review Request 59001: Added volume secret isolator.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59001/
---

(Updated May 22, 2017, 4:55 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Addressed Gilbert's comments


Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
---

Added volume secret isolator.


Diffs (updated)
-

  src/CMakeLists.txt a038c0b919cb7ac46c99b37bcfb839217b4ab9b4 
  src/Makefile.am 3e71393c4a8e50c9c6f703bbef7f7bdc6a53e6ee 
  src/slave/containerizer/mesos/containerizer.cpp 
50a63b58b4960729316b0b5685793ce18ee5ce93 
  src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION 
  src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
  src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION 
  src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 
  src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59001/diff/10/

Changes: https://reviews.apache.org/r/59001/diff/9-10/


Testing
---

Added new tests an ran `make check`.


Thanks,

Kapil Arya

Re: Review Request 58999: Added --secret_resolver flag to agent.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58999/
---

(Updated May 22, 2017, 4:54 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Addressed Vinod's comment


Repository: mesos


Description
---

Updated Containerizer to accept SecretResolver.


Diffs (updated)
-

  src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3 
  src/slave/containerizer/containerizer.hpp 
4c31a1f5c853c1dc66480c7b4c867a87a1bb5c41 
  src/slave/containerizer/containerizer.cpp 
9024371b6c4228f0903cfeef3bbec736e1a425f8 
  src/slave/containerizer/mesos/containerizer.hpp 
04ab997454534b8e5e821b53b83e166e5018e11c 
  src/slave/containerizer/mesos/containerizer.cpp 
50a63b58b4960729316b0b5685793ce18ee5ce93 
  src/slave/flags.hpp 28f6482c38a2d388e624726d5e7bccc5cb260fce 
  src/slave/flags.cpp e172aa526cfd38f4f30efda22ef011146e5c1a7d 
  src/slave/main.cpp cc833279ae0a1c2e62166afe059cad14eb9978a4 


Diff: https://reviews.apache.org/r/58999/diff/8/

Changes: https://reviews.apache.org/r/58999/diff/7-8/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 59460: Added new agent flag 'executor_reregister_timeout'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59460/
---

(Updated May 22, 2017, 6:46 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-7540
https://issues.apache.org/jira/browse/MESOS-7540


Repository: mesos


Description
---

This patch adds a new agent flag, 'executor_reregister_timeout',
which allows operators to configure the time which an executor has
to reregister with the agent before it will be considered gone and
terminated.


Diffs
-

  src/slave/constants.hpp 9c1d7245c0a8ecd657bb64dafb8b0fa4780325f4 
  src/slave/flags.hpp 28f6482c38a2d388e624726d5e7bccc5cb260fce 
  src/slave/flags.cpp e172aa526cfd38f4f30efda22ef011146e5c1a7d 
  src/slave/slave.cpp 14de72fa4a8746504a251d735bf56041b934df40 


Diff: https://reviews.apache.org/r/59460/diff/1/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59461/
---

(Updated May 22, 2017, 6:46 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-7540
https://issues.apache.org/jira/browse/MESOS-7540


Repository: mesos


Description
---

This patch updates the tests to make use of the new
'executor_reregister_timeout' agent flag.


Diffs
-

  src/tests/containerizer/port_mapping_tests.cpp 
a528382e8b4831b9c7e8dcc877a5e242909f0cd5 
  src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650 
  src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
  src/tests/persistent_volume_tests.cpp 
ef0085316d76bd05a86b7930446f6439b2101645 
  src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
  src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5 


Diff: https://reviews.apache.org/r/59461/diff/1/


Testing
---

`make check`


Thanks,

Greg Mann

Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59461/
---

Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Repository: mesos


Description
---

This patch updates the tests to make use of the new
'executor_reregister_timeout' agent flag.


Diffs
-

  src/tests/containerizer/port_mapping_tests.cpp 
a528382e8b4831b9c7e8dcc877a5e242909f0cd5 
  src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650 
  src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
  src/tests/persistent_volume_tests.cpp 
ef0085316d76bd05a86b7930446f6439b2101645 
  src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
  src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5 


Diff: https://reviews.apache.org/r/59461/diff/1/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 59458: Avoid validation of agent re-registration message if possible.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59458/
---

(Updated May 22, 2017, 6:37 p.m.)


Review request for mesos, Neil Conway and Jiang Yan Xu.


Summary (updated)
-

Avoid validation of agent re-registration message if possible.


Bugs: MESOS-7538
https://issues.apache.org/jira/browse/MESOS-7538


Repository: mesos


Description (updated)
---

If we already have a re-registration in flight from this agent, we don't
need to validate the re-registration message since it will be dropped
anyway. Agent re-registration is a hot path after master failover,
and validating the re-registration message can be somewhat expensive.


Diffs (updated)
-

  src/master/master.cpp e0705a532dfffd379a5bfdc3d2b095bf1c9da880 


Diff: https://reviews.apache.org/r/59458/diff/2/

Changes: https://reviews.apache.org/r/59458/diff/1-2/


Testing
---

make check (Fedora 25)


Thanks,

James Peach

Review Request 59460: Added new agent flag 'executor_reregister_timeout'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59460/
---

Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Repository: mesos


Description
---

This patch adds a new agent flag, 'executor_reregister_timeout',
which allows operators to configure the time which an executor has
to reregister with the agent before it will be considered gone and
terminated.


Diffs
-

  src/slave/constants.hpp 9c1d7245c0a8ecd657bb64dafb8b0fa4780325f4 
  src/slave/flags.hpp 28f6482c38a2d388e624726d5e7bccc5cb260fce 
  src/slave/flags.cpp e172aa526cfd38f4f30efda22ef011146e5c1a7d 
  src/slave/slave.cpp 14de72fa4a8746504a251d735bf56041b934df40 


Diff: https://reviews.apache.org/r/59460/diff/1/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 59458: Belay the reregistration validation if it is already in flight.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59458/#review175675
---


Ship it!




Commit summary seems a bit confusing to me. How about

"Avoided validation of agent re-registration in some cases.

If the agent is still being authorized, don't bother validating the
agent's re-registration message, since we are going to drop it
anyway. Agent re-registration is a hot path after master failover,
and validating the re-registration message is somewhat expensive."

- Neil Conway


On May 22, 2017, 6:12 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59458/
> ---
> 
> (Updated May 22, 2017, 6:12 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7538
> https://issues.apache.org/jira/browse/MESOS-7538
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If we already have a re-registration in flight from this agent, we
> don't need to validate the re-registration message since it will be
> dropped anyway.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp e0705a532dfffd379a5bfdc3d2b095bf1c9da880 
> 
> 
> Diff: https://reviews.apache.org/r/59458/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 59458: Belay the reregistration validation if it is already in flight.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59458/
---

Review request for mesos, Neil Conway and Jiang Yan Xu.


Bugs: MESOS-7538
https://issues.apache.org/jira/browse/MESOS-7538


Repository: mesos


Description
---

If we already have a re-registration in flight from this agent, we
don't need to validate the re-registration message since it will be
dropped anyway.


Diffs
-

  src/master/master.cpp e0705a532dfffd379a5bfdc3d2b095bf1c9da880 


Diff: https://reviews.apache.org/r/59458/diff/1/


Testing
---

make check (Fedora 25)


Thanks,

James Peach

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59018/#review175669
---



Bad patch!

Reviews applied: [59018, 59017, 59016, 59141, 59015, 59014, 59013, 59012, 
59011, 59010, 59318, 59001, 59000, 58999, 58760, 58759, 58925, 58924, 58923]

Failed command: python support/apply-reviews.py -n -r 59000

Error:
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:353
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply

Full log: NotAvailableYet\console

- Mesos Reviewbot Windows


On May 22, 2017, 6:04 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59018/
> ---
> 
> (Updated May 22, 2017, 6:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported Image::Secret in docker URI fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 
> 
> 
> Diff: https://reviews.apache.org/r/59018/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> Manually tested using mesos-execute with task group. Verified that pulling 
> separate private image from different registries using different image 
> secrets works correctly.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59018/
---

(Updated May 22, 2017, 11:04 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088


Repository: mesos


Description
---

Supported Image::Secret in docker URI fetcher plugin.


Diffs (updated)
-

  src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 


Diff: https://reviews.apache.org/r/59018/diff/4/

Changes: https://reviews.apache.org/r/59018/diff/3-4/


Testing
---

make check

Manually tested using mesos-execute with task group. Verified that pulling 
separate private image from different registries using different image secrets 
works correctly.


Thanks,

Gilbert Song

Re: Review Request 59017: Added support for docker spec helper 'parseAuthConfig()'.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/
---

(Updated May 22, 2017, 11:03 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088


Repository: mesos


Description
---

Added support for docker spec helper 'parseAuthConfig()'.


Diffs (updated)
-

  include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03 
  src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17 
  src/tests/containerizer/docker_spec_tests.cpp 
d812592261aa46256bea287e768ca1f1c586aeff 


Diff: https://reviews.apache.org/r/59017/diff/3/

Changes: https://reviews.apache.org/r/59017/diff/2-3/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 59141: Added new parameter 'data' to the URI fetcher interface.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59141/
---

(Updated May 22, 2017, 11:03 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088


Repository: mesos


Description
---

Added new parameter 'data' to the URI fetcher interface.


Diffs (updated)
-

  include/mesos/uri/fetcher.hpp ebf86c78b794a6ef46332df788a1317bbec5d983 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
  src/tests/uri_fetcher_tests.cpp 4892909bbb47f60c95d8d9f0f175a5db32d4a164 
  src/uri/fetcher.cpp f4d1a4c69e910260dc536aa42ae03fd17403b060 
  src/uri/fetchers/copy.hpp f4a2fb3d5156e5ebfdf7c4202f8dc9b1cd1d6ac7 
  src/uri/fetchers/copy.cpp 5e1470503f4fa0e543680c93b2ad3e36351afc1c 
  src/uri/fetchers/curl.hpp 083f155092d159cd83069bfdfd905d679e9ab57c 
  src/uri/fetchers/curl.cpp 24b53c77946170cba45152c458d85b6fddfce9f8 
  src/uri/fetchers/docker.hpp 65e01cba1d41688a8ee5da73d1d6f57515fbc7f5 
  src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 
  src/uri/fetchers/hadoop.hpp 4923dc6491d7cc6efc6ced4f5356af9f945ba5d2 
  src/uri/fetchers/hadoop.cpp 3c5ffe607c92ea1ab66ba261bd70031f2907cea6 


Diff: https://reviews.apache.org/r/59141/diff/3/

Changes: https://reviews.apache.org/r/59141/diff/2-3/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 59141: Added new parameter 'data' to the URI fetcher interface.

[Gilbert Song]

> On May 18, 2017, 12:54 a.m., Qian Zhang wrote:
> > include/mesos/uri/fetcher.hpp
> > Line 72 (original), 74 (patched)
> > 
> >
> > Suggest to add a description for the newly introduced parameter `data` 
> > to explain what it is for.

Thanks, Qian. That is the reason why I added a TODO below. This interface for 
the URI fetcher is not finalized. We will update it asap.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59141/#review175360
---


On May 12, 2017, 4:19 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59141/
> ---
> 
> (Updated May 12, 2017, 4:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added new parameter 'data' to the URI fetcher interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp ebf86c78b794a6ef46332df788a1317bbec5d983 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
>   src/uri/fetcher.cpp f4d1a4c69e910260dc536aa42ae03fd17403b060 
>   src/uri/fetchers/copy.hpp f4a2fb3d5156e5ebfdf7c4202f8dc9b1cd1d6ac7 
>   src/uri/fetchers/copy.cpp 5e1470503f4fa0e543680c93b2ad3e36351afc1c 
>   src/uri/fetchers/curl.hpp 083f155092d159cd83069bfdfd905d679e9ab57c 
>   src/uri/fetchers/curl.cpp 24b53c77946170cba45152c458d85b6fddfce9f8 
>   src/uri/fetchers/docker.hpp 65e01cba1d41688a8ee5da73d1d6f57515fbc7f5 
>   src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 
>   src/uri/fetchers/hadoop.hpp 4923dc6491d7cc6efc6ced4f5356af9f945ba5d2 
>   src/uri/fetchers/hadoop.cpp 3c5ffe607c92ea1ab66ba261bd70031f2907cea6 
> 
> 
> Diff: https://reviews.apache.org/r/59141/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59420: Added some comments to ContainerConfig protobuf.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59420/#review175666
---


Ship it!




Ship It!

- Jie Yu


On May 19, 2017, 10:09 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59420/
> ---
> 
> (Updated May 19, 2017, 10:09 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These comments clarify some of the expectations of each field
> of the `ContainerConfig` protobuf, especially where fields
> are duplicated based on other fields.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 0f96334c236027780db1d88807e09685ccda4562 
> 
> 
> Diff: https://reviews.apache.org/r/59420/diff/1/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 59016: Fixed the comment style issue in docker/spec.hpp.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59016/
---

(Updated May 22, 2017, 11 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Changes
---

Rebased.


Repository: mesos


Description
---

Fixed the comment style issue in docker/spec.hpp.


Diffs (updated)
-

  include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03 


Diff: https://reviews.apache.org/r/59016/diff/2/

Changes: https://reviews.apache.org/r/59016/diff/1-2/


Testing
---

N/A


Thanks,

Gilbert Song

Re: Review Request 59012: Implemented passing the secret resolver to registry puller.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59012/
---

(Updated May 22, 2017, 10:58 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088


Repository: mesos


Description
---

Implemented passing the secret resolver to registry puller.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
97837c83cc223950750e4cd088f4da067023c96c 
  src/slave/containerizer/mesos/provisioner/appc/store.hpp 
15c79e9401a821e445fbd32b34503e4fb0014d42 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
09a40a5835454bb7519d11bae4a851337a89b935 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
6dacdb1403433a37dd31a93d4ff2e37d4685eb87 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
ac9dae8ecbb897b8ff942d11ac70281a63e06831 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
62ddb7a332030f3116477408d8b16c19e434c159 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
  src/slave/containerizer/mesos/provisioner/docker/store.hpp 
e1abff19c8877ad07900bb2f44deca1cdda41f58 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
7d6c1b93a2c0e265b9344a0fc27f1cf4ed5325f2 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
6509ee48c89e40702d37057d1d3a17e9a6ebab58 
  src/slave/containerizer/mesos/provisioner/store.hpp 
82a9be64264ae829773c1e2e8a4360f78641cbf6 
  src/slave/containerizer/mesos/provisioner/store.cpp 
7141d63fcf2dbc3fbf00508c7f92945aab014fb2 


Diff: https://reviews.apache.org/r/59012/diff/5/

Changes: https://reviews.apache.org/r/59012/diff/4-5/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 59011: Fixed docker/appc store 'using' format.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59011/
---

(Updated May 22, 2017, 10:57 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Changes
---

Rebased.


Repository: mesos


Description
---

Fixed docker/appc store 'using' format.


Diffs (updated)
-

  include/mesos/appc/spec.hpp e9430df03b49f49d367e19b18991ead77fe5b830 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
09a40a5835454bb7519d11bae4a851337a89b935 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 
  src/slave/containerizer/mesos/provisioner/store.cpp 
7141d63fcf2dbc3fbf00508c7f92945aab014fb2 


Diff: https://reviews.apache.org/r/59011/diff/2/

Changes: https://reviews.apache.org/r/59011/diff/1-2/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 59010: Updated protobuf comments for Image::Secret.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59010/
---

(Updated May 22, 2017, 10:56 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Changes
---

Rebased.


Repository: mesos


Description
---

Updated protobuf comments for Image::Secret.


Diffs (updated)
-

  include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154 
  include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3 


Diff: https://reviews.apache.org/r/59010/diff/3/

Changes: https://reviews.apache.org/r/59010/diff/2-3/


Testing
---

N/A.


Thanks,

Gilbert Song

Re: Review Request 59419: Updated mesos-local work directory structure.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59419/#review175660
---


Ship it!




Ship It!

- Jie Yu


On May 19, 2017, 10:07 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59419/
> ---
> 
> (Updated May 19, 2017, 10:07 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7304
> https://issues.apache.org/jira/browse/MESOS-7304
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This combines the `--work_dir` and `--runtime_dir` flags for the
> mesos-local helper (**not** the Agent flags, which have the same name).
> Only the `--work_dir` will remain.
> 
> The new directory structure will be the following:
> 
>   work_dir (mesos-local flag)
>   |-- agents
>   |   |-- 0
>   |   |   |-- fetch (Agent --fetcher_cache_dir flag)
>   |   |   |-- run   (Agent --runtime_dir flag)
>   |   |   |-- work  (Agent --work_dir flag)
>   |   |-- 1
>   |   |   ...
>   |-- master
> 
> 
> Diffs
> -
> 
>   src/local/flags.hpp 0cef5ac730d19b00f78869e987993a71e464ca05 
>   src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3 
> 
> 
> Diff: https://reviews.apache.org/r/59419/diff/1/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 59017: Added support for docker spec helper 'parseAuthConfig()'.

[Gilbert Song]

> On May 9, 2017, 4:25 p.m., Vinod Kone wrote:
> > include/mesos/docker/spec.hpp
> > Lines 83 (patched)
> > 
> >
> > no unit test for this?
> 
> Gilbert Song wrote:
> This helper was tested in unit test when the parameter is a JSON object. 
> Thought no duplicate unit test needed for the `string` parameter since they 
> are the same implementation.
> 
> Chun-Hung Hsiao wrote:
> Since the string version calls the JSON version, how about just testing 
> the string version instead so we have both functions covered?

good idea.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/#review174398
---


On May 10, 2017, 5:47 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59017/
> ---
> 
> (Updated May 10, 2017, 5:47 a.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for docker spec helper 'parseAuthConfig()'.
> 
> 
> Diffs
> -
> 
>   include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03 
>   src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17 
> 
> 
> Diff: https://reviews.apache.org/r/59017/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59001: Added volume secret isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59001/#review175639
---


Fix it, then Ship it!




LGTM! Fix it, ship it!


src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 29-34 (patched)


Please re-order:

```
#include 
#include 
#include 

#include 
#include 
```



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 164 (patched)


Just a nit:

`const Secret&`



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 264 (patched)


Do we have to do `force` move?


- Gilbert Song


On May 16, 2017, 12:22 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59001/
> ---
> 
> (Updated May 16, 2017, 12:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added volume secret isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt eef718d95b5d8e051a5094369dc9b4532bc307ff 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 97837c83cc223950750e4cd088f4da067023c96c 
>   src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION 
>   src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 
>   src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59001/diff/9/
> 
> 
> Testing
> ---
> 
> Added new tests an ran `make check`.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 59454: Adjust test to account for changes to bytes.hpp.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59454/
---

Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil 
Conway.


Bugs: MESOS-7520
https://issues.apache.org/jira/browse/MESOS-7520


Repository: mesos


Description
---

This fixes a test that uses the old inheritance types from `bytes.hpp`.


Diffs
-

  src/tests/persistent_volume_tests.cpp ef0085316 


Diff: https://reviews.apache.org/r/59454/diff/1/


Testing
---

`./bootstrap && mkdir build && cd build && ../configure --disable-python 
--disable-java --disable-optimize --disable-hardening &&  make check -j$(nproc)`


Thanks,

Aaron Wood

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/
---

(Updated May 22, 2017, 4:56 p.m.)


Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil 
Conway.


Bugs: MESOS-7520
https://issues.apache.org/jira/browse/MESOS-7520


Repository: mesos


Description
---

Many of the `constexpr` variables fail to compile with errors such as `error: 
'Megabytes(32).Megabytes::' is not a constant expression because it 
refers to an incompletely initialized variable`. 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829

This patch changes around the `Bytes` class a bit by getting rid of the small 
classes that extend `Bytes`.


Diffs
-

  3rdparty/stout/include/stout/bytes.hpp 98223db50 


Diff: https://reviews.apache.org/r/59413/diff/4/


Testing
---

`./bootstrap && mkdir build && cd build && ../configure --disable-python 
--disable-java --disable-optimize --disable-hardening &&  make -j$(nproc)`


Thanks,

Aaron Wood

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/
---

(Updated May 22, 2017, 4:52 p.m.)


Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil 
Conway.


Changes
---

Rework patch to only target bytes.hpp.


Summary (updated)
-

Fix bytes.hpp constexpr compilation failure with GCC 7.1.


Bugs: MESOS-7520
https://issues.apache.org/jira/browse/MESOS-7520


Repository: mesos


Description (updated)
---

Many of the `constexpr` variables fail to compile with errors such as `error: 
'Megabytes(32).Megabytes::' is not a constant expression because it 
refers to an incompletely initialized variable`. 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829

This patch changes around the `Bytes` class a bit by getting rid of the small 
classes that extend `Bytes`.


Diffs (updated)
-

  3rdparty/stout/include/stout/bytes.hpp 98223db50 


Diff: https://reviews.apache.org/r/59413/diff/4/

Changes: https://reviews.apache.org/r/59413/diff/3-4/


Testing
---

`./bootstrap && mkdir build && cd build && ../configure --disable-python 
--disable-java --disable-optimize --disable-hardening &&  make -j$(nproc)`


Thanks,

Aaron Wood

Re: Review Request 59434: Added a few master log lines.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59434/#review175652
---




src/master/master.cpp
Lines 5615 (patched)


This basically duplicates the INFO message below. Why do we need both?



src/master/master.cpp
Line 5946 (original), 5955 (patched)


This basically duplicates the INFO message on line 6127. Why do we need 
both?


- James Peach


On May 22, 2017, 5:38 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59434/
> ---
> 
> (Updated May 22, 2017, 5:38 a.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - On the agent (re)-registration code paths.
> - Could be helpful for triaging performance issues.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 02affe2d6dc76ef91363df04d8d8cbed3beaf34f 
> 
> 
> Diff: https://reviews.apache.org/r/59434/diff/1/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/#review175651
---



Can you please split this into 2 separate patches for `Bytes` and `Duration`?

- James Peach


On May 19, 2017, 7 p.m., Aaron Wood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59413/
> ---
> 
> (Updated May 19, 2017, 7 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and 
> Neil Conway.
> 
> 
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Many of the `constexpr` variables fail to compile with errors such as `error: 
> 'Megabytes(32).Megabytes::' is not a constant expression because 
> it refers to an incompletely initialized variable`. 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
> 
> This patch changes around the `Bytes` class a bit by getting rid of the small 
> classes that extend `Bytes`. Additionally, any usage of the `Duration` class 
> has been adjusted to not instantiate using the base type (which triggers the 
> issue along with `constexpr`).
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/bytes.hpp 98223db50 
>   src/master/constants.hpp 725680b1e 
>   src/sched/constants.hpp 9edb25b38 
>   src/sched/sched.cpp ef73c1dcc 
>   src/scheduler/constants.hpp e3da12646 
>   src/slave/constants.hpp 9c1d7245c 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 929b7e0b7 
>   src/slave/slave.cpp 14de72fa4 
>   src/slave/status_update_manager.cpp 0cd88ac3a 
> 
> 
> Diff: https://reviews.apache.org/r/59413/diff/3/
> 
> 
> Testing
> ---
> 
> `./bootstrap && mkdir build && cd build && ../configure --disable-python 
> --disable-java --disable-optimize --disable-hardening &&  make -j$(nproc)`
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>

Re: Review Request 59100: Enabled authorization for v1 API call GET_MAINTENANCE_SCHEDULE.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59100/
---

(Updated May 22, 2017, 6:11 p.m.)


Review request for mesos, Adam B and Greg Mann.


Bugs: MESOS-7415
https://issues.apache.org/jira/browse/MESOS-7415


Repository: mesos


Description (updated)
---

Enables the use of authorization for the `GET_MAINTENANCE_SCHEDULE`
v1 API call, using the ACL `GetMaintenanceSchedule` and the action
of the same name as the API call.

It also updates the `ApiTests` to take into account the authorization
case.


Diffs (updated)
-

  src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da 
  src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 
  src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09 


Diff: https://reviews.apache.org/r/59100/diff/3/

Changes: https://reviews.apache.org/r/59100/diff/2-3/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 59099: Enabled authorization for v1 API call UPDATE_MAINTENANCE_SCHEDULE.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59099/
---

(Updated May 22, 2017, 6:09 p.m.)


Review request for mesos, Adam B and Greg Mann.


Bugs: MESOS-7415
https://issues.apache.org/jira/browse/MESOS-7415


Repository: mesos


Description (updated)
---

Enables the use of authorization for the `UPDATE_MAINTENANCE_SCHEDULE`
v1 API call, using the ACL `UpdateMaintenanceSchedule` and the action
of the same name as the API call.

It also updates the `ApiTests` to take into account the authorization
case.


Diffs (updated)
-

  src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da 
  src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 
  src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09 


Diff: https://reviews.apache.org/r/59099/diff/3/

Changes: https://reviews.apache.org/r/59099/diff/2-3/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 58964: Added authorization support for operator endpoints.

[Alexander Rojas]

> On May 17, 2017, 11:57 a.m., Adam B wrote:
> > include/mesos/authorizer/acls.proto
> > Line 354 (original), 354 (patched)
> > 
> >
> > Should this be `agents` plural?
> 
> Alexander Rojas wrote:
> Probably, but if we want to change it it should be a blocker for 1.3.0. 
> Once it lands we will have to go through a six months deprecation cycle.

I created [r/59453/](https://reviews.apache.org/r/59453/), and I am talking 
with the release admins to see if we can change it before release.


> On May 17, 2017, 11:57 a.m., Adam B wrote:
> > include/mesos/authorizer/authorizer.proto
> > Lines 58 (patched)
> > 
> >
> > Unused?!?
> 
> Alexander Rojas wrote:
> sorry, original I was planning to have the request use the machine ID to 
> be authorized. I still think it makes sense to give the machine ID, which the 
> authorizer could ignore. Let's decide on that.

Well, I just modify it so authorization depends on the machine id, although the 
local authorizer doesn't use it.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58964/#review175224
---


On May 22, 2017, 6:05 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58964/
> ---
> 
> (Updated May 22, 2017, 6:05 p.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Bugs: MESOS-7415
> https://issues.apache.org/jira/browse/MESOS-7415
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the actions `UPDATE_MAINTENANCE_SCHEDULE`,
> `GET_MAINTENANCE_SCHEDULE`, `START_MAINTENANCE`, `STOP_MAINTENANCE`
> and `GET_MAINTENANCE_STATUS` to the authorizer API as well as the
> necesary code to handle these new actions.
> 
> While the interface `mesos::Authorizer` takes an object with type
> `MachineID` to perform authorization; the default implementation of
> the interface `mesos::LocalAuthorizer` ignores the object choosing the
> semantics of allow maintenance on all nodes or none. This was done to
> extend the capacities of custom authorizers which may have special
> rules for authorization.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> ae0b1ea2e6417d186b1606542d75f3a20e0811db 
>   include/mesos/authorizer/authorizer.hpp 
> 4a7376fb6ca2be0a513ad54f56eea3cf8cdd024d 
>   include/mesos/authorizer/authorizer.proto 
> c9184d151befa4cea9bdebb36a315c760e6424b2 
>   src/authorizer/local/authorizer.cpp 
> 89aaf4b712d337d519445c922606789c334e5101 
>   src/tests/authorization_tests.cpp 32aa6ac4db7854507127ea2fb88b3e92daa277c0 
> 
> 
> Diff: https://reviews.apache.org/r/58964/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 58964: Added authorization support for operator endpoints.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58964/
---

(Updated May 22, 2017, 6:05 p.m.)


Review request for mesos, Adam B and Greg Mann.


Bugs: MESOS-7415
https://issues.apache.org/jira/browse/MESOS-7415


Repository: mesos


Description (updated)
---

Adds the actions `UPDATE_MAINTENANCE_SCHEDULE`,
`GET_MAINTENANCE_SCHEDULE`, `START_MAINTENANCE`, `STOP_MAINTENANCE`
and `GET_MAINTENANCE_STATUS` to the authorizer API as well as the
necesary code to handle these new actions.

While the interface `mesos::Authorizer` takes an object with type
`MachineID` to perform authorization; the default implementation of
the interface `mesos::LocalAuthorizer` ignores the object choosing the
semantics of allow maintenance on all nodes or none. This was done to
extend the capacities of custom authorizers which may have special
rules for authorization.


Diffs (updated)
-

  include/mesos/authorizer/acls.proto ae0b1ea2e6417d186b1606542d75f3a20e0811db 
  include/mesos/authorizer/authorizer.hpp 
4a7376fb6ca2be0a513ad54f56eea3cf8cdd024d 
  include/mesos/authorizer/authorizer.proto 
c9184d151befa4cea9bdebb36a315c760e6424b2 
  src/authorizer/local/authorizer.cpp 89aaf4b712d337d519445c922606789c334e5101 
  src/tests/authorization_tests.cpp 32aa6ac4db7854507127ea2fb88b3e92daa277c0 


Diff: https://reviews.apache.org/r/58964/diff/4/

Changes: https://reviews.apache.org/r/58964/diff/3-4/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58955/
---

(Updated May 22, 2017, 5:57 p.m.)


Review request for mesos, Adam B and Greg Mann.


Bugs: MESOS-7414
https://issues.apache.org/jira/browse/MESOS-7414


Repository: mesos


Description
---

Enables authorization in the v1 API call `SET_LOGGING_LEVEL` following
the existing implementation for the agent call with the same name.
Likewise it reuses the authorizer action `SET_LOG_LEVEL`.


Diffs (updated)
-

  src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da 
  src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09 


Diff: https://reviews.apache.org/r/58955/diff/4/

Changes: https://reviews.apache.org/r/58955/diff/3-4/


Testing
---

make check


Thanks,

Alexander Rojas

Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59453/
---

Review request for mesos, Adam B, Greg Mann, Michael Park, and Neil Conway.


Repository: mesos


Description
---

Renames the field `RegisterAgent.agent` to `RegisterAgent.agents` in
order to come make it consistent with other ACLs.


Diffs
-

  include/mesos/authorizer/acls.proto ae0b1ea2e6417d186b1606542d75f3a20e0811db 
  src/authorizer/local/authorizer.cpp 89aaf4b712d337d519445c922606789c334e5101 
  src/tests/authorization_tests.cpp 32aa6ac4db7854507127ea2fb88b3e92daa277c0 
  src/tests/master_authorization_tests.cpp 
e4233c19b1d9e3e2734259503d0daec4ce243667 
  src/tests/script.cpp 791d331d6bdf178098b2ce0dfb185f9128632459 


Diff: https://reviews.apache.org/r/59453/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas