Re: Review Request 59937: Added agent `--resource_provider_config_dir` flag.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59937/
---

(Updated June 30, 2017, 4:10 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.


Changes
---

addressed comments.


Bugs: MESOS-7571
https://issues.apache.org/jira/browse/MESOS-7571


Repository: mesos


Description
---

Added agent `--resource_provider_config_dir` flag.


Diffs (updated)
-

  docs/configuration.md 0eb696a949003ff11831aed5e4f4ab384cf9992e 
  src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
  src/slave/flags.cpp c84aa6724170bba46bbe8410b71d42a1626e 


Diff: https://reviews.apache.org/r/59937/diff/3/

Changes: https://reviews.apache.org/r/59937/diff/2-3/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 59936: Added streaming function for ResourceProviderInfo.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59936/
---

(Updated June 30, 2017, 4:02 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.


Changes
---

Addressed comments.


Repository: mesos


Description
---

Added streaming function for ResourceProviderInfo.


Diffs (updated)
-

  include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7 
  include/mesos/v1/mesos.hpp c2e6ec5c4fa06d0179d6aaf3371ace4b6e6dbdaf 
  src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9 
  src/v1/mesos.cpp 3b9f9b43e748159ae753880bbe4a5975814073ab 


Diff: https://reviews.apache.org/r/59936/diff/3/

Changes: https://reviews.apache.org/r/59936/diff/2-3/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 59935: Introduced a streaming function for a vector.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/
---

(Updated June 30, 2017, 3:54 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.


Changes
---

Addressed comments.


Repository: mesos


Description
---

Introduced a streaming function for a vector.


Diffs (updated)
-

  include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7 
  include/mesos/v1/mesos.hpp c2e6ec5c4fa06d0179d6aaf3371ace4b6e6dbdaf 
  src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9 
  src/v1/mesos.cpp 3b9f9b43e748159ae753880bbe4a5975814073ab 


Diff: https://reviews.apache.org/r/59935/diff/3/

Changes: https://reviews.apache.org/r/59935/diff/2-3/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 60545: Optimized use of DispatchEvent by lazy evaluation of method value.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60545/#review179327
---



@abudnik do you have any benchmarking around this change?

- James Peach


On June 29, 2017, 5:08 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60545/
> ---
> 
> (Updated June 29, 2017, 5:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> DispatchEvent contains value of pointer-to-member function stored in
> std::string, which is calculated each time DispatchEvent object is
> constructed. However, this value is used only in tests (see
> FUTURE_DISPATCH), imposing unnecessary overhead in production.
> This patch introduces lazy evolution of pointer-to-member by storing
> std::function object instead of std::string. Wrapper function captures
> value of pointer-to-member function and returns its stringified version
> on invocation. This function invoked by demand in test code, hence
> mitigating overhead of evaluation and storing value of pointer to
> member function.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/dispatch.hpp 
> 3a0793888dc0df5e3ec31b06f47cd920c71e0db9 
>   3rdparty/libprocess/include/process/event.hpp 
> 8afe6266eb0dc5a17af35d79efb6bfdf9e6a0ee9 
>   3rdparty/libprocess/include/process/gmock.hpp 
> e9af943b39436f365fe687301febb5c7fbefffc4 
>   3rdparty/libprocess/src/process.cpp 
> 8ff37d1b5781c42f96be2da391ed000158eea7b8 
> 
> 
> Diff: https://reviews.apache.org/r/60545/diff/1/
> 
> 
> Testing
> ---
> 
> 1. make check (mac os x 10.12, fedora 25)
> 2. internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 59935: Introduced a streaming function for a vector.

[Jie Yu]

> On June 9, 2017, 11:07 a.m., Benjamin Bannier wrote:
> > include/mesos/type_utils.hpp
> > Lines 382-384 (original), 394-396 (patched)
> > 
> >
> > Not yours, but this one has a similar problem.
> > 
> > I believe it should be possible to generalize this to e.g.,
> > 
> > template 
> > std::ostream& operator<<(
> > std::ostream& stream,
> > const hashmap& map)
> > {
> >   return stream << stringify(map);
> > }

I'll address that later.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/#review177462
---


On June 26, 2017, 4:31 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59935/
> ---
> 
> (Updated June 26, 2017, 4:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced a streaming function for a vector.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7 
>   src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9 
> 
> 
> Diff: https://reviews.apache.org/r/59935/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Quinn Leng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/
---

(Updated June 30, 2017, 1:37 a.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description (updated)
---

Added filtering to the '/tasks' endpoint.

Added query parameter support for '/tasks' endpoint.
To query a specific task, you can specify 'task_id'
and 'framework_id' in the query parameter. Thus the
format would look like 
{{'/tasks?framework_id=[framework id]_id=[task id]'}}

If no task id and framework id specified, it will return
the whole list of tasks just like previous version.


Diffs
-

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
  src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
  src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 


Diff: https://reviews.apache.org/r/60107/diff/11/


Testing
---

Passed "make check"
Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" 
--gtest_repeat=1000 --gtest_break_on_failure"


Thanks,

Quinn Leng

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

[Megha Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60105/
---

(Updated June 29, 2017, 11:42 p.m.)


Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-6223
https://issues.apache.org/jira/browse/MESOS-6223


Repository: mesos


Description
---

Prior to Mesos 1.4 we bypass the state recovery and
start as a new agent upon reboot. Starting in Mesos 1.4
we'll attempt to recover the slave state even after reboot
except for when there is a SlaveInfo mismatch.
Here, we cleanup the slave state for a rebooted agent if
there's been a SlaveInfo mismatch during recovery to
ensure that no other state is recovered and the
agent enventually registers as a new agent.


Diffs (updated)
-

  src/slave/slave.cpp f808458849bb9667a91abe18868751d377d36e0c 


Diff: https://reviews.apache.org/r/60105/diff/10/

Changes: https://reviews.apache.org/r/60105/diff/9-10/


Testing
---

make check done together with 60104 and 56895


Thanks,

Megha Sharma

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

[Megha Sharma]

> On June 24, 2017, 6:19 a.m., Jiang Yan Xu wrote:
> > src/slave/slave.cpp
> > Lines 6014 (patched)
> > 
> >
> > s/INFO/WARNING/.

Changed to warning. I was debating earlier between warning and info and felt 
info was more apt since mesos is already doing the remediation here.


- Megha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60105/#review178830
---


On June 29, 2017, 11:35 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60105/
> ---
> 
> (Updated June 29, 2017, 11:35 p.m.)
> 
> 
> Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6223
> https://issues.apache.org/jira/browse/MESOS-6223
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to Mesos 1.4 we bypass the state recovery and
> start as a new agent upon reboot. Starting in Mesos 1.4
> we'll attempt to recover the slave state even after reboot
> except for when there is a SlaveInfo mismatch.
> Here, we cleanup the slave state for a rebooted agent if
> there's been a SlaveInfo mismatch during recovery to
> ensure that no other state is recovered and the
> agent enventually registers as a new agent.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp f808458849bb9667a91abe18868751d377d36e0c 
> 
> 
> Diff: https://reviews.apache.org/r/60105/diff/9/
> 
> 
> Testing
> ---
> 
> make check done together with 60104 and 56895
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

[Megha Sharma]

> On June 24, 2017, 6:19 a.m., Jiang Yan Xu wrote:
> > src/slave/slave.cpp
> > Lines 6011-6020 (patched)
> > 
> >
> > Could you use the code in my comment:
> > 
> > ```
> >   if (!state->rebooted) {
> > return Failure(message);
> >   }
> > 
> >   LOG(WARNING) << "Falling back to recover as a new agent due to error: 
> > "
> ><< message;
> > 
> >   // Clean up the slave state to avoid any state recovery for the
> >   // old agent.
> >   slaveState = None();
> > ```
> > 
> > I'll comment on the specific lines for the reasoning.

Aah my bad, will get rid of the else.


- Megha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60105/#review178830
---


On June 29, 2017, 11:35 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60105/
> ---
> 
> (Updated June 29, 2017, 11:35 p.m.)
> 
> 
> Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6223
> https://issues.apache.org/jira/browse/MESOS-6223
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to Mesos 1.4 we bypass the state recovery and
> start as a new agent upon reboot. Starting in Mesos 1.4
> we'll attempt to recover the slave state even after reboot
> except for when there is a SlaveInfo mismatch.
> Here, we cleanup the slave state for a rebooted agent if
> there's been a SlaveInfo mismatch during recovery to
> ensure that no other state is recovered and the
> agent enventually registers as a new agent.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp f808458849bb9667a91abe18868751d377d36e0c 
> 
> 
> Diff: https://reviews.apache.org/r/60105/diff/9/
> 
> 
> Testing
> ---
> 
> make check done together with 60104 and 56895
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

[Megha Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60105/
---

(Updated June 29, 2017, 11:35 p.m.)


Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-6223
https://issues.apache.org/jira/browse/MESOS-6223


Repository: mesos


Description
---

Prior to Mesos 1.4 we bypass the state recovery and
start as a new agent upon reboot. Starting in Mesos 1.4
we'll attempt to recover the slave state even after reboot
except for when there is a SlaveInfo mismatch.
Here, we cleanup the slave state for a rebooted agent if
there's been a SlaveInfo mismatch during recovery to
ensure that no other state is recovered and the
agent enventually registers as a new agent.


Diffs (updated)
-

  src/slave/slave.cpp f808458849bb9667a91abe18868751d377d36e0c 


Diff: https://reviews.apache.org/r/60105/diff/9/

Changes: https://reviews.apache.org/r/60105/diff/8-9/


Testing
---

make check done together with 60104 and 56895


Thanks,

Megha Sharma

Re: Review Request 59128: Added initialization logic in Mesos agent for IPv6 flags.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59128/
---

(Updated June 29, 2017, 11:24 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Operators can now set the IPv6 address for the agent using the `--ip6`
and `--ip6_discovery_command` flags. Currently, the only place the agent
will use the IPv6 address would be to advertise v6 addresses for
containers running on the host network.


Diffs (updated)
-

  src/slave/main.cpp 66ae7db4039eedba7ff4eff51495384317c09354 


Diff: https://reviews.apache.org/r/59128/diff/3/

Changes: https://reviews.apache.org/r/59128/diff/2-3/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59127/
---

(Updated June 29, 2017, 11:25 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added IPv6 flags for Mesos agent.


Diffs (updated)
-

  src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
  src/slave/flags.cpp c84aa6724170bba46bbe8410b71d42a1626e 


Diff: https://reviews.apache.org/r/59127/diff/4/

Changes: https://reviews.apache.org/r/59127/diff/3-4/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 59688: Moved `net::IPNetwork` to `net::IP:Network`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59688/
---

(Updated June 29, 2017, 11:24 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Moved `net::IPNetwork` to `net::IP:Network`.


Diffs (updated)
-

  3rdparty/stout/include/stout/ip.hpp ee48befac8b9bb4956aec0c5bdebd69347bd5890 
  3rdparty/stout/tests/ip_tests.cpp 39ee0598e3580510a30894fd3f47d2014f596ef7 


Diff: https://reviews.apache.org/r/59688/diff/4/

Changes: https://reviews.apache.org/r/59688/diff/3-4/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 59721: Refactored net::IP and added net::IPv4 and net::IPv6.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59721/
---

(Updated June 29, 2017, 11:24 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Classes can now initialize the specialized classes whenever they need to
create explicit v4 and v6 addresses, rather than relying on the
`create/Try` semantics of net::IP.


Diffs (updated)
-

  3rdparty/stout/include/stout/ip.hpp ee48befac8b9bb4956aec0c5bdebd69347bd5890 
  3rdparty/stout/tests/ip_tests.cpp 39ee0598e3580510a30894fd3f47d2014f596ef7 


Diff: https://reviews.apache.org/r/59721/diff/5/

Changes: https://reviews.apache.org/r/59721/diff/4-5/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59739: Replaced use of `net::IPNetwork` by `net::IP::Network`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59739/
---

(Updated June 29, 2017, 11:24 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Replaced use of `net::IPNetwork` by `net::IP::Network`.


Diffs (updated)
-

  3rdparty/stout/include/stout/posix/ip.hpp 
0d7e85a4b4b8263691dfb7654835312bbd117db6 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
b386fbed17698dd6c59bc6c53edfe8a7ece6a3eb 
  
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
 ce795628f19f0e8138ad9a0b50b7d644b9d734a8 
  src/tests/containerizer/cni_isolator_tests.cpp 
17afdf45a839bb80aa19663f97eaebec332ceee8 
  src/tests/utils.hpp a2ae43c6a20ab3753a3501d8ce23ffb0f6ac0005 
  src/tests/utils.cpp 053976d3c4cf120ff5e7dff6e96c6862a5b617b1 


Diff: https://reviews.apache.org/r/59739/diff/5/

Changes: https://reviews.apache.org/r/59739/diff/4-5/


Testing
---

make.


Thanks,

Avinash sridharan

Re: Review Request 60136: Refactored inet::Address to base of inet4::Address and inet6::Address.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60136/
---

(Updated June 29, 2017, 11:23 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Refactored inet::Address to base of inet4::Address and inet6::Address.


Diffs (updated)
-

  3rdparty/libprocess/include/process/address.hpp 
6b143c3d00c1d7ebd1697c26b6d312a64f30839a 
  3rdparty/libprocess/include/process/pid.hpp 
c634916a37f570194945b9c7d7b786ffeae0408a 
  3rdparty/libprocess/include/process/socket.hpp 
42287c128fb352af6a196b7abc77f913a2ddbba0 
  3rdparty/libprocess/src/http.cpp f317f2f0826e006342cfea20b15b80e7c8fc68a9 
  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
7d493301bd5c0f24bf89e0b213f07ffe7801508b 
  3rdparty/libprocess/src/pid.cpp 023f881841f466d91243d2773961b67f82da4e91 
  3rdparty/libprocess/src/poll_socket.cpp 
9d1b2769ac31928d5ce4f64467c12ca0f58c11cf 
  3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8 
  3rdparty/libprocess/src/socket.cpp 85920a1abb3a2b2da167647dcf1351b825c72c80 
  3rdparty/libprocess/src/tests/http_tests.cpp 
09c7297aa0e80accd09ce6d81390a0f662bec6f2 
  3rdparty/libprocess/src/tests/process_tests.cpp 
38d787a083a5eb31e922d283f4b4bed2bd62eb0a 
  3rdparty/libprocess/src/tests/socket_tests.cpp 
fdcd23dcb05d683cfb3ae14956fe3fd8fe166603 
  3rdparty/libprocess/src/tests/test_linkee.cpp 
77df385d3388788658fa40d033816e1fbb8d8f2c 


Diff: https://reviews.apache.org/r/60136/diff/2/

Changes: https://reviews.apache.org/r/60136/diff/1-2/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 60148: Mesos updates for new inet4::Address.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60148/
---

(Updated June 29, 2017, 11:23 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Mesos updates for new inet4::Address.


Diffs (updated)
-

  src/tests/utils.cpp 053976d3c4cf120ff5e7dff6e96c6862a5b617b1 


Diff: https://reviews.apache.org/r/60148/diff/2/

Changes: https://reviews.apache.org/r/60148/diff/1-2/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60149/
---

(Updated June 29, 2017, 11:23 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/parse.hpp 
3448c571ece36b8d45bbe1317efc824468fe3466 


Diff: https://reviews.apache.org/r/60149/diff/3/

Changes: https://reviews.apache.org/r/60149/diff/2-3/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59131: Added an IPv6 address storage to UPID.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/
---

(Updated June 29, 2017, 11:23 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added an IPv6 address storage to UPID.


Diffs (updated)
-

  3rdparty/libprocess/include/process/pid.hpp 
c634916a37f570194945b9c7d7b786ffeae0408a 
  3rdparty/libprocess/src/pid.cpp 023f881841f466d91243d2773961b67f82da4e91 


Diff: https://reviews.apache.org/r/59131/diff/5/

Changes: https://reviews.apache.org/r/59131/diff/4-5/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/
---

(Updated June 29, 2017, 11:22 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added storage for IPv6 in a `libprocess` process.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8 


Diff: https://reviews.apache.org/r/59130/diff/6/

Changes: https://reviews.apache.org/r/59130/diff/5-6/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59233: Updated v6 address for containers running on host network.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/
---

(Updated June 29, 2017, 11:22 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Currently the agent is populating only the v4 address for containers
running on the host network. However, clusters running on a dual stack
network need to report v4 and v6 address for containers running on the
host network. This change allows v6 address specified by operators to be
advertised for containers running on the host network.


Diffs (updated)
-

  include/mesos/mesos.proto 3338349c399c9fb5b7fb2fc5886fb492ffb944c4 
  include/mesos/v1/mesos.proto 6f0ad71260c36a9cb401c716e02c561580fb433b 
  src/slave/slave.cpp 1f7aed48eb3ab3ee2a797d4061a6e289852b8199 


Diff: https://reviews.apache.org/r/59233/diff/6/

Changes: https://reviews.apache.org/r/59233/diff/5-6/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 60551: Added a test for docker container running on a v4/6 host network.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60551/
---

(Updated June 29, 2017, 11:22 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added a test for docker container running on a v4/6 host network.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
cf9470245ebc81e799fb2b2a67464298564fc56f 
  src/tests/mesos.hpp eac2c96985cdbbf1a50cfc054862eae2d44fbfcd 
  src/tests/mesos.cpp d3e6bc0a92ec9b410712891c6a02d01ed2b587c1 


Diff: https://reviews.apache.org/r/60551/diff/2/

Changes: https://reviews.apache.org/r/60551/diff/1-2/


Testing
---

sudo ./bin/mesos-tests.sh


Thanks,

Avinash sridharan

Re: Review Request 59131: Added an IPv6 address storage to UPID.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/
---

(Updated June 29, 2017, 11:17 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased and fixed some missing copy operations for the new `address6` field.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added an IPv6 address storage to UPID.


Diffs (updated)
-

  3rdparty/libprocess/include/process/pid.hpp 
c634916a37f570194945b9c7d7b786ffeae0408a 
  3rdparty/libprocess/src/pid.cpp 023f881841f466d91243d2773961b67f82da4e91 


Diff: https://reviews.apache.org/r/59131/diff/4/

Changes: https://reviews.apache.org/r/59131/diff/3-4/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60149/
---

(Updated June 29, 2017, 11:16 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/parse.hpp 
3448c571ece36b8d45bbe1317efc824468fe3466 


Diff: https://reviews.apache.org/r/60149/diff/2/

Changes: https://reviews.apache.org/r/60149/diff/1-2/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/
---

(Updated June 29, 2017, 11:16 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added storage for IPv6 in a `libprocess` process.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8 


Diff: https://reviews.apache.org/r/59130/diff/5/

Changes: https://reviews.apache.org/r/59130/diff/4-5/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59233: Updated v6 address for containers running on host network.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/
---

(Updated June 29, 2017, 11:16 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Currently the agent is populating only the v4 address for containers
running on the host network. However, clusters running on a dual stack
network need to report v4 and v6 address for containers running on the
host network. This change allows v6 address specified by operators to be
advertised for containers running on the host network.


Diffs (updated)
-

  include/mesos/mesos.proto 3338349c399c9fb5b7fb2fc5886fb492ffb944c4 
  include/mesos/v1/mesos.proto 6f0ad71260c36a9cb401c716e02c561580fb433b 
  src/slave/slave.cpp 1f7aed48eb3ab3ee2a797d4061a6e289852b8199 


Diff: https://reviews.apache.org/r/59233/diff/5/

Changes: https://reviews.apache.org/r/59233/diff/4-5/


Testing
---

make check


Thanks,

Avinash sridharan

Review Request 60551: Added a test for docker container running on a v4/6 host network.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60551/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added a test for docker container running on a v4/6 host network.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
cf9470245ebc81e799fb2b2a67464298564fc56f 
  src/tests/mesos.hpp eac2c96985cdbbf1a50cfc054862eae2d44fbfcd 
  src/tests/mesos.cpp d3e6bc0a92ec9b410712891c6a02d01ed2b587c1 


Diff: https://reviews.apache.org/r/60551/diff/1/


Testing
---

sudo ./bin/mesos-tests.sh


Thanks,

Avinash sridharan

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Quinn Leng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/
---

(Updated June 29, 2017, 7:55 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description
---

Added filtering to the '/tasks' endpoint.


Diffs (updated)
-

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
  src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
  src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 


Diff: https://reviews.apache.org/r/60107/diff/11/

Changes: https://reviews.apache.org/r/60107/diff/10-11/


Testing
---

Passed "make check"
Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" 
--gtest_repeat=1000 --gtest_break_on_failure"


Thanks,

Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179295
---


Fix it, then Ship it!





src/common/http.hpp
Line 218 (original), 218 (patched)


s/. Ww/. W/



src/common/http.hpp
Line 233 (original), 233 (patched)


s/, W/. W/


- Vinod Kone


On June 29, 2017, 6:09 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> ---
> 
> (Updated June 29, 2017, 6:09 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering to the '/tasks' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/10/
> 
> 
> Testing
> ---
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 
> --gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

[Eric Chung]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/
---

(Updated June 29, 2017, 6:22 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, Joseph Wu, and Kevin Klues.


Bugs: MESOS-7310
https://issues.apache.org/jira/browse/MESOS-7310


Repository: mesos


Description (updated)
---

Part of MESOS-7310, this patch adds a new directory (src/python/lib/mesos) for 
placing the http client package, which will be importable via `import mesos` 
from the cli.

Review: https://reviews.apache.org/r/58394


Diffs
-

  src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443 
  src/python/.gitignore PRE-CREATION 
  src/python/lib/mesos/__init__.py PRE-CREATION 


Diff: https://reviews.apache.org/r/58394/diff/4/


Testing
---

Under src/cli_new:
1\. ./bootstrap
2\. . ./activate
3\. python
4\. >>> import mesos
5\. >>> mesos.\_\_path\_\_
6\. verify that the path printed out is indeed at src/python/lib/mesos


Thanks,

Eric Chung

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

[Eric Chung]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/
---

(Updated June 29, 2017, 6:18 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, Joseph Wu, and Kevin Klues.


Bugs: MESOS-7310
https://issues.apache.org/jira/browse/MESOS-7310


Repository: mesos


Description
---

Review: https://reviews.apache.org/r/58394


Diffs (updated)
-

  src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443 
  src/python/.gitignore PRE-CREATION 
  src/python/lib/mesos/__init__.py PRE-CREATION 


Diff: https://reviews.apache.org/r/58394/diff/4/

Changes: https://reviews.apache.org/r/58394/diff/3-4/


Testing
---

Under src/cli_new:
1\. ./bootstrap
2\. . ./activate
3\. python
4\. >>> import mesos
5\. >>> mesos.\_\_path\_\_
6\. verify that the path printed out is indeed at src/python/lib/mesos


Thanks,

Eric Chung

Review Request 60546: Harden Mesos when building with cmake.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60546/
---

Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Bugs: MESOS-7737
https://issues.apache.org/jira/browse/MESOS-7737


Repository: mesos


Description
---

Apply stack protectors (stronger stack protectors with newer compilers), 
position independent code suitable for linking into executables, security 
warnings, and generate position independent executables.


Diffs
-

  cmake/CompilationConfigure.cmake 3fa2e2f3b 
  cmake/MesosConfigure.cmake 5ecad2c0f 


Diff: https://reviews.apache.org/r/60546/diff/1/


Testing
---

`mkdir build && cd build && cmake .. && make -j$(nproc) && make check 
-j$(nproc)`


Thanks,

Aaron Wood

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Quinn Leng]

> On June 29, 2017, 1:12 a.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp
> > Lines 3510 (patched)
> > 
> >
> > is the order not determinisitc in our tests?

It's not deterministic, since tasks are stored in hashmap (which is implemented 
by unordered_map), the order it decided by the size of the bucket, the hash 
function, thus we can not guarantee the order


- Quinn


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179215
---


On June 29, 2017, 12:47 a.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> ---
> 
> (Updated June 29, 2017, 12:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering to the '/tasks' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/9/
> 
> 
> Testing
> ---
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 
> --gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Quinn Leng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/
---

(Updated June 29, 2017, 6:09 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description
---

Added filtering to the '/tasks' endpoint.


Diffs (updated)
-

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
  src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
  src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 


Diff: https://reviews.apache.org/r/60107/diff/10/

Changes: https://reviews.apache.org/r/60107/diff/9-10/


Testing
---

Passed "make check"
Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" 
--gtest_repeat=1000 --gtest_break_on_failure"


Thanks,

Quinn Leng

Review Request 60545: Optimized use of DispatchEvent by lazy evaluation of method value.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60545/
---

Review request for mesos, Alexander Rukletsov and Michael Park.


Repository: mesos


Description
---

DispatchEvent contains value of pointer-to-member function stored in
std::string, which is calculated each time DispatchEvent object is
constructed. However, this value is used only in tests (see
FUTURE_DISPATCH), imposing unnecessary overhead in production.
This patch introduces lazy evolution of pointer-to-member by storing
std::function object instead of std::string. Wrapper function captures
value of pointer-to-member function and returns its stringified version
on invocation. This function invoked by demand in test code, hence
mitigating overhead of evaluation and storing value of pointer to
member function.


Diffs
-

  3rdparty/libprocess/include/process/dispatch.hpp 
3a0793888dc0df5e3ec31b06f47cd920c71e0db9 
  3rdparty/libprocess/include/process/event.hpp 
8afe6266eb0dc5a17af35d79efb6bfdf9e6a0ee9 
  3rdparty/libprocess/include/process/gmock.hpp 
e9af943b39436f365fe687301febb5c7fbefffc4 
  3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8 


Diff: https://reviews.apache.org/r/60545/diff/1/


Testing
---

1. make check (mac os x 10.12, fedora 25)
2. internal CI


Thanks,

Andrei Budnik

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

[Andrei Budnik]

> On June 29, 2017, 9:48 a.m., Benjamin Mahler wrote:
> > Thanks Andrei, the code looks good. Can you split the test out? That way I 
> > can give a ship it on the code change, while we continue working on the 
> > test.

https://reviews.apache.org/r/60539/


> On June 29, 2017, 9:48 a.m., Benjamin Mahler wrote:
> > src/slave/http.cpp
> > Lines 1326 (patched)
> > 
> >
> > How about a TODO here?
> > 
> > TODO(abudnik): Consider storing the allocatedResources in the Slave 
> > struct rather than computing it here each time.

Added.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179240
---


On June 29, 2017, 3:23 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> ---
> 
> (Updated June 29, 2017, 3:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
---

(Updated June 29, 2017, 3:23 p.m.)


Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated".


Diffs (updated)
-

  src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 


Diff: https://reviews.apache.org/r/60369/diff/4/

Changes: https://reviews.apache.org/r/60369/diff/3-4/


Testing
---

make check


Thanks,

Andrei Budnik

Review Request 60539: Added test for allocated resources per each role in the agent endpoint.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60539/
---

Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

Added test for allocated resources per each role in the agent endpoint.


Diffs
-

  src/tests/reservation_endpoints_tests.cpp 
f710a188a7875c1cb847e39276b4b65332703ca5 


Diff: https://reviews.apache.org/r/60539/diff/1/


Testing
---

make check (mac os x, fedora 25)


Thanks,

Andrei Budnik

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/#review179253
---


Ship it!




Please make the commit description more explicit by adding what is the purpose 
of this change. You could use this review request to start a chain closing 
https://issues.apache.org/jira/browse/MESOS-7310, this will require to cut 
https://reviews.apache.org/r/58065/.

- Armand Grillet


On June 28, 2017, 6:56 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58394/
> ---
> 
> (Updated June 28, 2017, 6:56 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, Joseph Wu, and Kevin 
> Klues.
> 
> 
> Bugs: MESOS-7310
> https://issues.apache.org/jira/browse/MESOS-7310
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/58394
> 
> 
> Diffs
> -
> 
>   src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443 
>   src/python/.gitignore PRE-CREATION 
>   src/python/lib/mesos/__init__.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58394/diff/3/
> 
> 
> Testing
> ---
> 
> Under src/cli_new:
> 1\. ./bootstrap
> 2\. . ./activate
> 3\. python
> 4\. >>> import mesos
> 5\. >>> mesos.\_\_path\_\_
> 6\. verify that the path printed out is indeed at src/python/lib/mesos
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 59932: Added devolve functions for resource provider Event/Call.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59932/#review179250
---


Ship it!




Ship It!

- Jan Schlicht


On June 26, 2017, 6:29 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59932/
> ---
> 
> (Updated June 26, 2017, 6:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added devolve functions for resource provider Event/Call.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp a8c500785f400f5933640ad6afcbb5a7dae796c0 
>   src/internal/devolve.cpp 73774d975aab39352cf6a215b9b47e02a4b0aabf 
> 
> 
> Diff: https://reviews.apache.org/r/59932/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179240
---



Thanks Andrei, the code looks good. Can you split the test out? That way I can 
give a ship it on the code change, while we continue working on the test.


src/slave/http.cpp
Lines 1326 (patched)


How about a TODO here?

TODO(abudnik): Consider storing the allocatedResources in the Slave struct 
rather than computing it here each time.


- Benjamin Mahler


On June 28, 2017, 12:08 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> ---
> 
> (Updated June 28, 2017, 12:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
>   src/tests/reservation_endpoints_tests.cpp 
> f710a188a7875c1cb847e39276b4b65332703ca5 
> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60529: Fixed support/apply-reviews.py.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60529/#review179236
---


Fix it, then Ship it!





support/apply-reviews.py
Line 189 (original), 189 (patched)


Why call this url? It's the response FWICT.


- Benjamin Mahler


On June 29, 2017, 8:26 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60529/
> ---
> 
> (Updated June 29, 2017, 8:26 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While cleaning up this script for PyLint conformance in
> 09fc35978c77ed0f22df1823f5c9220f1ed098ed we introduced usage of an
> incorrect value `patch` when this script was run under Windows.
> 
> This commit restores the previous data flow. The issue was the cause
> of the Mesos Reviewbot Windows error messages seen when review
> requests were posted on the Review Board the past few days.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py c9c87c6fce4e125a664307f7ac8bc56f4919f157 
> 
> 
> Diff: https://reviews.apache.org/r/60529/diff/2/
> 
> 
> Testing
> ---
> 
> Added support to source_dirs in the PyLinter defined in 
> mesos-style.py. Only acceptable errors where displayed (e.g. due 
> to the name of the file containing a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 60529: Fixed support/apply-reviews.py.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60529/
---

(Updated June 29, 2017, 8:26 a.m.)


Review request for mesos and Joseph Wu.


Changes
---

Improved description.


Repository: mesos


Description (updated)
---

While cleaning up this script for PyLint conformance in
09fc35978c77ed0f22df1823f5c9220f1ed098ed we introduced usage of an
incorrect value `patch` when this script was run under Windows.

This commit restores the previous data flow. The issue was the cause
of the Mesos Reviewbot Windows error messages seen when review
requests were posted on the Review Board the past few days.


Diffs (updated)
-

  support/apply-reviews.py c9c87c6fce4e125a664307f7ac8bc56f4919f157 


Diff: https://reviews.apache.org/r/60529/diff/2/

Changes: https://reviews.apache.org/r/60529/diff/1-2/


Testing (updated)
---

Added support to source_dirs in the PyLinter defined in 
mesos-style.py. Only acceptable errors where displayed (e.g. due 
to the name of the file containing a dash instead of an underscore).


Thanks,

Armand Grillet

Re: Review Request 60529: Fixed support/apply-reviews.py.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60529/#review179234
---


Ship it!




Could you make the commit description more explicit, and e.g., call out what 
broke this in the first place, e.g.,

Fixed support/apply-reviews.py.

While cleaning up this script for pylint-conformance in
09fc35978c77ed0f22df1823f5c9220f1ed098ed we introduced usage of an
incorrect value when this script was run under Windows.

This commit restores the previous data flow.

- Benjamin Bannier


On June 29, 2017, 9:44 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60529/
> ---
> 
> (Updated June 29, 2017, 9:44 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The variable `patch` is not overwritten anymore. This patch fixes
> the Mesos Reviewbot Windows error messages seen recently on the
> Review Board.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py c9c87c6fce4e125a664307f7ac8bc56f4919f157 
> 
> 
> Diff: https://reviews.apache.org/r/60529/diff/1/
> 
> 
> Testing
> ---
> 
> Added support to source_dirs in the PyLinter defined
> in mesos-style.py. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Review Request 60529: Fixed support/apply-reviews.py.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60529/
---

Review request for mesos.


Repository: mesos


Description
---

The variable `patch` is not overwritten anymore. This patch fixes
the Mesos Reviewbot Windows error messages seen recently on the
Review Board.


Diffs
-

  support/apply-reviews.py c9c87c6fce4e125a664307f7ac8bc56f4919f157 


Diff: https://reviews.apache.org/r/60529/diff/1/


Testing
---

Added support to source_dirs in the PyLinter defined
in mesos-style.py. Linted until only acceptable errors
where displayed (e.g. due to the name of the file containing
a dash instead of an underscore).


Thanks,

Armand Grillet