----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/#review179240 -----------------------------------------------------------
Thanks Andrei, the code looks good. Can you split the test out? That way I can give a ship it on the code change, while we continue working on the test. src/slave/http.cpp Lines 1326 (patched) <https://reviews.apache.org/r/60369/#comment253885> How about a TODO here? TODO(abudnik): Consider storing the allocatedResources in the Slave struct rather than computing it here each time. - Benjamin Mahler On June 28, 2017, 12:08 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60369/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 12:08 p.m.) > > > Review request for mesos, Benjamin Mahler and haosdent huang. > > > Bugs: MESOS-6441 > https://issues.apache.org/jira/browse/MESOS-6441 > > > Repository: mesos > > > Description > ------- > > The JSON key for this information is "reserved_resources_allocated" > and "unreserved_resources_allocated". > > > Diffs > ----- > > src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c > src/tests/reservation_endpoints_tests.cpp > f710a188a7875c1cb847e39276b4b65332703ca5 > > > Diff: https://reviews.apache.org/r/60369/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Budnik > >
