Re: Review Request 67606: Allowed for unbundled libevent cmake builds.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204891
---



PASS: Mesos patch 67606 was successfully built and tested.

Reviews applied: `['67606']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67606

- Mesos Reviewbot Windows


On June 15, 2018, 7:06 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> ---
> 
> (Updated June 15, 2018, 7:06 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, 
> and Jan Schlicht.
> 
> 
> Bugs: MESOS-8998
> https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the option UNBUNDLED_LIBEVENT for using an installed libevent
> instead of the bundled version. That option is set towards
> TRUE by default on macOS, FALSE otherwise. Additionally adds the flag
> LIBEVENT_ROOT_DIR for specifying the path to an unbundled libevent.
> Updates the cmake documentation with the above flags.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/2/
> 
> 
> Testing
> ---
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE 
> -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
>   @rpath/libprocess.dylib (compatibility version 0.0.0, current version 
> 0.0.0)
>   /usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   /usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib
>  (compatibility version 2.1.5, current version 0.0.0)
>   /usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 
> 7.0.0, current version 7.3.0)
>   /usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 
> 9.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib
>  (compatibility version 1.0.0, current version 1.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib
>  (compatibility version 0.0.0, current version 0.0.0)
>   /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 
> 1.2.11)
>   /usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 
> 400.9.3)
>   /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current 
> version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE 
> -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
>   @rpath/libprocess.dylib (compatibility version 0.0.0, current version 
> 0.0.0)
>   /usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   /usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   /usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 
> 7.0.0, current version 7.9.0)
>   /usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 
> 7.0.0, current version 7.3.0)
>   /usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 
> 9.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib
>  (compatibility version 1.0.0, current version 1.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib
>  (compatibility version 0.0.0, current version 0.0.0)
>   /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 
> 1.2.11)
>   /usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility 
> 

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review204890
---



PASS: Mesos patch 67601 was successfully built and tested.

Reviews applied: `['67601']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67601

- Mesos Reviewbot Windows


On June 15, 2018, 6:20 p.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67601/
> ---
> 
> (Updated June 15, 2018, 6:20 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8816
> https://issues.apache.org/jira/browse/MESOS-8816
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added field container_id in ResourceUsage to agent monitor endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 
> 
> 
> Diff: https://reviews.apache.org/r/67601/diff/2/
> 
> 
> Testing
> ---
> 
> add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
> container_id field added sucessfully or not
> 
> 
> Thanks,
> 
> longfei niu
> 
>

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review204889
---



Patch looks great!

Reviews applied: [67563, 67526, 67564, 67565]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 15, 2018, 4:55 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> ---
> 
> (Updated June 15, 2018, 4:55 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> 231e9588c0d831c05a1d84f35f0f68105900789c 
> 
> 
> Diff: https://reviews.apache.org/r/67565/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67606: Allowed for unbundled libevent cmake builds.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/
---

(Updated June 16, 2018, 2:06 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, 
and Jan Schlicht.


Changes
---

Added macOS detection, added LIBEVENT_ROOT_DIR flag, updated cmake 
documentation.


Summary (updated)
-

Allowed for unbundled libevent cmake builds.


Bugs: MESOS-8998
https://issues.apache.org/jira/browse/MESOS-8998


Repository: mesos


Description (updated)
---

Adds the option UNBUNDLED_LIBEVENT for using an installed libevent
instead of the bundled version. That option is set towards
TRUE by default on macOS, FALSE otherwise. Additionally adds the flag
LIBEVENT_ROOT_DIR for specifying the path to an unbundled libevent.
Updates the cmake documentation with the above flags.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
  3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
  cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
  docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 


Diff: https://reviews.apache.org/r/67606/diff/2/

Changes: https://reviews.apache.org/r/67606/diff/1-2/


Testing
---

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE 
-DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
@rpath/libprocess.dylib (compatibility version 0.0.0, current version 
0.0.0)
/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 
1.0.0, current version 1.0.0)
/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 
1.0.0, current version 1.0.0)

/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib
 (compatibility version 2.1.5, current version 0.0.0)
/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 
7.0.0, current version 7.3.0)
/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 
9.0.0)

/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib
 (compatibility version 1.0.0, current version 1.0.0)

/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib
 (compatibility version 0.0.0, current version 0.0.0)
/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 
1.2.11)
/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility 
version 1.0.0, current version 1.0.0)
/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility 
version 1.0.0, current version 1.0.0)
/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility 
version 1.0.0, current version 1.0.0)
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 
400.9.3)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current 
version 1252.200.5)
```

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE 
-DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
@rpath/libprocess.dylib (compatibility version 0.0.0, current version 
0.0.0)
/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 
1.0.0, current version 1.0.0)
/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 
1.0.0, current version 1.0.0)
/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 
7.0.0, current version 7.9.0)
/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 
7.0.0, current version 7.3.0)
/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 
9.0.0)

/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib
 (compatibility version 1.0.0, current version 1.0.0)

/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib
 (compatibility version 0.0.0, current version 0.0.0)
/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 
1.2.11)
/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility 
version 1.0.0, current version 1.0.0)
/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility 
version 1.0.0, current version 1.0.0)
/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility 
version 1.0.0, current version 1.0.0)
/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility 
version 7.0.0, current version 7.9.0)

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

[longfei niu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/
---

(Updated 六月 16, 2018, 1:20 a.m.)


Review request for mesos and Gilbert Song.


Changes
---

Fixed questions


Bugs: MESOS-8816
https://issues.apache.org/jira/browse/MESOS-8816


Repository: mesos


Description (updated)
---

Added field container_id in ResourceUsage to agent monitor endpoint.


Diffs (updated)
-

  src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
  src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 


Diff: https://reviews.apache.org/r/67601/diff/2/

Changes: https://reviews.apache.org/r/67601/diff/1-2/


Testing
---

add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
container_id field added sucessfully or not


Thanks,

longfei niu

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204888
---



Patch looks great!

Reviews applied: [67606]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 15, 2018, 2:07 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> ---
> 
> (Updated June 15, 2018, 2:07 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-8998
> https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE 
> -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
>   @rpath/libprocess.dylib (compatibility version 0.0.0, current version 
> 0.0.0)
>   /usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   /usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib
>  (compatibility version 2.1.5, current version 0.0.0)
>   /usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 
> 7.0.0, current version 7.3.0)
>   /usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 
> 9.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib
>  (compatibility version 1.0.0, current version 1.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib
>  (compatibility version 0.0.0, current version 0.0.0)
>   /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 
> 1.2.11)
>   /usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 
> 400.9.3)
>   /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current 
> version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE 
> -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
>   @rpath/libprocess.dylib (compatibility version 0.0.0, current version 
> 0.0.0)
>   /usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   /usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   /usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 
> 7.0.0, current version 7.9.0)
>   /usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 
> 7.0.0, current version 7.3.0)
>   /usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 
> 9.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib
>  (compatibility version 1.0.0, current version 1.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib
>  (compatibility version 0.0.0, current version 0.0.0)
>   /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 
> 1.2.11)
>   /usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   

Re: Review Request 62515: Added mpsc_linked_queue and use it as the concurrent event queue.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62515/#review204887
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 62515`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62515

Relevant logs:

- 
[apply-review-62515-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62515/logs/apply-review-62515-stdout.log):

```
error: patch failed: 3rdparty/libprocess/src/tests/benchmarks.cpp:36
error: 3rdparty/libprocess/src/tests/benchmarks.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On June 15, 2018, 3:57 p.m., Dario Rexin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62515/
> ---
> 
> (Updated June 15, 2018, 3:57 p.m.)
> 
> 
> Review request for Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Linked queue
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c2fa3f9e8 
>   3rdparty/libprocess/src/event_queue.hpp 21c522dcb 
>   3rdparty/libprocess/src/mpsc_linked_queue.hpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 27451c275 
>   3rdparty/libprocess/src/tests/benchmarks.cpp a69170511 
>   3rdparty/libprocess/src/tests/mpsc_linked_queue_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62515/diff/5/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> queue.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/25/6743874f-97a8-459c-b9e9-e0b615ff372f__queue.patch
> queue.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/08/33de7354-3809-402d-806d-e8d9086856f7__queue.patch
> queue.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/06/15/b010f4cb-6492-4192-aa3b-bcbace547274__queue.patch
> 
> 
> Thanks,
> 
> Dario Rexin
> 
>

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review204886
---



PASS: Mesos patch 67517 was successfully built and tested.

Reviews applied: `['67510', '67516', '67513', '67517']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67517

- Mesos Reviewbot Windows


On June 15, 2018, 3:05 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> ---
> 
> (Updated June 15, 2018, 3:05 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
> 
> 
> Diffs
> -
> 
>   src/tests/master_allocator_tests.cpp 
> e1aef8a9625a805e7ad2dfad37bfeedee82f160d 
> 
> 
> Diff: https://reviews.apache.org/r/67517/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67596/
---

(Updated June 15, 2018, 11:29 p.m.)


Review request for mesos, Jie Yu, Joseph Wu, and Kevin Klues.


Changes
---

Improved test isolation.


Bugs: MESOS-6622
https://issues.apache.org/jira/browse/MESOS-6622


Repository: mesos


Description (updated)
---

This test is flaky because it tries to download the 1GB 'nvidia/cuda'
image from Docker Hub, which might take more than 1 minute and cause
the command executor unable to register in time.

This patch fixes this problem by using the default executor, which does
not wait for fetching task images before registration. If the image
fetch stalls more than 1 minute, the container will fail because of the
`--fetcher_stall_timeout` agent flag.

The time we wait for `TASK_FINISHED` is also extended to 180 seconds.


Diffs (updated)
-

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
d8c3e6d08a70bd129d8ac9c336be7a2bf7a4b0b2 


Diff: https://reviews.apache.org/r/67596/diff/2/

Changes: https://reviews.apache.org/r/67596/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204885
---


Fix it, then Ship it!




Seems reasonable. Going forward, we should be consistent with this patch when 
adding options to `UNBUNDLE` specific dependencies.


3rdparty/cmake/Findlibevent.cmake
Lines 36-45 (patched)


Just a suggestion, but if you wanted this could be:

```
set(LIBEVENT_LIBRARY_NAMES
  event
  event_pthreads)
  
if (ENABLE_SSL)
  list(APPEND LIBEVENT_LIBRARY_NAMES event_openssl)
endif()
```


- Andrew Schwartzmeyer


On June 14, 2018, 7:07 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> ---
> 
> (Updated June 14, 2018, 7:07 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-8998
> https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE 
> -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
>   @rpath/libprocess.dylib (compatibility version 0.0.0, current version 
> 0.0.0)
>   /usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   /usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib
>  (compatibility version 2.1.5, current version 0.0.0)
>   /usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 
> 7.0.0, current version 7.3.0)
>   /usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 
> 9.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib
>  (compatibility version 1.0.0, current version 1.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib
>  (compatibility version 0.0.0, current version 0.0.0)
>   /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 
> 1.2.11)
>   /usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 
> 400.9.3)
>   /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current 
> version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE 
> -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
>   @rpath/libprocess.dylib (compatibility version 0.0.0, current version 
> 0.0.0)
>   /usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   /usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 
> 1.0.0, current version 1.0.0)
>   /usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 
> 7.0.0, current version 7.9.0)
>   /usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 
> 7.0.0, current version 7.3.0)
>   /usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 
> 9.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib
>  (compatibility version 1.0.0, current version 1.0.0)
>   
> /Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib
>  (compatibility version 0.0.0, current version 0.0.0)
>   /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 
> 1.2.11)
>   /usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility 
> version 1.0.0, current version 1.0.0)
>   

Re: Review Request 67604: Made configured shell script inputs executable.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67604/#review204884
---


Ship it!




Tested a clean build with CMake + Ninja on Ubunto; all scripts in build/bin 
were executable :)

- Andrew Schwartzmeyer


On June 14, 2018, 3:20 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67604/
> ---
> 
> (Updated June 14, 2018, 3:20 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While this is not required for the autotools build where manual
> intervention is needed to make the output of `AC_CONFIG_FILES`
> executable, cmake will copy existing permissions when executing
> `configure_file`. Making the input files explicitly executable
> simplifies the needed steps in the cmake build and also serves as
> documentation.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e 
> 
> 
> Diff: https://reviews.apache.org/r/67604/diff/1/
> 
> 
> Testing
> ---
> 
> NOTE:
> 
> **Reviewboard seems to have issues tracking the permission changes in this 
> patch.
> Please apply the patch file below instead of the patch related directly to 
> this rr.**
> 
> (done shouting)
> 
> 
> # Testing done
> 
> * made sure that all shell scripts created as part of `cmake ..` are 
> executable
> * `make distcheck` for good measure, but likely unable to detect issues here.
> 
> 
> File Attachments
> 
> 
> PLEASE APPLY THIS PATCH MANUALLY INSTEAD
>   
> https://reviews.apache.org/media/uploaded/files/2018/06/14/2503e381-af7c-4de4-ac67-d259102bf5cf__0001-Made-configured-shell-script-inputs-executable.patch
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67596/#review204883
---


Ship it!




Ship It!

- Jie Yu


On June 14, 2018, 3:47 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67596/
> ---
> 
> (Updated June 14, 2018, 3:47 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joseph Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-6622
> https://issues.apache.org/jira/browse/MESOS-6622
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test is flaky because it tries to download the 1GB 'nvidia/cuda'
> image from Docker Hub, which might take more than 1 minute and cause
> the command executor unable to register in time.
> 
> This patch fixes this problem by using the default executor, which does
> not wait for fetching task images before registration. If the image
> fetch stalls (i.e. makes no progress) more than 1 minute, the container
> will fail because of the `--fetcher_stall_timeout` agent flag.
> 
> The time we wait for `TASK_FINISHED` is also extended to 180 seconds.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
> d8c3e6d08a70bd129d8ac9c336be7a2bf7a4b0b2 
> 
> 
> Diff: https://reviews.apache.org/r/67596/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67615: Modified `createStrippedScalarQuantity()` to clear all metadata fields.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67615/#review204882
---



PASS: Mesos patch 67615 was successfully built and tested.

Reviews applied: `['67561', '67615']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67615

- Mesos Reviewbot Windows


On June 15, 2018, 8:46 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67615/
> ---
> 
> (Updated June 15, 2018, 8:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kapil Arya, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently `createStrippedScalarQuantity()` strips resource meta-data
> except revocable and turns dynamic reservation into static reservation.
> However, no current code depends on this behavior and this leads to
> boilerplate code around call sites and performance overhead.
> 
> This patch further clears the above meta-data for simplicity
> and performance.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce 
>   include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932 
>   src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca 
>   src/master/allocator/mesos/hierarchical.cpp 
> b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 
>   src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1 
>   src/tests/sorter_tests.cpp 9cdffd778967bca3d0055be8a04fbb702432e59d 
>   src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8 
> 
> 
> Diff: https://reviews.apache.org/r/67615/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review204881
---



PASS: Mesos patch 67308 was successfully built and tested.

Reviews applied: `['67308']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67308

- Mesos Reviewbot Windows


On June 15, 2018, 8:45 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> ---
> 
> (Updated June 15, 2018, 8:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin 
> Mahler, Greg Mann, Jie Yu, James Peach, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -
> 
>   docs/cquery.md PRE-CREATION 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/
---

(Updated June 15, 2018, 3:05 p.m.)


Review request for mesos, Gastón Kleiman and Greg Mann.


Changes
---

Removed JSON input test.


Bugs: MESOS-8935
https://issues.apache.org/jira/browse/MESOS-8935


Repository: mesos


Description
---

This test verifies that the allocator honors the
`min_allocatable_resources` flag and only offers resources
that are more than at least one of the specified resources quantity.


Diffs (updated)
-

  src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d 


Diff: https://reviews.apache.org/r/67517/diff/2/

Changes: https://reviews.apache.org/r/67517/diff/1-2/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 67513: Added a master flag to configure minimum allocatable resources.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/
---

(Updated June 15, 2018, 3:02 p.m.)


Review request for mesos, Gastón Kleiman and Greg Mann.


Changes
---

Removed JSON input format.


Bugs: MESOS-8935
https://issues.apache.org/jira/browse/MESOS-8935


Repository: mesos


Description
---

This patch adds a new master flag `min_allocatable_resources`.
It specifies one or more resources quantities that define the
minimum allocatable resources for the allocator. The allocator
will only offer resources that are more than at least one of
the specified resources.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
647869286d46920b98521e219ce92c3260058c35 
  src/master/allocator/mesos/allocator.hpp 
c453c015b234deff7efd00269da25dcec8cbf1ae 
  src/master/allocator/mesos/hierarchical.hpp 
e9d1742bb35004735e3cb357286b4e5b17436a5c 
  src/master/allocator/mesos/hierarchical.cpp 
b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 
  src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc 
  src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d 
  src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
  src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559 
  src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c 
  src/tests/hierarchical_allocator_tests.cpp 
c97b2ba0884a7ded867c2d80e4749de54c89b5e4 
  src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d 
  src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9 
  src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351 
  src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b 
  src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210 


Diff: https://reviews.apache.org/r/67513/diff/2/

Changes: https://reviews.apache.org/r/67513/diff/1-2/


Testing
---

make check
Fixed all existing tests.
Dedicate test added in a subsequent patch.


Thanks,

Meng Zhu

Re: Review Request 67614: Removed memcpy from os::Fork::instantiate.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67614/#review204876
---


Ship it!




Thanks for this cleanup James!

Do you know whether we trigger just implementation-defined or really undefined 
behavior here? In the later case we might want to backport the change as this 
has been part of all releases since 0.28.0.

The change that broke `memcpy`'s preconditions was `4a01850c55` which changed 
`Tree::Memory::set` from `bool` to a `std::atomic_bool`. Let's call out that 
commit in the commit message here.

I left notes unrelated to your fix below; feel free to ignore them.


3rdparty/stout/include/stout/os/posix/fork.hpp
Line 338 (original), 338 (patched)


This function looks like it does not modify `tree`, but in fact does modify 
`tree.process` through a pointer. I feel something like taking a `Tree* tree` 
would be more honest.



3rdparty/stout/include/stout/os/posix/fork.hpp
Line 350 (original), 350 (patched)


There seems to be some non-async signal safe stuff in this `fork`/`exec*` 
bracket (e.g., `set.store`, construction of `std::set pids`, 
`pids.insert`).

We should probably create a ticket for that.


- Benjamin Bannier


On June 15, 2018, 8:36 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67614/
> ---
> 
> (Updated June 15, 2018, 8:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Hindman.
> 
> 
> Bugs: MESOS-9002
> https://issues.apache.org/jira/browse/MESOS-9002
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GCC 8.1 warns about using `memcpy` to copy a `os::Fork::Tree::Memory`
> struct because it doesn't have a trivial copy operator. We can replace
> the `memcpy` with direct access to the structure fields, which has the
> same effect.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/fork.hpp 
> 098224ee4abe73b61f180af3dac5989141e5908a 
> 
> 
> Diff: https://reviews.apache.org/r/67614/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review204874
---



Patch looks great!

Reviews applied: [67502, 67503, 67504, 67505]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 14, 2018, 11:13 p.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> ---
> 
> (Updated June 14, 2018, 11:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored verify-reviews.py to use commons.py and argparse
> 
> 
> Diffs
> -
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67614: Removed memcpy from os::Fork::instantiate.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67614/#review204871
---



PASS: Mesos patch 67614 was successfully built and tested.

Reviews applied: `['67614']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67614

- Mesos Reviewbot Windows


On June 15, 2018, 6:36 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67614/
> ---
> 
> (Updated June 15, 2018, 6:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Hindman.
> 
> 
> Bugs: MESOS-9002
> https://issues.apache.org/jira/browse/MESOS-9002
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GCC 8.1 warns about using `memcpy` to copy a `os::Fork::Tree::Memory`
> struct because it doesn't have a trivial copy operator. We can replace
> the `memcpy` with direct access to the structure fields, which has the
> same effect.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/fork.hpp 
> 098224ee4abe73b61f180af3dac5989141e5908a 
> 
> 
> Diff: https://reviews.apache.org/r/67614/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67616: Added the limitation of the nested container id length.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204869
---



PASS: Mesos patch 67616 was successfully built and tested.

Reviews applied: `['67616']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67616

- Mesos Reviewbot Windows


On June 15, 2018, 7:07 p.m., wei xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> ---
> 
> (Updated June 15, 2018, 7:07 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
> https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the limitation of the nested container id length.
> 
> 
> Diffs
> -
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp 
> d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Review Request 67615: Modified `createStrippedScalarQuantity()` to clear all metadata fields.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67615/
---

Review request for mesos, Benjamin Mahler, Kapil Arya, and Till Toenshoff.


Repository: mesos


Description
---

Currently `createStrippedScalarQuantity()` strips resource meta-data
except revocable and turns dynamic reservation into static reservation.
However, no current code depends on this behavior and this leads to
boilerplate code around call sites and performance overhead.

This patch further clears the above meta-data for simplicity
and performance.


Diffs
-

  include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce 
  include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932 
  src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca 
  src/master/allocator/mesos/hierarchical.cpp 
b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 
  src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1 
  src/tests/sorter_tests.cpp 9cdffd778967bca3d0055be8a04fbb702432e59d 
  src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8 


Diff: https://reviews.apache.org/r/67615/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/
---

(Updated June 15, 2018, 1:45 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, 
Greg Mann, Jie Yu, James Peach, Joseph Wu, and Till Toenshoff.


Changes
---

Updated and moved documentation into its own file.


Repository: mesos


Description
---

Note that while cquery and LSP support many editors, this only
demonstrates how to setup Emacs. Documentation on Vim setup is
welcome!


Diffs (updated)
-

  docs/cquery.md PRE-CREATION 
  docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 


Diff: https://reviews.apache.org/r/67308/diff/2/

Changes: https://reviews.apache.org/r/67308/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67597/#review204865
---



PASS: Mesos patch 67597 was successfully built and tested.

Reviews applied: `['67597']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67597

- Mesos Reviewbot Windows


On June 15, 2018, 5:44 p.m., bin zheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67597/
> ---
> 
> (Updated June 15, 2018, 5:44 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8871
> https://issues.apache.org/jira/browse/MESOS-8871
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed an issue where agent may fail to recover.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> 98c8fc769f2525c66539f08e2aa82506912e8a59 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 71247c308b205de3d20a41ceb06eed6aa70fb25d 
> 
> 
> Diff: https://reviews.apache.org/r/67597/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bin zheng
> 
>

Review Request 67616: Added the limitation of the nested container id length.

[wei xiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-7168
https://issues.apache.org/jira/browse/MESOS-7168


Repository: mesos


Description
---

Added the limitation of the nested container id length.


Diffs
-

  src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
  src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
  src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 


Diff: https://reviews.apache.org/r/67616/diff/1/


Testing
---


Thanks,

wei xiao

Review Request 67614: Removed memcpy from os::Fork::instantiate.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67614/
---

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-9002
https://issues.apache.org/jira/browse/MESOS-9002


Repository: mesos


Description
---

GCC 8.1 warns about using `memcpy` to copy a `os::Fork::Tree::Memory`
struct because it doesn't have a trivial copy operator. We can replace
the `memcpy` with direct access to the structure fields, which has the
same effect.


Diffs
-

  3rdparty/stout/include/stout/os/posix/fork.hpp 
098224ee4abe73b61f180af3dac5989141e5908a 


Diff: https://reviews.apache.org/r/67614/diff/1/


Testing
---

make check (Fedora 28)


Thanks,

James Peach

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

[bin zheng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67597/
---

(Updated 六月 15, 2018, 5:44 p.m.)


Review request for mesos and Gilbert Song.


Changes
---

Ok, Updated according to new idea


Bugs: MESOS-8871
https://issues.apache.org/jira/browse/MESOS-8871


Repository: mesos


Description (updated)
---

Fixed an issue where agent may fail to recover.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
98c8fc769f2525c66539f08e2aa82506912e8a59 
  src/tests/containerizer/provisioner_docker_tests.cpp 
71247c308b205de3d20a41ceb06eed6aa70fb25d 


Diff: https://reviews.apache.org/r/67597/diff/2/

Changes: https://reviews.apache.org/r/67597/diff/1-2/


Testing
---


Thanks,

bin zheng

Re: Review Request 67609: Added DaoTan Cui to the contributors list.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67609/#review204854
---



Patch looks great!

Reviews applied: [67609]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 15, 2018, 12:08 a.m., cui dt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67609/
> ---
> 
> (Updated June 15, 2018, 12:08 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added DaoTan Cui to the contributors list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 6a5b215050c8c4ac2b4416ec4afad8265a4d394a 
> 
> 
> Diff: https://reviews.apache.org/r/67609/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> cui dt
> 
>

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

[CHEN RUNCONG]

> On 六月 14, 2018, 11:18 p.m., Gilbert Song wrote:
> > src/slave/containerizer/docker.cpp
> > Lines 1386 (patched)
> > 
> >
> > one newline below

fixed it


- CHEN


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67585/#review204804
---


On 六月 15, 2018, 5:21 p.m., CHEN RUNCONG wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67585/
> ---
> 
> (Updated 六月 15, 2018, 5:21 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-6092
> https://issues.apache.org/jira/browse/MESOS-6092
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the issue:if the container is destroyed in the mean time, then we will 
> potentially segfault here.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 
> 
> 
> Diff: https://reviews.apache.org/r/67585/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> CHEN RUNCONG
> 
>

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

[CHEN RUNCONG]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67585/
---

(Updated 六月 15, 2018, 5:21 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-6092
https://issues.apache.org/jira/browse/MESOS-6092


Repository: mesos


Description
---

Fixed the issue:if the container is destroyed in the mean time, then we will 
potentially segfault here.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 


Diff: https://reviews.apache.org/r/67585/diff/3/

Changes: https://reviews.apache.org/r/67585/diff/2-3/


Testing
---


Thanks,

CHEN RUNCONG

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

[CHEN RUNCONG]

> On 六月 14, 2018, 11:18 p.m., Gilbert Song wrote:
> > src/slave/containerizer/docker.cpp
> > Lines 1383-1385 (patched)
> > 
> >
> > Please follow this format:
> > 
> > ```
> >   if (containers_[containerId]->state == Container::DESTROYING) {
> > return Failure(
> > "Container is being destroyed during launching excutor 
> > container");
> >   }
> > ```

ok


- CHEN


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67585/#review204804
---


On 六月 15, 2018, 5:21 p.m., CHEN RUNCONG wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67585/
> ---
> 
> (Updated 六月 15, 2018, 5:21 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-6092
> https://issues.apache.org/jira/browse/MESOS-6092
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the issue:if the container is destroyed in the mean time, then we will 
> potentially segfault here.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 
> 
> 
> Diff: https://reviews.apache.org/r/67585/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> CHEN RUNCONG
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204850
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67413', '67487', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

- Mesos Reviewbot Windows


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/4/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67604: Made configured shell script inputs executable.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67604/#review204847
---



Patch looks great!

Reviews applied: [67603, 67604]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 14, 2018, 10:20 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67604/
> ---
> 
> (Updated June 14, 2018, 10:20 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While this is not required for the autotools build where manual
> intervention is needed to make the output of `AC_CONFIG_FILES`
> executable, cmake will copy existing permissions when executing
> `configure_file`. Making the input files explicitly executable
> simplifies the needed steps in the cmake build and also serves as
> documentation.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e 
> 
> 
> Diff: https://reviews.apache.org/r/67604/diff/1/
> 
> 
> Testing
> ---
> 
> NOTE:
> 
> **Reviewboard seems to have issues tracking the permission changes in this 
> patch.
> Please apply the patch file below instead of the patch related directly to 
> this rr.**
> 
> (done shouting)
> 
> 
> # Testing done
> 
> * made sure that all shell scripts created as part of `cmake ..` are 
> executable
> * `make distcheck` for good measure, but likely unable to detect issues here.
> 
> 
> File Attachments
> 
> 
> PLEASE APPLY THIS PATCH MANUALLY INSTEAD
>   
> https://reviews.apache.org/media/uploaded/files/2018/06/14/2503e381-af7c-4de4-ac67-d259102bf5cf__0001-Made-configured-shell-script-inputs-executable.patch
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67412/#review204843
---


Ship it!




Ship It!

- Kevin Klues


On June 1, 2018, 3:14 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67412/
> ---
> 
> (Updated June 1, 2018, 3:14 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We set `PYTHON` and `PYTHON_VERSION` when configuring the build.
> We now cover all possible cases (both variables set, only one, none).
> This ensures that both variables are set after being checked.
> 
> 
> Diffs
> -
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
> 
> 
> Diff: https://reviews.apache.org/r/67412/diff/3/
> 
> 
> Testing
> ---
> 
> I added two lines after the new code:
> ```
>   AC_MSG_NOTICE([$PYTHON])
>   AC_MSG_NOTICE([$PYTHON_VERSION])
> ```
> 
> Then, when using `configure`, I've checked the output.
> ```
> $ ../configure 
> ...
> configure: /usr/bin/python
> configure: 2.7
> $ PYTHON_VERSION=4 ../configure
> ...
> configure: python4
> configure: 4
> $ PYTHON=yolo ../configure
> ...
> configure: yolo
> configure:
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67412/#review204842
---


Fix it, then Ship it!




Ship It!


configure.ac
Lines 2276-2277 (patched)


Changing this to the followign before I commit it:
```
+AC_CHECK_PROG([PYTHON_CHECK], [$PYTHON], [yes])
+AS_IF([test "x$PYTHON_CHECK" = "xyes"], [
+  PYTHON_VERSION=`$PYTHON -c "import sys; 
sys.stdout.write(sys.version[[:3]])"`
+], [
+  AC_MSG_ERROR([Cannot find Python executable '$PYTHON' in path.])
+])
```


- Kevin Klues


On June 1, 2018, 3:14 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67412/
> ---
> 
> (Updated June 1, 2018, 3:14 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We set `PYTHON` and `PYTHON_VERSION` when configuring the build.
> We now cover all possible cases (both variables set, only one, none).
> This ensures that both variables are set after being checked.
> 
> 
> Diffs
> -
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
> 
> 
> Diff: https://reviews.apache.org/r/67412/diff/3/
> 
> 
> Testing
> ---
> 
> I added two lines after the new code:
> ```
>   AC_MSG_NOTICE([$PYTHON])
>   AC_MSG_NOTICE([$PYTHON_VERSION])
> ```
> 
> Then, when using `configure`, I've checked the output.
> ```
> $ ../configure 
> ...
> configure: /usr/bin/python
> configure: 2.7
> $ PYTHON_VERSION=4 ../configure
> ...
> configure: python4
> configure: 4
> $ PYTHON=yolo ../configure
> ...
> configure: yolo
> configure:
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67355: Removed `os::getenv()` calls from `MesosProcess`.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67355/#review204834
---


Fix it, then Ship it!




I'll fix the outstanding issues and commit shortly.


src/executor/executor.cpp
Line 171 (original), 172-173 (patched)


Add a TODO MESOS-9001.


- Alexander Rukletsov


On May 29, 2018, 2:20 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67355/
> ---
> 
> (Updated May 29, 2018, 2:20 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
> huang, Ilya Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
> https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds overloaded constructor for `v1::executor::Mesos` class
> that accepts `environment` parameter that is passed over to
> `MesosProcess` constructor. This change is needed to get rid of
> `os::getenv()` calls, so that v1 Executor can be used in tests that
> require thread safety.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor.hpp ca48f29483f3f5caeb070f33d009ab89c9f4829b 
>   src/executor/executor.cpp 5e95f999535a81bf6873144a83d520897b3cdc8a 
>   src/tests/mesos.hpp 8f529fad7041cb375dc6b0e07273a8412d5519b4 
> 
> 
> Diff: https://reviews.apache.org/r/67355/diff/4/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67354/#review204835
---


Fix it, then Ship it!




I'll fix the outstanding issues and commit shortly.


src/exec/exec.cpp
Line 646 (original), 654-655 (patched)


Add a TODO MESOS-9001.


- Alexander Rukletsov


On May 29, 2018, 2:20 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67354/
> ---
> 
> (Updated May 29, 2018, 2:20 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
> huang, Ilya Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
> https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds overloaded constructor for `MesosExecutorDriver` that
> accepts `environment` parameter and stores it in the class variable.
> This new constructor is needed to get rid of `os::getenv()` calls,
> so that `MesosExecutorDriver` can be used in tests that require
> thread safety.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp d14c0369f6731100d27092142b56f108f8881003 
>   src/exec/exec.cpp 65a671d7ce83a51087d290ba039d18deba6313c2 
> 
> 
> Diff: https://reviews.apache.org/r/67354/diff/3/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67356/#review204832
---


Fix it, then Ship it!




I'll fix the outstanding issues and commit shortly.


src/tests/containerizer.cpp
Lines 128-129 (original), 128-129 (patched)


```
// Assemble the environment for the executor.
//
// NOTE: Since in this case the executor will live in the same OS 
process,
// pass the environment into the executor driver (library) c-tor 
directly
// instead of manipulating `setenv`/`getenv` to avoid concurrent
// modification of the environment.
```


- Alexander Rukletsov


On May 29, 2018, 2:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67356/
> ---
> 
> (Updated May 29, 2018, 2:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
> huang, Ilya Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
> https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes `os::setenv()`, `os::unsetenv()` calls that are
> currently used to implicitly configure both MesosExecutorDriver and
> v1 Executor via global environment variables. This change prepares a
> map containing modified environment and passes it to a constructor of
> an executor.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb 
> 
> 
> Diff: https://reviews.apache.org/r/67356/diff/5/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/#review204840
---




include/mesos/master/master.proto
Lines 605-606 (original), 605-609 (patched)


Please also update comments in `include/mesos/v1/master/master.proto`



include/mesos/master/master.proto
Lines 606 (patched)


```
// This is the latest state of the task according to the agent,
// which can be more recent...
```


- Zhitao Li


On June 15, 2018, 5:45 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67575/
> ---
> 
> (Updated June 15, 2018, 5:45 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Vinod Kone, 
> and Zhitao Li.
> 
> 
> Bugs: MESOS-9000
> https://issues.apache.org/jira/browse/MESOS-9000
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this change, the master would only send TaskUpdated messages
> to subscribers when the latest known task state on the agent changed.
> 
> This implied that schedulers could not reliably wait for the status
> information corresponding to specific state updates (i.e. TASK_RUNNING),
> since there is no guarantee that subscribers get notified during
> the time when this status update will be included in the status field.
> 
> After this change, TaskUpdate messages are sent whenever the latest
> acknowledged state of the task changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/67575/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review204839
---



PASS: Mesos patch 67565 was successfully built and tested.

Reviews applied: `['67563', '67526', '67564', '67565']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67565

- Mesos Reviewbot Windows


On June 15, 2018, 11:55 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> ---
> 
> (Updated June 15, 2018, 11:55 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> 231e9588c0d831c05a1d84f35f0f68105900789c 
> 
> 
> Diff: https://reviews.apache.org/r/67565/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67411: Broadened check for Autotools Python environment variables.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67411/#review204837
---


Ship it!




Ship It!

- Kevin Klues


On June 15, 2018, 1:16 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67411/
> ---
> 
> (Updated June 15, 2018, 1:16 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The checks now also apply if we run configure with disabled Python
> bindings but enabled new CLI. Another check regarding the Python
> version has been kept separated as we will use different Python
> versions for both components in a later commit.
> 
> 
> Diffs
> -
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
> 
> 
> Diff: https://reviews.apache.org/r/67411/diff/3/
> 
> 
> Testing
> ---
> 
> ```
> $ PYTHON=yolo PYTHON_VERSION=3 ../configure --disable-java --disable-python 
> --enable-new-cli
> ...
> configure: error: only specify one of PYTHON or PYTHON_VERSION
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67411: Broadened check for Autotools Python environment variables.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67411/
---

(Updated June 15, 2018, 1:16 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
and Kevin Klues.


Bugs: MESOS-8955
https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description (updated)
---

The checks now also apply if we run configure with disabled Python
bindings but enabled new CLI. Another check regarding the Python
version has been kept separated as we will use different Python
versions for both components in a later commit.


Diffs (updated)
-

  configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 


Diff: https://reviews.apache.org/r/67411/diff/3/

Changes: https://reviews.apache.org/r/67411/diff/2-3/


Testing
---

```
$ PYTHON=yolo PYTHON_VERSION=3 ../configure --disable-java --disable-python 
--enable-new-cli
...
configure: error: only specify one of PYTHON or PYTHON_VERSION
```


Thanks,

Armand Grillet

Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization.

[Benjamin Bannier]

> On June 12, 2018, 9:47 p.m., Jie Yu wrote:
> > src/tests/containerizer/nested_mesos_containerizer_tests.cpp
> > Lines 1017-1028 (original), 1012-1028 (patched)
> > 
> >
> > Any reason we cannot use a named pipe as well here?
> 
> Benjamin Bannier wrote:
> The container mounts its own filesystem. I am not sure how we'd make a 
> named pipe in the host filesystem visible (we need to be able to access the 
> pipe from thr outside to make sure we only inspect the filesystem in the 
> nested container once the parent filesystem is ready).

Changed test to use a named pipe in a volume now.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67398/#review204629
---


On June 15, 2018, 3 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67398/
> ---
> 
> (Updated June 15, 2018, 3 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-8917
> https://issues.apache.org/jira/browse/MESOS-8917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some tests of nested container functionality used pipes passed to
> launched tasks to detect whether a task has actually started executing
> the workload (`TASK_RUNNING` updates might be sent before the task
> workload is actually started).
> 
> Once we avoid leaking unspecified file descriptors into forked
> processes, this test setup will be broken. In this patch we replace
> the use of pipes for synchronization with HTTP requests to an actor
> running in the tests, or wait on other observable side effects.
> 
> 
> Diffs
> -
> 
>   src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> 6050e6ebed87249382d56aedb6d98d3cf9812bb9 
> 
> 
> Diff: https://reviews.apache.org/r/67398/diff/4/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> Tested in internal CI on a number of platforms.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67398/
---

(Updated June 15, 2018, 3 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Removed `Waiter`.


Bugs: MESOS-8917
https://issues.apache.org/jira/browse/MESOS-8917


Repository: mesos


Description
---

Some tests of nested container functionality used pipes passed to
launched tasks to detect whether a task has actually started executing
the workload (`TASK_RUNNING` updates might be sent before the task
workload is actually started).

Once we avoid leaking unspecified file descriptors into forked
processes, this test setup will be broken. In this patch we replace
the use of pipes for synchronization with HTTP requests to an actor
running in the tests, or wait on other observable side effects.


Diffs (updated)
-

  src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
6050e6ebed87249382d56aedb6d98d3cf9812bb9 


Diff: https://reviews.apache.org/r/67398/diff/4/

Changes: https://reviews.apache.org/r/67398/diff/3-4/


Testing
---

`sudo make check`

Tested in internal CI on a number of platforms.


Thanks,

Benjamin Bannier

Re: Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/
---

(Updated June 15, 2018, 7:54 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67564/diff/2/

Changes: https://reviews.apache.org/r/67564/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/
---

(Updated June 15, 2018, 7:55 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67565/diff/2/

Changes: https://reviews.apache.org/r/67565/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 67526: Added container-specific cgroup FS mounts.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/
---

(Updated June 15, 2018, 7:53 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Only do container-specific cgroups mounts for container with rootfs.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added container-specific cgroup FS mounts.


Diffs (updated)
-

  src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
215e32461e851668247f9fae62aa656f5dd5e245 


Diff: https://reviews.apache.org/r/67526/diff/3/

Changes: https://reviews.apache.org/r/67526/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

[Benno Evers]

> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/include/process/http.hpp
> > Line 701 (original), 701-702 (patched)
> > 
> >
> > Why not using `process::http::Status::string()`  
> > https://github.com/apache/mesos/blob/2198b961d24b788564d36490cf52f78d7ec07655/3rdparty/libprocess/src/http.cpp#L176-L180
> >  instead?
> > 
> > Maybe then you can even put a single line into `Response` c-tor instead 
> > of modifying individual classes.
> 
> Benno Evers wrote:
> I didn't know about this function, but looking at it it seems to be in 
> direct violation of our style guide at 
> (https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables)
>  so we should probably look into deprecating it rather than promoting further 
> usage.
> 
> But even w/o that issue, I'm not sure that
> 
> ```
>   BadRequest()
> : Response(Status::string(Status::BAD_REQUEST), Status::BAD_REQUEST) 
> {}
> ```
> 
> is better than
> 
> ```
>   BadRequest()
> : Response("400 Bad Request.", Status::BAD_REQUEST) {}
> ```
> 
> 
> I dont think putting it in the default constructor of `Response` is a 
> good idea, because we more or less endorse constructing responses like this
> 
> ```
>   process::http::OK response;
>   response.type = response.PATH;
>   response.path = path;
>   response.headers["Content-Type"] = "application/octet-stream";
>   response.headers["Content-Disposition"] =
> strings::format("attachment; filename=%s", path).get();
> ```
> 
> and we would need to audit all usages of such responses to ensure they're 
> not confused by suddenly having an additional body.
> 
> Alexander Rukletsov wrote:
> What I don't like about the current approach is the duplication: we 
> already have `code -> string` mapping in http.cpp, it would be good to reuse 
> it here so that they don't go out of sync.

I guess I don't really see why it would be a problem if the two go out of sync 
- many pages have very elaborate 404 error pages including images, animations 
and lots of text, so I don't think any tool will have the assumption that the 
response body equals the stringified HTTP status code.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67414/#review204313
---


On June 1, 2018, 3:14 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67414/
> ---
> 
> (Updated June 1, 2018, 3:14 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> By default on error libprocess would only return a response
> with the correct status code and no response body.
> 
> However, most browsers do not visually indicate the response
> status code, making it hard for the user to figure out what
> exactly the problem was.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 055447e13117c0a3ba79d0fc326ece657e8f064f 
> 
> 
> Diff: https://reviews.apache.org/r/67414/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67597/#review204824
---



Patch looks great!

Reviews applied: [67597]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 14, 2018, 7:48 a.m., bin zheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67597/
> ---
> 
> (Updated June 14, 2018, 7:48 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8871
> https://issues.apache.org/jira/browse/MESOS-8871
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed an issue where agent may fail to recover if the agent dies before image 
> store cache to the checkpoint. when images file is empty, remove it and 
> continue.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> 98c8fc769f2525c66539f08e2aa82506912e8a59 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 71247c308b205de3d20a41ceb06eed6aa70fb25d 
> 
> 
> Diff: https://reviews.apache.org/r/67597/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bin zheng
> 
>

Re: Review Request 67602: Improve the debug logging in mesos container

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67602/#review204822
---



Patch looks great!

Reviews applied: [67602]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 14, 2018, 7:45 p.m., CHEN RUNCONG wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67602/
> ---
> 
> (Updated June 14, 2018, 7:45 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8423
> https://issues.apache.org/jira/browse/MESOS-8423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improve the debug logging in mesos container
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 7b3b0d34a26a695e36a2f89e24b80b02ecc9b7c7 
> 
> 
> Diff: https://reviews.apache.org/r/67602/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> CHEN RUNCONG
> 
>