Re: Review Request 68970: Fixed JSON object type error when using `support/apply-reviews.py`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68970/#review209400 --- PASS: Mesos patch 68970 was successfully built and tested. Reviews applied: `['68970']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2444/mesos-review-68970 - Mesos Reviewbot Windows On Oct. 10, 2018, 5:21 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68970/ > --- > > (Updated Oct. 10, 2018, 5:21 a.m.) > > > Review request for mesos, Till Toenshoff and Vinod Kone. > > > Bugs: MESOS-9253 > https://issues.apache.org/jira/browse/MESOS-9253 > > > Repository: mesos > > > Description > --- > > The error `TypeError: the JSON object must be str, not 'bytes'` was > visible when using `support/apply-reviews.py` in our CI. This issue > seems to only happen in old versions of Python 3 that are not supported > but the fix works with any version of Python 3 and allows us to not > change the Python interpreter used by reviewbot. > > > Diffs > - > > support/apply-reviews.py 92ad85945fb97e6ae3e21b3b9ab53c885158417e > > > Diff: https://reviews.apache.org/r/68970/diff/1/ > > > Testing > --- > > Added the line `print(type(json_str))` in `def url_to_json(url):` to verify > that the type was now a `str` and not a `http.client.HTTPResponse`. > > > Thanks, > > Armand Grillet > >
Review Request 68970: Fixed JSON object type error when using `support/apply-reviews.py`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68970/ --- Review request for mesos, Till Toenshoff and Vinod Kone. Bugs: MESOS-9253 https://issues.apache.org/jira/browse/MESOS-9253 Repository: mesos Description --- The error `TypeError: the JSON object must be str, not 'bytes'` was visible when using `support/apply-reviews.py` in our CI. This issue seems to only happen in old versions of Python 3 that are not supported but the fix works with any version of Python 3 and allows us to not change the Python interpreter used by reviewbot. Diffs - support/apply-reviews.py 92ad85945fb97e6ae3e21b3b9ab53c885158417e Diff: https://reviews.apache.org/r/68970/diff/1/ Testing --- Added the line `print(type(json_str))` in `def url_to_json(url):` to verify that the type was now a `str` and not a `http.client.HTTPResponse`. Thanks, Armand Grillet
Re: Review Request 68706: Added master failover reregistration progress metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/#review209389 --- PASS: Mesos patch 68706 was successfully built and tested. Reviews applied: `['68706']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2443/mesos-review-68706 - Mesos Reviewbot Windows On Oct. 9, 2018, 11:24 p.m., Xudong Ni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68706/ > --- > > (Updated Oct. 9, 2018, 11:24 p.m.) > > > Review request for mesos, Benjamin Mahler, James Peach, and Jiang Yan Xu. > > > Bugs: MESOS-9178 > https://issues.apache.org/jira/browse/MESOS-9178 > > > Repository: mesos > > > Description > --- > > During the master failover, the time that the master elected is > considered as the start of failover. In the progress of > reregistration, the percentile represents the time when such > percentile of agents finished registration again; The percentile of > these data as in this metrics can represent overall reregistration > progress; In case of degradation towards to the end of reregistration, > the high percentile can reflect it; In the case there are unreachable > agents in the failover, if certain percentile recovery couldn't be > reached, the intiail value of that percentile will not be updated. > > > Diffs > - > > docs/monitoring.md 00c6ea94bcb73746aef740236632ede123f5b534 > src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 > src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 > src/master/metrics.hpp e1da18e6ba2737f729e1e30653020538150ae898 > src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 > > > Diff: https://reviews.apache.org/r/68706/diff/3/ > > > Testing > --- > > Tested in mmaster with 6 reregistration agents: > "master/slave_reregistrations": 6, > > In the middle of reregistration process: > "master/slaves_100_percent_reregistered_secs": 0, > "master/slaves_25_percent_reregistered_secs": 2.244662016, > "master/slaves_50_percent_reregistered_secs": 3.599491072, > "master/slaves_75_percent_reregistered_secs": 9.53919616, > "master/slaves_90_percent_reregistered_secs": 0, > "master/slaves_99_percent_reregistered_secs": 0, > > When all registrations finished: > "master/slaves_100_percent_reregistered_secs": 29.697210112, > "master/slaves_25_percent_reregistered_secs": 2.244662016, > "master/slaves_50_percent_reregistered_secs": 3.599491072, > "master/slaves_75_percent_reregistered_secs": 9.53919616, > "master/slaves_90_percent_reregistered_secs": 29.697210112, > "master/slaves_99_percent_reregistered_secs": 29.697210112, > > > Thanks, > > Xudong Ni > >
[GitHub] bmahler closed pull request #314: Fixed failed test `CGROUPS_ROOT_PidNamespace*`.
bmahler closed pull request #314: Fixed failed test `CGROUPS_ROOT_PidNamespace*`. URL: https://github.com/apache/mesos/pull/314 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/src/tests/slave_recovery_tests.cpp b/src/tests/slave_recovery_tests.cpp index 3188b03b25..c0d44e914c 100644 --- a/src/tests/slave_recovery_tests.cpp +++ b/src/tests/slave_recovery_tests.cpp @@ -4528,10 +4528,8 @@ TEST_F(MesosContainerizerSlaveRecoveryTest, CGROUPS_ROOT_PidNamespaceForward) // Scheduler expectations. EXPECT_CALL(sched, registered(_, _, _)); - Future statusStarting; Future statusRunning; EXPECT_CALL(sched, statusUpdate(_, _)) -.WillOnce(FutureArg<1>(&statusStarting)) .WillOnce(FutureArg<1>(&statusRunning)) .WillRepeatedly(Return()); @@ -4565,9 +4563,6 @@ TEST_F(MesosContainerizerSlaveRecoveryTest, CGROUPS_ROOT_PidNamespaceForward) ContainerID containerId = *(containers->begin()); // Wait until task is running. - AWAIT_READY(statusStarting); - EXPECT_EQ(TASK_STARTING, statusStarting->state()); - AWAIT_READY(statusRunning); EXPECT_EQ(TASK_RUNNING, statusRunning->state()); @@ -4643,10 +4638,8 @@ TEST_F(MesosContainerizerSlaveRecoveryTest, CGROUPS_ROOT_PidNamespaceBackward) // Scheduler expectations. EXPECT_CALL(sched, registered(_, _, _)); - Future statusStarting; Future statusRunning; EXPECT_CALL(sched, statusUpdate(_, _)) -.WillOnce(FutureArg<1>(&statusStarting)) .WillOnce(FutureArg<1>(&statusRunning)) .WillRepeatedly(Return()); @@ -4679,10 +4672,6 @@ TEST_F(MesosContainerizerSlaveRecoveryTest, CGROUPS_ROOT_PidNamespaceBackward) ContainerID containerId = *(containers->begin()); - // Wait until task is running. - AWAIT_READY(statusStarting); - EXPECT_EQ(TASK_STARTING, statusStarting->state()); - AWAIT_READY(statusRunning); EXPECT_EQ(TASK_RUNNING, statusRunning->state()); This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mengzhugithub closed pull request #307: Generated a new bundle of Boost headers.
mengzhugithub closed pull request #307: Generated a new bundle of Boost headers.
URL: https://github.com/apache/mesos/pull/307
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/3rdparty/boost-1.65.0.tar.gz b/3rdparty/boost-1.65.0.tar.gz
index 25973f3ec5..e9f02d71e8 100644
Binary files a/3rdparty/boost-1.65.0.tar.gz and b/3rdparty/boost-1.65.0.tar.gz
differ
diff --git a/3rdparty/boost.md b/3rdparty/boost.md
new file mode 100644
index 00..e6373f295b
--- /dev/null
+++ b/3rdparty/boost.md
@@ -0,0 +1,41 @@
+# Boost
+
+README for the Mesos third party Boost distribution.
+
+We use the Boost `bcp` utility to bundle only the minimum subset of Boost
headers used by Mesos.
+See: http://www.boost.org/doc/libs/1_65_0/tools/bcp/doc/html/index.html
+
+## Instructions for upgrading Boost. (Based on Boost 1.65.0)
+```
+# Download Boost tarball e.g. boost_1_65_0.tar.gz
+
+# Uncompress Boost and build bcp.
+ $ tar -zxvf boost_1_65_0.tar.gz
+ $ cd boost_1_65_0
+ $ ./bootstrap.sh
+ $ ./b2 tools/bcp
+
+# Get list of all C++ source files in Mesos.
+ $ find -name "*.cpp" -o -name "*.hpp" > files.txt
+
+# Scan the source files using bcp to produce a subset of the headers.
+ $ mkdir ../boost-1.65.0
+ $ cat files.txt | xargs -I {} ./dist/bin/bcp --scan --boost=./ {}
../boost-1.65.0
+
+# Inspect contents of extracted headers and remove unnecessary lib files.
+ $ cd ../boost-1.65.0
+ $ rm -r libs
+
+# Compress Boost directory and bundle it into Mesos.
+ $ cd ..
+ $ GZIP=--best tar -zcf boost-1.65.0.tar.gz boost-1.65.0
+ $ cp boost-1.65.0.tar.gz /3rdparty/
+
+# Update 3rdparty/cmake/Versions.cmake with the new version and
+# its SHA-256 hash. You can obtain the hash as follows, make sure
+# to do this on the stripped release:
+ $ openssl sha -sha256 3rdparty/boost-1.65.0.tar.gz
+
+
+# Update this README if needed.
+```
diff --git a/3rdparty/cmake/Versions.cmake b/3rdparty/cmake/Versions.cmake
index c65d7b3d2d..a1c8184f2a 100644
--- a/3rdparty/cmake/Versions.cmake
+++ b/3rdparty/cmake/Versions.cmake
@@ -1,5 +1,5 @@
set(BOOST_VERSION "1.65.0")
-set(BOOST_HASH
"SHA256=085A1696AE2E735AACD0A497d46AACD7EEC0476E0D39937162F642B92F406476")
+set(BOOST_HASH
"SHA256=0442df595dc56e7da11665120ce9d92ec40c192eb060488131b346bac0938ba3")
set(CONCURRENTQUEUE_VERSION "7b69a8f")
set(CONCURRENTQUEUE_HASH
"SHA256=B2741A1FB2172C2A829503A85D5EE7548BE7ED04236A3FD1EFD2B6088E065CB7")
set(CSI_VERSION "0.2.0")
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mengzhugithub commented on issue #307: Generated a new bundle of Boost headers.
mengzhugithub commented on issue #307: Generated a new bundle of Boost headers. URL: https://github.com/apache/mesos/pull/307#issuecomment-428391409 This patch has landed in https://reviews.apache.org/r/68489. Closing this one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mengzhugithub opened a new pull request #314: Fixed failed test `CGROUPS_ROOT_PidNamespace*`.
mengzhugithub opened a new pull request #314: Fixed failed test `CGROUPS_ROOT_PidNamespace*`. URL: https://github.com/apache/mesos/pull/314 In 1.4, the command executor does not send `TASK_STARTING` update. This patch removes such expectations from the tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Review Request 68706: Added master failover reregistration progress metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 9, 2018, 11:24 p.m.) Review request for mesos, Benjamin Mahler, James Peach, and Jiang Yan Xu. Changes --- fixed the style Bugs: MESOS-9178 https://issues.apache.org/jira/browse/MESOS-9178 Repository: mesos Description --- During the master failover, the time that the master elected is considered as the start of failover. In the progress of reregistration, the percentile represents the time when such percentile of agents finished registration again; The percentile of these data as in this metrics can represent overall reregistration progress; In case of degradation towards to the end of reregistration, the high percentile can reflect it; In the case there are unreachable agents in the failover, if certain percentile recovery couldn't be reached, the intiail value of that percentile will not be updated. Diffs (updated) - docs/monitoring.md 00c6ea94bcb73746aef740236632ede123f5b534 src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 src/master/metrics.hpp e1da18e6ba2737f729e1e30653020538150ae898 src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 Diff: https://reviews.apache.org/r/68706/diff/3/ Changes: https://reviews.apache.org/r/68706/diff/2-3/ Testing --- Tested in mmaster with 6 reregistration agents: "master/slave_reregistrations": 6, In the middle of reregistration process: "master/slaves_100_percent_reregistered_secs": 0, "master/slaves_25_percent_reregistered_secs": 2.244662016, "master/slaves_50_percent_reregistered_secs": 3.599491072, "master/slaves_75_percent_reregistered_secs": 9.53919616, "master/slaves_90_percent_reregistered_secs": 0, "master/slaves_99_percent_reregistered_secs": 0, When all registrations finished: "master/slaves_100_percent_reregistered_secs": 29.697210112, "master/slaves_25_percent_reregistered_secs": 2.244662016, "master/slaves_50_percent_reregistered_secs": 3.599491072, "master/slaves_75_percent_reregistered_secs": 9.53919616, "master/slaves_90_percent_reregistered_secs": 29.697210112, "master/slaves_99_percent_reregistered_secs": 29.697210112, Thanks, Xudong Ni
Re: Review Request 68706: Added master failover reregistration progress metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/#review209386 --- PASS: Mesos patch 68706 was successfully built and tested. Reviews applied: `['68706']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2442/mesos-review-68706 - Mesos Reviewbot Windows On Oct. 9, 2018, 1:45 p.m., Xudong Ni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68706/ > --- > > (Updated Oct. 9, 2018, 1:45 p.m.) > > > Review request for mesos, Benjamin Mahler, James Peach, and Jiang Yan Xu. > > > Bugs: MESOS-9178 > https://issues.apache.org/jira/browse/MESOS-9178 > > > Repository: mesos > > > Description > --- > > During the master failover, the time that the master elected is > considered as the start of failover. In the progress of > reregistration, the percentile represents the time when such > percentile of agents finished registration again; The percentile of > these data as in this metrics can represent overall reregistration > progress; In case of degradation towards to the end of reregistration, > the high percentile can reflect it; In the case there are unreachable > agents in the failover, if certain percentile recovery couldn't be > reached, the intiail value of that percentile will not be updated. > > > Diffs > - > > docs/monitoring.md 00c6ea94bcb73746aef740236632ede123f5b534 > src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 > src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 > src/master/metrics.hpp e1da18e6ba2737f729e1e30653020538150ae898 > src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 > > > Diff: https://reviews.apache.org/r/68706/diff/2/ > > > Testing > --- > > Tested in mmaster with 6 reregistration agents: > "master/slave_reregistrations": 6, > > In the middle of reregistration process: > "master/slaves_100_percent_reregistered_secs": 0, > "master/slaves_25_percent_reregistered_secs": 2.244662016, > "master/slaves_50_percent_reregistered_secs": 3.599491072, > "master/slaves_75_percent_reregistered_secs": 9.53919616, > "master/slaves_90_percent_reregistered_secs": 0, > "master/slaves_99_percent_reregistered_secs": 0, > > When all registrations finished: > "master/slaves_100_percent_reregistered_secs": 29.697210112, > "master/slaves_25_percent_reregistered_secs": 2.244662016, > "master/slaves_50_percent_reregistered_secs": 3.599491072, > "master/slaves_75_percent_reregistered_secs": 9.53919616, > "master/slaves_90_percent_reregistered_secs": 29.697210112, > "master/slaves_99_percent_reregistered_secs": 29.697210112, > > > Thanks, > > Xudong Ni > >
Re: Review Request 61818: Adjusted a comment and a log message around container termination.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61818/#review209384
---
Bad patch!
Reviews applied: [61818]
Failed command: /usr/bin/python3 support/apply-reviews.py -n -r 61818
Error:
2018-10-09 21:40:59 URL:https://reviews.apache.org/r/61818/diff/raw/
[1537/1537] -> "61818.patch" [1]
Traceback (most recent call last):
File "support/apply-reviews.py", line 453, in
main()
File "support/apply-reviews.py", line 448, in main
reviewboard(options)
File "support/apply-reviews.py", line 438, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 166, in apply_review
commit_patch(options)
File "support/apply-reviews.py", line 257, in commit_patch
data = patch_data(options)
File "support/apply-reviews.py", line 304, in patch_data
return reviewboard_data(options)
File "support/apply-reviews.py", line 346, in reviewboard_data
review = url_to_json(review_api_url(review_id)).get('review_request')
File "support/apply-reviews.py", line 98, in url_to_json
return json.loads(json_str.read())
File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
s.__class__.__name__))
TypeError: the JSON object must be str, not 'bytes'
Full log: https://builds.apache.org/job/Mesos-Reviewbot/23468/console
- Mesos Reviewbot
On Oct. 9, 2018, 3:50 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61818/
> ---
>
> (Updated Oct. 9, 2018, 3:50 p.m.)
>
>
> Review request for mesos, Gilbert Song, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> When the container launch is aborted and the container is
> cleaned up in the containerizer before `executorLaunched()` is
> invoked, `containerizer->wait()` called in `executorLaunched()`
> does not hold a termination object. This case should not be
> logged as an error.
>
>
> Diffs
> -
>
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/61818/diff/1/
>
>
> Testing
> ---
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 68706: Added master failover reregistration progress metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 9, 2018, 8:45 p.m.) Review request for mesos, Benjamin Mahler, James Peach, and Jiang Yan Xu. Bugs: MESOS-9178 https://issues.apache.org/jira/browse/MESOS-9178 Repository: mesos Description (updated) --- During the master failover, the time that the master elected is considered as the start of failover. In the progress of reregistration, the percentile represents the time when such percentile of agents finished registration again; The percentile of these data as in this metrics can represent overall reregistration progress; In case of degradation towards to the end of reregistration, the high percentile can reflect it; In the case there are unreachable agents in the failover, if certain percentile recovery couldn't be reached, the intiail value of that percentile will not be updated. Diffs (updated) - docs/monitoring.md 00c6ea94bcb73746aef740236632ede123f5b534 src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 src/master/metrics.hpp e1da18e6ba2737f729e1e30653020538150ae898 src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 Diff: https://reviews.apache.org/r/68706/diff/2/ Changes: https://reviews.apache.org/r/68706/diff/1-2/ Testing (updated) --- Tested in mmaster with 6 reregistration agents: "master/slave_reregistrations": 6, In the middle of reregistration process: "master/slaves_100_percent_reregistered_secs": 0, "master/slaves_25_percent_reregistered_secs": 2.244662016, "master/slaves_50_percent_reregistered_secs": 3.599491072, "master/slaves_75_percent_reregistered_secs": 9.53919616, "master/slaves_90_percent_reregistered_secs": 0, "master/slaves_99_percent_reregistered_secs": 0, When all registrations finished: "master/slaves_100_percent_reregistered_secs": 29.697210112, "master/slaves_25_percent_reregistered_secs": 2.244662016, "master/slaves_50_percent_reregistered_secs": 3.599491072, "master/slaves_75_percent_reregistered_secs": 9.53919616, "master/slaves_90_percent_reregistered_secs": 29.697210112, "master/slaves_99_percent_reregistered_secs": 29.697210112, Thanks, Xudong Ni
Re: Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68965/#review209379
---
Bad patch!
Reviews applied: [68965]
Failed command: /usr/bin/python3 support/apply-reviews.py -n -r 68965
Error:
2018-10-09 19:25:03 URL:https://reviews.apache.org/r/68965/diff/raw/
[3114/3114] -> "68965.patch" [1]
Traceback (most recent call last):
File "support/apply-reviews.py", line 453, in
main()
File "support/apply-reviews.py", line 448, in main
reviewboard(options)
File "support/apply-reviews.py", line 438, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 166, in apply_review
commit_patch(options)
File "support/apply-reviews.py", line 257, in commit_patch
data = patch_data(options)
File "support/apply-reviews.py", line 304, in patch_data
return reviewboard_data(options)
File "support/apply-reviews.py", line 346, in reviewboard_data
review = url_to_json(review_api_url(review_id)).get('review_request')
File "support/apply-reviews.py", line 98, in url_to_json
return json.loads(json_str.read())
File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
s.__class__.__name__))
TypeError: the JSON object must be str, not 'bytes'
Full log: https://builds.apache.org/job/Mesos-Reviewbot/23467/console
- Mesos Reviewbot
On Oct. 9, 2018, 2:18 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68965/
> ---
>
> (Updated Oct. 9, 2018, 2:18 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Added try/catch statements when using Mesos util functions in new CLI.
>
>
> Diffs
> -
>
> src/python/cli_new/lib/cli/mesos.py
> 7cf84bcf1d327bc9c63934e371692cef989ad3aa
> src/python/cli_new/lib/cli/plugins/agent/main.py
> 5e821b36162cea8183f233a86181144daeca0753
> src/python/cli_new/lib/cli/plugins/task/main.py
> a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
>
>
> Diff: https://reviews.apache.org/r/68965/diff/2/
>
>
> Testing
> ---
>
> ```
> (mesos-cli) ? cli_new (MESOS-8795) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_list (cli.tests.task.TestTaskPlugin) ... ok
>
> --
> Ran 4 tests in 5.350s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 61818: Adjusted a comment and a log message around container termination.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61818/#review209374 --- PASS: Mesos patch 61818 was successfully built and tested. Reviews applied: `['61818']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2441/mesos-review-61818 - Mesos Reviewbot Windows On Oct. 9, 2018, 3:50 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61818/ > --- > > (Updated Oct. 9, 2018, 3:50 p.m.) > > > Review request for mesos, Gilbert Song, Ian Downes, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > When the container launch is aborted and the container is > cleaned up in the containerizer before `executorLaunched()` is > invoked, `containerizer->wait()` called in `executorLaunched()` > does not hold a termination object. This case should not be > logged as an error. > > > Diffs > - > > src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a > > > Diff: https://reviews.apache.org/r/61818/diff/1/ > > > Testing > --- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 61818: Adjusted a comment and a log message around container termination.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61818/ --- (Updated Oct. 9, 2018, 3:50 p.m.) Review request for mesos, Gilbert Song, Ian Downes, Jie Yu, and Vinod Kone. Repository: mesos Description --- When the container launch is aborted and the container is cleaned up in the containerizer before `executorLaunched()` is invoked, `containerizer->wait()` called in `executorLaunched()` does not hold a termination object. This case should not be logged as an error. Diffs - src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a Diff: https://reviews.apache.org/r/61818/diff/1/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov
Re: Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68965/#review209368 --- PASS: Mesos patch 68965 was successfully built and tested. Reviews applied: `['68965']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2440/mesos-review-68965 - Mesos Reviewbot Windows On Oct. 9, 2018, 2:18 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68965/ > --- > > (Updated Oct. 9, 2018, 2:18 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8795 > https://issues.apache.org/jira/browse/MESOS-8795 > > > Repository: mesos > > > Description > --- > > Added try/catch statements when using Mesos util functions in new CLI. > > > Diffs > - > > src/python/cli_new/lib/cli/mesos.py > 7cf84bcf1d327bc9c63934e371692cef989ad3aa > src/python/cli_new/lib/cli/plugins/agent/main.py > 5e821b36162cea8183f233a86181144daeca0753 > src/python/cli_new/lib/cli/plugins/task/main.py > a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 > > > Diff: https://reviews.apache.org/r/68965/diff/2/ > > > Testing > --- > > ``` > (mesos-cli) ? cli_new (MESOS-8795) ? mesos-cli-tests > Running the Mesos CLI unit tests > > TestAgentPlugin > test_list (cli.tests.agent.TestAgentPlugin) ... ok > > TestInfrastructure > test_capture_output (cli.tests.tests.TestInfrastructure) ... ok > test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok > > TestTaskPlugin > test_list (cli.tests.task.TestTaskPlugin) ... ok > > -- > Ran 4 tests in 5.350s > > OK > ``` > > > Thanks, > > Armand Grillet > >
Re: Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68965/#review209367 --- Ship it! Ship It! - Kevin Klues On Okt. 9, 2018, 2:18 nachm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68965/ > --- > > (Updated Okt. 9, 2018, 2:18 nachm.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8795 > https://issues.apache.org/jira/browse/MESOS-8795 > > > Repository: mesos > > > Description > --- > > Added try/catch statements when using Mesos util functions in new CLI. > > > Diffs > - > > src/python/cli_new/lib/cli/mesos.py > 7cf84bcf1d327bc9c63934e371692cef989ad3aa > src/python/cli_new/lib/cli/plugins/agent/main.py > 5e821b36162cea8183f233a86181144daeca0753 > src/python/cli_new/lib/cli/plugins/task/main.py > a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 > > > Diff: https://reviews.apache.org/r/68965/diff/2/ > > > Testing > --- > > ``` > (mesos-cli) ? cli_new (MESOS-8795) ? mesos-cli-tests > Running the Mesos CLI unit tests > > TestAgentPlugin > test_list (cli.tests.agent.TestAgentPlugin) ... ok > > TestInfrastructure > test_capture_output (cli.tests.tests.TestInfrastructure) ... ok > test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok > > TestTaskPlugin > test_list (cli.tests.task.TestTaskPlugin) ... ok > > -- > Ran 4 tests in 5.350s > > OK > ``` > > > Thanks, > > Armand Grillet > >
Re: Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68965/ --- (Updated Oct. 9, 2018, 4:18 p.m.) Review request for mesos and Kevin Klues. Changes --- Updated caller to print info about master. Bugs: MESOS-8795 https://issues.apache.org/jira/browse/MESOS-8795 Repository: mesos Description --- Added try/catch statements when using Mesos util functions in new CLI. Diffs (updated) - src/python/cli_new/lib/cli/mesos.py 7cf84bcf1d327bc9c63934e371692cef989ad3aa src/python/cli_new/lib/cli/plugins/agent/main.py 5e821b36162cea8183f233a86181144daeca0753 src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 Diff: https://reviews.apache.org/r/68965/diff/2/ Changes: https://reviews.apache.org/r/68965/diff/1-2/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-8795) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 4 tests in 5.350s OK ``` Thanks, Armand Grillet
Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68965/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8795 https://issues.apache.org/jira/browse/MESOS-8795 Repository: mesos Description --- Added try/catch statements when using Mesos util functions in new CLI. Diffs - src/python/cli_new/lib/cli/plugins/agent/main.py 5e821b36162cea8183f233a86181144daeca0753 src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 Diff: https://reviews.apache.org/r/68965/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-8795) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 4 tests in 5.350s OK ``` Thanks, Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review209364 --- PASS: Mesos patch 66683 was successfully built and tested. Reviews applied: `['66683']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2439/mesos-review-66683 - Mesos Reviewbot Windows On Oct. 9, 2018, 12:49 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > --- > > (Updated Oct. 9, 2018, 12:49 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > --- > > Updated address sanitization in new CLI to accept DNS names. > > > Diffs > - > > src/python/cli_new/lib/cli/config.py > c88952b9f87f1cf558d7aef44803d7a24873d8bf > src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db > src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a > > > Diff: https://reviews.apache.org/r/66683/diff/7/ > > > Testing > --- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://.com:5061" > ``` > On the server providing `http://.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review209358 --- Ship it! Ship It! - Kevin Klues On Okt. 9, 2018, 12:49 nachm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > --- > > (Updated Okt. 9, 2018, 12:49 nachm.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > --- > > Updated address sanitization in new CLI to accept DNS names. > > > Diffs > - > > src/python/cli_new/lib/cli/config.py > c88952b9f87f1cf558d7aef44803d7a24873d8bf > src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db > src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a > > > Diff: https://reviews.apache.org/r/66683/diff/7/ > > > Testing > --- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://.com:5061" > ``` > On the server providing `http://.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- (Updated Oct. 9, 2018, 2:49 p.m.) Review request for mesos and Kevin Klues. Changes --- Removed `master_address` variable and moved function. Bugs: MESOS-8025 https://issues.apache.org/jira/browse/MESOS-8025 Repository: mesos Description --- Updated address sanitization in new CLI to accept DNS names. Diffs (updated) - src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a Diff: https://reviews.apache.org/r/66683/diff/7/ Changes: https://reviews.apache.org/r/66683/diff/6-7/ Testing --- Ran `mesos agent list` successfully with config: ``` [master] address = "http://.com:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- (Updated Oct. 9, 2018, 2:16 p.m.) Review request for mesos and Kevin Klues. Changes --- Published Kevin's review request. Bugs: MESOS-8025 https://issues.apache.org/jira/browse/MESOS-8025 Repository: mesos Description --- Updated address sanitization in new CLI to accept DNS names. Diffs (updated) - src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a Diff: https://reviews.apache.org/r/66683/diff/6/ Changes: https://reviews.apache.org/r/66683/diff/5-6/ Testing --- Ran `mesos agent list` successfully with config: ``` [master] address = "http://.com:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review209356 --- PASS: Mesos patch 66683 was successfully built and tested. Reviews applied: `['66683']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2438/mesos-review-66683 - Mesos Reviewbot Windows On Oct. 9, 2018, 5:37 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > --- > > (Updated Oct. 9, 2018, 5:37 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > --- > > Updated address sanitization in new CLI to accept DNS names. > > > Diffs > - > > src/python/cli_new/lib/cli/config.py > c88952b9f87f1cf558d7aef44803d7a24873d8bf > src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db > src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a > > > Diff: https://reviews.apache.org/r/66683/diff/5/ > > > Testing > --- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://.com:5061" > ``` > On the server providing `http://.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- (Updated Oct. 9, 2018, 11:37 a.m.) Review request for mesos and Kevin Klues. Summary (updated) - Updated address sanitization in new CLI to accept DNS names. Bugs: MESOS-8025 https://issues.apache.org/jira/browse/MESOS-8025 Repository: mesos Description (updated) --- Updated address sanitization in new CLI to accept DNS names. Diffs (updated) - src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a Diff: https://reviews.apache.org/r/66683/diff/5/ Changes: https://reviews.apache.org/r/66683/diff/4-5/ Testing --- Ran `mesos agent list` successfully with config: ``` [master] address = "http://.com:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet
