Re: Review Request 71368: Updated site's middleman versions.

2019-08-25 Thread Benjamin Bannier 


> On Aug. 25, 2019, 11:09 p.m., Benjamin Mahler wrote:
> > site/Gemfile
> > Lines 3-6 (original), 3-6 (patched)
> > 
> >
> > Hm.. what's this syntax expressing? Ditto above.

This means "any package version with version 3.x.x", see 
https://bundler.io/v1.5/gemfile.html#gemfiles.

We additionally version-control `Gemfile.lock`, so there is no strong need to 
bind specific versions in this case here. We want to exclude middleman from 
4.x.x upwards though as it is incompatible.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/#review217429
---


On Aug. 25, 2019, 11:20 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71368/
> ---
> 
> (Updated Aug. 25, 2019, 11:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated site's middleman versions.
> 
> 
> Diffs
> -
> 
>   site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71368/diff/1/
> 
> 
> Testing
> ---
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71368: Updated site's middleman versions.

2019-08-25 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/#review217429
---




site/Gemfile
Lines 3-6 (original), 3-6 (patched)


Hm.. what's this syntax expressing? Ditto above.


- Benjamin Mahler


On Aug. 25, 2019, 9:20 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71368/
> ---
> 
> (Updated Aug. 25, 2019, 9:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated site's middleman versions.
> 
> 
> Diffs
> -
> 
>   site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71368/diff/1/
> 
> 
> Testing
> ---
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71367: Updated site's dependencies.

2019-08-25 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71367/#review217428
---


Ship it!




Ship It!

- Benjamin Mahler


On Aug. 25, 2019, 9:11 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71367/
> ---
> 
> (Updated Aug. 25, 2019, 9:11 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This bumps e.g., `nokogiri` to a version not affected by CVE-2019-5477
> anymore (not that it would have any impact on our use of it).
> 
> 
> Diffs
> -
> 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71367/diff/1/
> 
> 
> Testing
> ---
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71368: Updated site's middleman versions.

2019-08-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/#review217427
---



Patch looks great!

Reviews applied: [71367, 71368]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 25, 2019, 9:20 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71368/
> ---
> 
> (Updated Aug. 25, 2019, 9:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated site's middleman versions.
> 
> 
> Diffs
> -
> 
>   site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71368/diff/1/
> 
> 
> Testing
> ---
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 71368: Updated site's middleman versions.

2019-08-25 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Updated site's middleman versions.


Diffs
-

  site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
  site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 


Diff: https://reviews.apache.org/r/71368/diff/1/


Testing
---

Site still generates.


Thanks,

Benjamin Bannier

Review Request 71367: Updated site's dependencies.

2019-08-25 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71367/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

This bumps e.g., `nokogiri` to a version not affected by CVE-2019-5477
anymore (not that it would have any impact on our use of it).


Diffs
-

  site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 


Diff: https://reviews.apache.org/r/71367/diff/1/


Testing
---

Site still generates.


Thanks,

Benjamin Bannier

Re: Review Request 71361: Added missing `return` statement in `Slave::statusUpdate`.

2019-08-25 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71361/#review217426
---


Ship it!




Ship It!

- Gilbert Song


On Aug. 23, 2019, 5:57 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71361/
> ---
> 
> (Updated Aug. 23, 2019, 5:57 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, if `statusUpdate` was called for a pending task, it would
> forward the status update and then continue executing `statusUpdate`,
> which then checks if there is an executor that is aware of this task.
> Given that a pending task is not known to any executor, it would always
> handle it by forwarding status update one more time. This patch adds
> missing `return` statement, which fixes the issue.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 1d0ec9d2428c3ffa28ad3e960b74f171013cf0c2 
> 
> 
> Diff: https://reviews.apache.org/r/71361/diff/1/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>