Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/ --- (Updated Sept. 28, 2016, 6:22 p.m.) Review request for mesos and Vinod Kone. Changes --- Fix indentation and spacing Bugs: MESOS-6210 https://issues.apache.org/jira/browse/MESOS-6210 Repository: mesos Description --- Detect paths starting with `/redirect/` or `/master_id/redirect/` and return 404 instead of getting into a redirect loop. Diffs (updated) - src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 Diff: https://reviews.apache.org/r/52105/diff/ Testing --- Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` ``` Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Wed, 28 Sep 2016 17:49:22 GMT < Location: //192.168.1.234:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:24 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:26 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:38 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Wed, 28 Sep 2016 17:49:48 GMT < Location: //192.168.1.234:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:50 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:51 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:54 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact ``` It is worth noting that in this PR /master/redirect/ and /redirect/ return 404, not 307. This behavior is consistent with master. Thanks, Charles Allen
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master.
> On Sept. 24, 2016, 8:02 p.m., haosdent huang wrote:
> > src/master/http.cpp, lines 2046-2048
> > <https://reviews.apache.org/r/52105/diff/3/?file=1509354#file1509354line2046>
> >
> > Hi, @drcrallen This comment is not true. As
> > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L427-L429,
> > we use `::redirect` to redirect any path to the leading master internally.
> > So the `request.url.path` may be anything here. This is why I suggest to
> > change to
> >
> > ```
> > diff --git a/src/master/http.cpp b/src/master/http.cpp
> > index e9f9d16..c77229a 100644
> > --- a/src/master/http.cpp
> > +++ b/src/master/http.cpp
> > @@ -2038,6 +2038,11 @@ Future Master::Http::redirect(const
> > Request& request) const
> > // When request url is '/redirect' or '/master/redirect', redirect
> > to the
> > // base url of leading master to avoid infinite redirect loop.
> > return TemporaryRedirect(basePath);
> > + } else if (strings::startsWith(request.url.path, "/redirect/") ||
> > + strings::startsWith(request.url.path,
> > + "/" + master->self().id +
> > "/redirect/")) {
> > +// Stop redirection here to avoid fall into an infinite
> > redirection loop.
> > +return NotFound();
> >} else {
> > ```
> >
> > in the previous comment.
>
> Charles Allen wrote:
> Sure, I can do that.
>
> haosdent huang wrote:
> Many thanks!
Fixed
- Charles
-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52105/#review150311
---
On Sept. 28, 2016, 5:56 p.m., Charles Allen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52105/
> ---
>
> (Updated Sept. 28, 2016, 5:56 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6210
> https://issues.apache.org/jira/browse/MESOS-6210
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Detect paths starting with `/redirect/` or `/master_id/redirect/`
> and return 404 instead of getting into a redirect loop.
>
>
> Diffs
> -
>
> src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740
>
> Diff: https://reviews.apache.org/r/52105/diff/
>
>
> Testing
> ---
>
> Single Node started with `./src/mesos-master --work_dir=/tmp/mesos`
>
>
> ```
> Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 307 Temporary Redirect
> < Date: Wed, 28 Sep 2016 17:49:22 GMT
> < Location: //192.168.1.234:5050
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect/ HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Wed, 28 Sep 2016 17:49:24 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/redirect/foo
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect/foo HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Wed, 28 Sep 2016 17:49:26 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/redirect_foo
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect_foo HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Wed, 28 Sep 2016 17:49:38 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-P
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master.
> On Sept. 24, 2016, 8:29 p.m., haosdent huang wrote: > > It would be better to adjust the commit message like > > > > ``` > > Avoided the redirection loop when request `/redirect/xxx`. > > > > Avoid the redirection loop when send `/redirect/xxx` request to the > > master. > > ``` Fixed - Charles --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/#review150313 ------- On Sept. 28, 2016, 5:56 p.m., Charles Allen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52105/ > --- > > (Updated Sept. 28, 2016, 5:56 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6210 > https://issues.apache.org/jira/browse/MESOS-6210 > > > Repository: mesos > > > Description > --- > > Detect paths starting with `/redirect/` or `/master_id/redirect/` > and return 404 instead of getting into a redirect loop. > > > Diffs > - > > src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 > > Diff: https://reviews.apache.org/r/52105/diff/ > > > Testing > --- > > Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` > > > ``` > Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /redirect HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 307 Temporary Redirect > < Date: Wed, 28 Sep 2016 17:49:22 GMT > < Location: //192.168.1.234:5050 > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/ > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /redirect/ HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 404 Not Found > < Date: Wed, 28 Sep 2016 17:49:24 GMT > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/redirect/foo > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /redirect/foo HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 404 Not Found > < Date: Wed, 28 Sep 2016 17:49:26 GMT > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/redirect_foo > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /redirect_foo HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 404 Not Found > < Date: Wed, 28 Sep 2016 17:49:38 GMT > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirect > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirect HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 307 Temporary Redirect > < Date: Wed, 28 Sep 2016 17:49:48 GMT > < Location: //192.168.1.234:5050 > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirect/ > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirect/ HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 404 Not Found > < Date: Wed, 28 Sep 2016 17:49:50 GMT > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirect/foo > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirect/foo HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 404 Not Found > < Date: Wed, 28 Sep 2016 17:49:51 GMT > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirect_foo > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirect_foo HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 404 Not Found > < Date: Wed, 28 Sep 2016 17:49:54 GMT > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > ``` > > It is worth noting that in this PR /master/redirect/ and /redirect/ return > 404, not 307. This behavior is consistent with master. > > > Thanks, > > Charles Allen > >
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/ --- (Updated Sept. 28, 2016, 5:56 p.m.) Review request for mesos and Vinod Kone. Changes --- Fix silly typo in description Bugs: MESOS-6210 https://issues.apache.org/jira/browse/MESOS-6210 Repository: mesos Description (updated) --- Detect paths starting with `/redirect/` or `/master_id/redirect/` and return 404 instead of getting into a redirect loop. Diffs (updated) - src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 Diff: https://reviews.apache.org/r/52105/diff/ Testing --- Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` ``` Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Wed, 28 Sep 2016 17:49:22 GMT < Location: //192.168.1.234:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:24 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:26 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:38 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Wed, 28 Sep 2016 17:49:48 GMT < Location: //192.168.1.234:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:50 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:51 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:54 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact ``` It is worth noting that in this PR /master/redirect/ and /redirect/ return 404, not 307. This behavior is consistent with master. Thanks, Charles Allen
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/ --- (Updated Sept. 28, 2016, 5:54 p.m.) Review request for mesos and Vinod Kone. Changes --- Addressed code reviews Summary (updated) - Avoid redirect loop in `/redirect/xxx` in the master. Bugs: MESOS-6210 https://issues.apache.org/jira/browse/MESOS-6210 Repository: mesos Description (updated) --- Detect paths starting with `/redirect/` or `/master_id/redirect` and return 404 instead of getting into a redirect loop. Diffs (updated) - src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 Diff: https://reviews.apache.org/r/52105/diff/ Testing (updated) --- Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` ``` Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Wed, 28 Sep 2016 17:49:22 GMT < Location: //192.168.1.234:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:24 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:26 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:38 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Wed, 28 Sep 2016 17:49:48 GMT < Location: //192.168.1.234:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:50 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:51 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:54 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact ``` It is worth noting that in this PR /master/redirect/ and /redirect/ return 404, not 307. This behavior is consistent with master. Thanks, Charles Allen
Re: Review Request 52105: Prevent `/redirect/foo` loop.
> On Sept. 24, 2016, 8:02 p.m., haosdent huang wrote:
> > src/master/http.cpp, lines 2046-2048
> > <https://reviews.apache.org/r/52105/diff/3/?file=1509354#file1509354line2046>
> >
> > Hi, @drcrallen This comment is not true. As
> > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L427-L429,
> > we use `::redirect` to redirect any path to the leading master internally.
> > So the `request.url.path` may be anything here. This is why I suggest to
> > change to
> >
> > ```
> > diff --git a/src/master/http.cpp b/src/master/http.cpp
> > index e9f9d16..c77229a 100644
> > --- a/src/master/http.cpp
> > +++ b/src/master/http.cpp
> > @@ -2038,6 +2038,11 @@ Future Master::Http::redirect(const
> > Request& request) const
> > // When request url is '/redirect' or '/master/redirect', redirect
> > to the
> > // base url of leading master to avoid infinite redirect loop.
> > return TemporaryRedirect(basePath);
> > + } else if (strings::startsWith(request.url.path, "/redirect/") ||
> > + strings::startsWith(request.url.path,
> > + "/" + master->self().id +
> > "/redirect/")) {
> > +// Stop redirection here to avoid fall into an infinite
> > redirection loop.
> > +return NotFound();
> >} else {
> > ```
> >
> > in the previous comment.
Sure, I can do that.
- Charles
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52105/#review150311
---
On Sept. 23, 2016, 6:04 p.m., Charles Allen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52105/
> ---
>
> (Updated Sept. 23, 2016, 6:04 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6210
> https://issues.apache.org/jira/browse/MESOS-6210
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Prevent `/redirect/foo` loop.
>
>
> Diffs
> -
>
> src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740
>
> Diff: https://reviews.apache.org/r/52105/diff/
>
>
> Testing
> ---
>
> Single Node started with `./src/mesos-master --work_dir=/tmp/mesos`
>
>
> ```
> Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 307 Temporary Redirect
> < Date: Fri, 23 Sep 2016 17:30:17 GMT
> < Location: //10.17.97.185:5050
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect/ HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Fri, 23 Sep 2016 17:30:19 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/redirect/foo
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect/foo HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Fri, 23 Sep 2016 17:30:21 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/redirect_foo
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect_foo HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Fri, 23 Sep 2016 17:30:23 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/master/redirect/
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /master/redirect/ HTTP/1.1
>
Re: Review Request 52105: Prevent `/redirect/foo` loop.
> On Sept. 23, 2016, 3:05 p.m., haosdent huang wrote:
> > src/master/http.cpp, lines 2038-2040
> > <https://reviews.apache.org/r/52105/diff/2/?file=1508538#file1508538line2038>
> >
> > Another problem here is if we call `redirect(/redirect_a)` in http.cpp,
> > would get unexpected result. So how about just return 404 which consistent
> > with `/redirect/`
> >
> > ```
> > // When current master is not the leader, redirect to the leading
> > master.
> > if (!master->elected()) {
> > return redirect(request);
> > }
> > ```
>
> Charles Allen wrote:
> Would that mean things like `/redirect/foo` should also return 404?
>
> haosdent huang wrote:
> yes.
>
> haosdent huang wrote:
> This is consistent with `/redirect/`. And I think something like
> `/redirect/foo/redirect/bar/xxx` make it messy if we keep redirecting to
> `/foo/redirect/xxx` here.
Please see updated examples. Pretty much everything is 404 except explicitly
`/redirect` and `/{master_id}/redirect`
- Charles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52105/#review150185
---
On Sept. 23, 2016, 6:04 p.m., Charles Allen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52105/
> ---
>
> (Updated Sept. 23, 2016, 6:04 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6210
> https://issues.apache.org/jira/browse/MESOS-6210
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Prevent `/redirect/foo` loop.
>
>
> Diffs
> -
>
> src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740
>
> Diff: https://reviews.apache.org/r/52105/diff/
>
>
> Testing
> ---
>
> Single Node started with `./src/mesos-master --work_dir=/tmp/mesos`
>
>
> ```
> Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 307 Temporary Redirect
> < Date: Fri, 23 Sep 2016 17:30:17 GMT
> < Location: //10.17.97.185:5050
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect/ HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Fri, 23 Sep 2016 17:30:19 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/redirect/foo
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect/foo HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Fri, 23 Sep 2016 17:30:21 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/redirect_foo
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect_foo HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Fri, 23 Sep 2016 17:30:23 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/master/redirect/
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /master/redirect/ HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Fri, 23 Sep 2016 17:30:49 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/master/redirect
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /master/redirect HTTP/1.1
> > Host:
Re: Review Request 52105: Prevent `/redirect/foo` loop.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/ --- (Updated Sept. 23, 2016, 6:04 p.m.) Review request for mesos and Vinod Kone. Changes --- Fixing review comments Bugs: MESOS-6210 https://issues.apache.org/jira/browse/MESOS-6210 Repository: mesos Description --- Prevent `/redirect/foo` loop. Diffs (updated) - src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 Diff: https://reviews.apache.org/r/52105/diff/ Testing (updated) --- Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` ``` Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Fri, 23 Sep 2016 17:30:17 GMT < Location: //10.17.97.185:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Fri, 23 Sep 2016 17:30:19 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Fri, 23 Sep 2016 17:30:21 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Fri, 23 Sep 2016 17:30:23 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Fri, 23 Sep 2016 17:30:49 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Fri, 23 Sep 2016 17:30:50 GMT < Location: //10.17.97.185:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Fri, 23 Sep 2016 17:30:53 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Fri, 23 Sep 2016 17:30:55 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact ``` It is worth noting that in this PR /master/redirect/ and /redirect/ return 404, not 307. This behavior is consistent with master. Thanks, Charles Allen
Re: Review Request 52105: Prevent `/redirect/foo` loop.
> On Sept. 23, 2016, 3:05 p.m., haosdent huang wrote:
> > src/master/http.cpp, lines 2038-2040
> > <https://reviews.apache.org/r/52105/diff/2/?file=1508538#file1508538line2038>
> >
> > Another problem here is if we call `redirect(/redirect_a)` in http.cpp,
> > would get unexpected result. So how about just return 404 which consistent
> > with `/redirect/`
> >
> > ```
> > // When current master is not the leader, redirect to the leading
> > master.
> > if (!master->elected()) {
> > return redirect(request);
> > }
> > ```
Would that mean things like `/redirect/foo` should also return 404?
- Charles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52105/#review150185
-------
On Sept. 22, 2016, 8:47 p.m., Charles Allen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52105/
> ---
>
> (Updated Sept. 22, 2016, 8:47 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6210
> https://issues.apache.org/jira/browse/MESOS-6210
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Prevent `/redirect/foo` loop.
>
>
> Diffs
> -
>
> src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740
>
> Diff: https://reviews.apache.org/r/52105/diff/
>
>
> Testing
> ---
>
> Single Node started with `./src/mesos-master --work_dir=/tmp/mesos`
>
>
> ```
> Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 307 Temporary Redirect
> < Date: Thu, 22 Sep 2016 20:35:18 GMT
> < Location: //10.17.97.185:5050
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/master/redirect
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /master/redirect HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 307 Temporary Redirect
> < Date: Thu, 22 Sep 2016 20:35:23 GMT
> < Location: //10.17.97.185:5050
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/master/redirect/
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /master/redirect/ HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 404 Not Found
> < Date: Thu, 22 Sep 2016 20:35:29 GMT
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/master/redirect/foo
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /master/redirect/foo HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 307 Temporary Redirect
> < Date: Thu, 22 Sep 2016 20:35:31 GMT
> < Location: //10.17.97.185:5050
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/master/redirect/foo/bar
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /master/redirect/foo/bar HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 307 Temporary Redirect
> < Date: Thu, 22 Sep 2016 20:35:34 GMT
> < Location: //10.17.97.185:5050
> < Content-Length: 0
> <
> * Connection #0 to host 127.0.0.1 left intact
> Charless-MacBook-Pro:~ charlesallen$ curl -v
> http://127.0.0.1:5050/redirect/foo/bar
> * Trying 127.0.0.1...
> * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> > GET /redirect/foo/bar HTTP/1.1
> > Host: 127.0.0.1:5050
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 307 Temporary Redirect
> < Date: Thu, 22 Sep 2016 20:35:41 GMT
> < Location: //10.17.97.185:5050
> < Content-Length:
Re: Review Request 52105: Prevent `/redirect/foo` loop.
> On Sept. 21, 2016, 3:18 p.m., haosdent huang wrote: > > Hi, @drcrallen Thanks a lot for your patch! > > > > I saw your patch try to redirect > > `http://SOME_MASTER:5050/master/redirect/master/frameworks` to > > `http://LEADER_MASTER:5050/master/frameworks`. Could you elaborate the user > > cases about this? Because we have handled the endpoint redirection > > automatically internal. For example, when you request > > `http://NON_LEADING_MASTER:5050/master/frameworks`, mesos master would > > redirect to `http://LEADING_MASTER:5050/master/frameworks`. > > Charles Allen wrote: > That comes from two things: > > 1. > http://mesos.apache.org/documentation/latest/endpoints/master/redirect/ > suggests using redirect as a UI bookmarking mechanism, as such, it seemed > reasonable for other calls to be able to redirect through the same mechanism. > This might be a left-over suggestion from pre-1.0 though. An alternative > thing here would be to update the redirect docs to remove the suggestion for > UI bookmarking if it is no longer required. > 2. That's how some other internal discovery mechanism are setup here, so > I kind of expected http://SOME_MASTER:5050/master/redirect/state to redirect > to the master and get the cluster state. But if the non-leading masters > should redirect to the leading masters then I don't think that is helpful > anymore, and I think that behavior changed with 1.0? > > haosdent huang wrote: > Hi, @drcrallen > > >1. ... suggests using redirect as a UI bookmarking mechanism > > I think you may misunderstand this. We suggest to bookmark > `http://SOME_MASTER:5050/master/redirect` to open the leading master quickly. > And it has never work for `/master/redirect/xxx` before. > > > 2. xxx so I kind of expected > http://SOME_MASTER:5050/master/redirect/state to redirect to the master and > get the cluster state. > > I think just need to access `http://SOME_MASTER:5050/master/state` here. > If `SOME_MASTER` is not the leading master, it would redirct to > `http://LEADING_MASTER/master/state` automatically. This hehaviour never > change with 1.0 > > Charles Allen wrote: > Allright, I'll simplify the patch to only do the string starts with check. @Haosdent simplified scope, and updated master comment testing info with new results. - Charles --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/#review149824 --- On Sept. 22, 2016, 8:47 p.m., Charles Allen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52105/ > --- > > (Updated Sept. 22, 2016, 8:47 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6210 > https://issues.apache.org/jira/browse/MESOS-6210 > > > Repository: mesos > > > Description > --- > > Prevent `/redirect/foo` loop. > > > Diffs > - > > src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 > > Diff: https://reviews.apache.org/r/52105/diff/ > > > Testing > --- > > Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` > > > ``` > Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /redirect HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 307 Temporary Redirect > < Date: Thu, 22 Sep 2016 20:35:18 GMT > < Location: //10.17.97.185:5050 > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirect > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirect HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 307 Temporary Redirect > < Date: Thu, 22 Sep 2016 20:35:23 GMT > < Location: //10.17.97.185:5050 > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirect/ > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirect/ HTTP/1.1 > > Host: 1
Re: Review Request 52105: Prevent `/redirect/foo` loop.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/ --- (Updated Sept. 22, 2016, 8:47 p.m.) Review request for mesos and Vinod Kone. Changes --- Updated test case Bugs: MESOS-6210 https://issues.apache.org/jira/browse/MESOS-6210 Repository: mesos Description --- Prevent `/redirect/foo` loop. Diffs - src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 Diff: https://reviews.apache.org/r/52105/diff/ Testing (updated) --- Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` ``` Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Thu, 22 Sep 2016 20:35:18 GMT < Location: //10.17.97.185:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Thu, 22 Sep 2016 20:35:23 GMT < Location: //10.17.97.185:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Thu, 22 Sep 2016 20:35:29 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Thu, 22 Sep 2016 20:35:31 GMT < Location: //10.17.97.185:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/foo/bar * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/foo/bar HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Thu, 22 Sep 2016 20:35:34 GMT < Location: //10.17.97.185:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/foo/bar * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/foo/bar HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Thu, 22 Sep 2016 20:35:41 GMT < Location: //10.17.97.185:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirectNOTFOUND/foo/bar * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirectNOTFOUND/foo/bar HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Thu, 22 Sep 2016 20:35:47 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact ``` It is worth noting that in this PR /master/redirect/ and /redirect/ return 404, not 307. This behavior is consistent with master. Thanks, Charles Allen
Re: Review Request 52105: Prevent `/redirect/foo` loop.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/ --- (Updated Sept. 22, 2016, 8:46 p.m.) Review request for mesos and Vinod Kone. Changes --- Now with simple loop prevention Summary (updated) - Prevent `/redirect/foo` loop. Bugs: MESOS-6210 https://issues.apache.org/jira/browse/MESOS-6210 Repository: mesos Description (updated) --- Prevent `/redirect/foo` loop. Diffs (updated) - src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 Diff: https://reviews.apache.org/r/52105/diff/ Testing --- Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` ``` Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Tue, 20 Sep 2016 23:12:24 GMT < Location: //10.17.97.185:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Tue, 20 Sep 2016 23:12:35 GMT < Location: //10.17.97.185:5050/foo < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/test * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/test HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Tue, 20 Sep 2016 23:12:49 GMT < Location: //10.17.97.185:5050/test < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirectNOTFOUND/test * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirectNOTFOUND/test HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Tue, 20 Sep 2016 23:12:57 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Tue, 20 Sep 2016 23:13:32 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/test * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/test HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Tue, 20 Sep 2016 23:13:43 GMT < Location: //10.17.97.185:5050/test < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact ``` It is worth noting that in this PR /master/redirect/ and /redirect/ return 404, not 307. This behavior is consistent with master. Thanks, Charles Allen
Re: Review Request 52105: Add smarter master redirects.
> On Sept. 21, 2016, 3:18 p.m., haosdent huang wrote: > > Hi, @drcrallen Thanks a lot for your patch! > > > > I saw your patch try to redirect > > `http://SOME_MASTER:5050/master/redirect/master/frameworks` to > > `http://LEADER_MASTER:5050/master/frameworks`. Could you elaborate the user > > cases about this? Because we have handled the endpoint redirection > > automatically internal. For example, when you request > > `http://NON_LEADING_MASTER:5050/master/frameworks`, mesos master would > > redirect to `http://LEADING_MASTER:5050/master/frameworks`. > > Charles Allen wrote: > That comes from two things: > > 1. > http://mesos.apache.org/documentation/latest/endpoints/master/redirect/ > suggests using redirect as a UI bookmarking mechanism, as such, it seemed > reasonable for other calls to be able to redirect through the same mechanism. > This might be a left-over suggestion from pre-1.0 though. An alternative > thing here would be to update the redirect docs to remove the suggestion for > UI bookmarking if it is no longer required. > 2. That's how some other internal discovery mechanism are setup here, so > I kind of expected http://SOME_MASTER:5050/master/redirect/state to redirect > to the master and get the cluster state. But if the non-leading masters > should redirect to the leading masters then I don't think that is helpful > anymore, and I think that behavior changed with 1.0? > > haosdent huang wrote: > Hi, @drcrallen > > >1. ... suggests using redirect as a UI bookmarking mechanism > > I think you may misunderstand this. We suggest to bookmark > `http://SOME_MASTER:5050/master/redirect` to open the leading master quickly. > And it has never work for `/master/redirect/xxx` before. > > > 2. xxx so I kind of expected > http://SOME_MASTER:5050/master/redirect/state to redirect to the master and > get the cluster state. > > I think just need to access `http://SOME_MASTER:5050/master/state` here. > If `SOME_MASTER` is not the leading master, it would redirct to > `http://LEADING_MASTER/master/state` automatically. This hehaviour never > change with 1.0 Allright, I'll simplify the patch to only do the string starts with check. - Charles --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/#review149824 --- On Sept. 21, 2016, 3:03 a.m., Charles Allen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52105/ > --- > > (Updated Sept. 21, 2016, 3:03 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6210 > https://issues.apache.org/jira/browse/MESOS-6210 > > > Repository: mesos > > > Description > --- > > Add smarter master redirects. > > > Diffs > - > > docs/endpoints/master/redirect.md 3387b64c32fe394949863cbcb3e2b58be1b00bd0 > src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 > > Diff: https://reviews.apache.org/r/52105/diff/ > > > Testing > --- > > Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` > > > ``` > Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /redirect HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 307 Temporary Redirect > < Date: Tue, 20 Sep 2016 23:12:24 GMT > < Location: //10.17.97.185:5050 > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/redirect/foo > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /redirect/foo HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 307 Temporary Redirect > < Date: Tue, 20 Sep 2016 23:12:35 GMT > < Location: //10.17.97.185:5050/foo > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirect/test > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirect/test HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.4
Re: Review Request 52105: Add smarter master redirects.
> On Sept. 21, 2016, 3:18 p.m., haosdent huang wrote: > > Hi, @drcrallen Thanks a lot for your patch! > > > > I saw your patch try to redirect > > `http://SOME_MASTER:5050/master/redirect/master/frameworks` to > > `http://LEADER_MASTER:5050/master/frameworks`. Could you elaborate the user > > cases about this? Because we have handled the endpoint redirection > > automatically internal. For example, when you request > > `http://NON_LEADING_MASTER:5050/master/frameworks`, mesos master would > > redirect to `http://LEADING_MASTER:5050/master/frameworks`. That comes from two things: 1. http://mesos.apache.org/documentation/latest/endpoints/master/redirect/ suggests using redirect as a UI bookmarking mechanism, as such, it seemed reasonable for other calls to be able to redirect through the same mechanism. This might be a left-over suggestion from pre-1.0 though. An alternative thing here would be to update the redirect docs to remove the suggestion for UI bookmarking if it is no longer required. 2. That's how some other internal discovery mechanism are setup here, so I kind of expected http://SOME_MASTER:5050/master/redirect/state to redirect to the master and get the cluster state. But if the non-leading masters should redirect to the leading masters then I don't think that is helpful anymore, and I think that behavior changed with 1.0? - Charles --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/#review149824 ----------- On Sept. 21, 2016, 3:03 a.m., Charles Allen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52105/ > --- > > (Updated Sept. 21, 2016, 3:03 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6210 > https://issues.apache.org/jira/browse/MESOS-6210 > > > Repository: mesos > > > Description > --- > > Add smarter master redirects. > > > Diffs > - > > docs/endpoints/master/redirect.md 3387b64c32fe394949863cbcb3e2b58be1b00bd0 > src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 > > Diff: https://reviews.apache.org/r/52105/diff/ > > > Testing > --- > > Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` > > > ``` > Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /redirect HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 307 Temporary Redirect > < Date: Tue, 20 Sep 2016 23:12:24 GMT > < Location: //10.17.97.185:5050 > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/redirect/foo > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /redirect/foo HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 307 Temporary Redirect > < Date: Tue, 20 Sep 2016 23:12:35 GMT > < Location: //10.17.97.185:5050/foo > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirect/test > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirect/test HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 307 Temporary Redirect > < Date: Tue, 20 Sep 2016 23:12:49 GMT > < Location: //10.17.97.185:5050/test > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirectNOTFOUND/test > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirectNOTFOUND/test HTTP/1.1 > > Host: 127.0.0.1:5050 > > User-Agent: curl/7.43.0 > > Accept: */* > > > < HTTP/1.1 404 Not Found > < Date: Tue, 20 Sep 2016 23:12:57 GMT > < Content-Length: 0 > < > * Connection #0 to host 127.0.0.1 left intact > Charless-MacBook-Pro:~ charlesallen$ curl -v > http://127.0.0.1:5050/master/redirect/ > * Trying 127.0.0.1... > * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > > GET /master/redirect
Review Request 52105: Add smarter master redirects.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/ --- Review request for mesos. Bugs: MESOS-6210 https://issues.apache.org/jira/browse/MESOS-6210 Repository: mesos Description --- Add smarter master redirects. Diffs - docs/endpoints/master/redirect.md 3387b64c32fe394949863cbcb3e2b58be1b00bd0 src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 Diff: https://reviews.apache.org/r/52105/diff/ Testing --- Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` ``` Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Tue, 20 Sep 2016 23:12:24 GMT < Location: //10.17.97.185:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Tue, 20 Sep 2016 23:12:35 GMT < Location: //10.17.97.185:5050/foo < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/test * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/test HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Tue, 20 Sep 2016 23:12:49 GMT < Location: //10.17.97.185:5050/test < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirectNOTFOUND/test * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirectNOTFOUND/test HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Tue, 20 Sep 2016 23:12:57 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Tue, 20 Sep 2016 23:13:32 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/test * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/test HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Tue, 20 Sep 2016 23:13:43 GMT < Location: //10.17.97.185:5050/test < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact ``` It is worth noting that in this PR /master/redirect/ and /redirect/ return 404, not 307. This behavior is consistent with master. Thanks, Charles Allen
Review Request 50862: [MESOS-5929] Update app.js to handle petabyte scale
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50862/ --- Review request for mesos and haosdent huang. Bugs: MESOS-5929 https://issues.apache.org/jira/browse/MESOS-5929 Repository: mesos Description --- Update app.js to handle petabyte scale Diffs - src/webui/master/static/js/app.js 665c442d57356207369846e3a691767d864cfbcc Diff: https://reviews.apache.org/r/50862/diff/ Testing --- I applied the patch to app.js by breakpointing in the javascript using chrome developer tools, and modifying the javascript in the developer tools. This caused TB scale to display properly. Thanks, Charles Allen
Review Request 49483: Add Charles Allen to contributors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49483/ --- Review request for mesos. Repository: mesos Description --- Add Charles Allen to contributors Diffs - docs/contributors.yaml 04451e3e040aeb155feee74c789677085e6544f5 Diff: https://reviews.apache.org/r/49483/diff/ Testing --- Thanks, Charles Allen
Re: Review Request 49422: Have maven run in batch mode
KB 12/15 KB 15/15 KB Downloaded: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-javadoc-plugin/2.8.1/maven-javadoc-plugin-2.8.1.pom (15 KB at 168.8 KB/sec) Downloading: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-javadoc-plugin/2.8.1/maven-javadoc-plugin-2.8.1.jar 4/289 KB 8/289 KB 9/289 KB 13/289 KB 17/289 KB 21/289 KB 25/289 KB 29/289 KB 32/289 KB 36/289 KB 40/289 KB 41/289 KB 45/289 KB 49/289 KB 53/289 KB 57/289 KB 58/289 KB 62/289 KB 66/289 KB 70/289 KB 74/289 KB 78/289 KB 82/289 KB 86/289 KB 90/289 KB 94/289 KB 98/289 KB 102/289 KB 106/289 KB 110/289 KB 114/289 KB 118/289 KB 122/289 KB 126/289 KB 130/289 KB 134/289 KB 138/289 KB 142/289 KB 146/289 KB 150/289 KB 154/289 KB 158/289 KB 162/289 KB 166/289 KB 170/289 KB 174/289 KB 178/289 KB 182/289 KB 186/289 KB 190/289 KB 194/289 KB 198/289 KB 202/289 KB 206/289 KB 210/289 KB 214/289 KB 218/289 KB 222/289 KB 226/289 KB 230/289 KB 234/289 KB 238/289 KB 242/289 KB 246/289 KB 250/289 KB 254/289 KB 258/289 KB 262/289 KB 266/289 KB 270/289 KB 274/289 KB 278/289 KB 282/289 KB 286/289 KB 289/289 KB Downloaded: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-javadoc-plugin/2.8.1/maven-javadoc-plugin-2.8.1.jar (289 KB at 3276.1 KB/sec) Downloading: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-shade-plugin/2.2/maven-shade-plugin-2.2.pom 4/8 KB 8/8 KB 8/8 KB Downloaded: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-shade-plugin/2.2/maven-shade-plugin-2.2.pom (8 KB at 88.0 KB/sec) Downloading: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-shade-plugin/2.2/maven-shade-plugin-2.2.jar 4/98 KB 8/98 KB 12/98 KB 16/98 KB 20/98 KB 24/98 KB 28/98 KB 32/98 KB 36/98 KB 40/98 KB 44/98 KB 48/98 KB 52/98 KB 56/98 KB 60/98 KB 64/98 KB 64/98 KB 68/98 KB 72/98 KB 76/98 KB 80/98 KB 84/98 KB 88/98 KB 92/98 KB 96/98 KB 98/98 KB ``` Here's what it does with `-B` ``` [INFO] Scanning for projects... [INFO] Downloading: https://metamx.artifactoryonline.com/metamx/pub-libs-releases-local/org/apache/apache/11/apache-11.pom [INFO] Downloading: https://metamx.artifactoryonline.com/metamx/libs-releases/org/apache/apache/11/apache-11.pom [INFO] Downloaded: https://metamx.artifactoryonline.com/metamx/libs-releases/org/apache/apache/11/apache-11.pom (15 KB at 87.2 KB/sec) [INFO] [INFO] [INFO] Building mesos 1.0.0 [INFO] [INFO] Downloading: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-remote-resources-plugin/1.3/maven-remote-resources-plugin-1.3.pom [INFO] Downloaded: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-remote-resources-plugin/1.3/maven-remote-resources-plugin-1.3.pom (12 KB at 113.8 KB/sec) [INFO] Downloading: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom [INFO] Downloaded: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom (13 KB at 88.1 KB/sec) [INFO] Downloading: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/maven-parent/21/maven-parent-21.pom [INFO] Downloaded: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/maven/maven-parent/21/maven-parent-21.pom (27 KB at 200.8 KB/sec) [INFO] Downloading: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/apache/10/apache-10.pom [INFO] Downloaded: https://metamx.artifactoryonline.com/metamx/plugins-releases/org/apache/apache/10/apache-10.pom (15 KB at 111.1 KB/sec) ``` - Charles --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49422/#review140198 --- On June 30, 2016, 3:59 a.m., Charles Allen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49422/ > --- > > (Updated June 30, 2016, 3:59 a.m.) > >
Review Request 49422: Have maven run in batch mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49422/ --- Review request for mesos. Bugs: MESOS-5749 https://issues.apache.org/jira/browse/MESOS-5749 Repository: mesos Description --- Adds the `-B` flag to the MESOS_JAR target's maven build and install Diffs - src/Makefile.am bdad9c2ae07585b53aac97341550f3ea0b852ae7 Diff: https://reviews.apache.org/r/49422/diff/ Testing --- Ran test on in-house jenkins cluster. Works fine. Thanks, Charles Allen
