Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-06-01 Thread Eric Mumau via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67065/#review204205
---


Ship it!




Ship It!

- Eric Mumau


On June 1, 2018, 9:58 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67065/
> ---
> 
> (Updated June 1, 2018, 9:58 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This archiver utility can be invoked to extract a compressed or
> uncompressed archive with several different supported formats.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc 
>   3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
>   3rdparty/stout/include/Makefile.am e0097c438a62a9802d6e60c78493bf97333f20ed 
>   3rdparty/stout/include/stout/archiver.hpp PRE-CREATION 
>   3rdparty/stout/tests/CMakeLists.txt 
> 86111a8709cab709ba1bf844043d3a1da07b6241 
>   3rdparty/stout/tests/archiver_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67065/diff/6/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-30 Thread Eric Mumau via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204085
---


Ship it!




- Eric Mumau


On May 30, 2018, 8:30 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 30, 2018, 8:30 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/7/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-30 Thread Eric Mumau via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204084
---




src/tests/fetcher_tests.cpp
Line 1015 (original)


Were these tests removed deliberately?


- Eric Mumau


On May 30, 2018, 8:30 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 30, 2018, 8:30 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/7/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Eric Mumau via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66952/#review202463
---




3rdparty/stout/include/stout/os/windows/fd.hpp
Lines 183 (patched)


Shouldn't the overlapped_ member be constant?


- Eric Mumau


On May 4, 2018, 5:15 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66952/
> ---
> 
> (Updated May 4, 2018, 5:15 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670 and MESOS-8674
> https://issues.apache.org/jira/browse/MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8674
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an field to WindowsFD for functions that need to know if a
> Windows file is opened in overlapped mode, such as `os::read`, since
> Windows doesn't provide a Win32 API for it.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> bab16e869e69c214e18de584d1615311316e001a 
>   3rdparty/stout/include/stout/os/windows/open.hpp 
> 701dcec7c4c1162d38d8f25596af29ed3b32691d 
> 
> 
> Diff: https://reviews.apache.org/r/66952/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`.

2017-12-19 Thread Eric Mumau via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64701/#review194190
---


Ship it!




Ship It!

- Eric Mumau


On Dec. 19, 2017, 3:44 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64701/
> ---
> 
> (Updated Dec. 19, 2017, 3:44 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After upgrading Visual Studio to 15.5.2, warning C4530 started being
> emitted for practically every file. Since we use the STL (which uses
> exceptions), apparently we need to compile with `/EHsc`. This sets the
> exception-handling model to catch C++ exceptions, and to assume that
> functions declared as `extern "C"` never throw a C++ exception.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2 
> 
> 
> Diff: https://reviews.apache.org/r/64701/diff/2/
> 
> 
> Testing
> ---
> 
> Built on Windows, warning is gone (and gone in 3rdparty builds too).
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>