Re: Review Request 49903: Printed empty set if `Resources` instance is empty.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49903/#review141750
---
Ship it!
Ship It!
- Isabel Jimenez
On July 11, 2016, 4:31 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49903/
> ---
>
> (Updated July 11, 2016, 4:31 p.m.)
>
>
> Review request for mesos, Isabel Jimenez, Michael Park, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Prior to this patch, empty `Resources` instances have been omitted
> if printed to a stream. This showed up as double space, which is
> confusing. Now, an empty `Resources` instance is explicitly printed.
>
> Prior:
> <...> with oversubscribed resources (total: <...>, allocated: )
>
> After:
> <...> with oversubscribed resources {} (total: <...>, allocated: {})
>
>
> Diffs
> -
>
> src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968
> src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a
>
> Diff: https://reviews.apache.org/r/49903/diff/
>
>
> Testing
> ---
>
> make check + visual inspection
>
> Prior:
> ```
> Agent 0aa85f40-9409-45d7-b45c-6b6905b2836d-S0 (192.168.0.18) updated with
> oversubscribed resources (total: cpus(*):8; mem(*):15360; disk(*):470847;
> ports(*):[31000-32000], allocated: )
> ```
>
> After:
> ```
> Agent cd200600-03f7-4f5a-8721-94659c149145-S0 (192.168.0.18) updated with
> oversubscribed resources {} (total: cpus(*):8; mem(*):15360; disk(*):470847;
> ports(*):[31000-32000], allocated: {})
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42674: Replaced busybox with alpine in docker tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review116162 --- Ship it! Ship It! - Isabel Jimenez On Jan. 25, 2016, 7:18 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42674/ > --- > > (Updated Jan. 25, 2016, 7:18 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu. > > > Repository: mesos > > > Description > --- > > Replaced busybox with alpine in docker tests. > Busybox is currently causing issues with Docker daemon with btrfs backed > (https://github.com/docker/docker/issues/16755), which is the default on > CentOS 7. Docker daemon is reporting too many routes/links after downloading > busybox, which is exactly the issue referred in the previous link. > Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed. > > > Diffs > - > > src/tests/containerizer/docker_containerizer_tests.cpp > 81ab3625a69644d9659d484f3c605aaa5a10b397 > src/tests/containerizer/docker_tests.cpp > 9583070d64e96f5a57db62b3fb69073ecc5b502b > src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 > src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 > > Diff: https://reviews.apache.org/r/42674/diff/ > > > Testing > --- > > make check > > > Thanks, > > Timothy Chen > >
Re: Review Request 42674: Replaced busybox with alpine in docker tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115956 --- src/tests/health_check_tests.cpp (line 351) <https://reviews.apache.org/r/42674/#comment176994> Why can't we be consistent and use the official alpine image here too? - Isabel Jimenez On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42674/ > --- > > (Updated Jan. 23, 2016, 12:02 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu. > > > Repository: mesos > > > Description > --- > > Replaced busybox with alpine in docker tests. > Busybox is currently causing issues with Docker daemon with btrfs backed > (https://github.com/docker/docker/issues/16755), which is the default on > CentOS 7. > Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed. > > > Diffs > - > > src/tests/containerizer/docker_containerizer_tests.cpp > 81ab3625a69644d9659d484f3c605aaa5a10b397 > src/tests/containerizer/docker_tests.cpp > 9583070d64e96f5a57db62b3fb69073ecc5b502b > src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 > src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 > > Diff: https://reviews.apache.org/r/42674/diff/ > > > Testing > --- > > make check > > > Thanks, > > Timothy Chen > >
Re: Review Request 42674: Replaced busybox with alpine in docker tests.
> On Jan. 23, 2016, 12:14 a.m., Isabel Jimenez wrote: > > +1 for this change. Alpine is great. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115956 --- On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42674/ > --- > > (Updated Jan. 23, 2016, 12:02 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu. > > > Repository: mesos > > > Description > --- > > Replaced busybox with alpine in docker tests. > Busybox is currently causing issues with Docker daemon with btrfs backed > (https://github.com/docker/docker/issues/16755), which is the default on > CentOS 7. > Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed. > > > Diffs > - > > src/tests/containerizer/docker_containerizer_tests.cpp > 81ab3625a69644d9659d484f3c605aaa5a10b397 > src/tests/containerizer/docker_tests.cpp > 9583070d64e96f5a57db62b3fb69073ecc5b502b > src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 > src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 > > Diff: https://reviews.apache.org/r/42674/diff/ > > > Testing > --- > > make check > > > Thanks, > > Timothy Chen > >
Re: Review Request 23747: check missing apache headers script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23747/#review110045 --- test - Isabel Jimenez On July 22, 2014, 1:37 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23747/ > --- > > (Updated July 22, 2014, 1:37 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > --- > > Script used to generate review requests: 23749, 23783, 23784 > > > Diffs > - > > support/check-apache-header.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/23747/diff/ > > > Testing > --- > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 39908: Added a section to Upgrades doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 6 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- Added mention to Credential protobuf change in 0.26 in uprades.md Diffs - docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote: > > docs/upgrades.md, line 16 > > <https://reviews.apache.org/r/39908/diff/1/?file=1114771#file1114771line16> > > > > AFAIK this isn't Java-specific. This will mostly impact Java frameworks since they'll have to not only update the generated protos but change their framework code. See: https://github.com/apache/mesos/commit/38dbadc944f56e24725fba102bbd2db76cb31228#diff-2ca9e1a2a6f66a790bbbfae40708ecfaL249 - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review104953 --- On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39908/ > --- > > (Updated Nov. 3, 2015, 6 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3560 > https://issues.apache.org/jira/browse/MESOS-3560 > > > Repository: mesos > > > Description > --- > > Added mention to Credential protobuf change in 0.26 in uprades.md > > > Diffs > - > > docs/upgrades.md 3854e59 > > Diff: https://reviews.apache.org/r/39908/diff/ > > > Testing > --- > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 39908: Added a section to Upgrades doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 10:23 p.m.) Review request for mesos and Michael Park. Changes --- Added CHANGELOG section and removed a trailing space Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- Added mention to Credential protobuf change in 0.26 in uprades.md Diffs (updated) - CHANGELOG 99d8882 docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 10:30 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- Added mention to Credential protobuf change in 0.26 in uprades.md Diffs (updated) - CHANGELOG 99d8882 docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 7:52 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- Added mention to Credential protobuf change in 0.26 in uprades.md Diffs (updated) - docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote: > > docs/upgrades.md, line 16 > > <https://reviews.apache.org/r/39908/diff/1/?file=1114771#file1114771line16> > > > > AFAIK this isn't Java-specific. > > Isabel Jimenez wrote: > This will mostly impact Java frameworks since they'll have to not only > update the generated protos but change their framework code. See: > > https://github.com/apache/mesos/commit/38dbadc944f56e24725fba102bbd2db76cb31228#diff-2ca9e1a2a6f66a790bbbfae40708ecfaL249 > > Neil Conway wrote: > Sorry, I'm still confused: updating the generated protos will require > changes to framework code (if your framework examines the `secret` field), > regardless of language. e.g., the type of the field has changed from []byte > to string in the Go generated code. True, let me remove the language specificity. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review104953 ----------- On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39908/ > --- > > (Updated Nov. 3, 2015, 6 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3560 > https://issues.apache.org/jira/browse/MESOS-3560 > > > Repository: mesos > > > Description > --- > > Added mention to Credential protobuf change in 0.26 in uprades.md > > > Diffs > ----- > > docs/upgrades.md 3854e59 > > Diff: https://reviews.apache.org/r/39908/diff/ > > > Testing > --- > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 39908: Added a section to Upgrades doc
> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote: > > CHANGELOG, line 1 > > <https://reviews.apache.org/r/39908/diff/4/?file=1115243#file1115243line1> > > > > s/Version 0.26.0/Version 0.26.0(WIP) > > Isabel Jimenez wrote: > This are the release notes, so they apply only for releases. No need to > specify WIP > > Guangya Liu wrote: > The CHANGELOG for 0.26.0 was not finished, I think that we put a `WIP` > here and remove it when release 0.26.0, thoughts? Thanks. My bad, I will specify WIP. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105002 ----------- On Nov. 3, 2015, 10:30 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39908/ > --- > > (Updated Nov. 3, 2015, 10:30 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3560 > https://issues.apache.org/jira/browse/MESOS-3560 > > > Repository: mesos > > > Description > --- > > Added mention to Credential protobuf change in 0.26 in uprades.md > > > Diffs > - > > CHANGELOG 99d8882 > docs/upgrades.md 3854e59 > > Diff: https://reviews.apache.org/r/39908/diff/ > > > Testing > --- > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 39908: Added a section to Upgrades doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 4, 2015, 12:14 a.m.) Review request for mesos and Michael Park. Changes --- rebase Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- Added mention to Credential protobuf change in 0.26 in uprades.md Diffs (updated) - CHANGELOG 75f7355 docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 11:41 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- Added mention to Credential protobuf change in 0.26 in uprades.md Diffs (updated) - CHANGELOG 99d8882 docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote: > > CHANGELOG, line 1 > > <https://reviews.apache.org/r/39908/diff/4/?file=1115243#file1115243line1> > > > > s/Version 0.26.0/Version 0.26.0(WIP) This are the release notes, so they apply only for releases. No need to specify WIP - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105002 --- On Nov. 3, 2015, 10:30 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39908/ > --- > > (Updated Nov. 3, 2015, 10:30 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3560 > https://issues.apache.org/jira/browse/MESOS-3560 > > > Repository: mesos > > > Description > --- > > Added mention to Credential protobuf change in 0.26 in uprades.md > > > Diffs > - > > CHANGELOG 99d8882 > docs/upgrades.md 3854e59 > > Diff: https://reviews.apache.org/r/39908/diff/ > > > Testing > --- > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 39908: Added a section to Upgrades doc
> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote: > > CHANGELOG, line 4 > > <https://reviews.apache.org/r/39908/diff/4/?file=1115243#file1115243line4> > > > > Why not put this to `Bug` catalog? As this is an API breaking change we prefered to refer to it under 'API changes' even if the JIRA type is orgininally a bug - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105002 --- On Nov. 3, 2015, 10:30 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39908/ > --- > > (Updated Nov. 3, 2015, 10:30 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3560 > https://issues.apache.org/jira/browse/MESOS-3560 > > > Repository: mesos > > > Description > --- > > Added mention to Credential protobuf change in 0.26 in uprades.md > > > Diffs > - > > CHANGELOG 99d8882 > docs/upgrades.md 3854e59 > > Diff: https://reviews.apache.org/r/39908/diff/ > > > Testing > --- > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 39908: Added a section to Upgrades doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/ --- (Updated Nov. 3, 2015, 11:51 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- Added mention to Credential protobuf change in 0.26 in uprades.md Diffs (updated) - CHANGELOG 99d8882 docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 39708: Removed redundant code for conversion from PID to HTTP based frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39708/#review104337 --- Ship it! Ship It! - Isabel Jimenez On Oct. 28, 2015, 4:51 a.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39708/ > --- > > (Updated Oct. 28, 2015, 4:51 a.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > This conversion logic is redundant and is already being taken care of as part > of the `updateConnection` function. > > https://github.com/apache/mesos/blob/master/src/master/master.hpp#L1736 > > > Diffs > - > > src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb > > Diff: https://reviews.apache.org/r/39708/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 39709: Added logic to ensure the during a HTTP to PID scheduler downgrade, the previous HTTP instance gets an error message
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39709/#review104339 --- Ship it! Ship It! - Isabel Jimenez On Oct. 28, 2015, 4:54 a.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39709/ > --- > > (Updated Oct. 28, 2015, 4:54 a.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Presently, when there is a downgrade from HTTP to PID based scheduler, we did > not use to send the previous HTTP scheduler instance an error message. > Modified the logic to send in an error message to the old HTTP based instance. > > > Diffs > - > > src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb > > Diff: https://reviews.apache.org/r/39709/diff/ > > > Testing > --- > > make check + a test to verify HTTP to PID downgrade in another review in the > chain > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 39710: Added test to verify downgrade from HTTP to PID based schedulers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39710/#review104347 --- Ship it! Ship It! - Isabel Jimenez On Oct. 28, 2015, 8:43 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39710/ > --- > > (Updated Oct. 28, 2015, 8:43 p.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > See summary > > > Diffs > - > > src/tests/scheduler_http_api_tests.cpp > d338a1bc6fdb3aa0b40e5727991181b31b2e7592 > > Diff: https://reviews.apache.org/r/39710/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38577: Added synchronous validation for Call in Agent
> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.hpp, line 31 > > <https://reviews.apache.org/r/38577/diff/8/?file=1108614#file1108614line31> > > > > why space here? Added it there after a review comment. > On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.cpp, line 75 > > <https://reviews.apache.org/r/38577/diff/8/?file=1108615#file1108615line75> > > > > also print status.source() We don't have a stringify for this. > On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/tests/executor_http_api_tests.cpp, line 505 > > <https://reviews.apache.org/r/38577/diff/8/?file=1108616#file1108616line505> > > > > make sure this pattern is consistent everywhere else in this file. Inversed advise here, killed this and made sure above pattern is consistent everywhere. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review104123 --- On Oct. 27, 2015, 1:20 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38577/ > --- > > (Updated Oct. 27, 2015, 1:20 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-2906 > https://issues.apache.org/jira/browse/MESOS-2906 > > > Repository: mesos > > > Description > --- > > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > - > > src/CMakeLists.txt e6169a0 > src/Makefile.am e797dac > src/slave/http.cpp 3f7f71b > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > src/tests/executor_http_api_tests.cpp e429d84 > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 38618: Changed executor HTTP API tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38618/ --- (Updated Oct. 27, 2015, 12:09 a.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- rebase Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- The SUBSCRIBE Call is supposed to have a 'subscribe' message. This change is needed so test can pass tests after call validation. Diffs (updated) - src/tests/executor_http_api_tests.cpp e429d84 Diff: https://reviews.apache.org/r/38618/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 27, 2015, 12:23 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Changes --- rebase Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs (updated) - src/CMakeLists.txt e6169a0 src/Makefile.am e797dac src/slave/http.cpp 3f7f71b src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION src/tests/executor_http_api_tests.cpp e429d84 Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38844: Added unit tests for Call validation in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Oct. 27, 2015, 12:37 a.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- rebase Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Unit tests for Call validation in Agent. Diffs (updated) - src/tests/executor_http_api_tests.cpp e429d84 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 27, 2015, 1:20 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Changes --- review Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs (updated) - src/CMakeLists.txt e6169a0 src/Makefile.am e797dac src/slave/http.cpp 3f7f71b src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION src/tests/executor_http_api_tests.cpp e429d84 Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38844: Added unit tests for Call validation in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Oct. 27, 2015, 1:30 a.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- changes after review comments Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Unit tests for Call validation in Agent. Diffs (updated) - src/tests/executor_http_api_tests.cpp e429d84 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102705 --- Ship it! Ship It! - Isabel Jimenez On Oct. 14, 2015, 6:26 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39323/ > --- > > (Updated Oct. 14, 2015, 6:26 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-3734 > https://issues.apache.org/jira/browse/MESOS-3734 > > > Repository: mesos > > > Description > --- > > 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on > OSX. Apparently there is not a portable way to instruct sed not to make a > backup > file; hence, we now create a backup file and then immediately delete it. > > > Diffs > - > > src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d > > Diff: https://reviews.apache.org/r/39323/diff/ > > > Testing > --- > > Successfully built on OSX. > > > Thanks, > > Neil Conway > >
Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/ --- (Updated Oct. 13, 2015, 7:53 a.m.) Review request for mesos and Michael Park. Changes --- + test Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- When decoding the JSON credential file into the Credential protobuf object, the 'secret' which is in 'bytes' is mapped into base64 string automatically by protobuf from JSON. This creates an unintended behavior, forcing users to encode in base64 their secret when wanting to pass a JSON file to the --credentials flag. Diffs (updated) - include/mesos/mesos.proto 4a16be1 src/examples/java/TestExceptionFramework.java 78720b0 src/examples/java/TestFramework.java aad94c0 src/tests/credentials_tests.cpp ced27c4 Diff: https://reviews.apache.org/r/39098/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/ --- (Updated Oct. 13, 2015, 8:45 a.m.) Review request for mesos and Michael Park. Changes --- review comments Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- When decoding the JSON credential file into the Credential protobuf object, the 'secret' which is in 'bytes' is mapped into base64 string automatically by protobuf from JSON. This creates an unintended behavior, forcing users to encode in base64 their secret when wanting to pass a JSON file to the --credentials flag. Diffs (updated) - include/mesos/mesos.proto 4a16be1 src/examples/java/TestExceptionFramework.java 78720b0 src/examples/java/TestFramework.java aad94c0 src/tests/credentials_tests.cpp ced27c4 Diff: https://reviews.apache.org/r/39098/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/ --- (Updated Oct. 8, 2015, 1 a.m.) Review request for mesos and Michael Park. Changes --- Added java framework example changes Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- When decoding the JSON credential file into the Credential protobuf object, the 'secret' which is in 'bytes' is mapped into base64 string automatically by protobuf from JSON. This creates an unintended behavior, forcing users to encode in base64 their secret when wanting to pass a JSON file to the --credentials flag. Diffs (updated) - include/mesos/mesos.proto 4a16be1 src/examples/java/TestExceptionFramework.java 78720b0 src/examples/java/TestFramework.java aad94c0 Diff: https://reviews.apache.org/r/39098/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38899: Added handler for Executor->Framework message for the Executor HTTP API
> On Oct. 7, 2015, 6:40 p.m., Isabel Jimenez wrote: > > Ship It! LGTM, just might need to get rebase on changes for switch syntax in other patches. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38899/#review101805 --- On Oct. 7, 2015, 6:39 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38899/ > --- > > (Updated Oct. 7, 2015, 6:39 p.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-2295 > https://issues.apache.org/jira/browse/MESOS-2295 > > > Repository: mesos > > > Description > --- > > Trivial change to call the `executorMessage(...)` function that already > existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage. > > > Diffs > - > > src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b > > Diff: https://reviews.apache.org/r/38899/diff/ > > > Testing > --- > > make check. Would add tests later after the MESOS-3480 review chain gets > committed. > > > Thanks, > > Anand Mazumdar > >
Review Request 39100: Changed Credential validation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39100/ --- Review request for mesos and Michael Park. Repository: mesos Description --- We should validate credentials before anything else in HTTP endpoints. Diffs - src/master/http.cpp 4b9f9ed Diff: https://reviews.apache.org/r/39100/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 39100: Changed Credential validation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39100/ --- (Updated Oct. 7, 2015, 7:15 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-3560 https://issues.apache.org/jira/browse/MESOS-3560 Repository: mesos Description --- We should validate credentials before anything else in HTTP endpoints. Diffs - src/master/http.cpp 4b9f9ed Diff: https://reviews.apache.org/r/39100/diff/ Testing --- make check Thanks, Isabel Jimenez
Review Request 39003: Fixed Python protobuf V1 generation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39003/ --- Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco Massenzio. Repository: mesos Description --- V1 protobus were not being generated for python. Diffs - src/Makefile.am e698927 Diff: https://reviews.apache.org/r/39003/diff/ Testing --- make check and verify v1 protobufs were properly generated Thanks, Isabel Jimenez
Review Request 39002: Fixed sed command for Python protos generation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39002/ --- Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco Massenzio. Repository: mesos Description --- The current command didn't complete the protobuf generation and resulted in an empty file. Diffs - src/Makefile.am e698927 Diff: https://reviews.apache.org/r/39002/diff/ Testing --- make check and verified that protobufs were properly generated Thanks, Isabel Jimenez
Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38875/#review101562
---
src/slave/http.cpp (line 298)
<https://reviews.apache.org/r/38875/#comment158997>
Could you please change the syntax for every case to be consistent with `:
{` through this switch?
- Isabel Jimenez
On Sept. 30, 2015, 3:39 a.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38875/
> ---
>
> (Updated Sept. 30, 2015, 3:39 a.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Refactored the `api/v1/executor` endpoint to do executor/framework
> exists(`NULL`) checks before `Subscribe` since the slave explicitly knows the
> `frameworkID/executorID` when it launches it. Also modified tests to first
> spawn a dummy `cat` process and then make a `Subscribe` call to ensure that
> the Agent knows about the Framework/Executor and not reject it via
> `BadRequest` due to the `NULL` checks.
>
>
> Diffs
> -
>
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/tests/executor_http_api_tests.cpp
> 31938c295367686d444f8a8aa2c43d2696b481ec
>
> Diff: https://reviews.apache.org/r/38875/diff/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101565 --- Ship it! Ship It! - Isabel Jimenez On Sept. 30, 2015, 6:06 a.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38877/ > --- > > (Updated Sept. 30, 2015, 6:06 a.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-3515 > https://issues.apache.org/jira/browse/MESOS-3515 > > > Repository: mesos > > > Description > --- > > This change adds the functionality for executors to `Subscribe` via the > `api/v1/executor` endpoint. It also stores a marker file as part of the > `Subscribe` call if framework `checkpointing` is enabled. This can then be > used by the agent when recovering to wait for reconnecting back with the > executor. > > Since `Call::Update` is in progress as part of MESOS-3476. I have added a > `CHECK` if a executor tries to send a list of unacknowledged tasks as part of > the `Subscribe` call. > > > Diffs > - > > src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b > src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 > src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c > > Diff: https://reviews.apache.org/r/38877/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101550 --- LGTM just small nit from standing review issue - Isabel Jimenez On Sept. 30, 2015, 3:38 a.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38873/ > --- > > (Updated Sept. 30, 2015, 3:38 a.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-3480 > https://issues.apache.org/jira/browse/MESOS-3480 > > > Repository: mesos > > > Description > --- > > This change implements helper functions for evolving old style Executor > messages in `src/messages/messages.proto` to V1 Executor Events defined in > `include/mesos/v1/executor/executor.proto`. This is needed for MESOS-3480 > > > Diffs > - > > src/internal/evolve.hpp 9babac3ccbfb2bf9a3989a3ae20cf96e5f3a2903 > src/internal/evolve.cpp 625706e089984b32d8298a2eacf2f8af2bca931e > > Diff: https://reviews.apache.org/r/38873/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38646: Added WIP note for Executor endpoint in changelog
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38646/#review101544 --- Ship it! Ship It! - Isabel Jimenez On Sept. 25, 2015, 12:09 a.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38646/ > --- > > (Updated Sept. 25, 2015, 12:09 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > WIP Note for the 0.25 release that `api/v1/executor` endpoint is incomplete. > > > Diffs > - > > CHANGELOG 7a0c813847590e8e384054551381e4f13f5c67d2 > > Diff: https://reviews.apache.org/r/38646/diff/ > > > Testing > --- > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101551 --- Ship it! Ship It! - Isabel Jimenez On Oct. 5, 2015, 11:09 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38873/ > --- > > (Updated Oct. 5, 2015, 11:09 p.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-3480 > https://issues.apache.org/jira/browse/MESOS-3480 > > > Repository: mesos > > > Description > --- > > This change implements helper functions for evolving old style Executor > messages in `src/messages/messages.proto` to V1 Executor Events defined in > `include/mesos/v1/executor/executor.proto`. This is needed for MESOS-3480 > > > Diffs > - > > src/internal/evolve.hpp 9babac3ccbfb2bf9a3989a3ae20cf96e5f3a2903 > src/internal/evolve.cpp 625706e089984b32d8298a2eacf2f8af2bca931e > > Diff: https://reviews.apache.org/r/38873/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 5, 2015, 3:54 p.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs (updated) - src/CMakeLists.txt 891f951 src/Makefile.am f060998 src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 2, 2015, 6:42 p.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs (updated) - src/CMakeLists.txt 891f951 src/Makefile.am 8aa4566 src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38844: Added unit tests for Call validation in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Oct. 2, 2015, 6:53 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Unit tests for Call validation in Agent. Diffs (updated) - src/tests/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38967/#review101385 --- src/Makefile.am (line 225) <https://reviews.apache.org/r/38967/#comment158761> Could you also add a fix for v1 python proto generation? - Isabel Jimenez On Oct. 2, 2015, 10:27 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38967/ > --- > > (Updated Oct. 2, 2015, 10:27 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-3575 > https://issues.apache.org/jira/browse/MESOS-3575 > > > Repository: mesos > > > Description > --- > > For now , till we find out a way on how we go about distributing the V1 > protobufs. This fail-safe change dumps them into the existing MESOS > JAR(Java). This would save anyone the trouble of generating them before using > the new API. > > > Diffs > - > > src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805 > > Diff: https://reviews.apache.org/r/38967/diff/ > > > Testing > --- > > Verified Java JAR has the required protobufs. > > > Thanks, > > Anand Mazumdar > >
Review Request 38844: Added unit tests for Call validation in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos Description --- Unit tests for Call validation in Agent. Diffs - src/tests/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 29, 2015, 8 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs (updated) - src/Makefile.am 8aa4566 src/slave/http.cpp cddc8ad src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38844: Added unit tests for Call validation in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Sept. 29, 2015, 8:08 a.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Unit tests for Call validation in Agent. Diffs - src/tests/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in Agent
> On Sept. 29, 2015, 8:29 p.m., Anand Mazumdar wrote: > > src/slave/validation.cpp, line 57 > > <https://reviews.apache.org/r/38577/diff/3/?file=1086533#file1086533line57> > > > > Sorry for the ping pong iterations on this but noticed another missing > > validation check for `Call::UPDATE` while working on MESOS-3480. > > > > Can we also check if `TaskState` is not `TASK_STAGING` and return an > > validation error if so ? > > > > https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L2838 This introduces a change of behavior, I'll reflect this on the design Doc too. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review101003 ----------- On Sept. 29, 2015, 8:15 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38577/ > --- > > (Updated Sept. 29, 2015, 8:15 p.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-2906 > https://issues.apache.org/jira/browse/MESOS-2906 > > > Repository: mesos > > > Description > --- > > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > - > > src/CMakeLists.txt 891f951 > src/Makefile.am 8aa4566 > src/slave/http.cpp f9cf7bb > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Review Request 38867: Added drop message method in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38867/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Repository: mesos Description --- We need a drop message method in Agent, similar to the one existing in Master. Diffs - src/slave/slave.hpp 18be4f8 src/slave/slave.cpp d1c9977 Diff: https://reviews.apache.org/r/38867/diff/ Testing --- make Thanks, Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 29, 2015, 9:25 p.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs (updated) - src/CMakeLists.txt 891f951 src/Makefile.am 8aa4566 src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38844: Added unit tests for Call validation in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Sept. 29, 2015, 9:27 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- Adding test for invalid status update 'TASK_STAGING' Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Unit tests for Call validation in Agent. Diffs (updated) - src/tests/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38844: Added unit tests for Call validation in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Sept. 29, 2015, 8:05 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- rebase Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Unit tests for Call validation in Agent. Diffs (updated) - src/tests/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 29, 2015, 8:15 p.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Changes --- Added validation.cpp to CMakelist Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs (updated) - src/CMakeLists.txt 891f951 src/Makefile.am 8aa4566 src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38844: Added unit tests for Call validation in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Sept. 29, 2015, 8:25 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Unit tests for Call validation in Agent. Diffs (updated) - src/tests/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38844: Added unit tests for Call validation in Agent
> On Sept. 29, 2015, 8:11 p.m., Anand Mazumdar wrote: > > Can you also update the new tests to use the updated way to test recovery > > of Agent as done by the other tests ? ( Otherwise, these would be flaky ) Done :) Thanks - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/#review101001 --- On Sept. 29, 2015, 8:25 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38844/ > --- > > (Updated Sept. 29, 2015, 8:25 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-2906 > https://issues.apache.org/jira/browse/MESOS-2906 > > > Repository: mesos > > > Description > --- > > Unit tests for Call validation in Agent. > > > Diffs > - > > src/tests/executor_http_api_tests.cpp c2c05f4 > > Diff: https://reviews.apache.org/r/38844/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 38577: Added synchronous validation for Call in Agent
> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > <https://reviews.apache.org/r/38577/diff/2/?file=1080351#file1080351line501> > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). > > Isabel Jimenez wrote: > We don't have cmake support for the agent yet. > > Alex Clemmer wrote: > I'm pleased to report that we do, actually! Could we please put this line > in the `CMakeLists.txt` found in `src/`. > > Alex Clemmer wrote: > (I should mention that the reason I didn't appear earlier to remind you > is because this was only checked in a day or so ago.) Great news! - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review100653 ------- On Sept. 29, 2015, 8 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38577/ > --- > > (Updated Sept. 29, 2015, 8 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-2906 > https://issues.apache.org/jira/browse/MESOS-2906 > > > Repository: mesos > > > Description > --- > > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > - > > src/Makefile.am 8aa4566 > src/slave/http.cpp cddc8ad > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 38577: Added synchronous validation for Call in Agent
> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/slave/validation.hpp, line 36 > > <https://reviews.apache.org/r/38577/diff/2/?file=1080353#file1080353line36> > > > > Can you please add tests in this patch? Adding tests in a separate dependant patch. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review100653 --- On Sept. 22, 2015, 9:46 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38577/ > --- > > (Updated Sept. 22, 2015, 9:46 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-2906 > https://issues.apache.org/jira/browse/MESOS-2906 > > > Repository: mesos > > > Description > --- > > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > - > > src/Makefile.am e224060 > src/slave/http.cpp 12a4d39 > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 38779: Use new HTTP status code check in scheduler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/#review100708 --- Ship it! Ship It! - Isabel Jimenez On Sept. 25, 2015, 10:40 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38779/ > --- > > (Updated Sept. 25, 2015, 10:40 p.m.) > > > Review request for mesos, Anand Mazumdar and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Use new HTTP status code check in scheduler. > > > Diffs > - > > src/scheduler/scheduler.cpp ee146eb81a8ad72bc04c62d1e223de6aa27b351d > > Diff: https://reviews.apache.org/r/38779/diff/ > > > Testing > --- > > make check > > > Thanks, > > Timothy Chen > >
Re: Review Request 38577: Added synchronous validation for Call in Agent
> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > <https://reviews.apache.org/r/38577/diff/2/?file=1080351#file1080351line501> > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). We don't have cmake support for the agent yet. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review100653 --- On Sept. 22, 2015, 9:46 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38577/ > --- > > (Updated Sept. 22, 2015, 9:46 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-2906 > https://issues.apache.org/jira/browse/MESOS-2906 > > > Repository: mesos > > > Description > --- > > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > - > > src/Makefile.am e224060 > src/slave/http.cpp 12a4d39 > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 22, 2015, 9:46 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs - src/Makefile.am e224060 src/slave/http.cpp 12a4d39 src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Review Request 38618: Changed executor HTTP API tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38618/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- The SUBSCRIBE Call is supposed to have a 'subscribe' message. This change is needed so test can pass tests after call validation. Diffs - src/tests/executor_http_api_tests.cpp 9dbc519 Diff: https://reviews.apache.org/r/38618/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 22, 2015, 9:43 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Changes --- review comments Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs (updated) - src/Makefile.am e224060 src/slave/http.cpp 12a4d39 src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Review Request 38619: Added missing header guards for master/validation.hpp
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38619/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos Description --- Header guards were missing in master/validation.hpp Diffs - src/master/validation.hpp 3434868 Diff: https://reviews.apache.org/r/38619/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in Agent
> On Sept. 22, 2015, 1:08 a.m., Anand Mazumdar wrote: > > src/slave/validation.hpp, line 28 > > <https://reviews.apache.org/r/38577/diff/1/?file=1078641#file1078641line28> > > > > newline before. I am expecting other people to add slave validation > > code in this file too in the future. So separating `namespace > > executor/call` by a newline would be a good idea. I don't think is very relevant for this patch, but I agree that a separation can help future changes. > On Sept. 22, 2015, 1:08 a.m., Anand Mazumdar wrote: > > src/slave/validation.hpp, line 32 > > <https://reviews.apache.org/r/38577/diff/1/?file=1078641#file1078641line32> > > > > What do you think about going ahead and implementing some unit tests ? > > > > You can create another patch if you would like for the tests. But in > > general, it's good practice to have tests in most cases even for this > > trivial validation code :) > > > > I guess we would need the following tests in > > `src/tests/executor_http_api_tests.cpp` ? > > - Missing Executor/Framework Id. > > - Invalid call message that is not initialized. > > - Invalid call message that does not have Subscribe/Update/Message but > > has the corresponding type set. Getting a patch for tests separately. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review99886 --- On Sept. 22, 2015, 9:46 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38577/ > --- > > (Updated Sept. 22, 2015, 9:46 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-2906 > https://issues.apache.org/jira/browse/MESOS-2906 > > > Repository: mesos > > > Description > --- > > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > - > > src/Makefile.am e224060 > src/slave/http.cpp 12a4d39 > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Review Request 38577: Added synchronous validation for Call in Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-2906 https://issues.apache.org/jira/browse/MESOS-2906 Repository: mesos Description --- Added validation for Call protobuf message in Agent /api/v1/executor endpoint. Diffs - src/Makefile.am e224060 src/slave/http.cpp 12a4d39 src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38497: Introduced Executor HTTP endpoint on Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38497/#review99779 --- Ship it! Ship It! - Isabel Jimenez On Sept. 18, 2015, 5:18 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38497/ > --- > > (Updated Sept. 18, 2015, 5:18 p.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-2907 > https://issues.apache.org/jira/browse/MESOS-2907 > > > Repository: mesos > > > Description > --- > > This change introduces a stub endpoint on Agent. As of now, it doesn't do > much except validating the `Content-Type`, `Accept` headers among other > trivial validations. Most of the functionality already existed in > `src/master/http.cpp` > > > Diffs > - > > src/slave/http.cpp 101aa06e981eaa43bf6c68268b057f3d15e33e2e > src/slave/slave.hpp 32e18305f3b630ab5f4e7aca2ef14cdb14c10721 > src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 > > Diff: https://reviews.apache.org/r/38497/diff/ > > > Testing > --- > > make check + tests in r38499 > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38499: Tests for executor endpoint on agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38499/#review99789 --- Ship it! Ship It! - Isabel Jimenez On Sept. 18, 2015, 5:19 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38499/ > --- > > (Updated Sept. 18, 2015, 5:19 p.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-2907 > https://issues.apache.org/jira/browse/MESOS-2907 > > > Repository: mesos > > > Description > --- > > This change introduces basic validation tests for the Executor HTTP endpoint > on Agent. > > > Diffs > - > > src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 > src/tests/executor_http_api_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38499/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38496/#review99614 --- Ship it! Ship It! - Isabel Jimenez On Sept. 18, 2015, 5:18 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38496/ > --- > > (Updated Sept. 18, 2015, 5:18 p.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-2907 > https://issues.apache.org/jira/browse/MESOS-2907 > > > Repository: mesos > > > Description > --- > > This change adds a trivial devolve call for V1 Executor Protobuf -> > unversioned protobuf that can be used internally. > > > Diffs > - > > src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe > src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda > > Diff: https://reviews.apache.org/r/38496/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38416: Allow HTTP response codes to be checked with code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review99193 --- Ship it! Ship It! - Isabel Jimenez On Sept. 16, 2015, 1:03 a.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38416/ > --- > > (Updated Sept. 16, 2015, 1:03 a.m.) > > > Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Jiang > Yan Xu. > > > Bugs: MESOS-3429 > https://issues.apache.org/jira/browse/MESOS-3429 > > > Repository: mesos > > > Description > --- > > Allow HTTP response codes to be checked with code. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > fbd6cf7967173495875a8ea90ed28ade88b982a2 > > Diff: https://reviews.apache.org/r/38416/diff/ > > > Testing > --- > > make > > > Thanks, > > Timothy Chen > >
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
> On Sept. 15, 2015, 10:40 p.m., Anand Mazumdar wrote: > > LGTM minus Two Nits: > > > > 1. Can we update the description of the review to just say that this change > > just copies the existing unversioned protobuf to the V1 namespace. > > 2. I am assuming that you would take care of Vinod's earlier comment around > > `invalid calls result in BadRequest` for `message Error` description in a > > separate patch as you had commented earlier. 1. Done 2. Yes, we have to capture this in both executor and scheduler protos. I'm sending a separate patch. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review99117 --- On Sept. 15, 2015, 10:46 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38143/ > --- > > (Updated Sept. 15, 2015, 10:46 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3375 > https://issues.apache.org/jira/browse/MESOS-3375 > > > Repository: mesos > > > Description > --- > > Executor protobufswere introduced in Mesos for the HTTP API, they need to be > added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf > ought to be changed as the executor HTTP API design evolves. > Note: This proto is a copy from the existing unversioned executor proto with > only the necessary changes. > > > Diffs > - > > include/mesos/v1/executor/executor.hpp PRE-CREATION > include/mesos/v1/executor/executor.proto PRE-CREATION > src/Makefile.am 509256f > > Diff: https://reviews.apache.org/r/38143/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
- Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review99117 --- On Sept. 15, 2015, 10:46 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38143/ > --- > > (Updated Sept. 15, 2015, 10:46 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3375 > https://issues.apache.org/jira/browse/MESOS-3375 > > > Repository: mesos > > > Description > --- > > Executor protobufswere introduced in Mesos for the HTTP API, they need to be > added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf > ought to be changed as the executor HTTP API design evolves. > Note: This proto is a copy from the existing unversioned executor proto with > only the necessary changes. > > > Diffs > - > > include/mesos/v1/executor/executor.hpp PRE-CREATION > include/mesos/v1/executor/executor.proto PRE-CREATION > src/Makefile.am 509256f > > Diff: https://reviews.apache.org/r/38143/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 15, 2015, 10:46 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-3375 https://issues.apache.org/jira/browse/MESOS-3375 Repository: mesos Description (updated) --- Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the executor HTTP API design evolves. Note: This proto is a copy from the existing unversioned executor proto with only the necessary changes. Diffs - include/mesos/v1/executor/executor.hpp PRE-CREATION include/mesos/v1/executor/executor.proto PRE-CREATION src/Makefile.am 509256f Diff: https://reviews.apache.org/r/38143/diff/ Testing --- make && make check Thanks, Isabel Jimenez
Re: Review Request 38278: Updating unversioned Executor protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/ --- (Updated Sept. 15, 2015, 10:24 p.m.) Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. Repository: mesos Description --- Adding last changes of the executor HTTP API design to the unversioned protobuf Diffs (updated) - include/mesos/executor/executor.proto 52c84b3 Diff: https://reviews.apache.org/r/38278/diff/ Testing --- make Thanks, Isabel Jimenez
Re: Review Request 38278: Updating unversioned Executor protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/ --- (Updated Sept. 15, 2015, 8:13 p.m.) Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. Repository: mesos Description --- Adding last changes of the executor HTTP API design to the unversioned protobuf Diffs (updated) - include/mesos/executor/executor.proto 52c84b3 Diff: https://reviews.apache.org/r/38278/diff/ Testing --- make Thanks, Isabel Jimenez
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 15, 2015, 8:16 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-3375 https://issues.apache.org/jira/browse/MESOS-3375 Repository: mesos Description --- Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the executor HTTP API design evolves. Diffs (updated) - include/mesos/v1/executor/executor.hpp PRE-CREATION include/mesos/v1/executor/executor.proto PRE-CREATION src/Makefile.am 509256f Diff: https://reviews.apache.org/r/38143/diff/ Testing --- make && make check Thanks, Isabel Jimenez
Re: Review Request 38321: Adding upgrade specifications to docs for '.json' endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38321/ --- (Updated Sept. 12, 2015, 6:08 p.m.) Review request for mesos and Adam B. Repository: mesos Description --- Adding a Note for the deprecation of endpoints with '.json' extension. Diffs (updated) - docs/upgrades.md c4b2880 Diff: https://reviews.apache.org/r/38321/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36126: Removing '.json' extension in slave endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/ --- (Updated Sept. 11, 2015, 9:41 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase + stats.json already deprecated on MESOS-2058 Bugs: MESOS-2983 https://issues.apache.org/jira/browse/MESOS-2983 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in slave Diffs (updated) - docs/network-monitoring.md acd70c5 src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-tail 256a804 src/slave/monitor.cpp 93ba279 src/slave/slave.hpp 09172f7 src/slave/slave.cpp 5e5522e src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/monitor_tests.cpp 53fb53e src/tests/slave_tests.cpp 5c1a3d3 src/webui/master/static/js/controllers.js fbf8696 src/webui/master/static/js/services.js 2cd9d7d Diff: https://reviews.apache.org/r/36126/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 11, 2015, 9:48 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs (updated) - docs/configuration.md 315dc53 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp a8807b6 src/master/flags.cpp 230c1dc src/slave/flags.cpp b676bac src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Review Request 38321: Adding upgrade specifications to docs for '.json' endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38321/ --- Review request for mesos and Adam B. Repository: mesos Description --- Adding a Note for the deprecation of endpoints with '.json' extension. Diffs - docs/upgrades.md c4b2880 Diff: https://reviews.apache.org/r/38321/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 6:04 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs (updated) - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/http.cpp a052e55 src/master/master.hpp 1dfc947 src/master/master.cpp 4b60e63 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 5:33 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs (updated) - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/http.cpp a052e55 src/master/master.hpp 1dfc947 src/master/master.cpp 4b60e63 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36126: Removing '.json' extension in slave endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/ --- (Updated Sept. 10, 2015, 5:43 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2983 https://issues.apache.org/jira/browse/MESOS-2983 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in slave Diffs (updated) - docs/configuration.md 315dc53 docs/network-monitoring.md acd70c5 src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-tail 256a804 src/master/flags.cpp 230c1dc src/slave/flags.cpp 7539441 src/slave/http.cpp b0fe5f5 src/slave/monitor.cpp 82aa659 src/slave/slave.hpp 09172f7 src/slave/slave.cpp 5e5522e src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/monitor_tests.cpp 53fb53e src/tests/slave_tests.cpp 5c1a3d3 src/webui/master/static/js/controllers.js 3445028 src/webui/master/static/js/services.js 2cd9d7d Diff: https://reviews.apache.org/r/36126/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
> On Sept. 9, 2015, 10:46 p.m., Adam B wrote: > > Looks great! I'm not sure if we needed to change all the internal > > references to remove .json, since we're keeping that endpoint for > > compatibility, but it's good that we're testing the new endpoint. > > > > Did you test to verify that the `.json` endpoints still work? Yes I tried the .json endpoints - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review98275 --- On Sept. 10, 2015, 5:33 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36125/ > --- > > (Updated Sept. 10, 2015, 5:33 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-2719 > https://issues.apache.org/jira/browse/MESOS-2719 > > > Repository: mesos-incubating > > > Description > --- > > Removing json extension for HTTP endpoints in master > > > Diffs > - > > src/cli/mesos-cat 73dc63e > src/cli/mesos-ps ee14d51 > src/cli/mesos-scp 77b8557 > src/cli/mesos-tail 256a804 > src/master/constants.hpp c3fe140 > src/master/http.cpp a052e55 > src/master/master.hpp 1dfc947 > src/master/master.cpp 4b60e63 > src/tests/fault_tolerance_tests.cpp 89cb18b > src/tests/master_tests.cpp 8a6b98b > src/webui/master/static/js/controllers.js 3445028 > > Diff: https://reviews.apache.org/r/36125/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 10, 2015, 5:58 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs (updated) - docs/configuration.md 315dc53 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp b2134aa src/master/flags.cpp 230c1dc src/slave/flags.cpp 7539441 src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 10, 2015, 5:59 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs - docs/configuration.md 315dc53 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp b2134aa src/master/flags.cpp 230c1dc src/slave/flags.cpp 7539441 src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36126: Removing '.json' extension in slave endpoints url
> On Sept. 9, 2015, 10:51 p.m., Adam B wrote: > > Minor comments, but it looks shippable to me after those are resolved. > > > > Did you test to verify that the old endpoints still work as expected? Yes I tested the old endpoints :) - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/#review98295 --- On Sept. 10, 2015, 5:43 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36126/ > --- > > (Updated Sept. 10, 2015, 5:43 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-2983 > https://issues.apache.org/jira/browse/MESOS-2983 > > > Repository: mesos-incubating > > > Description > --- > > Removing json extension for HTTP endpoints in slave > > > Diffs > - > > docs/configuration.md 315dc53 > docs/network-monitoring.md acd70c5 > src/cli/mesos-cat 73dc63e > src/cli/mesos-ps ee14d51 > src/cli/mesos-tail 256a804 > src/master/flags.cpp 230c1dc > src/slave/flags.cpp 7539441 > src/slave/http.cpp b0fe5f5 > src/slave/monitor.cpp 82aa659 > src/slave/slave.hpp 09172f7 > src/slave/slave.cpp 5e5522e > src/tests/fault_tolerance_tests.cpp 89cb18b > src/tests/monitor_tests.cpp 53fb53e > src/tests/slave_tests.cpp 5c1a3d3 > src/webui/master/static/js/controllers.js 3445028 > src/webui/master/static/js/services.js 2cd9d7d > > Diff: https://reviews.apache.org/r/36126/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 10, 2015, 11:38 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-3375 https://issues.apache.org/jira/browse/MESOS-3375 Repository: mesos Description --- Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the executor HTTP API design evolves. Diffs (updated) - include/mesos/v1/executor/executor.hpp PRE-CREATION include/mesos/v1/executor/executor.proto PRE-CREATION src/Makefile.am 8963cea Diff: https://reviews.apache.org/r/38143/diff/ Testing --- make && make check Thanks, Isabel Jimenez
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 10, 2015, 10:32 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-3375 https://issues.apache.org/jira/browse/MESOS-3375 Repository: mesos Description --- Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the executor HTTP API design evolves. Diffs (updated) - include/mesos/v1/executor/executor.hpp PRE-CREATION include/mesos/v1/executor/executor.proto PRE-CREATION src/Makefile.am 8963cea Diff: https://reviews.apache.org/r/38143/diff/ Testing --- make && make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 10, 2015, 9:46 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs (updated) - docs/configuration.md 315dc53 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp a8807b6 src/master/flags.cpp 230c1dc src/slave/flags.cpp b676bac src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 10, 2015, 11:33 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-3375 https://issues.apache.org/jira/browse/MESOS-3375 Repository: mesos Description --- Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the executor HTTP API design evolves. Diffs - include/mesos/v1/executor/executor.hpp PRE-CREATION include/mesos/v1/executor/executor.proto PRE-CREATION src/Makefile.am 8963cea Diff: https://reviews.apache.org/r/38143/diff/ Testing --- make && make check Thanks, Isabel Jimenez
Review Request 38278: Updating unversioned Executor protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/ --- Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. Repository: mesos Description --- Adding last changes of the executor HTTP API design to the unversioned protobuf Diffs - include/mesos/executor/executor.proto 52c84b3 Diff: https://reviews.apache.org/r/38278/diff/ Testing --- make Thanks, Isabel Jimenez
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
> On Sept. 10, 2015, 1:17 a.m., Vinod Kone wrote: > > include/mesos/v1/executor/executor.proto, lines 89-90 > > <https://reviews.apache.org/r/38143/diff/2/?file=1064673#file1064673line89> > > > > Much like with the scheduler, invalid calls result in BadRequest. We > > should really update this wording in executor and scheduler protos. Will open a new patch with both updates. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review98326 --- On Sept. 10, 2015, 10:32 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38143/ > --- > > (Updated Sept. 10, 2015, 10:32 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3375 > https://issues.apache.org/jira/browse/MESOS-3375 > > > Repository: mesos > > > Description > --- > > Executor protobufswere introduced in Mesos for the HTTP API, they need to be > added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf > ought to be changed as the executor HTTP API design evolves. > > > Diffs > - > > include/mesos/v1/executor/executor.hpp PRE-CREATION > include/mesos/v1/executor/executor.proto PRE-CREATION > src/Makefile.am 8963cea > > Diff: https://reviews.apache.org/r/38143/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 36126: Removing '.json' extension in slave endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/ --- (Updated Sept. 10, 2015, 9:09 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase Bugs: MESOS-2983 https://issues.apache.org/jira/browse/MESOS-2983 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in slave Diffs (updated) - docs/configuration.md 315dc53 docs/network-monitoring.md acd70c5 src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-tail 256a804 src/master/flags.cpp 230c1dc src/slave/flags.cpp b676bac src/slave/http.cpp 101aa06 src/slave/monitor.cpp 93ba279 src/slave/slave.hpp 09172f7 src/slave/slave.cpp 5e5522e src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/monitor_tests.cpp 53fb53e src/tests/slave_tests.cpp 5c1a3d3 src/webui/master/static/js/controllers.js fbf8696 src/webui/master/static/js/services.js 2cd9d7d Diff: https://reviews.apache.org/r/36126/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 9:23 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs (updated) - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/http.cpp 73e8857 src/master/master.hpp 1dfc947 src/master/master.cpp 4b60e63 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 9:27 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs (updated) - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/master.hpp 1dfc947 src/master/master.cpp 4b60e63 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38191: Removing unused Executor protobuf
> On Sept. 9, 2015, 5:33 p.m., Vinod Kone wrote: > > Why is this being removed? The plan is to have a v1/executor.proto and an > > unversioned executor.proto much like what we did with scheduler.proto. > > Anand Mazumdar wrote: > Vinod, Why can't the executor driver just directly use the V1 protobuf ? > The unversioned protobuf for scheduler was persisted since we had shipped the > scheduler driver with 0.23 to use the unversioned Call/Events or am I missing > something ? > > PS: I asked Isabel to remove it in CR 38143 > > Anand Mazumdar wrote: > Oops, I see what you mean now. You were referring to using this as an > internal protobuf for now i.e. devolve(...) - V1->internal. We should shelve > this review then, my bad. Discarding it. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38191/#review98222 ----------- On Sept. 8, 2015, 10:30 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38191/ > --- > > (Updated Sept. 8, 2015, 10:30 p.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3393 > https://issues.apache.org/jira/browse/MESOS-3393 > > > Repository: mesos > > > Description > --- > > The executor protobuf definition living outside the v1/ directory is unused, > it should be removed to avoid confusion. > > > Diffs > - > > include/mesos/executor/executor.hpp 85f181c > include/mesos/executor/executor.proto 52c84b3 > src/Makefile.am 5fdca0f > > Diff: https://reviews.apache.org/r/38191/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Review Request 38191: Removing unused Executor protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38191/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs: MESOS-3393 https://issues.apache.org/jira/browse/MESOS-3393 Repository: mesos Description --- The executor protobuf definition living outside the v1/ directory is unused, it should be removed to avoid confusion. Diffs - include/mesos/executor/executor.hpp 85f181c include/mesos/executor/executor.proto 52c84b3 src/Makefile.am 5fdca0f Diff: https://reviews.apache.org/r/38191/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 5, 2015, 10:05 p.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Changes --- Fixing typo Bugs: MESOS-3375 https://issues.apache.org/jira/browse/MESOS-3375 Repository: mesos Description --- Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the executor HTTP API design evolves. Diffs (updated) - include/mesos/v1/executor/executor.hpp PRE-CREATION include/mesos/v1/executor/executor.proto PRE-CREATION src/Makefile.am 5fdca0f Diff: https://reviews.apache.org/r/38143/diff/ Testing --- make && make check Thanks, Isabel Jimenez
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97872 --- include/mesos/v1/executor/executor.proto (line 47) <https://reviews.apache.org/r/38143/#comment153932> Here we're refering to 'Events', for the Subscribed event message FrameworkInfo will have the framework_id. Please note that this protobuf ought to have minor changes as the design evolves: https://docs.google.com/document/d/1dFmTrSZXCo5zj8H8SkJ4HT-V0z2YYnEZVV8Fd_-AupM/edit?usp=sharing include/mesos/v1/executor/executor.proto (line 91) <https://reviews.apache.org/r/38143/#comment153933> arojas is the orginal author of this TODO, if the assignee for this TODO needs to be rewritten, we should do it in a separate patch. include/mesos/v1/executor/executor.proto (line 169) <https://reviews.apache.org/r/38143/#comment153934> The design here follows the design for the scheduler HTTP API. All event messages require their type. Depending on the 'type' of call message, you should expect an optional corresponding type of message. For example if you have a 'Call' message of 'type' 'UPDATE' your call message will have the optional 'update' message inside with their required 'status' , 'timestamp' and 'uuid'. - Isabel Jimenez On Sept. 5, 2015, 2:35 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38143/ > --- > > (Updated Sept. 5, 2015, 2:35 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3375 > https://issues.apache.org/jira/browse/MESOS-3375 > > > Repository: mesos > > > Description > --- > > Executor protobufswere introduced in Mesos for the HTTP API, they need to be > added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf > ought to be changed as the executor HTTP API design evolves. > > > Diffs > - > > include/mesos/v1/executor/executor.hpp PRE-CREATION > include/mesos/v1/executor/executor.proto PRE-CREATION > src/Makefile.am 5fdca0f > > Diff: https://reviews.apache.org/r/38143/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 38143: Adding executor HTTP API protobuf to V1
> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote: > > include/mesos/v1/executor/executor.proto, line 47 > > <https://reviews.apache.org/r/38143/diff/1/?file=1064550#file1064550line47> > > > > I think that the framework id need to be set when call "SUBSCRIBE" but > > not after "SUBSCRIBED"? Here we're refering to 'Events', for the Subscribed event message FrameworkInfo will have the framework_id. Please note that this protobuf ought to have minor changes as the design evolves: https://docs.google.com/document/d/1dFmTrSZXCo5zj8H8SkJ4HT-V0z2YYnEZVV8Fd_-AupM/edit?usp=sharing > On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote: > > include/mesos/v1/executor/executor.proto, line 91 > > <https://reviews.apache.org/r/38143/diff/1/?file=1064550#file1064550line91> > > > > s/arojas/yourid? arojas is the orginal author of this TODO, if the assignee for this TODO needs to be rewritten, we should do it in a separate patch. > On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote: > > include/mesos/v1/executor/executor.proto, line 169 > > <https://reviews.apache.org/r/38143/diff/1/?file=1064550#file1064550line169> > > > > Do you mean that when type is Subscribe, there is no need to set any > > message? Why? I think that the framework id, executor id, command should be > > set? The design here follows the design for the scheduler HTTP API. All call and event messages require their type. Depending on the 'type' of call message, you should expect an optional corresponding type of message. For example if you have a 'Call' message of 'type' 'UPDATE' your call message will have the optional 'update' message inside with their required 'status' , 'timestamp' and 'uuid'. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97846 --- On Sept. 5, 2015, 2:35 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38143/ > --- > > (Updated Sept. 5, 2015, 2:35 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3375 > https://issues.apache.org/jira/browse/MESOS-3375 > > > Repository: mesos > > > Description > --- > > Executor protobufswere introduced in Mesos for the HTTP API, they need to be > added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf > ought to be changed as the executor HTTP API design evolves. > > > Diffs > - > > include/mesos/v1/executor/executor.hpp PRE-CREATION > include/mesos/v1/executor/executor.proto PRE-CREATION > src/Makefile.am 5fdca0f > > Diff: https://reviews.apache.org/r/38143/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Isabel Jimenez > >
