Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 26, 2016, 11:50 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add test cases to test logrotate with switch_user set to true and false. Diffs - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 26, 2016, 11:48 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add test cases to test logrotate with switch_user set to true and false. Diffs - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 17, 2016, 8:42 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add test cases to test logrotate with switch_user set to true and false. Diffs (updated) - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 17, 2016, 3:38 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 17, 2016, 3:38 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 17, 2016, 3:38 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs (updated) - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/containerizer/mesos/containerizer.cpp ec4ae32485a7ab6c9f73c512004d1220482a188e src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53473/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 17, 2016, 3:38 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add test cases to test logrotate with switch_user set to true and false. Diffs (updated) - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53473: Add new param user to logrotate's prepare function.
> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1388
> > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388>
> >
> > Passing None() has the agent crashing when we have switch_user=false.
>
> Sivaram Kannan wrote:
> That is the reason I thought I would have the current user of the agent
> set to logger.
>
> Joseph Wu wrote:
> The reason the agent/test would fail is because of this line in your
> fourth diff:
> https://reviews.apache.org/r/53473/diff/4#7
>
> `container->config.user()` has a return type of `string`. When the value
> is not set, calling `container->config.user()` returns the empty string. You
> need to manually convert it to an `Option`.
>
> `container->config` is a protobuf defined here:
>
> https://github.com/apache/mesos/blob/1.1.x/include/mesos/slave/containerizer.proto#L112
>
> Sivaram Kannan wrote:
> https://reviews.apache.org/r/53473/diff/6/ has an explicit conversion to
> Option. When container->config.user() is empty, I tried to set
>
> Option user = None()
>
> But the call logger->prepare(..., user), still crashes the agent. Doesn't
> the below code more logical than setting the value to None()?
>
> Result result = os::user();
> user = result.get();
>
> Joseph Wu wrote:
> What's the stack trace for the crash? (And what are the steps taken to
> repro?)
>
> Sivaram Kannan wrote:
> Sorry - should have added when I created the RBR.
>
> Steps to reproduce:
> 1. In the containerizer.cpp, change the below code in the rbr
> 2. Option user = None();
> if (container->config.has_user()) {
> user = container->config.user();
> } else {
> Result result = os::user();
> //user = result.get(); <= Current code
> user = None(); <=== Change it to this
> }
> 3. make and make check.
> 4. Run the below test
> 5. sudo bin/mesos-tests.sh --verbose
> --gtest_filter="UserContainerLoggerTest.ROOT_LOGROTATE_RotateAsSwitchUserFalse"
> 6. The above test would end up in a crash like below.
> 7. Stack Trace:
> 8. I1116 15:58:16.660096 15282 slave.cpp:2031] Queued task
> 'bffed9be-9830-4840-a313-e2ff3741b2fc' for executor
> 'bffed9be-9830-4840-a313-e2ff3741b2fc' of framework
> 16b6e12e-3344-4aad-adf1-a3460b3ad2a1-
> lt-mesos-tests: ../../3rdparty/stout/include/stout/option.hpp:111: const
> T& Option::get() const & [with T = std::basic_string]: Assertion
> `isSome()' failed.
> *** Aborted at 1479311896 (unix time) try "date -d @1479311896" if you
> are using GNU date ***
> PC: @ 0x7f89e65b0c37 (unknown)
> *** SIGABRT (@0x3ba2) received by PID 15266 (TID 0x7f89dd0db700) from PID
> 15266; stack trace: ***
> @ 0x7f89e694f330 (unknown)
> @ 0x7f89e65b0c37 (unknown)
> @ 0x7f89e65b4028 (unknown)
> @ 0x7f89e65a9bf6 (unknown)
> @ 0x7f89e65a9ca2 (unknown)
> @ 0xa8542f _ZNKR6OptionISsE3getEv
> @ 0x7f89dfba6a9b
> mesos::internal::logger::LogrotateContainerLoggerProcess::prepare()
> @ 0x7f89dfbbcb5e
> _ZZN7process8dispatchIN5mesos5slave15ContainerLogger14SubprocessInfoENS1_8internal6logger31LogrotateContainerLoggerProcessERKNS1_12ExecutorInfoERKSsRK6OptionISsES8_SsSE_EENS_6FutureIT_EERKNS_3PIDIT0_EEMSL_FSJ_T1_T2_T3_ET4_T5_T6_ENKUlPNS_11ProcessBaseEE_clESY_
> @ 0x7f89dfbcb54d
> _ZNSt17_Function_handlerIFvPN7process11ProcessBaseEEZNS0_8dispatchIN5mesos5slave15ContainerLogger14SubprocessInfoENS5_8internal6logger31LogrotateContainerLoggerProcessERKNS5_12ExecutorInfoERKSsRK6OptionISsESC_SsSI_EENS0_6FutureIT_EERKNS0_3PIDIT0_EEMSP_FSN_T1_T2_T3_ET4_T5_T6_EUlS2_E_E9_M_invokeERKSt9_Any_dataS2_
> @ 0x7f89eca9168d std::function<>::operator()()
> @ 0x7f89eca73e0d process::ProcessBase::visit()
> @ 0x7f89eca7c2ec process::DispatchEvent::visit()
> @ 0xa674b2 process::ProcessBase::serve()
> @ 0x7f89eca700fa process::ProcessManager::resume()
> @ 0x7f89eca6cc39
> _ZZN7process14ProcessManager12init_threadsEvENKUt_clEv
> @ 0x7f89eca7ba94
> _ZNSt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUt_vEE9_M_invokeIIEEEvSt12_Index_tupleIIXspT_EEE
> @ 0x7f89eca7b9eb
> _ZNSt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUt_vEEclEv
> @ 0x7f89eca7b984
> _ZNSt6thread5_ImplISt12_Bind_simpleIFZN7process14ProcessM
Re: Review Request 53473: Add new param user to logrotate's prepare function.
> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1388
> > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388>
> >
> > Passing None() has the agent crashing when we have switch_user=false.
>
> Sivaram Kannan wrote:
> That is the reason I thought I would have the current user of the agent
> set to logger.
>
> Joseph Wu wrote:
> The reason the agent/test would fail is because of this line in your
> fourth diff:
> https://reviews.apache.org/r/53473/diff/4#7
>
> `container->config.user()` has a return type of `string`. When the value
> is not set, calling `container->config.user()` returns the empty string. You
> need to manually convert it to an `Option`.
>
> `container->config` is a protobuf defined here:
>
> https://github.com/apache/mesos/blob/1.1.x/include/mesos/slave/containerizer.proto#L112
>
> Sivaram Kannan wrote:
> https://reviews.apache.org/r/53473/diff/6/ has an explicit conversion to
> Option. When container->config.user() is empty, I tried to set
>
> Option user = None()
>
> But the call logger->prepare(..., user), still crashes the agent. Doesn't
> the below code more logical than setting the value to None()?
>
> Result result = os::user();
> user = result.get();
>
> Joseph Wu wrote:
> What's the stack trace for the crash? (And what are the steps taken to
> repro?)
Sorry - should have added when I created the RBR.
Steps to reproduce:
1. In the containerizer.cpp, change the below code in the rbr
2. Option user = None();
if (container->config.has_user()) {
user = container->config.user();
} else {
Result result = os::user();
//user = result.get(); <= Current code
user = None(); <=== Change it to this
}
3. make and make check.
4. Run the below test
5. sudo bin/mesos-tests.sh --verbose
--gtest_filter="UserContainerLoggerTest.ROOT_LOGROTATE_RotateAsSwitchUserFalse"
6. The above test would end up in a crash like below.
7. Stack Trace:
8. I1116 15:58:16.660096 15282 slave.cpp:2031] Queued task
'bffed9be-9830-4840-a313-e2ff3741b2fc' for executor
'bffed9be-9830-4840-a313-e2ff3741b2fc' of framework
16b6e12e-3344-4aad-adf1-a3460b3ad2a1-
lt-mesos-tests: ../../3rdparty/stout/include/stout/option.hpp:111: const T&
Option::get() const & [with T = std::basic_string]: Assertion
`isSome()' failed.
*** Aborted at 1479311896 (unix time) try "date -d @1479311896" if you are
using GNU date ***
PC: @ 0x7f89e65b0c37 (unknown)
*** SIGABRT (@0x3ba2) received by PID 15266 (TID 0x7f89dd0db700) from PID
15266; stack trace: ***
@ 0x7f89e694f330 (unknown)
@ 0x7f89e65b0c37 (unknown)
@ 0x7f89e65b4028 (unknown)
@ 0x7f89e65a9bf6 (unknown)
@ 0x7f89e65a9ca2 (unknown)
@ 0xa8542f _ZNKR6OptionISsE3getEv
@ 0x7f89dfba6a9b
mesos::internal::logger::LogrotateContainerLoggerProcess::prepare()
@ 0x7f89dfbbcb5e
_ZZN7process8dispatchIN5mesos5slave15ContainerLogger14SubprocessInfoENS1_8internal6logger31LogrotateContainerLoggerProcessERKNS1_12ExecutorInfoERKSsRK6OptionISsES8_SsSE_EENS_6FutureIT_EERKNS_3PIDIT0_EEMSL_FSJ_T1_T2_T3_ET4_T5_T6_ENKUlPNS_11ProcessBaseEE_clESY_
@ 0x7f89dfbcb54d
_ZNSt17_Function_handlerIFvPN7process11ProcessBaseEEZNS0_8dispatchIN5mesos5slave15ContainerLogger14SubprocessInfoENS5_8internal6logger31LogrotateContainerLoggerProcessERKNS5_12ExecutorInfoERKSsRK6OptionISsESC_SsSI_EENS0_6FutureIT_EERKNS0_3PIDIT0_EEMSP_FSN_T1_T2_T3_ET4_T5_T6_EUlS2_E_E9_M_invokeERKSt9_Any_dataS2_
@ 0x7f89eca9168d std::function<>::operator()()
@ 0x7f89eca73e0d process::ProcessBase::visit()
@ 0x7f89eca7c2ec process::DispatchEvent::visit()
@ 0xa674b2 process::ProcessBase::serve()
@ 0x7f89eca700fa process::ProcessManager::resume()
@ 0x7f89eca6cc39 _ZZN7process14ProcessManager12init_threadsEvENKUt_clEv
@ 0x7f89eca7ba94
_ZNSt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUt_vEE9_M_invokeIIEEEvSt12_Index_tupleIIXspT_EEE
@ 0x7f89eca7b9eb
_ZNSt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUt_vEEclEv
@ 0x7f89eca7b984
_ZNSt6thread5_ImplISt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUt_vEEE6_M_runEv
@ 0x7f89e712aa60 (unknown)
@ 0x7f89e6947184 start_thread
@ 0x7f89e667437d (unknown)
- Sivaram
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53473/#review155916
---
On Nov. 14, 2016, 9:5
Re: Review Request 53473: Add new param user to logrotate's prepare function.
> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashing when we have switch_user=false. > > Sivaram Kannan wrote: > That is the reason I thought I would have the current user of the agent > set to logger. > > Joseph Wu wrote: > The reason the agent/test would fail is because of this line in your > fourth diff: > https://reviews.apache.org/r/53473/diff/4#7 > > `container->config.user()` has a return type of `string`. When the value > is not set, calling `container->config.user()` returns the empty string. You > need to manually convert it to an `Option`. > > `container->config` is a protobuf defined here: > > https://github.com/apache/mesos/blob/1.1.x/include/mesos/slave/containerizer.proto#L112 https://reviews.apache.org/r/53473/diff/6/ has an explicit conversion to Option. When container->config.user() is empty, I tried to set Option user = None() But the call logger->prepare(..., user), still crashes the agent. Doesn't the below code more logical than setting the value to None()? Result result = os::user(); user = result.get(); - Sivaram --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/#review155916 --- On Nov. 14, 2016, 9:52 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53473/ > --- > > (Updated Nov. 14, 2016, 9:52 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > --- > > Add new param user to logrotate's prepare function. > > > Diffs > - > > include/mesos/slave/container_logger.hpp > 939974736f9eb744c83036e074718d2a1eba8b0a > src/slave/container_loggers/lib_logrotate.hpp > 28fdf3bdcc66d473521b377f66ab0b48f6900f58 > src/slave/container_loggers/lib_logrotate.cpp > 53698d339f0f4d2dc916b53239ca0c36bbebcd42 > src/slave/container_loggers/logrotate.hpp > d1db69236f5a9b1dbb3113ad02218a512afdb46b > src/slave/container_loggers/sandbox.hpp > e0aeb32a9ec83af049af8a10010b819c1d8b25d8 > src/slave/container_loggers/sandbox.cpp > cc263ebef7e0c3e778fabafa49faa6dd315adc45 > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > src/slave/containerizer/mesos/containerizer.cpp > ec4ae32485a7ab6c9f73c512004d1220482a188e > src/tests/container_logger_tests.cpp > 1bb94a8461e481983f25a44737e4011ed5fc4b1f > > Diff: https://reviews.apache.org/r/53473/diff/ > > > Testing > --- > > Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > Run the mesos-logrotate-logger as root user and verify whether the logs are > getting rotated. > > > Thanks, > > Sivaram Kannan > >
Re: Review Request 53473: Add new param user to logrotate's prepare function.
> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashing when we have switch_user=false. That is the reason I thought I would have the current user of the agent set to logger. - Sivaram --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/#review155916 --- On Nov. 14, 2016, 9:52 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53473/ > --- > > (Updated Nov. 14, 2016, 9:52 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > --- > > Add new param user to logrotate's prepare function. > > > Diffs > - > > include/mesos/slave/container_logger.hpp > 939974736f9eb744c83036e074718d2a1eba8b0a > src/slave/container_loggers/lib_logrotate.hpp > 28fdf3bdcc66d473521b377f66ab0b48f6900f58 > src/slave/container_loggers/lib_logrotate.cpp > 53698d339f0f4d2dc916b53239ca0c36bbebcd42 > src/slave/container_loggers/logrotate.hpp > d1db69236f5a9b1dbb3113ad02218a512afdb46b > src/slave/container_loggers/sandbox.hpp > e0aeb32a9ec83af049af8a10010b819c1d8b25d8 > src/slave/container_loggers/sandbox.cpp > cc263ebef7e0c3e778fabafa49faa6dd315adc45 > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > src/slave/containerizer/mesos/containerizer.cpp > ec4ae32485a7ab6c9f73c512004d1220482a188e > src/tests/container_logger_tests.cpp > 1bb94a8461e481983f25a44737e4011ed5fc4b1f > > Diff: https://reviews.apache.org/r/53473/diff/ > > > Testing > --- > > Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > Run the mesos-logrotate-logger as root user and verify whether the logs are > getting rotated. > > > Thanks, > > Sivaram Kannan > >
Re: Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/#review155917 --- src/slave/containerizer/docker.cpp (line 1286) <https://reviews.apache.org/r/53473/#comment226008> Does not make much sense to run docker containrizer with anyother user other than root right?? - Sivaram Kannan On Nov. 14, 2016, 9:52 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53473/ > --- > > (Updated Nov. 14, 2016, 9:52 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > --- > > Add new param user to logrotate's prepare function. > > > Diffs > - > > include/mesos/slave/container_logger.hpp > 939974736f9eb744c83036e074718d2a1eba8b0a > src/slave/container_loggers/lib_logrotate.hpp > 28fdf3bdcc66d473521b377f66ab0b48f6900f58 > src/slave/container_loggers/lib_logrotate.cpp > 53698d339f0f4d2dc916b53239ca0c36bbebcd42 > src/slave/container_loggers/logrotate.hpp > d1db69236f5a9b1dbb3113ad02218a512afdb46b > src/slave/container_loggers/sandbox.hpp > e0aeb32a9ec83af049af8a10010b819c1d8b25d8 > src/slave/container_loggers/sandbox.cpp > cc263ebef7e0c3e778fabafa49faa6dd315adc45 > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > src/slave/containerizer/mesos/containerizer.cpp > ec4ae32485a7ab6c9f73c512004d1220482a188e > src/tests/container_logger_tests.cpp > 1bb94a8461e481983f25a44737e4011ed5fc4b1f > > Diff: https://reviews.apache.org/r/53473/diff/ > > > Testing > --- > > Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > Run the mesos-logrotate-logger as root user and verify whether the logs are > getting rotated. > > > Thanks, > > Sivaram Kannan > >
Re: Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/#review155916 --- src/slave/containerizer/mesos/containerizer.cpp (line 1388) <https://reviews.apache.org/r/53473/#comment226007> Passing None() has the agent crashing when we have switch_user=false. - Sivaram Kannan On Nov. 14, 2016, 9:52 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53473/ > --- > > (Updated Nov. 14, 2016, 9:52 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > --- > > Add new param user to logrotate's prepare function. > > > Diffs > - > > include/mesos/slave/container_logger.hpp > 939974736f9eb744c83036e074718d2a1eba8b0a > src/slave/container_loggers/lib_logrotate.hpp > 28fdf3bdcc66d473521b377f66ab0b48f6900f58 > src/slave/container_loggers/lib_logrotate.cpp > 53698d339f0f4d2dc916b53239ca0c36bbebcd42 > src/slave/container_loggers/logrotate.hpp > d1db69236f5a9b1dbb3113ad02218a512afdb46b > src/slave/container_loggers/sandbox.hpp > e0aeb32a9ec83af049af8a10010b819c1d8b25d8 > src/slave/container_loggers/sandbox.cpp > cc263ebef7e0c3e778fabafa49faa6dd315adc45 > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > src/slave/containerizer/mesos/containerizer.cpp > ec4ae32485a7ab6c9f73c512004d1220482a188e > src/tests/container_logger_tests.cpp > 1bb94a8461e481983f25a44737e4011ed5fc4b1f > > Diff: https://reviews.apache.org/r/53473/diff/ > > > Testing > --- > > Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > Run the mesos-logrotate-logger as root user and verify whether the logs are > getting rotated. > > > Thanks, > > Sivaram Kannan > >
Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/#review155915 --- src/tests/container_logger_tests.cpp (line 782) <https://reviews.apache.org/r/53699/#comment226006> Should I remove the below function? - Sivaram Kannan On Nov. 14, 2016, 9:51 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53699/ > --- > > (Updated Nov. 14, 2016, 9:51 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > --- > > Add test cases to test logrotate with switch_user set to true and false. > > > Diffs > - > > src/tests/container_logger_tests.cpp > 1bb94a8461e481983f25a44737e4011ed5fc4b1f > > Diff: https://reviews.apache.org/r/53699/diff/ > > > Testing > --- > > Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > Run the mesos-logrotate-logger as root user and verify whether the logs are > getting rotated. > > > Thanks, > > Sivaram Kannan > >
Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 14, 2016, 9:51 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add test cases to test logrotate with switch_user set to true and false. Diffs (updated) - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 14, 2016, 9:52 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 14, 2016, 9:52 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 14, 2016, 9:52 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs (updated) - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/containerizer/mesos/containerizer.cpp ec4ae32485a7ab6c9f73c512004d1220482a188e src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53473/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 14, 2016, 3:46 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 14, 2016, 3:46 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 14, 2016, 3:43 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs (updated) - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/containerizer/mesos/containerizer.cpp ec4ae32485a7ab6c9f73c512004d1220482a188e src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53473/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add test cases to test logrotate with switch_user set to true and false. Diffs - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 7, 2016, 10:56 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 7, 2016, 10:56 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 7, 2016, 10:56 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs (updated) - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53473/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 4, 2016, 2:58 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53473/diff/ Testing (updated) --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 4, 2016, 2:45 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 4, 2016, 2:45 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 4, 2016, 2:45 p.m.) Review request for mesos. Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs (updated) - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53473/diff/ Testing --- Thanks, Sivaram Kannan
Re: Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 4, 2016, 2:39 p.m.) Review request for mesos. Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs (updated) - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53473/diff/ Testing --- Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 4, 2016, 2:39 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 4, 2016, 2:39 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 4, 2016, 2:14 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Review Request 53473: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- Review request for mesos. Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53473/diff/ Testing --- Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 4, 2016, 2:14 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53306: Change unit test function for new user param in prepare func.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Nov. 4, 2016, 2:13 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Change unit test function for new user param in prepare func. Diffs - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Nov. 4, 2016, 2:13 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Nov. 4, 2016, 2:14 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user variable from library to binary. Diffs - src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Nov. 2, 2016, 8:47 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user variable from library to binary. Diffs - src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 2, 2016, 8:47 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 2, 2016, 8:41 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Nov. 2, 2016, 8:41 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user variable from library to binary. Diffs - src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/#review154461 --- src/slave/container_loggers/lib_logrotate.cpp (line 167) <https://reviews.apache.org/r/53305/#comment224025> I think we can delete the rbr #23209 with this change in place right? Should I discard #23209 ? - Sivaram Kannan On Nov. 1, 2016, 2 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53305/ > --- > > (Updated Nov. 1, 2016, 2 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > --- > > Add new param user to logrotate's prepare function. > > > Diffs > - > > include/mesos/slave/container_logger.hpp > 939974736f9eb744c83036e074718d2a1eba8b0a > src/slave/container_loggers/lib_logrotate.hpp > 28fdf3bdcc66d473521b377f66ab0b48f6900f58 > src/slave/container_loggers/lib_logrotate.cpp > 53698d339f0f4d2dc916b53239ca0c36bbebcd42 > src/slave/container_loggers/logrotate.hpp > d1db69236f5a9b1dbb3113ad02218a512afdb46b > src/slave/container_loggers/sandbox.hpp > e0aeb32a9ec83af049af8a10010b819c1d8b25d8 > src/slave/container_loggers/sandbox.cpp > cc263ebef7e0c3e778fabafa49faa6dd315adc45 > src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 > src/slave/containerizer/mesos/containerizer.cpp > 67cc595278f124cdf518d2f4fcfb257439f067e2 > > Diff: https://reviews.apache.org/r/53305/diff/ > > > Testing > --- > > 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > 2. Run the mesos-logrotate-logger as root user and verify whether the logs > are getting rotated. > 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh > > > Thanks, > > Sivaram Kannan > >
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 31, 2016, 7:20 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 7:19 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 7:18 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs (updated) - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53306: Change unit test function for new user param in prepare func.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 7:18 p.m.) Review request for mesos. Summary (updated) - Change unit test function for new user param in prepare func. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Change unit test function for new user param in prepare func. Diffs (updated) - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 31, 2016, 7:17 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 31, 2016, 7:17 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 31, 2016, 5:18 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 5:18 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Modify prepare function of logrotate to accept new param user. Diffs - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 5:18 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 31, 2016, 5:18 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user variable from library to binary. Diffs - src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Modify prepare function of logrotate to accept new param user. Diffs - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user variable from library to binary. Diffs - src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 5:10 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user variable from library to binary. Diffs (updated) - src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs (updated) - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Modify prepare function of logrotate to accept new param user. Diffs (updated) - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 3:57 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Modify prepare function of logrotate to accept new param user. Diffs (updated) - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 3:57 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs (updated) - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing (updated) --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 3:50 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Modify prepare function of logrotate to accept new param user. Diffs - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing (updated) --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 31, 2016, 3:47 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user variable from library to binary. Diffs (updated) - src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Review Request 53305: Add new param user to logrotate's prepare function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add new param user to logrotate's prepare function. Diffs - include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing --- Thanks, Sivaram Kannan
Review Request 53306: Modify prepare function of logrotate to accept new param user.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Modify prepare function of logrotate to accept new param user. Diffs - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing --- Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 31, 2016, 3:48 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 31, 2016, 3:47 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 31, 2016, 3:45 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user value from executor of switch_user flag is set. Diffs - src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 13, 2016, 6:52 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user value from executor of switch_user flag is set. Diffs (updated) - src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 11, 2016, 6:51 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 11, 2016, 6:51 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user variable from library to binary. Diffs (updated) - src/slave/container_loggers/lib_logrotate.cpp 0ca2b3d7dbb57c11c0740aed3914a6b75329af99 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 11, 2016, 6:50 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user value from executor of switch_user flag is set. Diffs (updated) - src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.
> On Oct. 11, 2016, 12:23 a.m., Joseph Wu wrote:
> > src/slave/slave.cpp, lines 4358-4365
> > <https://reviews.apache.org/r/52311/diff/8/?file=1524371#file1524371line4358>
> >
> > It is now possible replace this block with:
> > ```
> > executor.mutable_command()->add_arguments("--user=" + loggerUser.get());
> > ```
> >
> > Considering the variable's name and how it is used in this function,
> > you should consider renaming it `executorUser` and changing the type from
> > `Option` to `string`. Then, each place it needs to be set, you
> > check `if (flags.switch_user)`.
> > This is clearer than guarding it with `if (executorUser.isSome)`.
Don't I need to gaurd against empty string for user here?? Also, string is
directly used without std here, so, std namespace is imported somewhere right?
- Sivaram
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52311/#review152088
---
On Oct. 6, 2016, 3:30 a.m., Sivaram Kannan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52311/
> ---
>
> (Updated Oct. 6, 2016, 3:30 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-5856
> https://issues.apache.org/jira/browse/MESOS-5856
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Pass the user value from executor of switch_user flag is set.
>
>
> Diffs
> -
>
> src/slave/slave.cpp d30001bc0d1798311ba3966f67aadc6be2c92306
>
> Diff: https://reviews.apache.org/r/52311/diff/
>
>
> Testing
> ---
>
> 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether
> the logs are getting rotated.
> 2. Run the mesos-logrotate-logger as root user and verify whether the logs
> are getting rotated.
>
>
> Thanks,
>
> Sivaram Kannan
>
>
Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 6, 2016, 3:30 a.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Pass the user value from executor of switch_user flag is set. Diffs (updated) - src/slave/slave.cpp d30001bc0d1798311ba3966f67aadc6be2c92306 Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 6, 2016, 3:07 a.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user variable from library to binary. Diffs (updated) - src/slave/container_loggers/lib_logrotate.cpp 0ca2b3d7dbb57c11c0740aed3914a6b75329af99 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 6, 2016, 3:07 a.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 1, 2016, 10:42 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Pass the user value from executor of switch_user flag is set. Update the test case SlaveTest.GetExecutorInfo with the expected Command from 2 to 3. Diffs - src/slave/slave.cpp 958a33b962d6385e37af9372d9f8edd1f70bf676 src/tests/slave_tests.cpp 3471314675a11f850371e47b648bb43ee27e Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 1, 2016, 10:35 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Pass the user value from executor of switch_user flag is set. Diffs (updated) - src/slave/slave.cpp 958a33b962d6385e37af9372d9f8edd1f70bf676 src/tests/slave_tests.cpp 3471314675a11f850371e47b648bb43ee27e Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 1, 2016, 1:35 a.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp f906a167f8897385af5f54e1e77cb790121a Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 1, 2016, 1:34 a.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 1, 2016, 1:34 a.m.) Review request for mesos and Joseph Wu. Summary (updated) - Pass the user value from executor of switch_user flag is set. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Pass the user value from executor of switch_user flag is set. Diffs (updated) - src/slave/slave.cpp 958a33b962d6385e37af9372d9f8edd1f70bf676 Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 1, 2016, 1:33 a.m.) Review request for mesos and Joseph Wu. Summary (updated) - Switch the uid of the binary if a user is passed from the lib_logrotate. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Switch the uid of the binary if a user is passed from the lib_logrotate. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Pass the user variable from library to binary.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 1, 2016, 1:33 a.m.) Review request for mesos and Joseph Wu. Summary (updated) - Pass the user variable from library to binary. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Pass the user variable from library to binary. Diffs (updated) - src/slave/container_loggers/lib_logrotate.cpp 0ca2b3d7dbb57c11c0740aed3914a6b75329af99 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Sept. 30, 2016, 3:30 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp f906a167f8897385af5f54e1e77cb790121a Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 3:29 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid to passed user before spawning the process. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Set the user to stderr-logger binary too.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 30, 2016, 3:29 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Set the user to stderr-logger binary too. Diffs (updated) - src/slave/container_loggers/lib_logrotate.cpp 0ca2b3d7dbb57c11c0740aed3914a6b75329af99 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 30, 2016, 3:28 p.m.) Review request for mesos and Joseph Wu. Summary (updated) - Set the executorInfo user before the custom executor code flow. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Set the executorInfo user before the custom executor code flow. Diffs (updated) - src/slave/slave.cpp 958a33b962d6385e37af9372d9f8edd1f70bf676 Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 2:49 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid to passed user before spawning the process. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52308: Add variable user to handle switchUser passed from executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Sept. 30, 2016, 2:50 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Add variable user to handle switchUser passed from executor. Diffs (updated) - src/slave/container_loggers/logrotate.hpp f906a167f8897385af5f54e1e77cb790121a Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Set the user to stderr-logger binary too.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 30, 2016, 2:50 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Set the user to stderr-logger binary too. Diffs (updated) - src/slave/container_loggers/lib_logrotate.cpp 0ca2b3d7dbb57c11c0740aed3914a6b75329af99 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Fix removed empty lines from slave.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 30, 2016, 2:48 p.m.) Review request for mesos and Joseph Wu. Summary (updated) - Fix removed empty lines from slave.cpp. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Fix removed empty lines from slave.cpp. Diffs (updated) - src/slave/slave.cpp 958a33b962d6385e37af9372d9f8edd1f70bf676 Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Review Request 52424: Fix removed empty lines from slave.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52424/ --- Review request for mesos. Repository: mesos Description --- Fix removed empty lines from slave.cpp. Diffs - Diff: https://reviews.apache.org/r/52424/diff/ Testing --- Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 2:38 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid to passed user before spawning the process. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Sept. 30, 2016, 2:38 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Set the executorInfo user before the custom executor code flow. Diffs - src/slave/slave.cpp 958a33b962d6385e37af9372d9f8edd1f70bf676 Diff: https://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52309: Set the user to stderr-logger binary too.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 30, 2016, 2:38 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Set the user to stderr-logger binary too. Diffs - src/slave/container_loggers/lib_logrotate.cpp 0ca2b3d7dbb57c11c0740aed3914a6b75329af99 Diff: https://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
