Review Request 58771: Added tests for usernamespace support.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58771/ --- Review request for mesos. Repository: mesos Description --- WIP: Added tests for usernamespace support. Diffs - src/tests/containerizer/isolator_tests.cpp 355e15ff69ca6bdd94821f6566fd09a280d03b47 Diff: https://reviews.apache.org/r/58771/diff/1/ Testing --- Thanks, Srinivas Brahmaroutu
Review Request 58770: Enabled usernamespace support for default executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58770/ --- Review request for mesos. Repository: mesos Description --- WIP Enabled usernamespace support for default executor. Diffs - src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 src/slave/containerizer/mesos/containerizer.cpp 56db7eb1193c9812b62b9149c9c2b2dd9b66701c src/slave/containerizer/mesos/isolators/user/user.hpp PRE-CREATION src/slave/containerizer/mesos/launch.hpp 49eb9128ae5a1e4ec02e2b9d9e3cb67d7a8f7663 src/slave/containerizer/mesos/launch.cpp 2835beff9dbfa7f2a1cac306a58e2b1d66c14342 Diff: https://reviews.apache.org/r/58770/diff/1/ Testing --- Thanks, Srinivas Brahmaroutu
Review Request 58769: Added userns flag to ContainerLaunchInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58769/ --- Review request for mesos. Repository: mesos Description --- WIP Added userns flag to ContainerLaunchInfo. Diffs - include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2 Diff: https://reviews.apache.org/r/58769/diff/1/ Testing --- Thanks, Srinivas Brahmaroutu
Review Request 55782: Added preprocessing for bin scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55782/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-6757 https://issues.apache.org/jira/browse/MESOS-6757 Repository: mesos Description --- Added preprocessing for bin scripts. Diffs - CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f Diff: https://reviews.apache.org/r/55782/diff/ Testing --- cmake .. Thanks, Srinivas Brahmaroutu
Re: Review Request 55657: Added cpack to create source package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55657/ --- (Updated Jan. 18, 2017, 10:25 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-4245 https://issues.apache.org/jira/browse/MESOS-4245 Repository: mesos Description --- Added cpack to create source package. Diffs (updated) - CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f Diff: https://reviews.apache.org/r/55657/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Re: Review Request 55686: Added custom target for 'make distcheck'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55686/ --- (Updated Jan. 18, 2017, 10:25 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Changes --- make distcheck will untar the TGZ file under build directory The custom target will then create a build directory into that directory and runs a 'make check' to validate the source archive. Bugs: MESOS-5433 https://issues.apache.org/jira/browse/MESOS-5433 Repository: mesos Description --- Added custom target for 'make distcheck'. Diffs (updated) - CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f Diff: https://reviews.apache.org/r/55686/diff/ Testing --- make dist Thanks, Srinivas Brahmaroutu
Re: Review Request 55657: Added cpack to create source package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55657/ --- (Updated Jan. 18, 2017, 10:23 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Changes --- Currently the cpack source package is create in TGZ format. The sources packages are comparable to the make dist output. There may be a need to add support to add additional source files to the archive at some point. Summary (updated) - Added cpack to create source package. Bugs: MESOS-4245 https://issues.apache.org/jira/browse/MESOS-4245 Repository: mesos Description (updated) --- Added cpack to create source package. Diffs (updated) - CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f Diff: https://reviews.apache.org/r/55657/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Re: Review Request 55686: Added custom target for 'make distcheck'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55686/ --- (Updated Jan. 18, 2017, 10:22 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Changes --- Currently the cpack source package is create in TGZ format. The sources packages are comparable to the make dist output. There may be a need to add support to add additional source files to the archive at some point. Summary (updated) - Added custom target for 'make distcheck'. Bugs: MESOS-5433 https://issues.apache.org/jira/browse/MESOS-5433 Repository: mesos Description (updated) --- Added custom target for 'make distcheck'. Diffs (updated) - CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f Diff: https://reviews.apache.org/r/55686/diff/ Testing --- make dist Thanks, Srinivas Brahmaroutu
Review Request 55686: Added cpack to create source package. Currently the cpack source package is create in TGZ format. The sources packages are comparable to the make dist output. There may be a need
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55686/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5433 https://issues.apache.org/jira/browse/MESOS-5433 Repository: mesos Description --- Added cpack to create source package. Currently the cpack source package is create in TGZ format. The sources packages are comparable to the make dist output. There may be a need to add support to add additional source files to the archive at some point. Diffs - CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f Diff: https://reviews.apache.org/r/55686/diff/ Testing --- make dist Thanks, Srinivas Brahmaroutu
Review Request 55657: Added cpack to create source package. Currently the cpack source package is create in TGZ format. The sources packages are comparable to the make dist output. There may be a need
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55657/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-4245 https://issues.apache.org/jira/browse/MESOS-4245 Repository: mesos Description --- Added cpack to create source package. Currently the cpack source package is create in TGZ format. The sources packages are comparable to the make dist output. There may be a need to add support to add additional source files to the archive at some point. Diffs - CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f Diff: https://reviews.apache.org/r/55657/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Re: Review Request 50415: Added build step to build Java Protobuf.
> On Dec. 8, 2016, 8:59 p.m., Alex Clemmer wrote:
> > 3rdparty/CMakeLists.txt, line 347
> > <https://reviews.apache.org/r/50415/diff/6/?file=1579858#file1579858line347>
> >
> > If I'm understanding this correctly, this will download a fresh copy of
> > the protobuf tarball, and then build only the Java parts of it.
> >
> > Since we're already downloading this for the normal Protobuf build, it
> > seems like it would be easier to get rid of the `ExternalProject_Add` call
> > and simply append the java config, build, and install commands to the
> > protobuf config, build, and install commands. For example:
> >
> > ```
> > set(PROTOBUF_BUILD_CMD ${PROTOBUF_BUILD_CMD} ${PROTOBUF_JAVA_BUILD_CMD})
> > ```
> >
> > This should cause the normal protobuf build to build the Java stuff as
> > well, no?
>
> Srinivas Brahmaroutu wrote:
> I prefer to build the jar as a step for Java and I will add another step
> for Python. Hope this works.
>
> Alex Clemmer wrote:
> Can you speak a little more about why you prefer it? I personally would
> prefer to keep the Java, native, and Python builds of PB all coming from the
> same source tree just because it's less error-prone.
I fixed the that issue as you instructed, now the same source tree is used by
Java and Python builds. Adding a Java step and then a Python step to the same
project will just execute the step after building the protoc.
Source code is fetched, C++ build steps are performed.
Java step is invoked (depends on install step above) and Jar is built from the
same source. java/mvn install
Python step is invoked (depends on install step above) and egg is built from
the same source. python setup.py build
- Srinivas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50415/#review158565
---
On Dec. 10, 2016, 7:18 p.m., Srinivas Brahmaroutu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50415/
> ---
>
> (Updated Dec. 10, 2016, 7:18 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Added config, build and install steps for the External project
> protobuf_java.
> 'make probuf_java' produces the
> ${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
>
>
> Diffs
> -
>
> 3rdparty/CMakeLists.txt a340b29fc1cc8b68bf74bfc0c9c2274f0af84eee
>
> Diff: https://reviews.apache.org/r/50415/diff/
>
>
> Testing
> ---
>
> cmake && make protobuf-2.6.1-java
> check if
> 3rdparty/protobuf-2.6.1/src/protobuf-2.6.1-java/java/target/protobuf-java-2.6.1.jar
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>
Re: Review Request 50463: Added code to build libmesosjava shared library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- Builds mesosjava library from the mesos source files and the generated JNI header files. 'make mesosjava' genetated the library. Diffs (updated) - cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc Diff: https://reviews.apache.org/r/50463/diff/ Testing --- cmake && make mesosjava Build /src/libmesosjava.* shared libraries. Thanks, Srinivas Brahmaroutu
Re: Review Request 50459: Added code to generate JNI Header files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50459/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- Created a custom command to run javah on the generated java classes to create the JNI headers for Java bindings. 'make mesos-jni-headers' creates the jni header under the directory /include/java/jni/*.h Diffs (updated) - cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc src/java/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/50459/diff/ Testing --- cmake && make mesos-jni-header check to see if all the headers are generated. /include/java/jni/org_apache_mesos_Log.h /include/java/jni/org_apache_mesos_Log_Entry.h /include/java/jni/org_apache_mesos_Log_OperationFailedException.h /include/java/jni/org_apache_mesos_Log_Position.h /include/java/jni/org_apache_mesos_Log_Reader.h /include/java/jni/org_apache_mesos_Log_Writer.h /include/java/jni/org_apache_mesos_Log_WriterFailedException.h /include/java/jni/org_apache_mesos_MesosExecutorDriver.h /include/java/jni/org_apache_mesos_MesosSchedulerDriver.h /include/java/jni/org_apache_mesos_state_AbstractState.h /include/java/jni/org_apache_mesos_state_AbstractState_ExpungeFuture.h /include/java/jni/org_apache_mesos_state_AbstractState_FetchFuture.h /include/java/jni/org_apache_mesos_state_AbstractState_NamesFuture.h /include/java/jni/org_apache_mesos_state_AbstractState_StoreFuture.h /include/java/jni/org_apache_mesos_state_LevelDBState.h /include/java/jni/org_apache_mesos_state_LogState.h /include/java/jni/org_apache_mesos_state_Variable.h /include/java/jni/org_apache_mesos_state_ZooKeeperState.h Thanks, Srinivas Brahmaroutu
Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50457/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- Added a cmake library that makes use of configure_file to transform a source file at a relative location to the Source directory in to a target file at a realtive location into the Build Directory. The transformation replaces any CMake Variables in the source with assigned values. Diffs (updated) - cmake/Common.cmake 76b2a67419cb6836b598a0070f26632d4ca048ff src/java/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/50457/diff/ Testing --- cmake .. Check to see if /src/java/generated/org/apache/mesos/MesosNativeLibrary.java is generated. Thanks, Srinivas Brahmaroutu
Re: Review Request 50460: Added code to build libstate shared library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50460/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- Build libstate required by the mesos java bindings to communicate state information with java based components. Diffs (updated) - cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc src/state/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/50460/diff/ Testing --- cmake .. && make state build libstate dynamic library. Thanks, Srinivas Brahmaroutu
Re: Review Request 50458: Added code to build mesos-java.jar.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50458/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- The patch defines Java sources from the mesos repo along with generated protobug definitions in Java. Compiles these sources to create /src/java/mesos-java.jar. make mesos-java Diffs (updated) - cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc src/java/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/50458/diff/ Testing --- cmake && make mesos-java Check to see if /src/java/mesos-java.jar Thanks, Srinivas Brahmaroutu
Re: Review Request 50455: Enabled Java builds if Java is found.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50455/ --- (Updated Dec. 10, 2016, 7:18 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- Using FindJava and FindJNI cmake packages to detect java on the host, set JNI include paths and set HAS_JAVA global variable to conditionally build Java support. Diffs (updated) - cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc Diff: https://reviews.apache.org/r/50455/diff/ Testing --- cmake -DENABLE_JAVA=ON check build variables set for Java. cmake should output -- -- Java Found and will be enabled -- Thanks, Srinivas Brahmaroutu
Re: Review Request 50456: Added custom command to generate Java protobufs.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50456/
---
(Updated Dec. 10, 2016, 7:18 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902
Repository: mesos
Description (updated)
---
The Patch creates required directories mentioned below
${MESOS_BIN_INCLUDE_DIR}/java
${MESOS_BIN_SRC_DIR}/java/generated
Creates Java protobuf definitions under
${MESOS_BIN_SRC_DIR}/java/generated.
Diffs (updated)
-
cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc
src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc
src/java/CMakeLists.txt PRE-CREATION
Diff: https://reviews.apache.org/r/50456/diff/
Testing
---
cmake .. && make mesos-java-protos.
check to see if java/generated folder has all the new java files created.
/src/java/generated/org/apache/mesos/containerizer/Protos.java
/src/java/generated/org/apache/mesos/fetcher/Protos.java
/src/java/generated/org/apache/mesos/Protos.java
/src/java/generated/org/apache/mesos/scheduler/Protos.java
/src/java/generated/org/apache/mesos/v1/executor/Protos.java
/src/java/generated/org/apache/mesos/v1/Protos.java
/src/java/generated/org/apache/mesos/v1/scheduler/Protos.java
Thanks,
Srinivas Brahmaroutu
Re: Review Request 50414: Added variables for building Java Protobuf.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50414/
---
(Updated Dec. 10, 2016, 7:18 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902
Repository: mesos
Description
---
Added protobuf_java external project to 3rdparty.
This will setup PROTOBUF_JAVA_ROOT at location
/3rdparty/protobuf_java-2.6.1/src/protobuf_java-2.6.1
and also define the PROTOBUF_JAR at the location
${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
Diffs (updated)
-
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake
e9eabd08d327f4c714199f7bde91b9adf644a678
Diff: https://reviews.apache.org/r/50414/diff/
Testing
---
cmake .. && make
Thanks,
Srinivas Brahmaroutu
Re: Review Request 50415: Added build step to build Java Protobuf.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50415/
---
(Updated Dec. 10, 2016, 7:18 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902
Repository: mesos
Description
---
Added config, build and install steps for the External project
protobuf_java.
'make probuf_java' produces the
${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
Diffs (updated)
-
3rdparty/CMakeLists.txt a340b29fc1cc8b68bf74bfc0c9c2274f0af84eee
Diff: https://reviews.apache.org/r/50415/diff/
Testing
---
cmake && make protobuf-2.6.1-java
check if
3rdparty/protobuf-2.6.1/src/protobuf-2.6.1-java/java/target/protobuf-java-2.6.1.jar
Thanks,
Srinivas Brahmaroutu
Re: Review Request 50415: Added build step to build Java Protobuf.
> On Dec. 8, 2016, 8:59 p.m., Alex Clemmer wrote:
> > 3rdparty/CMakeLists.txt, line 311
> > <https://reviews.apache.org/r/50415/diff/6/?file=1579858#file1579858line311>
> >
> > I must be missing something, because I don't quite see why it's
> > necessary to copy `protoc` over to the Java root?
the build step in the source code requires protoc at relative location
../src/protoc
> On Dec. 8, 2016, 8:59 p.m., Alex Clemmer wrote:
> > 3rdparty/CMakeLists.txt, line 347
> > <https://reviews.apache.org/r/50415/diff/6/?file=1579858#file1579858line347>
> >
> > If I'm understanding this correctly, this will download a fresh copy of
> > the protobuf tarball, and then build only the Java parts of it.
> >
> > Since we're already downloading this for the normal Protobuf build, it
> > seems like it would be easier to get rid of the `ExternalProject_Add` call
> > and simply append the java config, build, and install commands to the
> > protobuf config, build, and install commands. For example:
> >
> > ```
> > set(PROTOBUF_BUILD_CMD ${PROTOBUF_BUILD_CMD} ${PROTOBUF_JAVA_BUILD_CMD})
> > ```
> >
> > This should cause the normal protobuf build to build the Java stuff as
> > well, no?
I prefer to build the jar as a step for Java and I will add another step for
Python. Hope this works.
- Srinivas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50415/#review158565
---
On Dec. 8, 2016, 11:04 p.m., Srinivas Brahmaroutu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50415/
> ---
>
> (Updated Dec. 8, 2016, 11:04 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Added config, build and install steps for the External project
> protobuf_java.
> 'make probuf_java' produces the
> ${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
>
>
> Diffs
> -
>
> 3rdparty/CMakeLists.txt a340b29fc1cc8b68bf74bfc0c9c2274f0af84eee
>
> Diff: https://reviews.apache.org/r/50415/diff/
>
>
> Testing
> ---
>
> cmake && make protobuf-2.6.1-java
> check if
> 3rdparty/protobuf-2.6.1/src/protobuf-2.6.1-java/java/target/protobuf-java-2.6.1.jar
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>
Re: Review Request 50415: Added build step to build Java Protobuf.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50415/
---
(Updated Dec. 8, 2016, 11:04 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902
Repository: mesos
Description
---
Added config, build and install steps for the External project
protobuf_java.
'make probuf_java' produces the
${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
Diffs (updated)
-
3rdparty/CMakeLists.txt a340b29fc1cc8b68bf74bfc0c9c2274f0af84eee
Diff: https://reviews.apache.org/r/50415/diff/
Testing
---
cmake && make protobuf-2.6.1-java
check if
3rdparty/protobuf-2.6.1/src/protobuf-2.6.1-java/java/target/protobuf-java-2.6.1.jar
Thanks,
Srinivas Brahmaroutu
Re: Review Request 50415: Added build step to build Java Protobuf.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50415/
---
(Updated Dec. 8, 2016, 6:19 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902
Repository: mesos
Description (updated)
---
Added config, build and install steps for the External project
protobuf_java.
'make probuf_java' produces the
${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
Diffs (updated)
-
3rdparty/CMakeLists.txt a340b29fc1cc8b68bf74bfc0c9c2274f0af84eee
Diff: https://reviews.apache.org/r/50415/diff/
Testing
---
cmake && make protobuf-2.6.1-java
check if
3rdparty/protobuf-2.6.1/src/protobuf-2.6.1-java/java/target/protobuf-java-2.6.1.jar
Thanks,
Srinivas Brahmaroutu
Re: Review Request 50414: Added variables for building Java Protobuf.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50414/
---
(Updated Dec. 8, 2016, 6:19 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902
Repository: mesos
Description (updated)
---
Added protobuf_java external project to 3rdparty.
This will setup PROTOBUF_JAVA_ROOT at location
/3rdparty/protobuf_java-2.6.1/src/protobuf_java-2.6.1
and also define the PROTOBUF_JAR at the location
${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
Diffs (updated)
-
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake
e9eabd08d327f4c714199f7bde91b9adf644a678
Diff: https://reviews.apache.org/r/50414/diff/
Testing
---
cmake .. && make
Thanks,
Srinivas Brahmaroutu
Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Oct. 31, 2016, 5:10 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Changes --- Change prior review to an up-to-date one -- Joseph Wu Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Added fles MESOS_DEFAULT_LIBRARY_LINKAGE which is set to STATIC on WIN32 and SHARED on OSX or Unix. This allows all libraries built static or shared. Also minor changes made to eliminate leveldb dependency when build slave or master. Also by setting the flag CMAKE_POSITION_INDEPENDENT_CODE to true cmake auto sets the flag -fPIC. Diffs (updated) - 3rdparty/http-parser/CMakeLists.txt.template 9a671973b754095e1de917f135a7deb978fb6eb6 cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt ba49d81335fd47a8ced334e282eadb00657bf2c2 src/slave/qos_controllers/CMakeLists.txt 87c92af21c012655c201c01cd4ba5ff912555119 src/slave/resource_estimators/CMakeLists.txt 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff Diff: https://reviews.apache.org/r/49862/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 52809: User Namespaces Initial Implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/ --- (Updated Oct. 17, 2016, 11:59 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Summary (updated) - User Namespaces Initial Implementation. Bugs: MESOS-2952 https://issues.apache.org/jira/browse/MESOS-2952 Repository: mesos Description (updated) --- Work in progress : implementing User namespaces. Phase 1: Create isolator and enable isolator to when Agent is run with "userns=true". If this flags is not set the original functionality will run the task as user who started the task. With the flag set to true, the task will be run inside the user namespace as a root inside the container and task is run as the user who started the task when seen from outside of the container. Approriate uid and gid maps are created. Phase 2: Provide mount point support for containers running in user namespace. This will allow to properly mount and access the filesystems with proper permission. Diffs (updated) - src/Makefile.am 3bcc0f2dfc2c4f71841bd6d161f39e0e919fc0d7 src/slave/containerizer/mesos/containerizer.cpp eac70d955e08142a2d054039d610a3d516b1b57e src/slave/containerizer/mesos/isolators/user/user.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/user/user.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/user/usermaps.hpp PRE-CREATION src/slave/containerizer/mesos/launch.cpp 8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 src/slave/flags.hpp 3c292bac9394347318865f49782907def6541742 src/slave/flags.cpp 87d9e4632321134192bb0a67f1b91db7d89f539b Diff: https://reviews.apache.org/r/52809/diff/ Testing --- Work in progress implementing User namespaces. Phase 1: Create isolator and enable isolator to when Agent is run with "userns=true". If this flags is not set the original functionality will run the task as user who started the task. With User namespace the task will be run inside the user namespace with as a root with the user who started the task is mapped to outside of the container. Approriate uid and gid maps are created. Phase 2: Provide mount point support for containers running in user namespace. Thanks, Srinivas Brahmaroutu
Re: Review Request 52810: Added tests to test usernamespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- (Updated Oct. 17, 2016, 11:58 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Description (updated) --- Basic testing to run the task as Root and Non-Root when user namespace is enabled. Diffs (updated) - src/tests/containerizer/isolator_tests.cpp 8fefeef8c83ed2ab01f56a1ec572d3acb307143c Diff: https://reviews.apache.org/r/52810/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Re: Review Request 52810: Added tests to test usernamespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- (Updated Oct. 17, 2016, 10:27 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Description --- Added tests to test usernamespaces. Diffs (updated) - src/tests/containerizer/isolator_tests.cpp 8fefeef8c83ed2ab01f56a1ec572d3acb307143c Diff: https://reviews.apache.org/r/52810/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Re: Review Request 52810: Added tests to test usernamespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- (Updated Oct. 17, 2016, 10:22 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Description (updated) --- Added tests to test usernamespaces. Diffs (updated) - src/tests/containerizer/isolator_tests.cpp 8fefeef8c83ed2ab01f56a1ec572d3acb307143c Diff: https://reviews.apache.org/r/52810/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Re: Review Request 51411: Added provisioner tests to provision using meta discovery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51411/ --- (Updated Oct. 16, 2016, 5:58 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added two tests that will test two of the image meta discovery paths. Test ROOT_MetaDiscoveryAppcImageTest pulls a appc image from quay.io and the test ROOT_MetaDiscoveryDockerImageTest pulls a docker image from the docker hub. Both tests use "useMetaDiscovery" flag along with other Appc image labels to invoke meta discovery algorithm from "rkt" tool. Diffs (updated) - src/tests/containerizer/provisioner_appc_tests.cpp a999fc7991da805dfbcdf5659fcfb762aee5b2b9 Diff: https://reviews.apache.org/r/51411/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Re: Review Request 50960: Added appc uri fetcher tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- (Updated Oct. 16, 2016, 5:58 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added tests to fetch using all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' fetch from docker registry ex: 'docker://hello-world'. Diffs (updated) - src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b Diff: https://reviews.apache.org/r/50960/diff/ Testing --- make check Found issue that the tests would fail if "rkt" binary is not available. Please suggest if I should use some environment variable to selectively run the tests under __IF_DEFINED_RKT Thanks, Srinivas Brahmaroutu
Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Oct. 16, 2016, 5:58 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- AppcFetcherPlugin returns a '.aci' file of a container image. Fetch supports all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' or fetch from docker registry ex: 'docker://hello-world'. Added new fetched plugin for Appc fetch algorithm. The new AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to fetch a container image into a store specified at a directory location using 'rkt fetch' command and method 'rktExport' exports the image fetched into the directory location as a '.aci' file that is in tar file format, usinf 'rkt image export' command. Diffs (updated) - src/Makefile.am 3bcc0f2dfc2c4f71841bd6d161f39e0e919fc0d7 src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c src/uri/fetchers/rkt.hpp PRE-CREATION src/uri/fetchers/rkt.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50959/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 51410: Enabled meta discovery and appc labels.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- (Updated Oct. 16, 2016, 5:58 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Summary (updated) - Enabled meta discovery and appc labels. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added appc_labels to mesos-execute so that we can indicate meta discovery using useMetaDiscovery="true" along with other appc labels that determines the os, arch of the image we are discovering. This logic needs to be documented so that user can switch between simple and meta discovery methods. This implementation is necessary as there is no other way to determine from the URI. Diffs (updated) - src/cli/execute.cpp fcf627b0dcbedd01700cc8c9acadf7ba0dae4faa src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp 373c7d4c0c7c4e35ca568f37e52915549798ee32 src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp f5e90527e6ace45a7745ca1ba1a9eeef938d2a68 src/slave/flags.hpp ec619f84c7f3be81db8ce8536936bf7d4207efa2 src/slave/flags.cpp 7f79cfcc7939680c38a3d0cd57471cc9976aff7c Diff: https://reviews.apache.org/r/51410/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Review Request 52810: Added tests to test usernamespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Description --- WIP : Added tests to test usernamespaces. Diffs - src/tests/containerizer/isolator_tests.cpp 8fefeef8c83ed2ab01f56a1ec572d3acb307143c Diff: https://reviews.apache.org/r/52810/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Review Request 52809: User Namespace implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Description --- WIP: User Namespace implementation. Diffs - src/Makefile.am fd01e1dfbdb04d073484ff6b7cc94b8d769f8a8e src/slave/containerizer/mesos/containerizer.cpp 32058c35ea9ca95f0a2665994c1ebccd5c840345 src/slave/containerizer/mesos/isolators/user/user.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/user/user.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/user/usermaps.hpp PRE-CREATION src/slave/containerizer/mesos/launch.cpp c6b669a04c006edfc78c06560d1eb088278c2f8e src/slave/flags.hpp 3952d04f6a00ac1dca1adf2bea7cc6e415620ce5 src/slave/flags.cpp 491d10f6a8a7ea8adbfe0a09f5fce79943bccfac Diff: https://reviews.apache.org/r/52809/diff/ Testing --- Work in progress implementing User namespaces. Phase 1: Create isolator and enable isolator to when Agent is run with "userns=true". If this flags is not set the original functionality will run the task as user who started the task. With User namespace the task will be run inside the user namespace with as a root with the user who started the task is mapped to outside of the container. Approriate uid and gid maps are created. Phase 2: Provide mount point support for containers running in user namespace. Thanks, Srinivas Brahmaroutu
Re: Review Request 52809: User Namespace implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/ --- (Updated Oct. 12, 2016, 11:01 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-2952 https://issues.apache.org/jira/browse/MESOS-2952 Repository: mesos Description --- WIP: User Namespace implementation. Diffs - src/Makefile.am fd01e1dfbdb04d073484ff6b7cc94b8d769f8a8e src/slave/containerizer/mesos/containerizer.cpp 32058c35ea9ca95f0a2665994c1ebccd5c840345 src/slave/containerizer/mesos/isolators/user/user.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/user/user.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/user/usermaps.hpp PRE-CREATION src/slave/containerizer/mesos/launch.cpp c6b669a04c006edfc78c06560d1eb088278c2f8e src/slave/flags.hpp 3952d04f6a00ac1dca1adf2bea7cc6e415620ce5 src/slave/flags.cpp 491d10f6a8a7ea8adbfe0a09f5fce79943bccfac Diff: https://reviews.apache.org/r/52809/diff/ Testing --- Work in progress implementing User namespaces. Phase 1: Create isolator and enable isolator to when Agent is run with "userns=true". If this flags is not set the original functionality will run the task as user who started the task. With User namespace the task will be run inside the user namespace with as a root with the user who started the task is mapped to outside of the container. Approriate uid and gid maps are created. Phase 2: Provide mount point support for containers running in user namespace. Thanks, Srinivas Brahmaroutu
Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Oct. 4, 2016, 11:45 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Builds shared libraries for dynamically loading them by various tests: libexamplemodule, libtestauthorizer, libtestisolator, libtestresource_estimator, libtestallocator, libtestcontainer_logger, libtestmastercontender, libtestanonymous, libtesthook, libtestmasterdetector, libtestauthentication, libtesthttpauthenticator, libtestqos_controller. Diffs (updated) - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt ba49d81335fd47a8ced334e282eadb00657bf2c2 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49863/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- (Updated Oct. 4, 2016, 11:46 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Builds library liblogrotate_container_logger useful to operate logrotate loggers. Diffs (updated) - src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c src/slave/container_loggers/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/49874/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49870: Added test executables required to run tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated Oct. 4, 2016, 11:46 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Builds executables dynamic-reservation-framework, test-http-framework, test-framework, test-executor, test-http-executor, long-lived-framework, long-lived-executor, no-executor-framework, docker-no-executor-framework, balloon-framework, balloon-executor, load-generator-framework, persistent-volume-framework Diffs (updated) - src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49870/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49921: Fixed mesos tests to run most of the tests on Unix and OSX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- (Updated Oct. 4, 2016, 11:46 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- This patch builds /src/mesos-tests This patch adds all test sources, categorize them so that some are run in environment with Java, on Unix, etc. Patch allows to run all the tests that are enabled on a platform by simply running the mesos-tests executable. Diffs (updated) - src/CMakeLists.txt ba49d81335fd47a8ced334e282eadb00657bf2c2 src/tests/CMakeLists.txt f5d66dc63143455506d8660674fbd9eb227625ff src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff src/tests/containerizer/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/49921/diff/ Testing --- cmake .. && make src/tests/mesos-tests (runs 723 tests with no failures) I did not enable any module that has even a single failue. There are many more tests that are passing. Thanks, Srinivas Brahmaroutu
Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Oct. 4, 2016, 9:12 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Builds shared libraries for dynamically loading them by various tests: libexamplemodule, libtestauthorizer, libtestisolator, libtestresource_estimator, libtestallocator, libtestcontainer_logger, libtestmastercontender, libtestanonymous, libtesthook, libtestmasterdetector, libtestauthentication, libtesthttpauthenticator, libtestqos_controller. Diffs (updated) - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt ba49d81335fd47a8ced334e282eadb00657bf2c2 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49863/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Oct. 4, 2016, 9:10 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Added fles MESOS_DEFAULT_LIBRARY_LINKAGE which is set to STATIC on WIN32 and SHARED on OSX or Unix. This allows all libraries built static or shared. Also minor changes made to eliminate leveldb dependency when build slave or master. Also by setting the flag CMAKE_POSITION_INDEPENDENT_CODE to true cmake auto sets the flag -fPIC. Diffs (updated) - 3rdparty/http-parser/CMakeLists.txt.template 9a671973b754095e1de917f135a7deb978fb6eb6 cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt ba49d81335fd47a8ced334e282eadb00657bf2c2 src/slave/qos_controllers/CMakeLists.txt 87c92af21c012655c201c01cd4ba5ff912555119 src/slave/resource_estimators/CMakeLists.txt 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff Diff: https://reviews.apache.org/r/49862/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 50327: Added scripts to build sample framework executables.
> On Oct. 3, 2016, 11:05 p.m., Joseph Wu wrote: > > src/examples/CMakeLists.txt, lines 84-92 > > <https://reviews.apache.org/r/50327/diff/4/?file=1492325#file1492325line84> > > > > Why are these necessary? I could build a couple of the example > > frameworks after deleting these. You are right, we can compile all example modules without additional libs or includes. - Srinivas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/#review151244 --- On Oct. 4, 2016, 4:53 p.m., Srinivas Brahmaroutu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50327/ > --- > > (Updated Oct. 4, 2016, 4:53 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > --- > > Added scripts to build sample framework executables. > > > Diffs > - > > CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f > cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 > src/CMakeLists.txt 35eb63fe9a8e47d97512e9904bf5a714c63722a7 > src/examples/CMakeLists.txt PRE-CREATION > src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/50327/diff/ > > > Testing > --- > > cmake .. && make dynamic-reservation-framework test-http-framework > test-framework test-executor test-http-executor long-lived-framework > long-lived-executor no-executor-framework docker-no-executor-framework > balloon-framework balloon-executor load-generator-framework > persistent-volume-framework > > > Thanks, > > Srinivas Brahmaroutu > >
Re: Review Request 50327: Added scripts to build sample framework executables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/ --- (Updated Oct. 4, 2016, 4:53 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Added scripts to build sample framework executables. Diffs (updated) - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 35eb63fe9a8e47d97512e9904bf5a714c63722a7 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/50327/diff/ Testing --- cmake .. && make dynamic-reservation-framework test-http-framework test-framework test-executor test-http-executor long-lived-framework long-lived-executor no-executor-framework docker-no-executor-framework balloon-framework balloon-executor load-generator-framework persistent-volume-framework Thanks, Srinivas Brahmaroutu
Re: Review Request 51410: Enabled meta discovery using appc labels.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- (Updated Sept. 23, 2016, 7:25 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added appc_labels to mesos-execute so that we can indicate meta discovery using useMetaDiscovery="true" along with other appc labels that determines the os, arch of the image we are discovering. This logic needs to be documented so that user can switch between simple and meta discovery methods. This implementation is necessary as there is no other way to determine from the URI. Diffs (updated) - src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp 907e761856e8996b72e4231de27fa15e884d52e3 Diff: https://reviews.apache.org/r/51410/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50960: Added appc uri fetcher tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- (Updated Sept. 19, 2016, 3:35 a.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added tests to fetch using all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' fetch from docker registry ex: 'docker://hello-world'. Diffs (updated) - src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b Diff: https://reviews.apache.org/r/50960/diff/ Testing (updated) --- make check Found issue that the tests would fail if "rkt" binary is not available. Please suggest if I should use some environment variable to selectively run the tests under __IF_DEFINED_RKT Thanks, Srinivas Brahmaroutu
Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Sept. 19, 2016, 3:34 a.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- AppcFetcherPlugin returns a '.aci' file of a container image. Fetch supports all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' or fetch from docker registry ex: 'docker://hello-world'. Added new fetched plugin for Appc fetch algorithm. The new AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to fetch a container image into a store specified at a directory location using 'rkt fetch' command and method 'rktExport' exports the image fetched into the directory location as a '.aci' file that is in tar file format, usinf 'rkt image export' command. Diffs (updated) - src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c src/uri/fetchers/rkt.hpp PRE-CREATION src/uri/fetchers/rkt.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50959/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.
> On Sept. 16, 2016, 12:38 a.m., Jie Yu wrote: > > src/uri/fetchers/appc.cpp, lines 149-151 > > <https://reviews.apache.org/r/50959/diff/3/?file=1492127#file1492127line149> > > > > I suggest we create a class called Rkt which abstracts the rkt tool. > > ``` > > Rkt rkt = Rkt::create(); > > rkt->fetch(...); > > rkt->export(...); > > ``` > > > > You can do the os::which check in Rkt::create. I did make sure that .then construct worksby moving it to a process with Fetch and Export methods. Apparently "export" cannot be a function name. - Srinivas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/#review149113 ------- On Sept. 19, 2016, 1:15 a.m., Srinivas Brahmaroutu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50959/ > --- > > (Updated Sept. 19, 2016, 1:15 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4288 > https://issues.apache.org/jira/browse/MESOS-4288 > > > Repository: mesos > > > Description > --- > > AppcFetcherPlugin returns a '.aci' file of a container image. > > Fetch supports all three modes that 'rkt fetch' supports, fetch with > meta discovery ex: 'coreos.com/hello:latest', fetch from a specific > location ex: 'https://github.com/xxx/hello.aci' or fetch from docker > registry ex: 'docker://hello-world'. > > Added new fetched plugin for Appc fetch algorithm. The new > AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to > fetch a container image into a store specified at a directory location > using 'rkt fetch' command and method 'rktExport' exports the image > fetched into the directory location as a '.aci' file that is in tar > file format, usinf 'rkt image export' command. > > > Diffs > - > > src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede > src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 > src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c > src/uri/fetchers/rkt.hpp PRE-CREATION > src/uri/fetchers/rkt.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/50959/diff/ > > > Testing > --- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
Re: Review Request 51411: Added provisioner tests to provision using meta discovery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51411/ --- (Updated Sept. 19, 2016, 1:16 a.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added two tests that will test two of the image meta discovery paths. Test ROOT_MetaDiscoveryAppcImageTest pulls a appc image from quay.io and the test ROOT_MetaDiscoveryDockerImageTest pulls a docker image from the docker hub. Both tests use "useMetaDiscovery" flag along with other Appc image labels to invoke meta discovery algorithm from "rkt" tool. Diffs (updated) - src/tests/containerizer/provisioner_appc_tests.cpp 6ef1c926d7aa942e241a24d4d3838a5f2d7c4bd1 Diff: https://reviews.apache.org/r/51411/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Re: Review Request 50960: Added appc uri fetcher tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- (Updated Sept. 19, 2016, 1:16 a.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added tests to fetch using all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' fetch from docker registry ex: 'docker://hello-world'. Diffs (updated) - src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b Diff: https://reviews.apache.org/r/50960/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 51410: Enabled meta discovery using appc labels.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- (Updated Sept. 19, 2016, 1:16 a.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added appc_labels to mesos-execute so that we can indicate meta discovery using useMetaDiscovery="true" along with other appc labels that determines the os, arch of the image we are discovering. This logic needs to be documented so that user can switch between simple and meta discovery methods. This implementation is necessary as there is no other way to determine from the URI. Diffs (updated) - src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp 907e761856e8996b72e4231de27fa15e884d52e3 Diff: https://reviews.apache.org/r/51410/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Sept. 19, 2016, 1:15 a.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- AppcFetcherPlugin returns a '.aci' file of a container image. Fetch supports all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' or fetch from docker registry ex: 'docker://hello-world'. Added new fetched plugin for Appc fetch algorithm. The new AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to fetch a container image into a store specified at a directory location using 'rkt fetch' command and method 'rktExport' exports the image fetched into the directory location as a '.aci' file that is in tar file format, usinf 'rkt image export' command. Diffs (updated) - src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c src/uri/fetchers/rkt.hpp PRE-CREATION src/uri/fetchers/rkt.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50959/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Added fles MESOS_DEFAULT_LIBRARY_LINKAGE which is set to STATIC on WIN32 and SHARED on OSX or Unix. This allows all libraries built static or shared. Also minor changes made to eliminate leveldb dependency when build slave or master. Also by setting the flag CMAKE_POSITION_INDEPENDENT_CODE to true cmake auto sets the flag -fPIC. Diffs (updated) - 3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8 3rdparty/http-parser/CMakeLists.txt.template 9a671973b754095e1de917f135a7deb978fb6eb6 cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 src/master/cmake/MasterConfigure.cmake 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c src/slave/qos_controllers/CMakeLists.txt 87c92af21c012655c201c01cd4ba5ff912555119 src/slave/resource_estimators/CMakeLists.txt 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 Diff: https://reviews.apache.org/r/49862/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49921: Fixed mesos tests to run most of the tests on Unix and OSX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- This patch builds /src/mesos-tests This patch adds all test sources, categorize them so that some are run in environment with Java, on Unix, etc. Patch allows to run all the tests that are enabled on a platform by simply running the mesos-tests executable. Diffs (updated) - src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 src/tests/CMakeLists.txt f5d66dc63143455506d8660674fbd9eb227625ff src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff Diff: https://reviews.apache.org/r/49921/diff/ Testing --- cmake .. && make src/tests/mesos-tests (runs 723 tests with no failures) I did not enable any module that has even a single failue. There are many more tests that are passing. Thanks, Srinivas Brahmaroutu
Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Builds library liblogrotate_container_logger useful to operate logrotate loggers. Diffs (updated) - src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c src/slave/container_loggers/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/49874/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49924: Added libprocess as a shared library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- This patch allow to build libprocess as shared library on OSX and Linux Diffs (updated) - 3rdparty/libprocess/src/CMakeLists.txt d1547ef6a8762385f653d3824307727e4d0a7e71 Diff: https://reviews.apache.org/r/49924/diff/ Testing --- cmake .. && make With this patch and https://reviews.apache.org/r/49862, Converted libmesos, http_parser and libprocess to shared libraries and we are using libevent shared library, zookeeper does not have a shared library in the 3rdparty (I guess the code is compiled as relocatable) and did not have issues linking. Thanks, Srinivas Brahmaroutu
Re: Review Request 49870: Added test executables required to run tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Builds executables dynamic-reservation-framework, test-http-framework, test-framework, test-executor, test-http-executor, long-lived-framework, long-lived-executor, no-executor-framework, docker-no-executor-framework, balloon-framework, balloon-executor, load-generator-framework, persistent-volume-framework Diffs (updated) - src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49870/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Builds shared libraries for dynamically loading them by various tests: libexamplemodule, libtestauthorizer, libtestisolator, libtestresource_estimator, libtestallocator, libtestcontainer_logger, libtestmastercontender, libtestanonymous, libtesthook, libtestmasterdetector, libtestauthentication, libtesthttpauthenticator, libtestqos_controller. Diffs (updated) - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49863/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49688: Added cmake build variables for mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- The patch simply sets up the mesos-tests target, also defines and sets up the required dependencies, includ and lib directories. Target and sources are added after building all test dependencies in a patch. Diffs (updated) - src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff src/tests/containerizer/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/49688/diff/ Testing --- cmake .. cmake check Thanks, Srinivas Brahmaroutu
Re: Review Request 50326: Added script to build mesos-resolve.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50326/ --- (Updated Sept. 6, 2016, 10:06 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Added script to build mesos-resolve. Diffs (updated) - src/cli/CMakeLists.txt c0120cd7f4ef8dc275edbd5cb1a4a6e23952ec63 Diff: https://reviews.apache.org/r/50326/diff/ Testing --- cmake .. && make mesos-resolve Thanks, Srinivas Brahmaroutu
Re: Review Request 50327: Added scripts to build sample framework executables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/ --- (Updated Sept. 6, 2016, 10:06 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Added scripts to build sample framework executables. Diffs (updated) - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/50327/diff/ Testing --- cmake .. && make dynamic-reservation-framework test-http-framework test-framework test-executor test-http-executor long-lived-framework long-lived-executor no-executor-framework docker-no-executor-framework balloon-framework balloon-executor load-generator-framework persistent-volume-framework Thanks, Srinivas Brahmaroutu
Re: Review Request 50325: Added script to build mesos-log tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50325/ --- (Updated Sept. 6, 2016, 10:06 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Added script to build mesos-log tool. Diffs (updated) - src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 src/log/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/50325/diff/ Testing --- cmake .. && make mesos-log Thanks, Srinivas Brahmaroutu
Re: Review Request 51410: Enabled meta discovery using appc labels.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- (Updated Sept. 6, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added appc_labels to mesos-execute so that we can indicate meta discovery using useMetaDiscovery="true" along with other appc labels that determines the os, arch of the image we are discovering. This logic needs to be documented so that user can switch between simple and meta discovery methods. This implementation is necessary as there is no other way to determine from the URI. Diffs (updated) - src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp 907e761856e8996b72e4231de27fa15e884d52e3 Diff: https://reviews.apache.org/r/51410/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50960: Added appc uri fetcher tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- (Updated Sept. 6, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added tests to fetch using all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' fetch from docker registry ex: 'docker://hello-world'. Diffs (updated) - src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b Diff: https://reviews.apache.org/r/50960/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 51411: Added provisioner tests to provision using meta discovery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51411/ --- (Updated Sept. 6, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added two tests that will test two of the image meta discovery paths. Test ROOT_MetaDiscoveryAppcImageTest pulls a appc image from quay.io and the test ROOT_MetaDiscoveryDockerImageTest pulls a docker image from the docker hub. Both tests use "useMetaDiscovery" flag along with other Appc image labels to invoke meta discovery algorithm from "rkt" tool. Diffs (updated) - src/tests/containerizer/provisioner_appc_tests.cpp b3ba176e506a6d1528290c07a8a0555b12c8cf70 Diff: https://reviews.apache.org/r/51411/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Sept. 6, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- AppcFetcherPlugin returns a '.aci' file of a container image. Fetch supports all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' or fetch from docker registry ex: 'docker://hello-world'. Added new fetched plugin for Appc fetch algorithm. The new AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to fetch a container image into a store specified at a directory location using 'rkt fetch' command and method 'rktExport' exports the image fetched into the directory location as a '.aci' file that is in tar file format, usinf 'rkt image export' command. Diffs (updated) - src/Makefile.am 15b9a63822eca8d0b428191940026756fba7821e src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c src/uri/fetchers/appc.hpp PRE-CREATION src/uri/fetchers/appc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50959/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50956: Added name to uri fetcher plugins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50956/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added name to uri fetcher plugins. Diffs (updated) - include/mesos/uri/fetcher.hpp 3add35c8c0e559203acb540a288d0b51ac817519 src/uri/fetchers/copy.hpp 64e686c3249a34c9c68f1bf0ccde1683516d9f26 src/uri/fetchers/copy.cpp f095ad65b50405c5e0869e74652ce9529332dd0c src/uri/fetchers/curl.hpp 447e01b9a566df133fd397cc4ea80150761f4653 src/uri/fetchers/curl.cpp cc3f9eec42eb841ecd320ffc83aa7884dc67c415 src/uri/fetchers/docker.hpp 6cb57be97d9494ea59ce9759e3d52e37b19d6c43 src/uri/fetchers/docker.cpp 72f70b8d17c947d5e9d8eb70c1c6bd6046bf1cd2 src/uri/fetchers/hadoop.hpp 1689f607a2bcff09887e5aa4d6e03de0ac020260 src/uri/fetchers/hadoop.cpp 3c69d43d7bc21061adb9c392da976dc5584e74d4 Diff: https://reviews.apache.org/r/50956/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50957: Added fetch method based on plugin name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50957/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description (updated) --- Added plugins by name into the Fetcher. Added a new fetch method to select plugin by name which ignores scheme and directly invokes fetch on the plugin. Diffs (updated) - include/mesos/uri/fetcher.hpp 3add35c8c0e559203acb540a288d0b51ac817519 src/uri/fetcher.cpp 198bd29993381758183edfce8faafba36da2d9ae Diff: https://reviews.apache.org/r/50957/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50960: Added appc uri fetcher tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description (updated) --- Added tests to fetch using all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' fetch from docker registry ex: 'docker://hello-world'. Diffs (updated) - src/tests/uri_fetcher_tests.cpp 072c09b8081e5d5dded907b1a0ffb6d739d86911 Diff: https://reviews.apache.org/r/50960/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50958: Added tests to invoke the fetcher plugins by name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50958/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Add a test case for each of the existing fetcher plugins to invoke them by name. Diffs (updated) - src/tests/uri_fetcher_tests.cpp 072c09b8081e5d5dded907b1a0ffb6d739d86911 Diff: https://reviews.apache.org/r/50958/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description (updated) --- AppcFetcherPlugin returns a '.aci' file of a container image. Fetch supports all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' or fetch from docker registry ex: 'docker://hello-world'. Added new fetched plugin for Appc fetch algorithm. The new AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to fetch a container image into a store specified at a directory location using 'rkt fetch' command and method 'rktExport' exports the image fetched into the directory location as a '.aci' file that is in tar file format, usinf 'rkt image export' command. Diffs (updated) - src/Makefile.am 69e56551f0adca6d6a9811cafea9a8d3c56d1df9 src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 src/uri/fetcher.cpp 198bd29993381758183edfce8faafba36da2d9ae src/uri/fetchers/appc.hpp PRE-CREATION src/uri/fetchers/appc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50959/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 51410: Enabled meta discovery using appc labels.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- (Updated Aug. 25, 2016, 3:21 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added appc_labels to mesos-execute so that we can indicate meta discovery using useMetaDiscovery="true" along with other appc labels that determines the os, arch of the image we are discovering. This logic needs to be documented so that user can switch between simple and meta discovery methods. This implementation is necessary as there is no other way to determine from the URI. Diffs - src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp 907e761856e8996b72e4231de27fa15e884d52e3 Diff: https://reviews.apache.org/r/51410/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Review Request 51411: Added provisioner tests to provision using meta discovery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51411/ --- Review request for mesos. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added two tests that will test two of the image meta discovery paths. Test ROOT_MetaDiscoveryAppcImageTest pulls a appc image from quay.io and the test ROOT_MetaDiscoveryDockerImageTest pulls a docker image from the docker hub. Both tests use "useMetaDiscovery" flag along with other Appc image labels to invoke meta discovery algorithm from "rkt" tool. Diffs - src/tests/containerizer/provisioner_appc_tests.cpp b3ba176e506a6d1528290c07a8a0555b12c8cf70 Diff: https://reviews.apache.org/r/51411/diff/ Testing --- Thanks, Srinivas Brahmaroutu
Review Request 51410: Enabled meta discovery using appc labels.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- Review request for mesos. Repository: mesos Description --- Added appc_labels to mesos-execute so that we can indicate meta discovery using useMetaDiscovery="true" along with other appc labels that determines the os, arch of the image we are discovering. This logic needs to be documented so that user can switch between simple and meta discovery methods. This implementation is necessary as there is no other way to determine from the URI. Diffs - src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp 907e761856e8996b72e4231de27fa15e884d52e3 Diff: https://reviews.apache.org/r/51410/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 49689: Added Appc runtime isolator tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/ --- (Updated Aug. 20, 2016, 9:05 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4778 https://issues.apache.org/jira/browse/MESOS-4778 Repository: mesos Description --- Added Appc runtime isolator tests. Diffs (updated) - src/Makefile.am d0f937d8879b11fac793b73f529762e95a9ff1e4 src/tests/containerizer/appc_archive.hpp PRE-CREATION src/tests/containerizer/appc_runtime_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/49689/diff/ Testing --- Make check Thanks, Srinivas Brahmaroutu
Review Request 50960: Added appc uri fetcher tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added tests to fetch using all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' fetch from docker registry ex: 'docker://hello-world'. Diffs - src/tests/uri_fetcher_tests.cpp 072c09b8081e5d5dded907b1a0ffb6d739d86911 Diff: https://reviews.apache.org/r/50960/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Aug. 10, 2016, 7:21 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description (updated) --- AppcFetcherPlugin returns a '.aci' file of a container image. Fetch supports all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' or fetch from docker registry ex: 'docker://hello-world'. Added new fetched plugin for Appc fetch algorithm. The new AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to fetch a container image into a store specified at a directory location using 'rkt fetch' command and method 'rktExport' exports the image fetched into the directory location as a '.aci' file that is in tar file format, usinf 'rkt image export' command. Diffs - src/Makefile.am cf76a699c33debb129722b7cba63a4e9e09f84f7 src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 src/uri/fetcher.cpp 198bd29993381758183edfce8faafba36da2d9ae src/uri/fetchers/appc.hpp PRE-CREATION src/uri/fetchers/appc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50959/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Review Request 50959: Added appc fetcher plugin to use rkt tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- AppcFetcherPlugin returns a '.aci' file of a container image. Fetch supports all three modes that 'rkt fetch' supports, fetch with meta discovery ex: 'coreos.com/hello:latest', fetch from a specific location ex: 'https://github.com/xxx/hello.aci' or fetch from docker registry ex: 'docker://hello-world'. Added new fetched plugin for Appc fetch algorithm. The new AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to fetch a container image into a store specified at a directory location using 'rkt fetch' command and method 'rktExport' exports the image fetched into the directory location as a '.aci' file that is in tar file format, usinf 'rkt image export' command. Diffs - src/Makefile.am cf76a699c33debb129722b7cba63a4e9e09f84f7 src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 src/uri/fetcher.cpp 198bd29993381758183edfce8faafba36da2d9ae src/uri/fetchers/appc.hpp PRE-CREATION src/uri/fetchers/appc.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50959/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Review Request 50958: Added tests to invoke the fetcher plugins by name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50958/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Add a test case for each of the existing fetcher plugins to invoke them by name. Diffs - src/tests/uri_fetcher_tests.cpp 072c09b8081e5d5dded907b1a0ffb6d739d86911 Diff: https://reviews.apache.org/r/50958/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Review Request 50957: Added fetch method based on plugin name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50957/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added plugins by name into the Fetcher. Added a new fetch method to select plugin by name which ignores scheme and directly invokes fetch on the plugin. Diffs - include/mesos/uri/fetcher.hpp 3add35c8c0e559203acb540a288d0b51ac817519 src/uri/fetcher.cpp 198bd29993381758183edfce8faafba36da2d9ae Diff: https://reviews.apache.org/r/50957/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Review Request 50956: Added name to uri fetcher plugins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50956/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288 https://issues.apache.org/jira/browse/MESOS-4288 Repository: mesos Description --- Added name to uri fetcher plugins. Diffs - include/mesos/uri/fetcher.hpp 3add35c8c0e559203acb540a288d0b51ac817519 src/uri/fetchers/copy.hpp 64e686c3249a34c9c68f1bf0ccde1683516d9f26 src/uri/fetchers/copy.cpp f095ad65b50405c5e0869e74652ce9529332dd0c src/uri/fetchers/curl.hpp 447e01b9a566df133fd397cc4ea80150761f4653 src/uri/fetchers/curl.cpp cc3f9eec42eb841ecd320ffc83aa7884dc67c415 src/uri/fetchers/docker.hpp 6cb57be97d9494ea59ce9759e3d52e37b19d6c43 src/uri/fetchers/docker.cpp 72f70b8d17c947d5e9d8eb70c1c6bd6046bf1cd2 src/uri/fetchers/hadoop.hpp 1689f607a2bcff09887e5aa4d6e03de0ac020260 src/uri/fetchers/hadoop.cpp 3c69d43d7bc21061adb9c392da976dc5584e74d4 Diff: https://reviews.apache.org/r/50956/diff/ Testing --- make check Thanks, Srinivas Brahmaroutu
Review Request 50954: Added documentation to Appc runtime support.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50954/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5837 https://issues.apache.org/jira/browse/MESOS-5837 Repository: mesos Description --- Added documentation to Appc runtime support. Diffs - docs/container-image.md 0feb0286218d1774f47640a7e41f0f65c6181db0 docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 Diff: https://reviews.apache.org/r/50954/diff/ Testing --- Tested documentation update. Thanks, Srinivas Brahmaroutu
Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- (Updated Aug. 8, 2016, 5:24 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description (updated) --- Builds library liblogrotate_container_logger useful to operate logrotate loggers. Diffs (updated) - src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c src/slave/container_loggers/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/49874/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49924: Added libprocess as a shared library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/ --- (Updated Aug. 8, 2016, 5:25 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description (updated) --- This patch allow to build libprocess as shared library on OSX and Linux Diffs (updated) - 3rdparty/libprocess/src/CMakeLists.txt d1547ef6a8762385f653d3824307727e4d0a7e71 Diff: https://reviews.apache.org/r/49924/diff/ Testing --- cmake .. && make With this patch and https://reviews.apache.org/r/49862, Converted libmesos, http_parser and libprocess to shared libraries and we are using libevent shared library, zookeeper does not have a shared library in the 3rdparty (I guess the code is compiled as relocatable) and did not have issues linking. Thanks, Srinivas Brahmaroutu
Re: Review Request 49921: Fixed mesos tests to run most of the tests on Unix and OSX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- (Updated Aug. 8, 2016, 5:24 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description (updated) --- This patch builds /src/mesos-tests This patch adds all test sources, categorize them so that some are run in environment with Java, on Unix, etc. Patch allows to run all the tests that are enabled on a platform by simply running the mesos-tests executable. Diffs (updated) - src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 src/tests/CMakeLists.txt 1ea8b2102753ae294bd75706ffaf08308e928acd src/tests/cmake/MesosTestsConfigure.cmake 361032082c3a5f76b949dc7981f75b53e02d84f5 Diff: https://reviews.apache.org/r/49921/diff/ Testing --- cmake .. && make src/tests/mesos-tests (runs 723 tests with no failures) I did not enable any module that has even a single failue. There are many more tests that are passing. Thanks, Srinivas Brahmaroutu
Re: Review Request 49870: Added test executables required to run tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated Aug. 8, 2016, 5:24 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description (updated) --- Builds executables dynamic-reservation-framework, test-http-framework, test-framework, test-executor, test-http-executor, long-lived-framework, long-lived-executor, no-executor-framework, docker-no-executor-framework, balloon-framework, balloon-executor, load-generator-framework, persistent-volume-framework Diffs (updated) - src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49870/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 8, 2016, 5:24 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Builds shared libraries for dynamically loading them by various tests: libexamplemodule, libtestauthorizer, libtestisolator, libtestresource_estimator, libtestallocator, libtestcontainer_logger, libtestmastercontender, libtestanonymous, libtesthook, libtestmasterdetector, libtestauthentication, libtesthttpauthenticator, libtestqos_controller. Diffs (updated) - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49863/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49688: Added cmake build variables for mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated Aug. 8, 2016, 5:23 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description (updated) --- The patch simply sets up the mesos-tests target, also defines and sets up the required dependencies, includ and lib directories. Target and sources are added after building all test dependencies in a patch. Diffs (updated) - src/tests/cmake/MesosTestsConfigure.cmake 361032082c3a5f76b949dc7981f75b53e02d84f5 src/tests/containerizer/CMakeLists.txt 2c52e43a9deee90fa32693731d6ebedb5201bb1f Diff: https://reviews.apache.org/r/49688/diff/ Testing --- cmake .. cmake check Thanks, Srinivas Brahmaroutu
Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Aug. 8, 2016, 5:23 a.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Summary (updated) - Changed libraies to shared on OSX and UNIX. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description (updated) --- Added fles MESOS_DEFAULT_LIBRARY_LINKAGE which is set to STATIC on WIN32 and SHARED on OSX or Unix. This allows all libraries built static or shared. Also minor changes made to eliminate leveldb dependency when build slave or master. Also by setting the flag CMAKE_POSITION_INDEPENDENT_CODE to true cmake auto sets the flag -fPIC. Diffs (updated) - 3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8 3rdparty/http-parser/CMakeLists.txt.template 9a671973b754095e1de917f135a7deb978fb6eb6 cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 src/master/cmake/MasterConfigure.cmake 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c src/slave/qos_controllers/CMakeLists.txt 87c92af21c012655c201c01cd4ba5ff912555119 src/slave/resource_estimators/CMakeLists.txt 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 Diff: https://reviews.apache.org/r/49862/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49870: Added test executables required to run tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated Aug. 7, 2016, 3:14 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Added test executables required to run tests. Diffs (updated) - src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49870/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 50463: Added code to build libmesosjava shared library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/ --- (Updated Aug. 4, 2016, 9:17 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- Added code to build libmesosjava shared library. Diffs (updated) - cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 Diff: https://reviews.apache.org/r/50463/diff/ Testing --- cmake && make mesosjava Build /src/libmesosjava.* shared libraries. Thanks, Srinivas Brahmaroutu
Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 4, 2016, 9:10 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description (updated) --- Builds shared libraries for dynamically loading them by various tests: libexamplemodule, libtestauthorizer, libtestisolator, libtestresource_estimator, libtestallocator, libtestcontainer_logger, libtestmastercontender, libtestanonymous, libtesthook, libtestmasterdetector, libtestauthentication, libtesthttpauthenticator, libtestqos_controller. Diffs - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49863/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 4, 2016, 9:08 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description (updated) --- Builds shared libraries for dynamically loading them by various tests: libexamplemodule, libtestauthorizer, libtestisolator, libtestresource_estimator, libtestallocator, libtestcontainer_logger, libtestmastercontender, libtestanonymous, libtesthook, libtestmasterdetector, libtestauthentication, libtesthttpauthenticator, libtestqos_controller. Diffs - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49863/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 4, 2016, 9:06 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description (updated) --- Builds shared libraries for dynamically loading them by various tests: libexamplemodule, libtestauthorizer, libtestisolator, libtestresource_estimator, libtestallocator, libtestcontainer_logger, libtestmastercontender, libtestanonymous, libtesthook, libtestmasterdetector, libtestauthentication, libtesthttpauthenticator, libtestqos_controller. Diffs - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49863/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 4, 2016, 9:02 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 https://issues.apache.org/jira/browse/MESOS-5792 Repository: mesos Description --- Added Test Modules that are loaded by mesos tests. Diffs (updated) - CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 src/examples/CMakeLists.txt PRE-CREATION src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION Diff: https://reviews.apache.org/r/49863/diff/ Testing --- cmake .. && make Thanks, Srinivas Brahmaroutu
Re: Review Request 50421: Added code to detect proper zookeeper home directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/ --- (Updated Aug. 4, 2016, 8:49 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Changes --- This path is required to handle the new installation structure with cmake builds. Earlier on auto tools zookeeper jar would be found at /3rdparty/zookeeper-3.4.8/zookeeper-3.4.8.jar and with cmake build system we have an additional directory structure added like /3rdparty/zookeeper-3.4.8/src/zookeeper-3.4.8/zookeeper-3.4.8.jar. This patch allows to set classpath from any of these locations by looking for both. Bugs: MESOS-5905 https://issues.apache.org/jira/browse/MESOS-5905 Repository: mesos Description (updated) --- Added code to detect proper zookeeper home directory. Diffs (updated) - src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 Diff: https://reviews.apache.org/r/50421/diff/ Testing --- cmake && make test with autotools to make sure the tests run. Thanks, Srinivas Brahmaroutu
Re: Review Request 50463: Added code to build libmesosjava shared library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/ --- (Updated Aug. 4, 2016, 8:42 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- Builds the shared library 'mesosjava' that allow interaction with Java components and share state information. Diffs - cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 32a8ae2320ee3dada8a19dd815eccb4710c18159 Diff: https://reviews.apache.org/r/50463/diff/ Testing --- cmake && make mesosjava Build /src/libmesosjava.* shared libraries. Thanks, Srinivas Brahmaroutu
Re: Review Request 50460: Added code to build libstate shared library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50460/ --- (Updated Aug. 4, 2016, 8:41 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- The patch build libstate a convenient library that allows state abstraction by providing necessary hooks to leveldb and zookeeper. Diffs (updated) - cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 src/state/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/50460/diff/ Testing --- cmake .. && make state build libstate dynamic library. Thanks, Srinivas Brahmaroutu
Re: Review Request 50459: Added code to generate JNI Header files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50459/ --- (Updated Aug. 4, 2016, 8:38 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description (updated) --- This patch generates C++ jni bindings, the header files that will allow calling Java classes from C++. Diffs (updated) - cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/java/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/50459/diff/ Testing --- cmake && make mesos-jni-header check to see if all the headers are generated. /include/java/jni/org_apache_mesos_Log.h /include/java/jni/org_apache_mesos_Log_Entry.h /include/java/jni/org_apache_mesos_Log_OperationFailedException.h /include/java/jni/org_apache_mesos_Log_Position.h /include/java/jni/org_apache_mesos_Log_Reader.h /include/java/jni/org_apache_mesos_Log_Writer.h /include/java/jni/org_apache_mesos_Log_WriterFailedException.h /include/java/jni/org_apache_mesos_MesosExecutorDriver.h /include/java/jni/org_apache_mesos_MesosSchedulerDriver.h /include/java/jni/org_apache_mesos_state_AbstractState.h /include/java/jni/org_apache_mesos_state_AbstractState_ExpungeFuture.h /include/java/jni/org_apache_mesos_state_AbstractState_FetchFuture.h /include/java/jni/org_apache_mesos_state_AbstractState_NamesFuture.h /include/java/jni/org_apache_mesos_state_AbstractState_StoreFuture.h /include/java/jni/org_apache_mesos_state_LevelDBState.h /include/java/jni/org_apache_mesos_state_LogState.h /include/java/jni/org_apache_mesos_state_Variable.h /include/java/jni/org_apache_mesos_state_ZooKeeperState.h Thanks, Srinivas Brahmaroutu
Re: Review Request 50458: Added code to build mesos-java.jar.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50458/ --- (Updated Aug. 4, 2016, 8:36 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Changes --- The patch builds 'mesos-java.jar; that contains the compiled java sources under mesos source tree along with generated protobuf java sources from 'mesos-java-protos' target. Bugs: MESOS-5902 https://issues.apache.org/jira/browse/MESOS-5902 Repository: mesos Description --- Added code to build mesos-java.jar. Diffs (updated) - cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 src/java/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/50458/diff/ Testing --- cmake && make mesos-java Check to see if /src/java/mesos-java.jar Thanks, Srinivas Brahmaroutu
