Re: Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95881 --- Patch looks great! Reviews applied: [37493] All tests passed. - Mesos ReviewBot On Aug. 19, 2015, 12:33 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 19, 2015, 12:33 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, Till Toenshoff, and Timothy Chen. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac db0632d60a6d82ab396931b4d913f34b625a45a7 Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95901 --- Ship it! Ship It! - Timothy Chen On Aug. 19, 2015, 12:33 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 19, 2015, 12:33 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, Till Toenshoff, and Timothy Chen. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac db0632d60a6d82ab396931b4d913f34b625a45a7 Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 18, 2015, 11:48 p.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, Till Toenshoff, and Timothy Chen. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs (updated) - configure.ac db0632d60a6d82ab396931b4d913f34b625a45a7 Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 19, 2015, 12:33 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, Till Toenshoff, and Timothy Chen. Changes --- Reordered the changes to configure.ac Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs (updated) - configure.ac db0632d60a6d82ab396931b4d913f34b625a45a7 Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95596 --- Patch looks great! Reviews applied: [37493] All tests passed. - Mesos ReviewBot On Aug. 17, 2015, 6:49 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 17, 2015, 6:49 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, Till Toenshoff, and Timothy Chen. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 17, 2015, 6:47 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs (updated) - configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37493: Detect gflags when present and link when building Python module
On Aug. 16, 2015, 3:42 a.m., Timothy Chen wrote: configure.ac, line 561 https://reviews.apache.org/r/37493/diff/1/?file=1040648#file1040648line561 I think we can basically follow the same syntax we've calling AC_CHECK_LIB in the other places [AC_CHECK_LIB([leveldb], [leveldb_open], [found_leveldb=yes])]) Otherwise this looks good to me. Till Toenshoff wrote: +1 Thanks, comments addressed, and I changed the conditional because I think it didn't quite make sense before. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95534 --- On Aug. 15, 2015, 12:28 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 15, 2015, 12:28 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37493: Detect gflags when present and link when building Python module
On Aug. 16, 2015, 3:42 a.m., Timothy Chen wrote: configure.ac, line 561 https://reviews.apache.org/r/37493/diff/1/?file=1040648#file1040648line561 I think we can basically follow the same syntax we've calling AC_CHECK_LIB in the other places [AC_CHECK_LIB([leveldb], [leveldb_open], [found_leveldb=yes])]) Otherwise this looks good to me. +1 - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95534 --- On Aug. 15, 2015, 12:28 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 15, 2015, 12:28 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95534 --- configure.ac (line 561) https://reviews.apache.org/r/37493/#comment150560 I think we can basically follow the same syntax we've calling AC_CHECK_LIB in the other places [AC_CHECK_LIB([leveldb], [leveldb_open], [found_leveldb=yes])]) Otherwise this looks good to me. - Timothy Chen On Aug. 15, 2015, 12:28 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 15, 2015, 12:28 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95504 --- Patch looks great! Reviews applied: [37493] All tests passed. - Mesos ReviewBot On Aug. 15, 2015, 12:28 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 15, 2015, 12:28 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
