Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

2015-09-26 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38755/
---

(Updated Sept. 26, 2015, 10:05 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Move compiler configuration logic to its own file.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake PRE-CREATION 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/38755/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

2015-09-26 Thread Alex Clemmer 


> On Sept. 25, 2015, 7:07 a.m., Alex Clemmer wrote:
> > cmake/CompilationConfigure.cmake, line 97
> > 
> >
> > Oh yeah. I forgot to remove these. I don't actually know what 
> > `pkglibexecdir` does in autoconf; I'll look it up tomorrow if no one 
> > mentions it before I get back to these reviews. :)

Please pay close attention to this. I only _think_ I got it right.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38755/#review100554
---


On Sept. 26, 2015, 10:05 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38755/
> ---
> 
> (Updated Sept. 26, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Move compiler configuration logic to its own file.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake PRE-CREATION 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38755/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

2015-09-25 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38755/#review100637
---



cmake/CompilationConfigure.cmake (line 84)


NOLINT?


- Artem Harutyunyan


On Sept. 24, 2015, 11:19 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38755/
> ---
> 
> (Updated Sept. 24, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Move compiler configuration logic to its own file.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake PRE-CREATION 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38755/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

2015-09-25 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38755/#review100618
---

Ship it!



cmake/CompilationConfigure.cmake (line 46)


Typo: earliser


- Joseph Wu


On Sept. 24, 2015, 11:19 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38755/
> ---
> 
> (Updated Sept. 24, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Move compiler configuration logic to its own file.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake PRE-CREATION 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38755/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

2015-09-25 Thread Artem Harutyunyan 


> On Sept. 25, 2015, 11:05 a.m., Artem Harutyunyan wrote:
> >

LGTM.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38755/#review100637
---


On Sept. 24, 2015, 11:19 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38755/
> ---
> 
> (Updated Sept. 24, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Move compiler configuration logic to its own file.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake PRE-CREATION 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38755/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

2015-09-25 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38755/
---

(Updated Sept. 25, 2015, 10:13 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Move compiler configuration logic to its own file.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake PRE-CREATION 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/38755/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

2015-09-25 Thread Alex Clemmer 


> On Sept. 25, 2015, 6:05 p.m., Artem Harutyunyan wrote:
> > cmake/CompilationConfigure.cmake, line 84
> > 
> >
> > NOLINT?

Doesn't complain on my box, I don't think it's necessary.

Also, this _does_ run when you commit normally, right? (_i.e._ not during a 
rebase)


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38755/#review100637
---


On Sept. 25, 2015, 10:13 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38755/
> ---
> 
> (Updated Sept. 25, 2015, 10:13 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Move compiler configuration logic to its own file.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake PRE-CREATION 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38755/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

2015-09-25 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38755/#review100554
---



cmake/CompilationConfigure.cmake (line 97)


Oh yeah. I forgot to remove these. I don't actually know what 
`pkglibexecdir` does in autoconf; I'll look it up tomorrow if no one mentions 
it before I get back to these reviews. :)


- Alex Clemmer


On Sept. 25, 2015, 6:19 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38755/
> ---
> 
> (Updated Sept. 25, 2015, 6:19 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Move compiler configuration logic to its own file.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake PRE-CREATION 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38755/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>