Re: Review Request 39204: Windows: Added support for `stout/os/read.hpp`.

2015-10-17 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39204/#review103035
---

Ship it!


- Joris Van Remoortere


On Oct. 13, 2015, 6:29 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39204/
> ---
> 
> (Updated Oct. 13, 2015, 6:29 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3641
> https://issues.apache.org/jira/browse/MESOS-3641
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `stout/os/read.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp 
> ffacce164980157ea225a4e64e33b8bf8ec38ab7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 
> d5698a5b44fd6083ac3119d6825d31f46efb2f38 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp 
> 09d63329f16f13d408742f9fc8f596d76c4d70c9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 50e35f43d87c69a83a9e7d039d1881404ea8be38 
> 
> Diff: https://reviews.apache.org/r/39204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39204: Windows: Added support for `stout/os/read.hpp`.

2015-10-13 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39204/
---

(Updated Oct. 13, 2015, 6:29 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3641
https://issues.apache.org/jira/browse/MESOS-3641


Repository: mesos


Description
---

Windows: Added support for `stout/os/read.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp 
ffacce164980157ea225a4e64e33b8bf8ec38ab7 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 
d5698a5b44fd6083ac3119d6825d31f46efb2f38 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp 
09d63329f16f13d408742f9fc8f596d76c4d70c9 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
50e35f43d87c69a83a9e7d039d1881404ea8be38 

Diff: https://reviews.apache.org/r/39204/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39204: Windows: Added support for `stout/os/read.hpp`.

2015-10-12 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39204/#review102319
---

Ship it!


Looks good.  (Checked that logical content of `read.hpp` is identical to 
`posix/read.hpp`.)


3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp (lines 136 - 138)


Nit: 2 newlines too many


- Joseph Wu


On Oct. 10, 2015, 1:12 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39204/
> ---
> 
> (Updated Oct. 10, 2015, 1:12 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3641
> https://issues.apache.org/jira/browse/MESOS-3641
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `stout/os/read.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp 
> ffacce164980157ea225a4e64e33b8bf8ec38ab7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 
> d5698a5b44fd6083ac3119d6825d31f46efb2f38 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp 
> 09d63329f16f13d408742f9fc8f596d76c4d70c9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 50e35f43d87c69a83a9e7d039d1881404ea8be38 
> 
> Diff: https://reviews.apache.org/r/39204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39204: Windows: Added support for `stout/os/read.hpp`.

2015-10-10 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39204/
---

(Updated Oct. 10, 2015, 8:12 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Changes
---

This update will make sure we're using the correct stdlib aliases for `read` on 
Windows.


Bugs: MESOS-3641
https://issues.apache.org/jira/browse/MESOS-3641


Repository: mesos


Description
---

Windows: Added support for `stout/os/read.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp 
ffacce164980157ea225a4e64e33b8bf8ec38ab7 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 
d5698a5b44fd6083ac3119d6825d31f46efb2f38 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp 
09d63329f16f13d408742f9fc8f596d76c4d70c9 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
50e35f43d87c69a83a9e7d039d1881404ea8be38 

Diff: https://reviews.apache.org/r/39204/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39204: Windows: Added support for `stout/os/read.hpp`.

2015-10-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39204/#review102164
---


Patch looks great!

Reviews applied: [39019, 39076, 39091, 39092, 39093, 39096, 39097, 39180, 
39181, 39201, 39182, 39202, 39203, 39204]

All tests passed.

- Mesos ReviewBot


On Oct. 10, 2015, 9:58 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39204/
> ---
> 
> (Updated Oct. 10, 2015, 9:58 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3641
> https://issues.apache.org/jira/browse/MESOS-3641
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `stout/os/read.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp 
> ffacce164980157ea225a4e64e33b8bf8ec38ab7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 
> d5698a5b44fd6083ac3119d6825d31f46efb2f38 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp 
> 09d63329f16f13d408742f9fc8f596d76c4d70c9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 50e35f43d87c69a83a9e7d039d1881404ea8be38 
> 
> Diff: https://reviews.apache.org/r/39204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>