Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-25 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107982
---


Patch looks great!

Reviews applied: [39320]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107901
---

Ship it!


Ship It!

- Guangya Liu


On 十一月 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated 十一月 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107800
---

Ship it!


Ship It!

- Neil Conway


On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Neil Conway 


> On Nov. 24, 2015, 3:58 p.m., Neil Conway wrote:
> > src/tests/fault_tolerance_tests.cpp, line 720
> > 
> >
> > I'd remove this comment -- various other places use the same pattern. 
> > I'd also remove the newline after CreateMasterFlags(), to match the other 
> > places we use this pattern.
> 
> Alexander Rukletsov wrote:
> I think we are not consistent, e.g. see 
> https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1293

Sure.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107793
---


On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Alexander Rukletsov 


> On Nov. 24, 2015, 3:58 p.m., Neil Conway wrote:
> > src/tests/fault_tolerance_tests.cpp, line 720
> > 
> >
> > I'd remove this comment -- various other places use the same pattern. 
> > I'd also remove the newline after CreateMasterFlags(), to match the other 
> > places we use this pattern.

I think we are not consistent, e.g. see 
https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1293


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107793
---


On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107748
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 23, 2015, 9:52 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 23, 2015, 9:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Alexander Rukletsov 


> On Nov. 24, 2015, 1:52 p.m., Benjamin Bannier wrote:
> > src/tests/fault_tolerance_tests.cpp, line 778
> > 
> >
> > You should just use `master::Flags().allocation_interval` to simplify 
> > this.

Do you think it will be cleaner? I have following thoughts:
- it extracts the default value from the `master::Flags` structs instead of 
being in sync with the test environment created by `CreateMasterFlags()`;
- we create a complete `master::Flags` object in order to use one flag.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107780
---


On Nov. 24, 2015, 1:13 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 1:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
>   src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
>   src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Alexander Rukletsov 


> On Nov. 23, 2015, 6:45 p.m., Neil Conway wrote:
> > An alternative would be to pause and advance the clock by the 
> > allocation_interval. Do you think that would be worth doing instead?

That's correct. I was not sure what approach is easier to understand. After you 
input I have checked the "testing-patterns.md" doc and it looks like clock 
magic is well documented and may therefore be a preferred solution. Will update 
the patch shortly.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107625
---


On Nov. 23, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 23, 2015, 5:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107780
---



src/tests/fault_tolerance_tests.cpp (line 778)


You should just use `master::Flags().allocation_interval` to simplify this.



src/tests/mesos.hpp (line 245)


Not needed.



src/tests/mesos.cpp (line 129)


Not needed.


- Benjamin Bannier


On Nov. 24, 2015, 1:13 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 1:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
>   src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
>   src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/
---

(Updated Nov. 24, 2015, 1:13 p.m.)


Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
Till Toenshoff.


Changes
---

Alternative approach to speeding up the test.


Bugs: MESOS-3732
https://issues.apache.org/jira/browse/MESOS-3732


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/fault_tolerance_tests.cpp 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
  src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
  src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10 

Diff: https://reviews.apache.org/r/39320/diff/


Testing
---

make check

The run time for the `FaultToleranceTest.FrameworkReregister` test has reduced 
from more than `1s` to less than `100ms`.
Before:
```
[ RUN  ] FaultToleranceTest.FrameworkReregister
[   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
```
After:
```
[ RUN  ] FaultToleranceTest.FrameworkReregister
[   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
```


Thanks,

Alexander Rukletsov

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Alexander Rukletsov 


> On Nov. 23, 2015, 6:45 p.m., Neil Conway wrote:
> > An alternative would be to pause and advance the clock by the 
> > allocation_interval. Do you think that would be worth doing instead?
> 
> Alexander Rukletsov wrote:
> That's correct. I was not sure what approach is easier to understand. 
> After you input I have checked the "testing-patterns.md" doc and it looks 
> like clock magic is well documented and may therefore be a preferred 
> solution. Will update the patch shortly.

Please check the updated version, slightly more intrusive.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107625
---


On Nov. 24, 2015, 1:13 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 1:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
>   src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
>   src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107793
---



src/tests/fault_tolerance_tests.cpp (line 720)


I'd remove this comment -- various other places use the same pattern. I'd 
also remove the newline after CreateMasterFlags(), to match the other places we 
use this pattern.


- Neil Conway


On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107794
---

Ship it!


Ship It!

- Benjamin Bannier


On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107664
---


Patch looks great!

Reviews applied: [39320]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 23, 2015, 5:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-23 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107625
---


An alternative would be to pause and advance the clock by the 
allocation_interval. Do you think that would be worth doing instead?

- Neil Conway


On Nov. 23, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 23, 2015, 5:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-10-16 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/
---

(Updated Oct. 16, 2015, 11:44 a.m.)


Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till Toenshoff.


Changes
---

Updated testing section.


Bugs: MESOS-3732
https://issues.apache.org/jira/browse/MESOS-3732


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/fault_tolerance_tests.cpp c97bc4691f9bac4a8677e6d2247be96ee9674b57 

Diff: https://reviews.apache.org/r/39320/diff/


Testing (updated)
---

make check

The run time for the `FaultToleranceTest.FrameworkReregister` test has reduced 
from more than `1s` to less than `100ms`.
Before:
```
[ RUN  ] FaultToleranceTest.FrameworkReregister
[   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
```
After:
```
[ RUN  ] FaultToleranceTest.FrameworkReregister
[   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
```


Thanks,

Alexander Rukletsov

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-10-16 Thread Alexander Rukletsov 


> On Oct. 15, 2015, 11:37 a.m., Benjamin Bannier wrote:
> > src/tests/fault_tolerance_tests.cpp, line 721
> > 
> >
> > I don't think hardcoding specific timeouts here is optimal ... there's 
> > nothing here that prevents this from not failing on slow/high load 
> > machines. Better would be to e.g. `wait` for some observable side effect 
> > before continuing; at least add a `TODO` (or better ticket) for that.

The test won't fail on slow machines, it will just take longer. However, I 
agree we a nicer solution is to intercept the allocation event and `advance()` 
the clock. As I have mentioned in the ticket 
(https://issues.apache.org/jira/browse/MESOS-3732), a better fix can be done by 
a new contributor.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review102774
---


On Oct. 16, 2015, 11:44 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Oct. 16, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> c97bc4691f9bac4a8677e6d2247be96ee9674b57 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-10-15 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review102774
---



src/tests/fault_tolerance_tests.cpp (line 721)


I don't think hardcoding specific timeouts here is optimal ... there's 
nothing here that prevents this from not failing on slow/high load machines. 
Better would be to e.g. `wait` for some observable side effect before 
continuing; at least add a `TODO` (or better ticket) for that.


- Benjamin Bannier


On Oct. 14, 2015, 4:29 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Oct. 14, 2015, 4:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> c97bc4691f9bac4a8677e6d2247be96ee9674b57 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-10-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review102670
---


Bad patch!

Reviews applied: [39320]

Failed command: ./support/apply-review.sh -n -r 39320

Error:
 2015-10-14 17:52:55 URL:https://reviews.apache.org/r/39320/diff/raw/ [751/751] 
-> "39320.patch" [1]
error: patch failed: src/tests/fault_tolerance_tests.cpp:716
error: src/tests/fault_tolerance_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 14, 2015, 4:29 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Oct. 14, 2015, 4:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> c97bc4691f9bac4a8677e6d2247be96ee9674b57 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-10-14 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review102647
---



src/tests/fault_tolerance_tests.cpp (line 719)


It may be obvious to many how this speeds up the test, but it would be nice 
to expain the gist in about 1 sentence for everybody else, especially newcomers 
who read such code for the first time.


- Bernd Mathiske


On Oct. 14, 2015, 9:29 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Oct. 14, 2015, 9:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> c97bc4691f9bac4a8677e6d2247be96ee9674b57 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>