Re: Review Request 40551: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-12-03 Thread Alexander Rukletsov 


> On Dec. 3, 2015, 1:40 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1026
> > 
> >
> > roleConsumedResources = roleConsumedResources.nonRevocable();

As you may know, `.nonRevocable()` filter landed rather recently, far later 
than this patch has been proposed. Right after, [a follow-up 
patch](https://reviews.apache.org/r/40821/) has been published for review and 
is part of the current chain. Applying `.nonRevocable()` filter required a more 
careful approach, otherwise we may blindly apply it to resources that do not 
contain revocable resources by default. Please review [that 
patch](https://reviews.apache.org/r/40821/) instead. Same for similar comments 
below.


> On Dec. 3, 2015, 1:40 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1054
> > 
> >
> > user nonRevocable()?

See above.


> On Dec. 3, 2015, 1:40 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1116
> > 
> >
> > use nonRevocable() directly?

See above.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40551/#review108817
---


On Nov. 30, 2015, 3:24 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40551/
> ---
> 
> (Updated Nov. 30, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota is satisfied in a separate loop over agents. Running total is 
> maintained as an exit criterion for the WDRF allocation stage.
> 
> Precursory version: https://reviews.apache.org/r/39401/
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 31ed62efb5b1a2edb567f43d37559c5914e0665e 
> 
> Diff: https://reviews.apache.org/r/40551/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40551: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-12-03 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40551/#review108817
---



src/master/allocator/mesos/hierarchical.cpp (line 1026)


roleConsumedResources = roleConsumedResources.nonRevocable();



src/master/allocator/mesos/hierarchical.cpp (line 1054)


user nonRevocable()?



src/master/allocator/mesos/hierarchical.cpp (line 1092)


I searched the mesos code and found that there is no reference for WDRF, 
shall we clarify this as weight DRF for one time?



src/master/allocator/mesos/hierarchical.cpp (line 1116)


use nonRevocable() directly?


- Guangya Liu


On 十一月 30, 2015, 3:24 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40551/
> ---
> 
> (Updated 十一月 30, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota is satisfied in a separate loop over agents. Running total is 
> maintained as an exit criterion for the WDRF allocation stage.
> 
> Precursory version: https://reviews.apache.org/r/39401/
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 31ed62efb5b1a2edb567f43d37559c5914e0665e 
> 
> Diff: https://reviews.apache.org/r/40551/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40551: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-12-03 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40551/#review108846
---

Ship it!


Fixed in-line.


src/master/allocator/mesos/hierarchical.cpp (line 1026)


new line.



src/master/allocator/mesos/hierarchical.cpp (lines 1100 - 1101)


Let's fold these together.



src/master/allocator/mesos/hierarchical.cpp (line 1118)


`const`?



src/master/allocator/mesos/hierarchical.cpp (line 1134)


Let's clarify that, in this case, we continue rather than "stop".



src/master/allocator/mesos/hierarchical.cpp (line 1137)


`are allocated or accounted for`


- Joris Van Remoortere


On Nov. 30, 2015, 3:24 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40551/
> ---
> 
> (Updated Nov. 30, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota is satisfied in a separate loop over agents. Running total is 
> maintained as an exit criterion for the WDRF allocation stage.
> 
> Precursory version: https://reviews.apache.org/r/39401/
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 31ed62efb5b1a2edb567f43d37559c5914e0665e 
> 
> Diff: https://reviews.apache.org/r/40551/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40551: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-30 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40551/
---

(Updated Nov. 30, 2015, 3:24 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Qian Zhang.


Changes
---

Minor corrections.


Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718


Repository: mesos


Description
---

Quota is satisfied in a separate loop over agents. Running total is maintained 
as an exit criterion for the WDRF allocation stage.

Precursory version: https://reviews.apache.org/r/39401/


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
31ed62efb5b1a2edb567f43d37559c5914e0665e 

Diff: https://reviews.apache.org/r/40551/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40551: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-25 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40551/
---

(Updated Nov. 25, 2015, 11:39 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Qian Zhang.


Changes
---

+mesos, +bernd-mesos, +kaysoky


Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718


Repository: mesos


Description
---

Quota is satisfied in a separate loop over agents. Running total is maintained 
as an exit criterion for the WDRF allocation stage.

Precursory version: https://reviews.apache.org/r/39401/


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
2765526047767cbd19d13c11ecfa6e90c505b3a7 

Diff: https://reviews.apache.org/r/40551/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov