Re: Review Request 41783: Implement the rotating container logger module.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/#review115318
---



src/slave/container_loggers/rotate.cpp (lines 128 - 131)


Future loop()
{
  return io::read(STDIN_FILENO, buffer, length)
.then([&](size_t readSize) -> Future {
  // ... comment here ...
  if (readSize <= 0) {
  EXIT(EXIT_SUCCESS);
  }
  Try result = write(buffer, size);
  if (result.isError()) {
return Error();
  }
  return dispatch(self(), ::loop);
}

Try write(buffer, size)
{
  if file is closed: if (leading.isNone()) {
// open the leading file
// deal with errors
  }
  
  if (need_to_rotate) {
rotate();
return write(buffer, size);
  }
  
  ... do the actual write ...
  return Nothing();
}


- Benjamin Hindman


On Jan. 16, 2016, 12:54 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41783/
> ---
> 
> (Updated Jan. 16, 2016, 12:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implement the rotating container logger module.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/rotate.hpp PRE-CREATION 
>   src/slave/container_loggers/rotate.cpp PRE-CREATION 
>   src/slave/container_loggers/rotating.hpp PRE-CREATION 
>   src/slave/container_loggers/rotating.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41783/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41783: Implement the rotating container logger module.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/
---

(Updated Jan. 15, 2016, 4:54 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

* Rework module implementation to use `logrotate` instead of custom logic.  
* * Removed the "number of files" flag in favor of a general "logrotate 
options" flag.
* * Gouged out the logic in `rotate.cpp` and replaced it with an `os::shell`.


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description
---

Implement the rotating container logger module.


Diffs (updated)
-

  src/slave/container_loggers/rotate.hpp PRE-CREATION 
  src/slave/container_loggers/rotate.cpp PRE-CREATION 
  src/slave/container_loggers/rotating.hpp PRE-CREATION 
  src/slave/container_loggers/rotating.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41783/diff/


Testing
---

make check


Thanks,

Joseph Wu

Re: Review Request 41783: Implement the rotating container logger module.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/
---

(Updated Jan. 14, 2016, 11:49 a.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Tweak some spacing.


Summary (updated)
-

Implement the rotating container logger module.


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description (updated)
---

Implement the rotating container logger module.


Diffs (updated)
-

  src/slave/container_loggers/rotate.hpp PRE-CREATION 
  src/slave/container_loggers/rotate.cpp PRE-CREATION 
  src/slave/container_loggers/rotating.hpp PRE-CREATION 
  src/slave/container_loggers/rotating.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41783/diff/


Testing
---

make check


Thanks,

Joseph Wu