-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 4:54 p.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
* Rework module implementation to use `logrotate` instead of custom logic.
* * Removed the "number of files" flag in favor of a general "logrotate
options" flag.
* * Gouged out the logic in `rotate.cpp` and replaced it with an `os::shell`.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description
-------
Implement the rotating container logger module.
Diffs (updated)
-----
src/slave/container_loggers/rotate.hpp PRE-CREATION
src/slave/container_loggers/rotate.cpp PRE-CREATION
src/slave/container_loggers/rotating.hpp PRE-CREATION
src/slave/container_loggers/rotating.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41783/diff/
Testing
-------
make check
Thanks,
Joseph Wu
