Re: Review Request 42252: Enabled master totalResources include allocation slack.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42252/#review115401
---


Patch looks great!

Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 42386, 40632, 
41847, 41791, 42113, 42194, 41848, 42491, 42547, 42252]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 20, 2016, 7:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42252/
> ---
> 
> (Updated Jan. 20, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4321
> https://issues.apache.org/jira/browse/MESOS-4321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After master call updateSlave, the totalResources do not include
> allocation resources, this will cause some problem when end user
> using /state endpoint to check resources status.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
> 
> Diff: https://reviews.apache.org/r/42252/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42252: Enabled master totalResources include allocation slack.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42252/#review115292
---


Considering that https://reviews.apache.org/r/41847/ has the same change, it 
may be appropriate to add a `Resources::nonUsageSlack()` helper.

- Joseph Wu


On Jan. 13, 2016, 6:37 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42252/
> ---
> 
> (Updated Jan. 13, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4321
> https://issues.apache.org/jira/browse/MESOS-4321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After master call updateSlave, the totalResources do not include
> allocation resources, this will cause some problem when end user
> using /state endpoint to check resources status.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 
> 
> Diff: https://reviews.apache.org/r/42252/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42252: Enabled master totalResources include allocation slack.

[Guangya Liu]

> On 一月 20, 2016, 12:16 a.m., Joseph Wu wrote:
> > Considering that https://reviews.apache.org/r/41847/ has the same change, 
> > it may be appropriate to add a `Resources::nonUsageSlack()` helper.

Added a helper here https://reviews.apache.org/r/42547/


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42252/#review115292
---


On 一月 13, 2016, 2:37 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42252/
> ---
> 
> (Updated 一月 13, 2016, 2:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4321
> https://issues.apache.org/jira/browse/MESOS-4321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After master call updateSlave, the totalResources do not include
> allocation resources, this will cause some problem when end user
> using /state endpoint to check resources status.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 
> 
> Diff: https://reviews.apache.org/r/42252/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42252: Enabled master totalResources include allocation slack.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42252/#review115341
---


Patch looks great!

Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 42386, 40632, 
41847, 41791, 42113, 42194, 41848, 42252]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 13, 2016, 2:37 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42252/
> ---
> 
> (Updated Jan. 13, 2016, 2:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4321
> https://issues.apache.org/jira/browse/MESOS-4321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After master call updateSlave, the totalResources do not include
> allocation resources, this will cause some problem when end user
> using /state endpoint to check resources status.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 
> 
> Diff: https://reviews.apache.org/r/42252/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42252: Enabled master totalResources include allocation slack.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42252/#review115339
---



src/master/master.cpp (line 4659)


It checked Optimistic Offer Phase 1 is enabled in 
https://reviews.apache.org/r/41847/. But I think it's not necessary. Checking 
the flag at `addSlave`, `updateAllocation` and `updateAvailable` in enough. In 
other place, we just need to handle the case that `allocationSlack` is empty; 
this case is also true when flag is enable by no `statless.reserved` resources.


Update test on `allocationSlack` in `totalResource`.

- Klaus Ma


On Jan. 13, 2016, 10:37 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42252/
> ---
> 
> (Updated Jan. 13, 2016, 10:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4321
> https://issues.apache.org/jira/browse/MESOS-4321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After master call updateSlave, the totalResources do not include
> allocation resources, this will cause some problem when end user
> using /state endpoint to check resources status.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 
> 
> Diff: https://reviews.apache.org/r/42252/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42252: Enabled master totalResources include allocation slack.

[Guangya Liu]

> On 一月 20, 2016, 3:43 a.m., Klaus Ma wrote:
> > src/master/master.cpp, line 4659
> > 
> >
> > It checked Optimistic Offer Phase 1 is enabled in 
> > https://reviews.apache.org/r/41847/. But I think it's not necessary. 
> > Checking the flag at `addSlave`, `updateAllocation` and `updateAvailable` 
> > in enough. In other place, we just need to handle the case that 
> > `allocationSlack` is empty; this case is also true when flag is enable by 
> > no `statless.reserved` resources.

You can add your comments to https://reviews.apache.org/r/40632/


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42252/#review115339
---


On 一月 13, 2016, 2:37 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42252/
> ---
> 
> (Updated 一月 13, 2016, 2:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4321
> https://issues.apache.org/jira/browse/MESOS-4321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After master call updateSlave, the totalResources do not include
> allocation resources, this will cause some problem when end user
> using /state endpoint to check resources status.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 
> 
> Diff: https://reviews.apache.org/r/42252/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42252: Enabled master totalResources include allocation slack.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42252/
---

(Updated 一月 20, 2016, 7:29 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4321
https://issues.apache.org/jira/browse/MESOS-4321


Repository: mesos


Description
---

After master call updateSlave, the totalResources do not include
allocation resources, this will cause some problem when end user
using /state endpoint to check resources status.


Diffs (updated)
-

  src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 

Diff: https://reviews.apache.org/r/42252/diff/


Testing
---

make
make check


Thanks,

Guangya Liu