Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127684
---



Bad patch!

Reviews applied: [45800, 45799, 45440, 45067]

Failed command: ./support/apply-review.sh -n -r 45067

Error:
2016-04-07 22:44:16 URL:https://reviews.apache.org/r/45067/diff/raw/ 
[13287/13287] -> "45067.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12394/console

- Mesos ReviewBot


On April 7, 2016, 9:50 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 7, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/
---

(Updated April 7, 2016, 9:50 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

See summary. Also removed the AuthN code. Once, the library
supports AuthN we can bring it back.


Diffs (updated)
-

  src/examples/long_lived_framework.cpp 
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45800/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127670
---



Bad patch!

Reviews applied: [45800, 45799, 45440, 45067]

Failed command: ./support/apply-review.sh -n -r 45067

Error:
2016-04-07 21:45:04 URL:https://reviews.apache.org/r/45067/diff/raw/ 
[13287/13287] -> "45067.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12392/console

- Mesos ReviewBot


On April 7, 2016, 9:25 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 7, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127665
---


Fix it, then Ship it!





src/examples/long_lived_framework.cpp (line 594)


// Add a TODO here to add support for AuthN.


- Vinod Kone


On April 7, 2016, 9:25 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 7, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/
---

(Updated April 7, 2016, 9:24 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

See summary. Also removed the AuthN code. Once, the library
supports AuthN we can bring it back.


Diffs (updated)
-

  src/examples/long_lived_framework.cpp 
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45800/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127501
---



Bad patch!

Reviews applied: [45800, 45799, 45440, 45067]

Failed command: ./support/apply-review.sh -n -r 45067

Error:
2016-04-06 23:10:16 URL:https://reviews.apache.org/r/45067/diff/raw/ 
[13287/13287] -> "45067.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12365/console

- Mesos ReviewBot


On April 6, 2016, 5:45 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 6, 2016, 5:45 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Joseph Wu 


> On April 6, 2016, 10:10 a.m., Joseph Wu wrote:
> > src/examples/long_lived_framework.cpp, lines 217-221
> > 
> >
> > Would be nice to log something here.
> 
> Anand Mazumdar wrote:
> Logging an `ERROR` would be useful. I had copied over from the old 
> interface that did not use to log anything. Does this sound reasonable to you?

Sounds good.  (Logging the `RESCIND` event might also be useful.)


> On April 6, 2016, 10:10 a.m., Joseph Wu wrote:
> > src/examples/long_lived_framework.cpp, line 593
> > 
> >
> > Does the HTTP scheduler driver initialize glog (like the old scheduler 
> > driver does)?
> 
> Anand Mazumdar wrote:
> It doesn't. We should ideally initialize logging inside the framework 
> itself.

The only consequence of not initializing glog is that glog will print a warning 
the first time we hit a `LOG(...) << ...` line.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127365
---


On April 6, 2016, 10:45 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 6, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Anand Mazumdar 


> On April 6, 2016, 5:10 p.m., Joseph Wu wrote:
> > src/examples/long_lived_framework.cpp, line 593
> > 
> >
> > Does the HTTP scheduler driver initialize glog (like the old scheduler 
> > driver does)?

It doesn't. We should ideally initialize logging inside the framework itself.


> On April 6, 2016, 5:10 p.m., Joseph Wu wrote:
> > src/examples/long_lived_framework.cpp, lines 217-221
> > 
> >
> > Would be nice to log something here.

Logging an `ERROR` would be useful. I had copied over from the old interface 
that did not use to log anything. Does this sound reasonable to you?


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127365
---


On April 6, 2016, 5:45 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 6, 2016, 5:45 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/
---

(Updated April 6, 2016, 5:45 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Joseph


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

See summary. Also removed the AuthN code. Once, the library
supports AuthN we can bring it back.


Diffs (updated)
-

  src/examples/long_lived_framework.cpp 
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45800/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127365
---



LGTM.


src/examples/long_lived_framework.cpp (lines 216 - 220)


Would be nice to log something here.



src/examples/long_lived_framework.cpp (line 590)


Does the HTTP scheduler driver initialize glog (like the old scheduler 
driver does)?


- Joseph Wu


On April 5, 2016, 8:43 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 5, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127286
---



Patch looks great!

Reviews applied: [45067, 45440, 45799, 45800]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 6, 2016, 3:43 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 6, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>