Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

2016-10-12 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/
---

(Updated Oct. 12, 2016, 2:25 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
and Vinod Kone.


Changes
---

Rebase on the large change in the prior-prior review.


Bugs: MESOS-3910
https://issues.apache.org/jira/browse/MESOS-3910


Repository: mesos


Description
---

Moves the destructor code in `HttpProxy` into the `Process::finalize`
function.  And changes the `HttpProxy`s termination logic to 
terminate via `UPID` which guards against double-termination.

Removes some unused initialization code, too.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp f1d746c52cfe659f5cd7da4b7a6424ff585619a3 

Diff: https://reviews.apache.org/r/50621/diff/


Testing
---

make

(More testing done later in the chain)


Thanks,

Joseph Wu

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

2016-09-21 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/#review149908
---


Ship it!




Ship It!

- Greg Mann


On Aug. 12, 2016, 10:02 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50621/
> ---
> 
> (Updated Aug. 12, 2016, 10:02 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves the destructor code in `HttpProxy` into the `Process::finalize`
> function.  And changes the `HttpProxy`s termination logic to 
> terminate via `UPID` which guards against double-termination.
> 
> Removes some unused initialization code, too.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 629f1644bc0a263972ec9efc41890c33f9406a34 
> 
> Diff: https://reviews.apache.org/r/50621/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> (More testing done later in the chain)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

2016-08-13 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/#review145717
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 12, 2016, 10:02 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50621/
> ---
> 
> (Updated Aug. 12, 2016, 10:02 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves the destructor code in `HttpProxy` into the `Process::finalize`
> function.  And changes the `HttpProxy`s termination logic to 
> terminate via `UPID` which guards against double-termination.
> 
> Removes some unused initialization code, too.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 629f1644bc0a263972ec9efc41890c33f9406a34 
> 
> Diff: https://reviews.apache.org/r/50621/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> (More testing done later in the chain)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

2016-08-12 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/
---

(Updated Aug. 12, 2016, 3:02 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
and Vinod Kone.


Changes
---

Change dependency.


Bugs: MESOS-3910
https://issues.apache.org/jira/browse/MESOS-3910


Repository: mesos


Description
---

Moves the destructor code in `HttpProxy` into the `Process::finalize`
function.  And changes the `HttpProxy`s termination logic to 
terminate via `UPID` which guards against double-termination.

Removes some unused initialization code, too.


Diffs
-

  3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 

Diff: https://reviews.apache.org/r/50621/diff/


Testing
---

make

(More testing done later in the chain)


Thanks,

Joseph Wu

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

2016-08-08 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/
---

(Updated Aug. 8, 2016, 6:07 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
and Vinod Kone.


Changes
---

Rebase and remove initialization code (unused).


Bugs: MESOS-3910
https://issues.apache.org/jira/browse/MESOS-3910


Repository: mesos


Description (updated)
---

Moves the destructor code in `HttpProxy` into the `Process::finalize`
function.  And changes the `HttpProxy`s termination logic to 
terminate via `UPID` which guards against double-termination.

Removes some unused initialization code, too.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 

Diff: https://reviews.apache.org/r/50621/diff/


Testing (updated)
---

make

(More testing done later in the chain)


Thanks,

Joseph Wu

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

2016-08-04 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/#review144856
---




3rdparty/libprocess/src/process.cpp (line 1201)


I don't think this `Sequence` is actually used any more - the code which 
used it seems to have been removed with this commit: 
https://github.com/apache/mesos/commit/19dfc49fe
but we failed to remove `authentications` from `HttpProxy` at that time.


- Greg Mann


On July 29, 2016, 11:54 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50621/
> ---
> 
> (Updated July 29, 2016, 11:54 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves the destructor code in `HttpProxy` into the `Process::finalize`
> function.  And changes the `HttpProxy`s termination logic to 
> terminate via `UPID` which guards against double-termination.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 7f331b812de2f0437838f48e0959441c8e04c358 
> 
> Diff: https://reviews.apache.org/r/50621/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> (More testing doen later in the chain)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>