Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/ --- (Updated Sept. 19, 2016, 1:40 p.m.) Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Artem Harutyunyan, and Joris Van Remoortere. Repository: mesos Description --- This updates the CHANGELOG to reflect: * Backporting MESOS-5986 to 0.27.4 and 0.28.3. * Backporting MESOS-6104 and MESOS-6152 to 0.27.4, 0.28.3, and 1.0.2. Diffs - CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 Diff: https://reviews.apache.org/r/51921/diff/ Testing (updated) --- Ran the 0.27.x, 0.28.x, and 1.0.x branches + backports through an internal CI... ... and results came back as expected (passing except for some known flaky tests in 0.27.x and 0.28.x). Thanks, Joseph Wu
Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/#review149537 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2016, 5:26 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51921/ > --- > > (Updated Sept. 15, 2016, 5:26 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Artem > Harutyunyan, and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > This updates the CHANGELOG to reflect: > * Backporting MESOS-5986 to 0.27.4 and 0.28.3. > * Backporting MESOS-6104 and MESOS-6152 to 0.27.4, 0.28.3, and 1.0.2. > > > Diffs > - > > CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 > > Diff: https://reviews.apache.org/r/51921/diff/ > > > Testing > --- > > TODO: Running the 0.27.x, 0.28.x, and 1.0.x branches + backports through an > internal CI... > > > Thanks, > > Joseph Wu > >
Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.
> On Sept. 15, 2016, 5:56 p.m., Joris Van Remoortere wrote: > > Did you want to fold the minor fix into your original patch to backport? > > Joseph Wu wrote: > Do you mean MESOS-6152? (i.e. `s/fd/owned_fd`) > > I kept the cherry-picks un-squashed to retain history. > > Joris Van Remoortere wrote: > Yeah. Maybe Vinod / BenM can chime in regarding squash vs. retain history. yea, lets not squash backports. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/#review149085 --- On Sept. 15, 2016, 5:26 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51921/ > --- > > (Updated Sept. 15, 2016, 5:26 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Artem > Harutyunyan, and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > This updates the CHANGELOG to reflect: > * Backporting MESOS-5986 to 0.27.4 and 0.28.3. > * Backporting MESOS-6104 and MESOS-6152 to 0.27.4, 0.28.3, and 1.0.2. > > > Diffs > - > > CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 > > Diff: https://reviews.apache.org/r/51921/diff/ > > > Testing > --- > > TODO: Running the 0.27.x, 0.28.x, and 1.0.x branches + backports through an > internal CI... > > > Thanks, > > Joseph Wu > >
Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/#review149154 --- Patch looks great! Reviews applied: [51921] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 15, 2016, 5:26 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51921/ > --- > > (Updated Sept. 15, 2016, 5:26 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Artem > Harutyunyan, and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > This updates the CHANGELOG to reflect: > * Backporting MESOS-5986 to 0.27.4 and 0.28.3. > * Backporting MESOS-6104 and MESOS-6152 to 0.27.4, 0.28.3, and 1.0.2. > > > Diffs > - > > CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 > > Diff: https://reviews.apache.org/r/51921/diff/ > > > Testing > --- > > TODO: Running the 0.27.x, 0.28.x, and 1.0.x branches + backports through an > internal CI... > > > Thanks, > > Joseph Wu > >
Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.
> On Sept. 15, 2016, 5:56 p.m., Joris Van Remoortere wrote: > > Did you want to fold the minor fix into your original patch to backport? > > Joseph Wu wrote: > Do you mean MESOS-6152? (i.e. `s/fd/owned_fd`) > > I kept the cherry-picks un-squashed to retain history. Yeah. Maybe Vinod / BenM can chime in regarding squash vs. retain history. - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/#review149085 --- On Sept. 15, 2016, 5:26 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51921/ > --- > > (Updated Sept. 15, 2016, 5:26 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Artem > Harutyunyan, and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > This updates the CHANGELOG to reflect: > * Backporting MESOS-5986 to 0.27.4 and 0.28.3. > * Backporting MESOS-6104 and MESOS-6152 to 0.27.4, 0.28.3, and 1.0.2. > > > Diffs > - > > CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 > > Diff: https://reviews.apache.org/r/51921/diff/ > > > Testing > --- > > TODO: Running the 0.27.x, 0.28.x, and 1.0.x branches + backports through an > internal CI... > > > Thanks, > > Joseph Wu > >
Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.
> On Sept. 15, 2016, 10:56 a.m., Joris Van Remoortere wrote: > > Did you want to fold the minor fix into your original patch to backport? Do you mean MESOS-6152? (i.e. `s/fd/owned_fd`) I kept the cherry-picks un-squashed to retain history. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/#review149085 --- On Sept. 15, 2016, 10:26 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51921/ > --- > > (Updated Sept. 15, 2016, 10:26 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Artem > Harutyunyan, and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > This updates the CHANGELOG to reflect: > * Backporting MESOS-5986 to 0.27.4 and 0.28.3. > * Backporting MESOS-6104 and MESOS-6152 to 0.27.4, 0.28.3, and 1.0.2. > > > Diffs > - > > CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 > > Diff: https://reviews.apache.org/r/51921/diff/ > > > Testing > --- > > TODO: Running the 0.27.x, 0.28.x, and 1.0.x branches + backports through an > internal CI... > > > Thanks, > > Joseph Wu > >
Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/#review149085 --- Did you want to fold the minor fix into your original patch to backport? - Joris Van Remoortere On Sept. 15, 2016, 5:26 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51921/ > --- > > (Updated Sept. 15, 2016, 5:26 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Artem > Harutyunyan, and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > This updates the CHANGELOG to reflect: > * Backporting MESOS-5986 to 0.27.4 and 0.28.3. > * Backporting MESOS-6104 and MESOS-6152 to 0.27.4, 0.28.3, and 1.0.2. > > > Diffs > - > > CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 > > Diff: https://reviews.apache.org/r/51921/diff/ > > > Testing > --- > > TODO: Running the 0.27.x, 0.28.x, and 1.0.x branches + backports through an > internal CI... > > > Thanks, > > Joseph Wu > >
