Re: Review Request 63550: Included commit message in `push-commits.py`.

[Vinod Kone]

> On Nov. 4, 2017, 1:44 a.m., Michael Park wrote:
> > support/push-commits.py
> > Lines 48-55 (original), 51-62 (patched)
> > 
> >
> > Since we're shelling out to `git` multiple times anyway, I think it'd 
> > be simpler to just do:
> > ```
> > reviews = check_output(['git', 'rev-list', '--reverse', merge_base + 
> > ".." + current_branch_ref]).split('\n')
> > ```
> > and then do:
> > ```
> > for review in reviews:
> >   commit_msg = check_output(['git', '--no-pager', 'log', '--no-color', 
> > '-n 1', review])
> >   # ...
> > ```
> > Relying on `--skip` going too far which in turn makes `commit_log` 
> > become a empty string and thus checking for `if not commit_log` is more 
> > complex than we need it to be I think.

I used `git show --no-patch` instead of `git log -n 1` as discussed offline.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63550/#review190083
---


On Nov. 6, 2017, 4:09 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63550/
> ---
> 
> (Updated Nov. 6, 2017, 4:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script previously closed the reviews without any description.
> Now it includes the commit log for easy reference.
> 
> 
> Diffs
> -
> 
>   support/push-commits.py 3e9d05cb03443e5a46422da67e91d43a119a66c6 
> 
> 
> Diff: https://reviews.apache.org/r/63550/diff/3/
> 
> 
> Testing
> ---
> 
> Tested manually by running in dry run mode.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 63550: Included commit message in `push-commits.py`.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63550/
---

(Updated Nov. 6, 2017, 4:09 p.m.)


Review request for mesos, Benjamin Mahler and Michael Park.


Changes
---

mpark's comments. NNFR.


Repository: mesos


Description
---

This script previously closed the reviews without any description.
Now it includes the commit log for easy reference.


Diffs (updated)
-

  support/push-commits.py 3e9d05cb03443e5a46422da67e91d43a119a66c6 


Diff: https://reviews.apache.org/r/63550/diff/3/

Changes: https://reviews.apache.org/r/63550/diff/2-3/


Testing
---

Tested manually by running in dry run mode.


Thanks,

Vinod Kone

Re: Review Request 63550: Included commit message in `push-commits.py`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63550/#review190095
---



Patch looks great!

Reviews applied: [63550]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 4, 2017, 12:40 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63550/
> ---
> 
> (Updated Nov. 4, 2017, 12:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script previously closed the reviews without any description.
> Now it includes the commit log for easy reference.
> 
> 
> Diffs
> -
> 
>   support/push-commits.py 3e9d05cb03443e5a46422da67e91d43a119a66c6 
> 
> 
> Diff: https://reviews.apache.org/r/63550/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually by running in dry run mode.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 63550: Included commit message in `push-commits.py`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63550/#review190086
---



PASS: Mesos patch 63550 was successfully built and tested.

Reviews applied: `['63550']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63550

- Mesos Reviewbot Windows


On Nov. 4, 2017, 2:40 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63550/
> ---
> 
> (Updated Nov. 4, 2017, 2:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script previously closed the reviews without any description.
> Now it includes the commit log for easy reference.
> 
> 
> Diffs
> -
> 
>   support/push-commits.py 3e9d05cb03443e5a46422da67e91d43a119a66c6 
> 
> 
> Diff: https://reviews.apache.org/r/63550/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually by running in dry run mode.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 63550: Included commit message in `push-commits.py`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63550/#review190083
---


Fix it, then Ship it!





support/push-commits.py
Lines 48-55 (original), 51-62 (patched)


Since we're shelling out to `git` multiple times anyway, I think it'd be 
simpler to just do:
```
reviews = check_output(['git', 'rev-list', '--reverse', merge_base + ".." + 
current_branch_ref]).split('\n')
```
and then do:
```
for review in reviews:
  commit_msg = check_output(['git', '--no-pager', 'log', '--no-color', '-n 
1', review])
  # ...
```
Relying on `--skip` going too far which in turn makes `commit_log` become a 
empty string and thus checking for `if not commit_log` is more complex than we 
need it to be I think.


- Michael Park


On Nov. 3, 2017, 5:40 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63550/
> ---
> 
> (Updated Nov. 3, 2017, 5:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script previously closed the reviews without any description.
> Now it includes the commit log for easy reference.
> 
> 
> Diffs
> -
> 
>   support/push-commits.py 3e9d05cb03443e5a46422da67e91d43a119a66c6 
> 
> 
> Diff: https://reviews.apache.org/r/63550/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually by running in dry run mode.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 63550: Included commit message in `push-commits.py`.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63550/
---

(Updated Nov. 4, 2017, 12:40 a.m.)


Review request for mesos, Benjamin Mahler and Michael Park.


Changes
---

fixed the skipping logic per mpark's offline comment.


Repository: mesos


Description
---

This script previously closed the reviews without any description.
Now it includes the commit log for easy reference.


Diffs (updated)
-

  support/push-commits.py 3e9d05cb03443e5a46422da67e91d43a119a66c6 


Diff: https://reviews.apache.org/r/63550/diff/2/

Changes: https://reviews.apache.org/r/63550/diff/1-2/


Testing
---

Tested manually by running in dry run mode.


Thanks,

Vinod Kone