Re: Review Request 65928: Improved handling of many roles in Web UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65928/#review198710 --- Patch looks great! Reviews applied: [65928] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 6, 2018, 3:24 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65928/ > --- > > (Updated March 6, 2018, 3:24 p.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Bugs: MESOS-8503 > https://issues.apache.org/jira/browse/MESOS-8503 > > > Repository: mesos > > > Description > --- > > Shows a clickable link if a framework has more than three roles. On > click all its roles will be displayed with the possibility to hide them > again. The roles are now displayed in their alphabetical order to make > it easier to find one among many. All previous functionalities remain. > > > Diffs > - > > src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7 > src/webui/master/static/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84 > src/webui/master/static/agent_framework.html > 06f1697aac91c70f5c0350159ffd26958a8436f1 > src/webui/master/static/framework.html > 82f6b279a9416d147fcfab094a326d67d0951dcc > src/webui/master/static/framework_roles.html PRE-CREATION > src/webui/master/static/frameworks.html > d37c6137b638a27e5bd0f70f08733d81550b3ace > src/webui/master/static/js/controllers.js > 66a4f2955a88fa44c3e5c717e9ce6b680050cc34 > > > Diff: https://reviews.apache.org/r/65928/diff/1/ > > > Testing > --- > > Manual testing. > >  > > > Thanks, > > Armand Grillet > >
Re: Review Request 65928: Improved handling of many roles in Web UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65928/#review198708 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['65928']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65928 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65928/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (125 ms) [--] 9 tests from Endpoint/SlaveEndpointTest (1216 ms total) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (39 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (45 ms) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (86 ms total) [--] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2544 ms) [--] 1 test from IsolationFlag/CpuIsolatorTest (2568 ms total) [--] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2480 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (2504 ms total) [--] Global test environment tear-down [==] 915 tests from 90 test cases ran. (469272 ms total) [ PASSED ] 914 tests. [ FAILED ] 1 test, listed below: [ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout 1 FAILED TEST YOU HAVE 211 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65928/logs/mesos-tests-stderr.log): ``` I0306 16:31:41.457370 7120 slave.cpp:3879] Shutting down framework d82f7cb9-1d0b-4725-9307-6dfbb682136f- I0306 16:31:41.457370 5584 master.cpp:10258] Updating the state of task 91d8f93a-f949-4812-9468-8699aa77f256 of framework d82f7cb9-1d0b-4725-9307-6dfbb682136f- (latest state: TASK_KILLED, status update state: TASK_KILLED) I0306 16:31:41.458369 7120 slave.cpp:6586] Shutting down executor '91d8f93a-f949-4812-9468-8699aa77f256' of framework d82f7cb9-1d0b-4725-9307-6dfbb682136f- at executor(1)@10.3.1.11:54215 I0306 16:31:41.460369 7120 slave.cpp:922] Agent terminating W0306 16:31:41.460369 7120 slave.cpp:3875] Ignoring shutdown framework d82f7cb9-1d0b-4725-9307-6dfbb682136f- because it is terminating I0306 16:31:41.461369 5584 master.cpp:10357] Removing task 91d8f93a-f949-4812-9468-8699aa77f256 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework d82f7cb9-1d0b-4725-9307-6dfbb682136f- on agent d82f7cb9-1d0b-4725-9307-6dfbb682136f-S0 at slave(398)@10.3.1.11:54191 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.clouI0306 16:31:40.743371 1216 exec.cpp:162] Version: 1.6.0 I0306 16:31:40.772435 10124 exec.cpp:236] Executor registered on agent d82f7cb9-1d0b-4725-9307-6dfbb682136f-S0 I0306 16:31:40.776394 616 executor.cpp:176] Received SUBSCRIBED event I0306 16:31:40.781391 616 executor.cpp:180] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net I0306 16:31:40.782397 616 executor.cpp:176] Received LAUNCH event I0306 16:31:40.787392 616 executor.cpp:648] Starting task 91d8f93a-f949-4812-9468-8699aa77f256 I0306 16:31:40.869393 616 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch ' I0306 16:31:41.420377 616 executor.cpp:661] Forked command at 3488 I0306 16:31:41.461369 7940 exec.cpp:445] Executor asked to shutdown I0306 16:31:41.462369 616 executor.cpp:176] Received SHUTDOWN event I0306 16:31:41.462369 616 executor.cpp:758] Shutting down I0306 16:31:41.462369 616 executor.cpp:868] Sending SIGTERM to process tree at pid 3dapp.net) I0306 16:31:41.464367 7120 containerizer.cpp:2338] Destroying container 955ce79b-4ea1-46ef-bc00-db073f88dd2f in RUNNING state I0306 16:31:41.464367 7120 containerizer.cpp:2952] Transitioning the state of container 955ce79b-4ea1-46ef-bc00-db073f88dd2f from RUNNING to DESTROYING I0306 16:31:41.465399 7120 launcher.cpp:156] Asked to destroy container 955ce79b-4ea1-46ef-bc00-db073f88dd2f I0306 16:31:41.466367 5584 master.cpp:1306] Agent d82f7cb9-1d0b-4725-9307-6dfbb682136f-S0 at slave(398)@10.3.1.11:54191 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected I0306 16:31:41.466367 5584 master.cpp:3276] Disconnecting
