Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

2018-05-16 Thread Radhika Jandhyala via Review Board 


> On May 14, 2018, 9:09 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/src/tests/subprocess_tests.cpp
> > Lines 779-796 (patched)
> > 
> >
> > This is a good and informative comment; however, [Mesos 
> > style](https://mesos.apache.org/documentation/latest/c++-style-guide/#comments)
> >  wants:
> > 
> > * End each sentence within a comment with a punctuation mark (please 
> > note that we generally prefer periods); this applies to incomplete 
> > sentences as well.
> > * Use backticks when quoting code excerpts or object/variable/function 
> > names.
> > 
> > So something like:
> > 
> > ```
> >   // The Windows version of `echo` is a built-in of the command
> >   // prompt, and it simply reproduces the entire command line string.
> >   // However, the flags class (and thus this test) is expecting the
> >   // semantics of a native binary interpreting the command line
> >   // arguments via the Windows API `CommandLineToArgv`. When a regular
> >   // Windows application (in contrast to `echo`) gets command line
> >   // arguments, the text is processed automatically by
> >   // `CommandLineToArgv`, which converts the command line string into
> >   // an array. For example, this is the output of `echo`:
> >   //
> >   //> cmd.exe /c echo "--s3=\"geek\""
> >   //"--s3=\"geek\""
> >   //
> >   // With `test-echo.exe`, a small native binary that just prints its
> >   // arguments, the output is:
> >   //
> >   // > test-echo.exe "--s3=\"geek\""
> >   // --s3="geek"
> >   //
> >   // This is the behavior expected by the test as the POSIX version of
> >   // `echo` is a native binary.
> > ```

Thanks for writing that up. It is so well written.


- Radhika


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67075/#review203066
---


On May 16, 2018, 5:55 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67075/
> ---
> 
> (Updated May 16, 2018, 5:55 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-8857
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/67152
> 
> Remove '\\' prefix for test-echo while joining with build dir
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 1b2d75d2b576e528db49635fce54174d56a29c59 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 269918e7f795bb62f8acd84cfc4233ff8682f90d 
>   3rdparty/libprocess/src/tests/test_echo.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67075/diff/4/
> 
> 
> Testing
> ---
> 
> [--] 18 tests from SubprocessTest
> [ RUN  ] SubprocessTest.PipeOutputToFileDescriptor
> [   OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms)
> [ RUN  ] SubprocessTest.PipeOutputToPath
> [   OK ] SubprocessTest.PipeOutputToPath (33 ms)
> [ RUN  ] SubprocessTest.EnvironmentEcho
> [   OK ] SubprocessTest.EnvironmentEcho (22 ms)
> [ RUN  ] SubprocessTest.Status
> [   OK ] SubprocessTest.Status (29 ms)
> [ RUN  ] SubprocessTest.PipeOutput
> [   OK ] SubprocessTest.PipeOutput (25 ms)
> [ RUN  ] SubprocessTest.PipeLargeOutput
> [   OK ] SubprocessTest.PipeLargeOutput (18 ms)
> [ RUN  ] SubprocessTest.PipeInput
> [   OK ] SubprocessTest.PipeInput (248 ms)
> [ RUN  ] SubprocessTest.PipeRedirect
> [   OK ] SubprocessTest.PipeRedirect (31 ms)
> [ RUN  ] SubprocessTest.PathOutput
> [   OK ] SubprocessTest.PathOutput (54 ms)
> [ RUN  ] SubprocessTest.PathInput
> [   OK ] SubprocessTest.PathInput (232 ms)
> [ RUN  ] SubprocessTest.FdOutput
> [   OK ] SubprocessTest.FdOutput (45 ms)
> [ RUN  ] SubprocessTest.FdInput
> [   OK ] SubprocessTest.FdInput (237 ms)
> [ RUN  ] SubprocessTest.Default
> hello world
> [   OK ] SubprocessTest.Default (21 ms)
> [ RUN  ] SubprocessTest.Flags
> [   OK ] SubprocessTest.Flags (34 ms)
> [ RUN  ] SubprocessTest.Environment
> [   OK ] SubprocessTest.Environment (32 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpaces
> [   OK ] SubprocessTest.EnvironmentWithSpaces (19 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpacesAndQuotes
> [   OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms)
> [ RUN  ] SubprocessTest.EnvironmentOverride
> [   OK ] SubprocessTest.EnvironmentOverride (17

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

2018-05-16 Thread Radhika Jandhyala via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67075/
---

(Updated May 16, 2018, 5:55 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: https://issues.apache.org/jira/browse/MESOS-8857

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857


Repository: mesos


Description (updated)
---

Review: https://reviews.apache.org/r/67152

Remove '\\' prefix for test-echo while joining with build dir


Diffs (updated)
-

  3rdparty/libprocess/src/tests/CMakeLists.txt 
1b2d75d2b576e528db49635fce54174d56a29c59 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
269918e7f795bb62f8acd84cfc4233ff8682f90d 
  3rdparty/libprocess/src/tests/test_echo.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67075/diff/4/

Changes: https://reviews.apache.org/r/67075/diff/3-4/


Testing
---

[--] 18 tests from SubprocessTest
[ RUN  ] SubprocessTest.PipeOutputToFileDescriptor
[   OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms)
[ RUN  ] SubprocessTest.PipeOutputToPath
[   OK ] SubprocessTest.PipeOutputToPath (33 ms)
[ RUN  ] SubprocessTest.EnvironmentEcho
[   OK ] SubprocessTest.EnvironmentEcho (22 ms)
[ RUN  ] SubprocessTest.Status
[   OK ] SubprocessTest.Status (29 ms)
[ RUN  ] SubprocessTest.PipeOutput
[   OK ] SubprocessTest.PipeOutput (25 ms)
[ RUN  ] SubprocessTest.PipeLargeOutput
[   OK ] SubprocessTest.PipeLargeOutput (18 ms)
[ RUN  ] SubprocessTest.PipeInput
[   OK ] SubprocessTest.PipeInput (248 ms)
[ RUN  ] SubprocessTest.PipeRedirect
[   OK ] SubprocessTest.PipeRedirect (31 ms)
[ RUN  ] SubprocessTest.PathOutput
[   OK ] SubprocessTest.PathOutput (54 ms)
[ RUN  ] SubprocessTest.PathInput
[   OK ] SubprocessTest.PathInput (232 ms)
[ RUN  ] SubprocessTest.FdOutput
[   OK ] SubprocessTest.FdOutput (45 ms)
[ RUN  ] SubprocessTest.FdInput
[   OK ] SubprocessTest.FdInput (237 ms)
[ RUN  ] SubprocessTest.Default
hello world
[   OK ] SubprocessTest.Default (21 ms)
[ RUN  ] SubprocessTest.Flags
[   OK ] SubprocessTest.Flags (34 ms)
[ RUN  ] SubprocessTest.Environment
[   OK ] SubprocessTest.Environment (32 ms)
[ RUN  ] SubprocessTest.EnvironmentWithSpaces
[   OK ] SubprocessTest.EnvironmentWithSpaces (19 ms)
[ RUN  ] SubprocessTest.EnvironmentWithSpacesAndQuotes
[   OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms)
[ RUN  ] SubprocessTest.EnvironmentOverride
[   OK ] SubprocessTest.EnvironmentOverride (17 ms)
[--] 18 tests from SubprocessTest (1201 ms total)


Thanks,

Radhika Jandhyala

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

2018-05-16 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67075/#review203255
---


Fix it, then Ship it!





3rdparty/libprocess/src/tests/subprocess_tests.cpp
Lines 807 (patched)


`path::join` joins with `os::PATH_SEPARATOR` aka `\`. You can remove the 
`\` from the second argument :)


- Andrew Schwartzmeyer


On May 16, 2018, 10:07 a.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67075/
> ---
> 
> (Updated May 16, 2018, 10:07 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-8857
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/67152
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 1b2d75d2b576e528db49635fce54174d56a29c59 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 269918e7f795bb62f8acd84cfc4233ff8682f90d 
>   3rdparty/libprocess/src/tests/test_echo.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67075/diff/3/
> 
> 
> Testing
> ---
> 
> [--] 18 tests from SubprocessTest
> [ RUN  ] SubprocessTest.PipeOutputToFileDescriptor
> [   OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms)
> [ RUN  ] SubprocessTest.PipeOutputToPath
> [   OK ] SubprocessTest.PipeOutputToPath (33 ms)
> [ RUN  ] SubprocessTest.EnvironmentEcho
> [   OK ] SubprocessTest.EnvironmentEcho (22 ms)
> [ RUN  ] SubprocessTest.Status
> [   OK ] SubprocessTest.Status (29 ms)
> [ RUN  ] SubprocessTest.PipeOutput
> [   OK ] SubprocessTest.PipeOutput (25 ms)
> [ RUN  ] SubprocessTest.PipeLargeOutput
> [   OK ] SubprocessTest.PipeLargeOutput (18 ms)
> [ RUN  ] SubprocessTest.PipeInput
> [   OK ] SubprocessTest.PipeInput (248 ms)
> [ RUN  ] SubprocessTest.PipeRedirect
> [   OK ] SubprocessTest.PipeRedirect (31 ms)
> [ RUN  ] SubprocessTest.PathOutput
> [   OK ] SubprocessTest.PathOutput (54 ms)
> [ RUN  ] SubprocessTest.PathInput
> [   OK ] SubprocessTest.PathInput (232 ms)
> [ RUN  ] SubprocessTest.FdOutput
> [   OK ] SubprocessTest.FdOutput (45 ms)
> [ RUN  ] SubprocessTest.FdInput
> [   OK ] SubprocessTest.FdInput (237 ms)
> [ RUN  ] SubprocessTest.Default
> hello world
> [   OK ] SubprocessTest.Default (21 ms)
> [ RUN  ] SubprocessTest.Flags
> [   OK ] SubprocessTest.Flags (34 ms)
> [ RUN  ] SubprocessTest.Environment
> [   OK ] SubprocessTest.Environment (32 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpaces
> [   OK ] SubprocessTest.EnvironmentWithSpaces (19 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpacesAndQuotes
> [   OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms)
> [ RUN  ] SubprocessTest.EnvironmentOverride
> [   OK ] SubprocessTest.EnvironmentOverride (17 ms)
> [--] 18 tests from SubprocessTest (1201 ms total)
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

2018-05-16 Thread Radhika Jandhyala via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67075/
---

(Updated May 16, 2018, 5:07 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: https://issues.apache.org/jira/browse/MESOS-8857

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857


Repository: mesos


Description (updated)
---

Review: https://reviews.apache.org/r/67152


Diffs (updated)
-

  3rdparty/libprocess/src/tests/CMakeLists.txt 
1b2d75d2b576e528db49635fce54174d56a29c59 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
269918e7f795bb62f8acd84cfc4233ff8682f90d 
  3rdparty/libprocess/src/tests/test_echo.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67075/diff/3/

Changes: https://reviews.apache.org/r/67075/diff/2-3/


Testing
---

[--] 18 tests from SubprocessTest
[ RUN  ] SubprocessTest.PipeOutputToFileDescriptor
[   OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms)
[ RUN  ] SubprocessTest.PipeOutputToPath
[   OK ] SubprocessTest.PipeOutputToPath (33 ms)
[ RUN  ] SubprocessTest.EnvironmentEcho
[   OK ] SubprocessTest.EnvironmentEcho (22 ms)
[ RUN  ] SubprocessTest.Status
[   OK ] SubprocessTest.Status (29 ms)
[ RUN  ] SubprocessTest.PipeOutput
[   OK ] SubprocessTest.PipeOutput (25 ms)
[ RUN  ] SubprocessTest.PipeLargeOutput
[   OK ] SubprocessTest.PipeLargeOutput (18 ms)
[ RUN  ] SubprocessTest.PipeInput
[   OK ] SubprocessTest.PipeInput (248 ms)
[ RUN  ] SubprocessTest.PipeRedirect
[   OK ] SubprocessTest.PipeRedirect (31 ms)
[ RUN  ] SubprocessTest.PathOutput
[   OK ] SubprocessTest.PathOutput (54 ms)
[ RUN  ] SubprocessTest.PathInput
[   OK ] SubprocessTest.PathInput (232 ms)
[ RUN  ] SubprocessTest.FdOutput
[   OK ] SubprocessTest.FdOutput (45 ms)
[ RUN  ] SubprocessTest.FdInput
[   OK ] SubprocessTest.FdInput (237 ms)
[ RUN  ] SubprocessTest.Default
hello world
[   OK ] SubprocessTest.Default (21 ms)
[ RUN  ] SubprocessTest.Flags
[   OK ] SubprocessTest.Flags (34 ms)
[ RUN  ] SubprocessTest.Environment
[   OK ] SubprocessTest.Environment (32 ms)
[ RUN  ] SubprocessTest.EnvironmentWithSpaces
[   OK ] SubprocessTest.EnvironmentWithSpaces (19 ms)
[ RUN  ] SubprocessTest.EnvironmentWithSpacesAndQuotes
[   OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms)
[ RUN  ] SubprocessTest.EnvironmentOverride
[   OK ] SubprocessTest.EnvironmentOverride (17 ms)
[--] 18 tests from SubprocessTest (1201 ms total)


Thanks,

Radhika Jandhyala

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

2018-05-15 Thread Radhika Jandhyala via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67075/
---

(Updated May 15, 2018, 11:14 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: https://issues.apache.org/jira/browse/MESOS-8857

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857


Repository: mesos


Description
---

Fix TEST_F(SubprocessTest, Flags)


Diffs (updated)
-

  3rdparty/libprocess/src/tests/CMakeLists.txt 
1b2d75d2b576e528db49635fce54174d56a29c59 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
269918e7f795bb62f8acd84cfc4233ff8682f90d 
  3rdparty/libprocess/src/tests/test_echo.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67075/diff/2/

Changes: https://reviews.apache.org/r/67075/diff/1-2/


Testing
---

[--] 18 tests from SubprocessTest
[ RUN  ] SubprocessTest.PipeOutputToFileDescriptor
[   OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms)
[ RUN  ] SubprocessTest.PipeOutputToPath
[   OK ] SubprocessTest.PipeOutputToPath (33 ms)
[ RUN  ] SubprocessTest.EnvironmentEcho
[   OK ] SubprocessTest.EnvironmentEcho (22 ms)
[ RUN  ] SubprocessTest.Status
[   OK ] SubprocessTest.Status (29 ms)
[ RUN  ] SubprocessTest.PipeOutput
[   OK ] SubprocessTest.PipeOutput (25 ms)
[ RUN  ] SubprocessTest.PipeLargeOutput
[   OK ] SubprocessTest.PipeLargeOutput (18 ms)
[ RUN  ] SubprocessTest.PipeInput
[   OK ] SubprocessTest.PipeInput (248 ms)
[ RUN  ] SubprocessTest.PipeRedirect
[   OK ] SubprocessTest.PipeRedirect (31 ms)
[ RUN  ] SubprocessTest.PathOutput
[   OK ] SubprocessTest.PathOutput (54 ms)
[ RUN  ] SubprocessTest.PathInput
[   OK ] SubprocessTest.PathInput (232 ms)
[ RUN  ] SubprocessTest.FdOutput
[   OK ] SubprocessTest.FdOutput (45 ms)
[ RUN  ] SubprocessTest.FdInput
[   OK ] SubprocessTest.FdInput (237 ms)
[ RUN  ] SubprocessTest.Default
hello world
[   OK ] SubprocessTest.Default (21 ms)
[ RUN  ] SubprocessTest.Flags
[   OK ] SubprocessTest.Flags (34 ms)
[ RUN  ] SubprocessTest.Environment
[   OK ] SubprocessTest.Environment (32 ms)
[ RUN  ] SubprocessTest.EnvironmentWithSpaces
[   OK ] SubprocessTest.EnvironmentWithSpaces (19 ms)
[ RUN  ] SubprocessTest.EnvironmentWithSpacesAndQuotes
[   OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms)
[ RUN  ] SubprocessTest.EnvironmentOverride
[   OK ] SubprocessTest.EnvironmentOverride (17 ms)
[--] 18 tests from SubprocessTest (1201 ms total)


Thanks,

Radhika Jandhyala

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

2018-05-14 Thread Andrew Schwartzmeyer 


> On May 14, 2018, 2:09 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/src/tests/subprocess_tests.cpp
> > Lines 797-802 (patched)
> > 
> >
> > Instead of this Windows code to construct the path to the exe, you can 
> > just use:
> > 
> > ```
> > path::join(BUILD_DIR, "test-echo.exe")
> > ```
> > 
> > (See the use of this in `process_tests.cpp` for `test-linkee` as an 
> > example.)
> 
> Radhika Jandhyala wrote:
> BUILD_DIR does not contain "debug" or "release" which is where the exes 
> get placed

Oh goodness... all those tests in `process_tests.cpp` that use it are 
disabled... I see. Okay, we should probably fix `BUILD_DIR` then to be correct, 
if possible.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67075/#review203066
---


On May 10, 2018, 3:24 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67075/
> ---
> 
> (Updated May 10, 2018, 3:24 p.m.)
> 
> 
> Review request for Andrew Schwartzmeyer.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-8857
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix TEST_F(SubprocessTest, Flags)
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 1b2d75d2b576e528db49635fce54174d56a29c59 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 269918e7f795bb62f8acd84cfc4233ff8682f90d 
>   3rdparty/libprocess/src/tests/test_flags.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67075/diff/1/
> 
> 
> Testing
> ---
> 
> [--] 18 tests from SubprocessTest
> [ RUN  ] SubprocessTest.PipeOutputToFileDescriptor
> [   OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms)
> [ RUN  ] SubprocessTest.PipeOutputToPath
> [   OK ] SubprocessTest.PipeOutputToPath (33 ms)
> [ RUN  ] SubprocessTest.EnvironmentEcho
> [   OK ] SubprocessTest.EnvironmentEcho (22 ms)
> [ RUN  ] SubprocessTest.Status
> [   OK ] SubprocessTest.Status (29 ms)
> [ RUN  ] SubprocessTest.PipeOutput
> [   OK ] SubprocessTest.PipeOutput (25 ms)
> [ RUN  ] SubprocessTest.PipeLargeOutput
> [   OK ] SubprocessTest.PipeLargeOutput (18 ms)
> [ RUN  ] SubprocessTest.PipeInput
> [   OK ] SubprocessTest.PipeInput (248 ms)
> [ RUN  ] SubprocessTest.PipeRedirect
> [   OK ] SubprocessTest.PipeRedirect (31 ms)
> [ RUN  ] SubprocessTest.PathOutput
> [   OK ] SubprocessTest.PathOutput (54 ms)
> [ RUN  ] SubprocessTest.PathInput
> [   OK ] SubprocessTest.PathInput (232 ms)
> [ RUN  ] SubprocessTest.FdOutput
> [   OK ] SubprocessTest.FdOutput (45 ms)
> [ RUN  ] SubprocessTest.FdInput
> [   OK ] SubprocessTest.FdInput (237 ms)
> [ RUN  ] SubprocessTest.Default
> hello world
> [   OK ] SubprocessTest.Default (21 ms)
> [ RUN  ] SubprocessTest.Flags
> [   OK ] SubprocessTest.Flags (34 ms)
> [ RUN  ] SubprocessTest.Environment
> [   OK ] SubprocessTest.Environment (32 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpaces
> [   OK ] SubprocessTest.EnvironmentWithSpaces (19 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpacesAndQuotes
> [   OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms)
> [ RUN  ] SubprocessTest.EnvironmentOverride
> [   OK ] SubprocessTest.EnvironmentOverride (17 ms)
> [--] 18 tests from SubprocessTest (1201 ms total)
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

2018-05-14 Thread Radhika Jandhyala via Review Board 


> On May 14, 2018, 9:09 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/src/tests/subprocess_tests.cpp
> > Lines 797-802 (patched)
> > 
> >
> > Instead of this Windows code to construct the path to the exe, you can 
> > just use:
> > 
> > ```
> > path::join(BUILD_DIR, "test-echo.exe")
> > ```
> > 
> > (See the use of this in `process_tests.cpp` for `test-linkee` as an 
> > example.)

BUILD_DIR does not contain "debug" or "release" which is where the exes get 
placed


> On May 14, 2018, 9:09 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/src/tests/test_flags.cpp
> > Lines 13-17 (patched)
> > 
> >
> > Mesos style uses C++ish `//` comments instead of Cish `/* */` comments. 
> > See 
> > [here](https://mesos.apache.org/documentation/latest/c++-style-guide/#comments)
> >  for more.

I have done as you suggested. test-linkee uses both // and /*


- Radhika


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67075/#review203066
---


On May 10, 2018, 10:24 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67075/
> ---
> 
> (Updated May 10, 2018, 10:24 p.m.)
> 
> 
> Review request for Andrew Schwartzmeyer.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-8857
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix TEST_F(SubprocessTest, Flags)
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 1b2d75d2b576e528db49635fce54174d56a29c59 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 269918e7f795bb62f8acd84cfc4233ff8682f90d 
>   3rdparty/libprocess/src/tests/test_flags.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67075/diff/1/
> 
> 
> Testing
> ---
> 
> [--] 18 tests from SubprocessTest
> [ RUN  ] SubprocessTest.PipeOutputToFileDescriptor
> [   OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms)
> [ RUN  ] SubprocessTest.PipeOutputToPath
> [   OK ] SubprocessTest.PipeOutputToPath (33 ms)
> [ RUN  ] SubprocessTest.EnvironmentEcho
> [   OK ] SubprocessTest.EnvironmentEcho (22 ms)
> [ RUN  ] SubprocessTest.Status
> [   OK ] SubprocessTest.Status (29 ms)
> [ RUN  ] SubprocessTest.PipeOutput
> [   OK ] SubprocessTest.PipeOutput (25 ms)
> [ RUN  ] SubprocessTest.PipeLargeOutput
> [   OK ] SubprocessTest.PipeLargeOutput (18 ms)
> [ RUN  ] SubprocessTest.PipeInput
> [   OK ] SubprocessTest.PipeInput (248 ms)
> [ RUN  ] SubprocessTest.PipeRedirect
> [   OK ] SubprocessTest.PipeRedirect (31 ms)
> [ RUN  ] SubprocessTest.PathOutput
> [   OK ] SubprocessTest.PathOutput (54 ms)
> [ RUN  ] SubprocessTest.PathInput
> [   OK ] SubprocessTest.PathInput (232 ms)
> [ RUN  ] SubprocessTest.FdOutput
> [   OK ] SubprocessTest.FdOutput (45 ms)
> [ RUN  ] SubprocessTest.FdInput
> [   OK ] SubprocessTest.FdInput (237 ms)
> [ RUN  ] SubprocessTest.Default
> hello world
> [   OK ] SubprocessTest.Default (21 ms)
> [ RUN  ] SubprocessTest.Flags
> [   OK ] SubprocessTest.Flags (34 ms)
> [ RUN  ] SubprocessTest.Environment
> [   OK ] SubprocessTest.Environment (32 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpaces
> [   OK ] SubprocessTest.EnvironmentWithSpaces (19 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpacesAndQuotes
> [   OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms)
> [ RUN  ] SubprocessTest.EnvironmentOverride
> [   OK ] SubprocessTest.EnvironmentOverride (17 ms)
> [--] 18 tests from SubprocessTest (1201 ms total)
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

2018-05-10 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67075/#review202877
---



PASS: Mesos patch 67075 was successfully built and tested.

Reviews applied: `['67075']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67075

- Mesos Reviewbot Windows


On May 10, 2018, 10:24 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67075/
> ---
> 
> (Updated May 10, 2018, 10:24 p.m.)
> 
> 
> Review request for Andrew Schwartzmeyer.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-8857
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix TEST_F(SubprocessTest, Flags)
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 1b2d75d2b576e528db49635fce54174d56a29c59 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 269918e7f795bb62f8acd84cfc4233ff8682f90d 
>   3rdparty/libprocess/src/tests/test_flags.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67075/diff/1/
> 
> 
> Testing
> ---
> 
> [--] 18 tests from SubprocessTest
> [ RUN  ] SubprocessTest.PipeOutputToFileDescriptor
> [   OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms)
> [ RUN  ] SubprocessTest.PipeOutputToPath
> [   OK ] SubprocessTest.PipeOutputToPath (33 ms)
> [ RUN  ] SubprocessTest.EnvironmentEcho
> [   OK ] SubprocessTest.EnvironmentEcho (22 ms)
> [ RUN  ] SubprocessTest.Status
> [   OK ] SubprocessTest.Status (29 ms)
> [ RUN  ] SubprocessTest.PipeOutput
> [   OK ] SubprocessTest.PipeOutput (25 ms)
> [ RUN  ] SubprocessTest.PipeLargeOutput
> [   OK ] SubprocessTest.PipeLargeOutput (18 ms)
> [ RUN  ] SubprocessTest.PipeInput
> [   OK ] SubprocessTest.PipeInput (248 ms)
> [ RUN  ] SubprocessTest.PipeRedirect
> [   OK ] SubprocessTest.PipeRedirect (31 ms)
> [ RUN  ] SubprocessTest.PathOutput
> [   OK ] SubprocessTest.PathOutput (54 ms)
> [ RUN  ] SubprocessTest.PathInput
> [   OK ] SubprocessTest.PathInput (232 ms)
> [ RUN  ] SubprocessTest.FdOutput
> [   OK ] SubprocessTest.FdOutput (45 ms)
> [ RUN  ] SubprocessTest.FdInput
> [   OK ] SubprocessTest.FdInput (237 ms)
> [ RUN  ] SubprocessTest.Default
> hello world
> [   OK ] SubprocessTest.Default (21 ms)
> [ RUN  ] SubprocessTest.Flags
> [   OK ] SubprocessTest.Flags (34 ms)
> [ RUN  ] SubprocessTest.Environment
> [   OK ] SubprocessTest.Environment (32 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpaces
> [   OK ] SubprocessTest.EnvironmentWithSpaces (19 ms)
> [ RUN  ] SubprocessTest.EnvironmentWithSpacesAndQuotes
> [   OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms)
> [ RUN  ] SubprocessTest.EnvironmentOverride
> [   OK ] SubprocessTest.EnvironmentOverride (17 ms)
> [--] 18 tests from SubprocessTest (1201 ms total)
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>