Re: Review Request 36828: Used std::thread instead of pthread for stout proc tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/#review93654 --- Ship it! I'll fix up and commit, thanks! 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp (line 107) https://reviews.apache.org/r/36828/#comment148067 s//mutex, cond, stop/ - Benjamin Hindman On July 27, 2015, 8:45 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/ --- (Updated July 27, 2015, 8:45 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 5d24f21f63433b8525370736dd630880d324ebeb Diff: https://reviews.apache.org/r/36828/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 36828: Used std::thread instead of pthread for stout proc tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/#review93167 --- 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp (line 107) https://reviews.apache.org/r/36828/#comment147439 Not yours but can you bump to previous line please? 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp (line 125) https://reviews.apache.org/r/36828/#comment147438 Same comments here as previous reviews: use Latch instead of condition variables here. - Benjamin Hindman On July 27, 2015, 7:04 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/ --- (Updated July 27, 2015, 7:04 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 5d24f21f63433b8525370736dd630880d324ebeb Diff: https://reviews.apache.org/r/36828/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 36828: Used std::thread instead of pthread for stout proc tests.
On July 27, 2015, 7:21 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp, line 142 https://reviews.apache.org/r/36828/diff/2/?file=106#file106line142 Same comments here as previous reviews: use Latch instead of condition variables here. This one is a little harder since Latch is in Libprocess! Shall we leave this one using synchronized for now? - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/#review93167 --- On July 27, 2015, 7:04 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/ --- (Updated July 27, 2015, 7:04 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 5d24f21f63433b8525370736dd630880d324ebeb Diff: https://reviews.apache.org/r/36828/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 36828: Used std::thread instead of pthread for stout proc tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/ --- (Updated July 27, 2015, 8:45 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Changes --- fixing style issue. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 5d24f21f63433b8525370736dd630880d324ebeb Diff: https://reviews.apache.org/r/36828/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 36828: Used std::thread instead of pthread for stout proc tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/#review93080 --- Ship it! 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp (line 97) https://reviews.apache.org/r/36828/#comment147342 const? - Artem Harutyunyan On July 26, 2015, 1:04 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/ --- (Updated July 26, 2015, 1:04 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 5d24f21f63433b8525370736dd630880d324ebeb Diff: https://reviews.apache.org/r/36828/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 36828: Used std::thread instead of pthread for stout proc tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/ --- (Updated July 27, 2015, 7:04 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Changes --- Addressed issues. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 5d24f21f63433b8525370736dd630880d324ebeb Diff: https://reviews.apache.org/r/36828/diff/ Testing --- make check Thanks, Joris Van Remoortere
Review Request 36828: Used std::thread instead of pthread for stout proc tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 5d24f21f63433b8525370736dd630880d324ebeb Diff: https://reviews.apache.org/r/36828/diff/ Testing --- make check Thanks, Joris Van Remoortere
