Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 27, 2015, 9:57 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, Timothy Chen, and Jiang Yan Xu. Changes --- Addressed comments. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs (updated) - src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96780 --- Bad patch! Reviews applied: [37196, 37197, 37198, 37200] Failed command: ./support/apply-review.sh -n -r 37200 Error: 2015-08-27 22:38:32 URL:https://reviews.apache.org/r/37200/diff/raw/ [28082/28082] - 37200.patch [1] 37200.patch:457: trailing whitespace. return Failure(Untar image failed with exit code: + warning: 1 line adds whitespace errors. Successfully applied: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers. Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers. Review: https://reviews.apache.org/r/37200 src/slave/containerizer/provisioners/docker/store.cpp:184: trailing whitespace. + return Failure(Untar image failed with exit code: + Failed to commit patch - Mesos ReviewBot On Aug. 27, 2015, 9:57 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 27, 2015, 9:57 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 27, 2015, 11:44 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs (updated) - src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96812 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37200, 37247, 37495, 37496, 37497] All tests passed. - Mesos ReviewBot On Aug. 27, 2015, 11:44 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 27, 2015, 11:44 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96556 --- src/slave/containerizer/provisioners/docker/paths.hpp (line 48) https://reviews.apache.org/r/37497/#comment152057 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 51) https://reviews.apache.org/r/37497/#comment152058 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 56) https://reviews.apache.org/r/37497/#comment152059 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 58) https://reviews.apache.org/r/37497/#comment152060 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 63) https://reviews.apache.org/r/37497/#comment152061 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 69) https://reviews.apache.org/r/37497/#comment152062 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 73) https://reviews.apache.org/r/37497/#comment152063 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 79) https://reviews.apache.org/r/37497/#comment152064 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 84) https://reviews.apache.org/r/37497/#comment152065 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 88) https://reviews.apache.org/r/37497/#comment152066 Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.cpp (line 21) https://reviews.apache.org/r/37497/#comment152056 This should be the first include. src/slave/containerizer/provisioners/docker/paths.cpp (line 35) https://reviews.apache.org/r/37497/#comment152049 Just one blank line between these and the others as we stay entirely within the same scope (global) here. src/slave/containerizer/provisioners/docker/paths.cpp (line 48) https://reviews.apache.org/r/37497/#comment152050 See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 61) https://reviews.apache.org/r/37497/#comment152051 See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 70) https://reviews.apache.org/r/37497/#comment152052 See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 85) https://reviews.apache.org/r/37497/#comment152053 See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 93) https://reviews.apache.org/r/37497/#comment152054 See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 100) https://reviews.apache.org/r/37497/#comment152055 See above. src/slave/containerizer/provisioners/docker/reference_store.cpp (line 161) https://reviews.apache.org/r/37497/#comment152068 Does this break a vital function of Mesos? -- If so, make it a LOG(ERROR) Does this still allow normal function but will disable certain optimizing features? -- If so, make it a LOG(WARNING) Is this valuable information for a user to understand the status of the system? -- If so, make it a LOG(INFO) Anything else is usually a VLOG(1) as it is understandable and useful mostly for developers. - Till Toenshoff On Aug. 25, 2015, 9:03 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 9:03 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 6:51 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Changes --- Rebased on master. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96433 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37200, 37247, 37495, 37496, 37497] All tests passed. - Mesos ReviewBot On Aug. 25, 2015, 9:03 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 9:03 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 9:03 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Changes --- Rebased on master. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs (updated) - src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 1:35 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Changes --- Moved staging path into docker store path. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96280 --- Bad patch! Reviews applied: [37196, 37197, 37198, 37200] Failed command: ./support/apply-review.sh -n -r 37200 Error: 2015-08-25 02:27:51 URL:https://reviews.apache.org/r/37200/diff/raw/ [31109/31109] - 37200.patch [1] error: patch failed: src/slave/containerizer/provisioners/docker.cpp:160 error: src/slave/containerizer/provisioners/docker.cpp: patch does not apply error: patch failed: src/slave/containerizer/provisioners/docker/store.cpp:264 error: src/slave/containerizer/provisioners/docker/store.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Aug. 25, 2015, 1:35 a.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 1:35 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 19, 2015, 6:46 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs (updated) - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review95908 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37200, 37247, 37495, 37496, 37497] All tests passed. - Mesos ReviewBot On Aug. 19, 2015, 6:46 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 19, 2015, 6:46 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 16, 2015, 8:38 a.m.) Review request for mesos, Jojy Varghese and Timothy Chen. Changes --- Addressed comments. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs (updated) - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review95540 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37199, 37200, 37245, 37246, 37247, 37495, 37496, 37497] All tests passed. - Mesos ReviewBot On Aug. 16, 2015, 8:38 a.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 16, 2015, 8:38 a.m.) Review request for mesos, Jojy Varghese and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review95509 --- src/Makefile.am (line 635) https://reviews.apache.org/r/37497/#comment150535 Does this belong in this review? src/slave/containerizer/provisioners/docker/local_store.cpp (line 358) https://reviews.apache.org/r/37497/#comment150536 We align the arrows like what you did in vlog src/slave/containerizer/provisioners/docker/reference_store.cpp (line 180) https://reviews.apache.org/r/37497/#comment150537 I think this should be 4 space indented: if (!os::exists( paths. - Timothy Chen On Aug. 15, 2015, 6:56 a.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 15, 2015, 6:56 a.m.) Review request for mesos, Jojy Varghese and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 15, 2015, 1:27 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
