Re: Review Request 38774: state: fix file descriptor leak

2015-09-28 Thread Chi Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38774/
---

(Updated Sept. 28, 2015, 8:42 p.m.)


Review request for mesos and Ben Mahler.


Bugs: mesos-3519
https://issues.apache.org/jira/browse/mesos-3519


Repository: mesos


Description
---

state: fix file descriptor leak


Diffs (updated)
-

  src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 

Diff: https://reviews.apache.org/r/38774/diff/


Testing
---

make check


Thanks,

Chi Zhang

Re: Review Request 38774: state: fix file descriptor leak

2015-09-28 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38774/#review100907
---

Ship it!


I'll get this committed shortly, thanks!


src/slave/state.cpp (line 655)


Ditto here



src/slave/state.cpp (line 731)


newline after this :)


- Ben Mahler


On Sept. 28, 2015, 8:42 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38774/
> ---
> 
> (Updated Sept. 28, 2015, 8:42 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> state: fix file descriptor leak
> 
> 
> Diffs
> -
> 
>   src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 
> 
> Diff: https://reviews.apache.org/r/38774/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38774: state: fix file descriptor leak

2015-09-26 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38774/#review100765
---


Is there already an RAII wrapper for os::close() we can use? If not, might be 
worth writing one.

- Neil Conway


On Sept. 25, 2015, 9 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38774/
> ---
> 
> (Updated Sept. 25, 2015, 9 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> state: fix file descriptor leak
> 
> 
> Diffs
> -
> 
>   src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 
> 
> Diff: https://reviews.apache.org/r/38774/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38774: state: fix file descriptor leak

2015-09-25 Thread Chi Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38774/
---

(Updated Sept. 25, 2015, 9 p.m.)


Review request for mesos.


Bugs: mesos-3519
https://issues.apache.org/jira/browse/mesos-3519


Repository: mesos


Description
---

state: fix file descriptor leak


Diffs
-

  src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 

Diff: https://reviews.apache.org/r/38774/diff/


Testing (updated)
---

make check


Thanks,

Chi Zhang

Re: Review Request 38774: state: fix file descriptor leak

2015-09-25 Thread Cong Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38774/#review100688
---



src/slave/state.cpp (line 656)


Can be moved upper, out of this if/else, save one line of code. ;)



src/slave/state.cpp (line 746)


Ditto


- Cong Wang


On Sept. 25, 2015, 9 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38774/
> ---
> 
> (Updated Sept. 25, 2015, 9 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> state: fix file descriptor leak
> 
> 
> Diffs
> -
> 
>   src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 
> 
> Diff: https://reviews.apache.org/r/38774/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Review Request 38774: state: fix file descriptor leak

2015-09-25 Thread Chi Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38774/
---

Review request for mesos.


Bugs: mesos-3519
https://issues.apache.org/jira/browse/mesos-3519


Repository: mesos


Description
---

state: fix file descriptor leak


Diffs
-

  src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 

Diff: https://reviews.apache.org/r/38774/diff/


Testing
---


Thanks,

Chi Zhang

Re: Review Request 38774: state: fix file descriptor leak

2015-09-25 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38774/#review100690
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Sept. 25, 2015, 9 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38774/
> ---
> 
> (Updated Sept. 25, 2015, 9 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> state: fix file descriptor leak
> 
> 
> Diffs
> -
> 
>   src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 
> 
> Diff: https://reviews.apache.org/r/38774/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38774: state: fix file descriptor leak

2015-09-25 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38774/#review100713
---



src/slave/state.cpp (lines 666 - 680)


Would you mind also just flattening this down to an os::close? This code is 
not helpful and it will help you perform a single close after the truncate.



src/slave/state.cpp (lines 756 - 770)


Ditto here.


- Ben Mahler


On Sept. 25, 2015, 9 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38774/
> ---
> 
> (Updated Sept. 25, 2015, 9 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> state: fix file descriptor leak
> 
> 
> Diffs
> -
> 
>   src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 
> 
> Diff: https://reviews.apache.org/r/38774/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>