-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38774/#review100713
-----------------------------------------------------------



src/slave/state.cpp (lines 666 - 680)
<https://reviews.apache.org/r/38774/#comment157973>

    Would you mind also just flattening this down to an os::close? This code is 
not helpful and it will help you perform a single close after the truncate.



src/slave/state.cpp (lines 756 - 770)
<https://reviews.apache.org/r/38774/#comment157974>

    Ditto here.


- Ben Mahler


On Sept. 25, 2015, 9 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38774/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 9 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: mesos-3519
>     https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> state: fix file descriptor leak
> 
> 
> Diffs
> -----
> 
>   src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 
> 
> Diff: https://reviews.apache.org/r/38774/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Reply via email to