Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

2015-10-15 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39180/
---

(Updated Oct. 15, 2015, 8:31 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3693


Repository: mesos


Description
---

Windows: Added support for `stout/os/open.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 
43f261fd7a60b534f642f826ebf6ab18d72180c2 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/open.hpp 
023993d859e3a101ca387c1a514cd75de0d2beb1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/open.hpp 
14fa11765c222cb4e80f5e45360d0f05facb578e 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
50e35f43d87c69a83a9e7d039d1881404ea8be38 
  src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
  src/sched/sched.cpp 9c5e3b8e42605f4647d897ba02ea3a17e494f355 
  src/tests/scheduler_http_api_tests.cpp 
ae1f6ffda966a2eca1eda578261a0a0c4432e6b3 

Diff: https://reviews.apache.org/r/39180/diff/


Testing
---

Ran both stout_tests from VS.


Thanks,

Alex Clemmer

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

2015-10-13 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39180/
---

(Updated Oct. 13, 2015, 6:26 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3693


Repository: mesos


Description
---

Windows: Added support for `stout/os/open.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 
43f261fd7a60b534f642f826ebf6ab18d72180c2 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/open.hpp 
023993d859e3a101ca387c1a514cd75de0d2beb1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/open.hpp 
14fa11765c222cb4e80f5e45360d0f05facb578e 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
50e35f43d87c69a83a9e7d039d1881404ea8be38 

Diff: https://reviews.apache.org/r/39180/diff/


Testing
---

Ran both stout_tests from VS.


Thanks,

Alex Clemmer

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

2015-10-13 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39180/#review102557
---


LGTM.


3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp (lines 50 - 52)


It'd be great to clarify this comment (discussed offline with Alex).


- Artem Harutyunyan


On Oct. 13, 2015, 11:26 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39180/
> ---
> 
> (Updated Oct. 13, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3693
> https://issues.apache.org/jira/browse/MESOS-3693
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `stout/os/open.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 
> 43f261fd7a60b534f642f826ebf6ab18d72180c2 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/open.hpp 
> 023993d859e3a101ca387c1a514cd75de0d2beb1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/open.hpp 
> 14fa11765c222cb4e80f5e45360d0f05facb578e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 50e35f43d87c69a83a9e7d039d1881404ea8be38 
> 
> Diff: https://reviews.apache.org/r/39180/diff/
> 
> 
> Testing
> ---
> 
> Ran both stout_tests from VS.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

2015-10-09 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39180/#review102138
---

Ship it!


Looks good (identical to the original open.hpp, except for the one new #ifdef).


3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp (line 20)


You need to remove these files from 
3rdparty/libprocess/3rdparty/stout/include/Makefile.am



3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp (lines 58 - 61)


One newline too many here.


- Joseph Wu


On Oct. 9, 2015, 11:30 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39180/
> ---
> 
> (Updated Oct. 9, 2015, 11:30 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3693
> https://issues.apache.org/jira/browse/MESOS-3693
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `stout/os/open.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 
> 43f261fd7a60b534f642f826ebf6ab18d72180c2 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/open.hpp 
> 023993d859e3a101ca387c1a514cd75de0d2beb1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/open.hpp 
> 14fa11765c222cb4e80f5e45360d0f05facb578e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 50e35f43d87c69a83a9e7d039d1881404ea8be38 
> 
> Diff: https://reviews.apache.org/r/39180/diff/
> 
> 
> Testing
> ---
> 
> Ran both stout_tests from VS.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

2015-10-09 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39180/
---

(Updated Oct. 10, 2015, 4:28 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3693


Repository: mesos


Description
---

Windows: Added support for `stout/os/open.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 
43f261fd7a60b534f642f826ebf6ab18d72180c2 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/open.hpp 
023993d859e3a101ca387c1a514cd75de0d2beb1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/open.hpp 
14fa11765c222cb4e80f5e45360d0f05facb578e 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
50e35f43d87c69a83a9e7d039d1881404ea8be38 

Diff: https://reviews.apache.org/r/39180/diff/


Testing
---

Ran both stout_tests from VS.


Thanks,

Alex Clemmer