Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-26 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review104061
---

Ship it!


This looks good! You missed launcher and linux_launcher (those are mesos 
containerizer specific). For the rest, it looks good. I'll commit this first 
and you can follow up with a patch to move launcher and linux_launcher.

- Jie Yu


On Oct. 20, 2015, 10 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 20, 2015, 10 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 55fa6f4019e1521dd816138e82db110d573ae6b8 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 466e6f838d143917fa7eebb13b0a670a6b80117c 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103351
---


Patch looks great!

Reviews applied: [39360]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 10 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 20, 2015, 10 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 55fa6f4019e1521dd816138e82db110d573ae6b8 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 466e6f838d143917fa7eebb13b0a670a6b80117c 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerizer/provisioner/docker/paths.hpp  
>   src/slave/containerizer/provisioner/docke

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-20 Thread Gilbert Song 


> On Oct. 19, 2015, 2:05 p.m., Cong Wang wrote:
> > You probably want to move src/tests/containerizer too?

Seems too much things under src/tests/, we may want to rearrange all of them 
together.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103157
---


On Oct. 20, 2015, 3 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 20, 2015, 3 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 55fa6f4019e1521dd816138e82db110d573ae6b8 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 466e6f838d143917fa7eebb13b0a670a6b80117c 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b2

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-20 Thread Gilbert Song 


> On Oct. 19, 2015, 1:05 p.m., Jie Yu wrote:
> > This is great! Thanks! The current patch does not apply, can you do a 
> > rebase?

Thanks. Rebased.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103150
---


On Oct. 20, 2015, 3 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 20, 2015, 3 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 55fa6f4019e1521dd816138e82db110d573ae6b8 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 466e6f838d143917fa7eebb13b0a670a6b80117c 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerize

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-20 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/
---

(Updated Oct. 20, 2015, 3 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.


Bugs: MESOS-3129
https://issues.apache.org/jira/browse/MESOS-3129


Repository: mesos


Description
---

Relocate MesosContainerizer specific files to the correct location


Diffs (updated)
-

  src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
  src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
  src/examples/test_isolator_module.cpp 
577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
  src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
  src/slave/containerizer/isolators/cgroups/constants.hpp  
  src/slave/containerizer/isolators/cgroups/cpushare.hpp 
54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 
ba748c6caec7253b42167e8a4f9b4535da858259 
  src/slave/containerizer/isolators/cgroups/mem.hpp  
  src/slave/containerizer/isolators/cgroups/mem.cpp 
55fa6f4019e1521dd816138e82db110d573ae6b8 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp  
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
  src/slave/containerizer/isolators/filesystem/linux.hpp 
93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 
  src/slave/containerizer/isolators/filesystem/posix.hpp  
  src/slave/containerizer/isolators/filesystem/posix.cpp 
eec510c4f7655d67b33ad90210eeb57fcc910684 
  src/slave/containerizer/isolators/filesystem/shared.hpp  
  src/slave/containerizer/isolators/filesystem/shared.cpp 
73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
  src/slave/containerizer/isolators/namespaces/pid.hpp  
  src/slave/containerizer/isolators/namespaces/pid.cpp 
a9823e08b195b8df82de2a7b410a4e6ef99f8853 
  src/slave/containerizer/isolators/network/helper.cpp 
e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
  src/slave/containerizer/isolators/network/port_mapping.hpp  
  src/slave/containerizer/isolators/network/port_mapping.cpp 
e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
  src/slave/containerizer/isolators/posix.hpp  
  src/slave/containerizer/isolators/posix/disk.hpp  
  src/slave/containerizer/isolators/posix/disk.cpp 
73e62a225da062733557287afa2273d8183d76fd 
  src/slave/containerizer/linux_launcher.cpp 
c03b89eb0678825b03a052874d6262f377a39e13 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 
  src/slave/containerizer/provisioner/appc/paths.hpp  
  src/slave/containerizer/provisioner/appc/paths.cpp 
8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
  src/slave/containerizer/provisioner/appc/spec.hpp  
  src/slave/containerizer/provisioner/appc/spec.cpp 
bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
  src/slave/containerizer/provisioner/appc/store.hpp 
e8455197dcc3f4c9856db20605f6862b8755a946 
  src/slave/containerizer/provisioner/appc/store.cpp 
a5ef4ea7cd08423360120430833c5881053637f5 
  src/slave/containerizer/provisioner/backend.hpp  
  src/slave/containerizer/provisioner/backend.cpp 
b5d96701ae6bd49365b169f4e5150b8c4dae1870 
  src/slave/containerizer/provisioner/backends/bind.hpp 
1685938fb4349e790b9595cc4c67584c7f31a392 
  src/slave/containerizer/provisioner/backends/bind.cpp 
1fe1746c0bc1c9c12e1378e6438122a91b58316b 
  src/slave/containerizer/provisioner/backends/copy.hpp 
7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
  src/slave/containerizer/provisioner/backends/copy.cpp 
92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
  src/slave/containerizer/provisioner/docker/local_puller.hpp 
4574e8a04663482625d7b54f765741f221ec13e0 
  src/slave/containerizer/provisioner/docker/local_puller.cpp 
74d0e1ead7d630e65a7e75cb6123139b9197efef 
  src/slave/containerizer/provisioner/docker/message.hpp 
466e6f838d143917fa7eebb13b0a670a6b80117c 
  src/slave/containerizer/provisioner/docker/message.proto  
  src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
885080dbd3603f8c71ac867b88edcfd22276567f 
  src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
2b2de5245bccbd01a856b214ac6525278d794537 
  src/slave/containerizer/provisioner/docker/paths.hpp  
  src/slave/containerizer/provisioner/docker/paths.cpp 
5733fb7137b1ecb8a904cc5354425c60c9e065f5 
  src/slave/containerizer/provisioner/docker/puller.hpp 
105b4e75439c2ad4c08e2fd364f288f1d39b9b59 
  src/slave/containerizer/provisioner/docker/puller.cpp 
cb05324689ffa26ce830b513e2d71b55517da3cb 
  src/slave/containerizer/provisioner/docker/registry_client.hpp  
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
24aa95c5800ff4dfb37465b71421b014b5dd5998 
  src/slave/containerizer/provisioner/docker/spec.hpp 
199db540e44581a411ce63082b917821d29360a8 
  src/slave/containerizer/provisioner/

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-19 Thread Cong Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103157
---


You probably want to move src/tests/containerizer too?

- Cong Wang


On Oct. 15, 2015, 11:23 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 15, 2015, 11:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 6f49e5ac77ab03248127a607664c8f895be72877 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 6368bf4caec6f8c3ac97282f41c55381f920bce9 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerizer/provisioner/docker/paths.hpp  
>   src/slave/containerizer/provisioner/docker/paths.c

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-19 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103150
---


This is great! Thanks! The current patch does not apply, can you do a rebase?

- Jie Yu


On Oct. 15, 2015, 11:23 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 15, 2015, 11:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 6f49e5ac77ab03248127a607664c8f895be72877 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 6368bf4caec6f8c3ac97282f41c55381f920bce9 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerizer/provisioner/docker/paths.hpp  
>   src/slave/containerizer/provis

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review102849
---


Patch looks great!

Reviews applied: [39360]

All tests passed.

- Mesos ReviewBot


On Oct. 15, 2015, 11:23 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 15, 2015, 11:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 6f49e5ac77ab03248127a607664c8f895be72877 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 6368bf4caec6f8c3ac97282f41c55381f920bce9 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerizer/provisioner/docker/paths.hpp  
>   src/slave/containerizer/provisioner

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-15 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/
---

(Updated Oct. 15, 2015, 4:23 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.


Bugs: MESOS-3129
https://issues.apache.org/jira/browse/MESOS-3129


Repository: mesos


Description
---

Relocate MesosContainerizer specific files to the correct location


Diffs (updated)
-

  src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
  src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
  src/examples/test_isolator_module.cpp 
577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
  src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
  src/slave/containerizer/isolators/cgroups/constants.hpp  
  src/slave/containerizer/isolators/cgroups/cpushare.hpp 
54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 
ba748c6caec7253b42167e8a4f9b4535da858259 
  src/slave/containerizer/isolators/cgroups/mem.hpp  
  src/slave/containerizer/isolators/cgroups/mem.cpp 
6f49e5ac77ab03248127a607664c8f895be72877 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp  
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
  src/slave/containerizer/isolators/filesystem/linux.hpp 
93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 
  src/slave/containerizer/isolators/filesystem/posix.hpp  
  src/slave/containerizer/isolators/filesystem/posix.cpp 
eec510c4f7655d67b33ad90210eeb57fcc910684 
  src/slave/containerizer/isolators/filesystem/shared.hpp  
  src/slave/containerizer/isolators/filesystem/shared.cpp 
73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
  src/slave/containerizer/isolators/namespaces/pid.hpp  
  src/slave/containerizer/isolators/namespaces/pid.cpp 
a9823e08b195b8df82de2a7b410a4e6ef99f8853 
  src/slave/containerizer/isolators/network/helper.cpp 
e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
  src/slave/containerizer/isolators/network/port_mapping.hpp  
  src/slave/containerizer/isolators/network/port_mapping.cpp 
e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
  src/slave/containerizer/isolators/posix.hpp  
  src/slave/containerizer/isolators/posix/disk.hpp  
  src/slave/containerizer/isolators/posix/disk.cpp 
73e62a225da062733557287afa2273d8183d76fd 
  src/slave/containerizer/linux_launcher.cpp 
c03b89eb0678825b03a052874d6262f377a39e13 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 
  src/slave/containerizer/provisioner/appc/paths.hpp  
  src/slave/containerizer/provisioner/appc/paths.cpp 
8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
  src/slave/containerizer/provisioner/appc/spec.hpp  
  src/slave/containerizer/provisioner/appc/spec.cpp 
bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
  src/slave/containerizer/provisioner/appc/store.hpp 
e8455197dcc3f4c9856db20605f6862b8755a946 
  src/slave/containerizer/provisioner/appc/store.cpp 
a5ef4ea7cd08423360120430833c5881053637f5 
  src/slave/containerizer/provisioner/backend.hpp  
  src/slave/containerizer/provisioner/backend.cpp 
b5d96701ae6bd49365b169f4e5150b8c4dae1870 
  src/slave/containerizer/provisioner/backends/bind.hpp 
1685938fb4349e790b9595cc4c67584c7f31a392 
  src/slave/containerizer/provisioner/backends/bind.cpp 
1fe1746c0bc1c9c12e1378e6438122a91b58316b 
  src/slave/containerizer/provisioner/backends/copy.hpp 
7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
  src/slave/containerizer/provisioner/backends/copy.cpp 
92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
  src/slave/containerizer/provisioner/docker/local_puller.hpp 
4574e8a04663482625d7b54f765741f221ec13e0 
  src/slave/containerizer/provisioner/docker/local_puller.cpp 
74d0e1ead7d630e65a7e75cb6123139b9197efef 
  src/slave/containerizer/provisioner/docker/message.hpp 
6368bf4caec6f8c3ac97282f41c55381f920bce9 
  src/slave/containerizer/provisioner/docker/message.proto  
  src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
885080dbd3603f8c71ac867b88edcfd22276567f 
  src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
2b2de5245bccbd01a856b214ac6525278d794537 
  src/slave/containerizer/provisioner/docker/paths.hpp  
  src/slave/containerizer/provisioner/docker/paths.cpp 
5733fb7137b1ecb8a904cc5354425c60c9e065f5 
  src/slave/containerizer/provisioner/docker/puller.hpp 
105b4e75439c2ad4c08e2fd364f288f1d39b9b59 
  src/slave/containerizer/provisioner/docker/puller.cpp 
cb05324689ffa26ce830b513e2d71b55517da3cb 
  src/slave/containerizer/provisioner/docker/registry_client.hpp  
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
471783d88b73b62afacac3d7952ebb5d5f442097 
  src/slave/containerizer/provisioner/docker/store.hpp 
b5e6c87d38bea531c1b504915a84625fc9777e0d 
  src/slave/containerizer/provisio

Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-15 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/
---

Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.


Bugs: MESOS-3129
https://issues.apache.org/jira/browse/MESOS-3129


Repository: mesos


Description
---

Relocate MesosContainerizer specific files to the correct location


Diffs
-

  src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
  src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
  src/examples/test_isolator_module.cpp 
577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
  src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
  src/slave/containerizer/isolators/cgroups/constants.hpp  
  src/slave/containerizer/isolators/cgroups/cpushare.hpp 
54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 
ba748c6caec7253b42167e8a4f9b4535da858259 
  src/slave/containerizer/isolators/cgroups/mem.hpp  
  src/slave/containerizer/isolators/cgroups/mem.cpp 
6f49e5ac77ab03248127a607664c8f895be72877 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp  
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
  src/slave/containerizer/isolators/filesystem/linux.hpp 
93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 
  src/slave/containerizer/isolators/filesystem/posix.hpp  
  src/slave/containerizer/isolators/filesystem/posix.cpp 
eec510c4f7655d67b33ad90210eeb57fcc910684 
  src/slave/containerizer/isolators/filesystem/shared.hpp  
  src/slave/containerizer/isolators/filesystem/shared.cpp 
73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
  src/slave/containerizer/isolators/namespaces/pid.hpp  
  src/slave/containerizer/isolators/namespaces/pid.cpp 
a9823e08b195b8df82de2a7b410a4e6ef99f8853 
  src/slave/containerizer/isolators/network/helper.cpp 
e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
  src/slave/containerizer/isolators/network/port_mapping.hpp  
  src/slave/containerizer/isolators/network/port_mapping.cpp 
e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
  src/slave/containerizer/isolators/posix.hpp  
  src/slave/containerizer/isolators/posix/disk.hpp  
  src/slave/containerizer/isolators/posix/disk.cpp 
73e62a225da062733557287afa2273d8183d76fd 
  src/slave/containerizer/linux_launcher.cpp 
c03b89eb0678825b03a052874d6262f377a39e13 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 
  src/slave/containerizer/provisioner/appc/paths.hpp  
  src/slave/containerizer/provisioner/appc/paths.cpp 
8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
  src/slave/containerizer/provisioner/appc/spec.hpp  
  src/slave/containerizer/provisioner/appc/spec.cpp 
bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
  src/slave/containerizer/provisioner/appc/store.hpp 
e8455197dcc3f4c9856db20605f6862b8755a946 
  src/slave/containerizer/provisioner/appc/store.cpp 
a5ef4ea7cd08423360120430833c5881053637f5 
  src/slave/containerizer/provisioner/backend.hpp  
  src/slave/containerizer/provisioner/backend.cpp 
b5d96701ae6bd49365b169f4e5150b8c4dae1870 
  src/slave/containerizer/provisioner/backends/bind.hpp 
1685938fb4349e790b9595cc4c67584c7f31a392 
  src/slave/containerizer/provisioner/backends/bind.cpp 
1fe1746c0bc1c9c12e1378e6438122a91b58316b 
  src/slave/containerizer/provisioner/backends/copy.hpp 
7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
  src/slave/containerizer/provisioner/backends/copy.cpp 
92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
  src/slave/containerizer/provisioner/docker/local_puller.hpp 
4574e8a04663482625d7b54f765741f221ec13e0 
  src/slave/containerizer/provisioner/docker/local_puller.cpp 
74d0e1ead7d630e65a7e75cb6123139b9197efef 
  src/slave/containerizer/provisioner/docker/message.hpp 
6368bf4caec6f8c3ac97282f41c55381f920bce9 
  src/slave/containerizer/provisioner/docker/message.proto  
  src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
885080dbd3603f8c71ac867b88edcfd22276567f 
  src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
2b2de5245bccbd01a856b214ac6525278d794537 
  src/slave/containerizer/provisioner/docker/paths.hpp  
  src/slave/containerizer/provisioner/docker/paths.cpp 
5733fb7137b1ecb8a904cc5354425c60c9e065f5 
  src/slave/containerizer/provisioner/docker/puller.hpp 
105b4e75439c2ad4c08e2fd364f288f1d39b9b59 
  src/slave/containerizer/provisioner/docker/puller.cpp 
cb05324689ffa26ce830b513e2d71b55517da3cb 
  src/slave/containerizer/provisioner/docker/registry_client.hpp  
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
471783d88b73b62afacac3d7952ebb5d5f442097 
  src/slave/containerizer/provisioner/docker/store.hpp 
b5e6c87d38bea531c1b504915a84625fc9777e0d 
  src/slave/containerizer/provisioner/docker/store.cpp 
637c97c0973bda492826803a9