Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review104019
---

Ship it!


Thanks for taking this on Greg!
Greg will follow up with some patches to make the style in this document 
consistent. We've kept it locally consistent for now.


docs/configuration.md (lines 1659 - 1660)


`the libevent development package is required`?



docs/configuration.md (line 1660)


`version 2+`



docs/configuration.md (line 1670)


`--enable-libevent is currently required`?



docs/configuration.md (line 1888)


It seems like there are 2 forms of this flag / message:
`--with-libevent[=DIR]` and ``--with-libevent=[=DIR]``

It seems like there are 2 forms of this message:
```
excludes building and using the bundled XXX package in lieu of an installed 
version at a location prefixed by the given path
```
and what you have.
Feel free to make them totally consistent with a new review.

Here and below.


- Joris Van Remoortere


On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 21, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103453
---


Patch looks great!

Reviews applied: [39494]

All tests passed.

- Mesos ReviewBot


On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 21, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103436
---

Ship it!


Ship It!

- Cong Wang


On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 21, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

[Greg Mann]

> On Oct. 21, 2015, 5:22 p.m., Cong Wang wrote:
> > docs/configuration.md, line 1915
> > 
> >
> > Like what you do for libevent, it would be nicer if you can add a URL 
> > to libnl3 too, but this is not a big deal...

Good call, added it. Thanks Cong!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103434
---


On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 21, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
---

(Updated Oct. 21, 2015, 5:28 p.m.)


Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Changes
---

Addressed comment.


Bugs: MESOS-3749
https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description
---

Added libnl, libevent and ssl flags to config docs.


Diffs (updated)
-

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
---

Viewed in the Mesos Website Container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103434
---



docs/configuration.md (line 1915)


Like what you do for libevent, it would be nicer if you can add a URL to 
libnl3 too, but this is not a big deal...


- Cong Wang


On Oct. 21, 2015, 4:17 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 21, 2015, 4:17 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103429
---


Patch looks great!

Reviews applied: [39494]

All tests passed.

- Mesos ReviewBot


On Oct. 21, 2015, 4:17 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 21, 2015, 4:17 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

[Greg Mann]

> On Oct. 21, 2015, 2:23 a.m., haosdent huang wrote:
> > docs/configuration.md, line 1655
> > 
> >
> > According the output of `../configure --help`, seems the document miss 
> > `--with-nl`. But I not sure should add it in this patch or a sperate patch.
> > ```
> > --with-nl=[DIR] specify where to locate the libnl3 library 
> > (required
> >   for network-isolator). [default: /usr]
> > ```

Since it's a small change, I went ahead and added it into this review. Thanks, 
haosdent!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103340
---


On Oct. 21, 2015, 4:17 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
> 
> (Updated Oct. 21, 2015, 4:17 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3749
> https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
---

(Updated Oct. 21, 2015, 4:17 p.m.)


Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Changes
---

Added --with-nl flag to config docs.


Summary (updated)
-

Added libnl, libevent and ssl flags to config docs.


Bugs: MESOS-3749
https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description (updated)
---

Added libnl, libevent and ssl flags to config docs.


Diffs (updated)
-

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
---

Viewed in the Mesos Website Container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann