Re: Review Request 41076: Added tests for implicit roles.

2015-12-17 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41076/
---

(Updated Dec. 17, 2015, 7:59 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg 
Mann, and Yongqiao Wang.


Bugs: MESOS-4085
https://issues.apache.org/jira/browse/MESOS-4085


Repository: mesos


Description
---

Also added tests for the "/role" HTTP endpoint.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
fb214a829a57529d3f5c49730ae9733f53e622ca 
  src/tests/role_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41076/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 41076: Added tests for implicit roles.

2015-12-09 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41076/#review109529
---


It would be great to have a test for "/roles" endpoint when:
- quota is set for a role and
- some resources are reserved dynamically for a role.


src/tests/role_tests.cpp (line 219)


Third person singular, please : ). Also below.



src/tests/role_tests.cpp (line 327)


I would suggest to pull the role name into a constant for readability.



src/tests/role_tests.cpp (line 402)


Do you want to check the status code as well using 
`AWAIT_EXPECT_RESPONSE_STATUS_EQ`?



src/tests/role_tests.cpp (line 463)


Again, how about pulling these roles into constants?


- Alexander Rukletsov


On Dec. 9, 2015, 5:54 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41076/
> ---
> 
> (Updated Dec. 9, 2015, 5:54 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg 
> Mann, and Yong Qiao Wang.
> 
> 
> Bugs: MESOS-4085
> https://issues.apache.org/jira/browse/MESOS-4085
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added tests for the "/role" HTTP endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> fb214a829a57529d3f5c49730ae9733f53e622ca 
>   src/tests/role_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41076/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41076: Added tests for implicit roles.

2015-12-08 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41076/
---

(Updated Dec. 8, 2015, 8:28 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg 
Mann, and Yong Qiao Wang.


Changes
---

Rebase.


Bugs: MESOS-4085
https://issues.apache.org/jira/browse/MESOS-4085


Repository: mesos


Description
---

Also added tests for the "/role" HTTP endpoint.


Diffs (updated)
-

  src/tests/role_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41076/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 41076: Added tests for implicit roles.

2015-12-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41076/#review109335
---


Patch looks great!

Reviews applied: [40995, 41075, 41076]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 8, 2015, 8:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41076/
> ---
> 
> (Updated Dec. 8, 2015, 8:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg 
> Mann, and Yong Qiao Wang.
> 
> 
> Bugs: MESOS-4085
> https://issues.apache.org/jira/browse/MESOS-4085
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added tests for the "/role" HTTP endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/role_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41076/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41076: Added tests for implicit roles.

2015-12-08 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41076/
---

(Updated Dec. 8, 2015, 7:18 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg 
Mann, and Yong Qiao Wang.


Changes
---

Address review comments, rebase.


Bugs: MESOS-4085
https://issues.apache.org/jira/browse/MESOS-4085


Repository: mesos


Description
---

Also added tests for the "/role" HTTP endpoint.


Diffs (updated)
-

  src/tests/role_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41076/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 41076: Added tests for implicit roles.

2015-12-08 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41076/
---

(Updated Dec. 9, 2015, 5:54 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg 
Mann, and Yong Qiao Wang.


Changes
---

Rebase, add extra test.


Bugs: MESOS-4085
https://issues.apache.org/jira/browse/MESOS-4085


Repository: mesos


Description
---

Also added tests for the "/role" HTTP endpoint.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
fb214a829a57529d3f5c49730ae9733f53e622ca 
  src/tests/role_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41076/diff/


Testing
---


Thanks,

Neil Conway

Review Request 41076: Added tests for implicit roles.

2015-12-07 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41076/
---

Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg 
Mann, and Yong Qiao Wang.


Repository: mesos


Description
---

Also added tests for the "/role" HTTP endpoint.


Diffs
-

  src/tests/role_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41076/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 41076: Added tests for implicit roles.

2015-12-07 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41076/
---

(Updated Dec. 8, 2015, 5:44 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg 
Mann, and Yong Qiao Wang.


Changes
---

Add link to bug.


Bugs: MESOS-4085
https://issues.apache.org/jira/browse/MESOS-4085


Repository: mesos


Description
---

Also added tests for the "/role" HTTP endpoint.


Diffs
-

  src/tests/role_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41076/diff/


Testing
---


Thanks,

Neil Conway