Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-17 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41337/#review110935
---



src/slave/slave.cpp (line 4860)


Honestly, I'd suggest to update `shutdownExecutor` to return future; so 
slave'll wait all future finished before `runTask`. LaunchTask periodic does 
not make sense :).


- Klaus Ma


On Dec. 17, 2015, 5:22 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41337/
> ---
> 
> (Updated Dec. 17, 2015, 5:22 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4148
> https://issues.apache.org/jira/browse/MESOS-4148
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set task as TASK_LOST if not enough allocation slack resources.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 
> 
> Diff: https://reviews.apache.org/r/41337/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-17 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41337/
---

(Updated Dec. 17, 2015, 9:22 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4148
https://issues.apache.org/jira/browse/MESOS-4148


Repository: mesos


Description
---

Set task as TASK_LOST if not enough allocation slack resources.


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 

Diff: https://reviews.apache.org/r/41337/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-16 Thread Jian Qiu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41337/#review110878
---



src/slave/slave.hpp (line 593)


How about using tuple queue> 
pendingTasks?


- Jian Qiu


On 十二月 17, 2015, 2:49 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41337/
> ---
> 
> (Updated 十二月 17, 2015, 2:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4148
> https://issues.apache.org/jira/browse/MESOS-4148
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set task as TASK_LOST if not enough allocation slack resources.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 
> 
> Diff: https://reviews.apache.org/r/41337/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-16 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41337/
---

(Updated Dec. 17, 2015, 2:49 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4148
https://issues.apache.org/jira/browse/MESOS-4148


Repository: mesos


Description
---

Set task as TASK_LOST if not enough allocation slack resources.


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 

Diff: https://reviews.apache.org/r/41337/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-16 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41337/
---

(Updated Dec. 16, 2015, 1:24 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-4148
https://issues.apache.org/jira/browse/MESOS-4148


Repository: mesos


Description
---

Set task as TASK_LOST if not enough allocation slack resources.


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 

Diff: https://reviews.apache.org/r/41337/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-16 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41337/
---

(Updated Dec. 16, 2015, 9:29 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Summary (updated)
-

WIP: Set task as TASK_LOST if not enough allocation slack resources.


Bugs: MESOS-4148
https://issues.apache.org/jira/browse/MESOS-4148


Repository: mesos


Description
---

Set task as TASK_LOST if not enough allocation slack resources.


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 

Diff: https://reviews.apache.org/r/41337/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-14 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41337/
---

(Updated Dec. 14, 2015, 8:52 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-4148
https://issues.apache.org/jira/browse/MESOS-4148


Repository: mesos


Description
---

Set task as TASK_LOST if not enough allocation slack resources.


Diffs (updated)
-

  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41337/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

2015-12-14 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41337/
---

Review request for mesos.


Bugs: MESOS-4148
https://issues.apache.org/jira/browse/MESOS-4148


Repository: mesos


Description
---

Set task as TASK_LOST if not enough allocation slack resources.


Diffs
-

  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41337/diff/


Testing
---

make
make check


Thanks,

Guangya Liu