Re: Review Request 42530: Changed `createReservationInfo` to take `Option`.

2016-01-19 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/
---

(Updated Jan. 20, 2016, 1:30 a.m.)


Review request for mesos and Michael Park.


Summary (updated)
-

Changed `createReservationInfo` to take `Option`.


Repository: mesos


Description (updated)
---

Changed `createReservationInfo` to take `Option`.


Diffs
-

  src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 

Diff: https://reviews.apache.org/r/42530/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Review Request 42530: Changed 'createReservationInfo' to take 'Option'.

2016-01-19 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

Changed 'createReservationInfo' to take 'Option'.


Diffs
-

  src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 

Diff: https://reviews.apache.org/r/42530/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 42530: Changed `createReservationInfo` to take `Option`.

2016-01-19 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/
---

(Updated Jan. 20, 2016, 3:40 a.m.)


Review request for mesos and Michael Park.


Changes
---

Addressed comment.


Repository: mesos


Description
---

Changed `createReservationInfo` to take `Option`.


Diffs (updated)
-

  src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 

Diff: https://reviews.apache.org/r/42530/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 42530: Changed `createReservationInfo` to take `Option`.

2016-01-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/#review115310
---



src/tests/mesos.hpp (line 479)


Oops, sorry. Let's give this a default argument of `None()` here for 
consistently in style and so that we can do `createReservationInfo()`.


- Michael Park


On Jan. 20, 2016, 1:30 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42530/
> ---
> 
> (Updated Jan. 20, 2016, 1:30 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed `createReservationInfo` to take `Option`.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
> 
> Diff: https://reviews.apache.org/r/42530/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>